Commit Graph

27244 Commits

Author SHA1 Message Date
Arc Wang
912f3558df Refactor UseOpenWifiPreferenceController into TogglePreferenceController
UseOpenWifiPreferenceController is essentially reimplementing TogglePreferenceController.

Add below 2 changes for test failure of CodeInspectionTest

1. Remove some arguments from constructor of the controller
2. Declare the controller in xml instead of in code

Bug: 132391311
Test: manual
      UseOpenWifiPreferenceControllerTest

Change-Id: Ie52e79fd0bc66a227bd46f09c74d1fbec614f636
2019-05-24 12:09:20 +08:00
Arc Wang
1ee4adf321 Refactor WifiWakeupPreferenceController into TogglePreferenceController
WifiWakeupPreferenceController is essentially reimplementing TogglePreferenceController.

Add below 2 changes for test failure of CodeInspectionTest

1. Remove some arguments from constructor of the controller
2. Declare the controller in xml instead of in code

Bug: 132391311
Test: manual
      WifiWakeupPreferenceControllerTest

Change-Id: I4aa607f78d5e7de70600a410dfc7267e6bd7d387
2019-05-24 12:05:37 +08:00
Yiwen Chen
cbb6ea5ea4 Merge "Keep consistency between sound and accessibility settings." 2019-05-23 14:52:48 +00:00
Yiwen Chen
494071463b Keep consistency between sound and accessibility settings.
Bug: 130741987
Test: Tested on device
Change-Id: Id6dd485c73f9453970b8d79929ffc04acb2c76c8
2019-05-23 00:13:01 -07:00
Salvador Martinez
f60a153dba Merge "Add metrics stuff for dark ui dialog fragment" into qt-dev am: d680ea2620 am: cfb9b61a6e
am: db06238cc2

Change-Id: I3c61ffb891feba0e6d7c2e2ff421c51c030b09f6
2019-05-22 20:37:10 -07:00
Antony Sargent
389e2a0a97 Merge "Prevent NullPointerException in SimStatusDialogController" into qt-dev am: e959c201ce am: ce8495d632
am: db9abe8dd8

Change-Id: Ibde17a1d7949d24b5861db8172a3313dda054c7b
2019-05-22 20:36:05 -07:00
Julia Reynolds
cba0b335c5 Merge "Fix hiding of channel fields" into qt-dev am: c14825c93d am: b1ec5751c1
am: 85a3096214

Change-Id: I0c5fc03a217e489cd1eec5022ecb42ace7390a0a
2019-05-22 16:31:19 -07:00
TreeHugger Robot
ce8ede7756 Merge "Fix talkback issue of header preference" 2019-05-22 13:52:17 +00:00
Salvador Martinez
db06238cc2 Merge "Add metrics stuff for dark ui dialog fragment" into qt-dev am: d680ea2620
am: cfb9b61a6e

Change-Id: I8c4182a6bd3c2fe2504c87bf5338cc15292529ab
2019-05-22 05:26:26 -07:00
Antony Sargent
db9abe8dd8 Merge "Prevent NullPointerException in SimStatusDialogController" into qt-dev am: e959c201ce
am: ce8495d632

Change-Id: If27659f370ed97e07ad024d125ae56b0f4a9efb4
2019-05-22 05:17:34 -07:00
Amin Shaikh
68dd6000ff Merge "Remove unnecessary STOPSHIP." into qt-dev am: ed3136b72d am: f692c8e570
am: 9156f4c6f1

Change-Id: Ic7fba2246a8b9a8e2bcbfa51d8211d20f003481d
2019-05-22 04:38:59 -07:00
TreeHugger Robot
e0e29543a5 Merge "Refreshes preference text when updateStates" 2019-05-22 10:54:55 +00:00
Antony Sargent
82bfe8eca4 Merge "Fix signal strength display in 'Choose network' list" into qt-dev am: 13acaddf47 am: 36ecc7006f
am: b8ea9d4516

Change-Id: Ibe3888d09a3adc66abd581559f7d921f34d6ea1f
2019-05-22 01:50:49 -07:00
Yanting Yang
70a8e313f2 Fix talkback issue of header preference
Header preference was just a static preference and used LayoutPreference
to show customized layout. But Preference default enabled the selectable
attribute, then caused the a11y service to speak out "Double-tap to
activate". Override the selectable attribute to fix it.

Fixes: 132856214
Test: robotests, visual
Change-Id: Ibc577de347edb66ab9de53f6177ca068a19ffa74
2019-05-22 16:38:50 +08:00
Raff Tsai
2db569e7ee Merge "Make SeekBarPreference to be selectable" into qt-dev am: dd59f1193f am: 574893b860
am: 59f0a82dc2

Change-Id: I4c099e731976d4020879e7ec6fe093f50a164dce
2019-05-21 21:24:27 -07:00
Hai Zhang
30a04be5be Merge "Remove SmsDefaultDialog which has been replaced by role." into qt-dev am: 98ba2a6b8b am: c46403a34e
am: e99117aa25

Change-Id: I6ab872fe7f7580555eb228f61f38154f5aab33f3
2019-05-21 21:22:31 -07:00
Alex Kershaw
5e8053e4fe Merge "Don't display footer text when calling app is DPC." into qt-dev am: 993446a68e am: e19ede22a2
am: 0f9426a8b5

Change-Id: I99302c800a78cc570c137e9a2df0b9a7621a6f4f
2019-05-21 21:21:32 -07:00
Raff Tsai
ff6cc9be3c Refreshes preference text when updateStates
Bug: 132391311
Test: robolectric
Change-Id: I94b59e6d748b8e8ee458f045861b2be2206e0a75
2019-05-22 11:40:00 +08:00
Julia Reynolds
85a3096214 Merge "Fix hiding of channel fields" into qt-dev am: c14825c93d
am: b1ec5751c1

Change-Id: I94345bc22e12357a79739cb12fe72067e03d8ba8
2019-05-21 17:30:09 -07:00
Amin Shaikh
9156f4c6f1 Merge "Remove unnecessary STOPSHIP." into qt-dev am: ed3136b72d
am: f692c8e570

Change-Id: I5ce22721e993c164daa0ccf78f00d07b9991114b
2019-05-21 17:18:39 -07:00
TreeHugger Robot
d680ea2620 Merge "Add metrics stuff for dark ui dialog fragment" into qt-dev 2019-05-22 00:08:49 +00:00
TreeHugger Robot
e959c201ce Merge "Prevent NullPointerException in SimStatusDialogController" into qt-dev 2019-05-21 20:34:13 +00:00
Antony Sargent
b8ea9d4516 Merge "Fix signal strength display in 'Choose network' list" into qt-dev am: 13acaddf47
am: 36ecc7006f

Change-Id: I3dd5cdfbbbddc9fed1ee229ef51563c9bd1f0b78
2019-05-21 13:19:41 -07:00
Raff Tsai
59f0a82dc2 Merge "Make SeekBarPreference to be selectable" into qt-dev am: dd59f1193f
am: 574893b860

Change-Id: I7761ee743a356507feff41c5554927c3ad61a815
2019-05-21 12:22:42 -07:00
Hai Zhang
e99117aa25 Merge "Remove SmsDefaultDialog which has been replaced by role." into qt-dev am: 98ba2a6b8b
am: c46403a34e

Change-Id: I640fdf4d893219fc9cbe33152bac327a983f86c5
2019-05-21 12:20:50 -07:00
Alex Kershaw
0f9426a8b5 Merge "Don't display footer text when calling app is DPC." into qt-dev am: 993446a68e
am: e19ede22a2

Change-Id: Ia9a653d6ce5c6a9164d044e7860e866a76817ee9
2019-05-21 12:20:01 -07:00
TreeHugger Robot
75867441a1 Merge "Update string" 2019-05-21 17:14:24 +00:00
Antony Sargent
5c46d93bd8 Prevent NullPointerException in SimStatusDialogController
In rare cases the SignalStrength we get for a SIM can be null, which
wasn't checked for in this code. This CL adds a null check and fixes the
tests so it's possible to verify the fix (one of the methods that would
have crashed was being spy'd over unnecessarily).

Fixes: 132570076
Test: make RunSettingsRobotests
Change-Id: Ifdec24f184ee2d93e5e242eb2c20695249992fc6
2019-05-21 10:02:10 -07:00
TreeHugger Robot
c14825c93d Merge "Fix hiding of channel fields" into qt-dev 2019-05-21 16:58:23 +00:00
TreeHugger Robot
ed3136b72d Merge "Remove unnecessary STOPSHIP." into qt-dev 2019-05-21 16:52:31 +00:00
TreeHugger Robot
13acaddf47 Merge "Fix signal strength display in 'Choose network' list" into qt-dev 2019-05-21 16:05:34 +00:00
Amin Shaikh
66dba94797 Remove unnecessary STOPSHIP.
THEME_CUSTOMIZATION_OVERLAY_PACKAGES will no be set in Q. When it is set, these developer settings will be removed entirely.

Change-Id: Ic33bb68a4e4a0fabc6731169ef96ecd386dc441e
Fixes: 122308197
Test: presubmit
2019-05-21 13:51:27 +00:00
TreeHugger Robot
dd59f1193f Merge "Make SeekBarPreference to be selectable" into qt-dev 2019-05-21 10:28:28 +00:00
TreeHugger Robot
546a06af3d Merge "[Wi-Fi DPP] Refine Wi-Fi DPP UI layouts with SUW library" 2019-05-21 09:56:05 +00:00
Salvador Martinez
d3f0b756e5 Merge "Break infinite refresh loop in battery estimates" into qt-dev am: e418874921 am: 9822f6ed92
am: 768e021974

Change-Id: I45bf3a5f3cb42d78a3feaf02bdedd2372167e12d
2019-05-21 01:32:19 -07:00
timhypeng
c82962b432 Update string
- merge title into body text

Bug: 131914743
Test: make -j50 RunSettingsRoboTests
Change-Id: I5298dbcc28f8ecb97f714c948cda12e040bfd391
2019-05-21 07:10:19 +00:00
TreeHugger Robot
98ba2a6b8b Merge "Remove SmsDefaultDialog which has been replaced by role." into qt-dev 2019-05-21 06:05:31 +00:00
Arc Wang
8e3c49123d [Wi-Fi DPP] Refine Wi-Fi DPP UI layouts with SUW library
1. Use GlifLayout in all fragments
2. Fragments use 32dp icon instead of 48 dp
3. Replace ScrollView & ProgressBar & Header & Footer of original layout with GlifLayout design
4. Remove ActionBar (no more back button on screen top)

Bug: 129021867
Test: manual
Change-Id: I2fda48cb7f7819b2c8dd85c10d39e1f187463bd8
2019-05-21 13:59:39 +08:00
Raff Tsai
81b9f5083d Make SeekBarPreference to be selectable
Fixes: 132983200
Test: make RunSettingsRoboTests, manual
Change-Id: I3d4bc59d948236ff2482945a4fc976ee61c37c27
2019-05-21 11:39:02 +08:00
TreeHugger Robot
993446a68e Merge "Don't display footer text when calling app is DPC." into qt-dev 2019-05-21 01:24:19 +00:00
Salvador Martinez
768e021974 Merge "Break infinite refresh loop in battery estimates" into qt-dev am: e418874921
am: 9822f6ed92

Change-Id: I3805df6ebe38197a128ce21bc83a6ad7474c8019
2019-05-20 17:21:03 -07:00
Antony Sargent
8c6098e5cf Fix signal strength display in 'Choose network' list
For GSM networks, the "Choose network" page allows you to manually pick
from among different cell networks, and shows signal strength and
network type (LTE, 3g, etc.) for available ones. The signal strength
wedges were transparent and not visible to the user - this CL fixes
that.

Bug: 132895135
Test: visual (Insert SIM with GSM service, then go to Settings ->
Network & internet -> Mobile network -> Advanced -> Automatically select
network)

Change-Id: Ibbbc60b590b09e4b4f5e31b49fe578769dcdbc4d
2019-05-20 17:20:31 -07:00
Hai Zhang
4feab60a30 Remove SmsDefaultDialog which has been replaced by role.
Bug: 131204827
Test: presubmit
Change-Id: If436d4f0777838dc490fa45901005008bb57315b
2019-05-20 15:23:05 -07:00
Salvador Martinez
e418874921 Merge "Break infinite refresh loop in battery estimates" into qt-dev 2019-05-20 21:22:23 +00:00
Julia Reynolds
72bdef0781 Fix hiding of channel fields
When channel is off

Test: atest
Bug: 132971502
Change-Id: I5772266e022e5ebb5dbf20f231ca30fad95e3db7
2019-05-20 14:03:07 -04:00
Narayan Kamath
6abd1e82d2 Merge "Hide AppButtonsPreferenceController for system modules." into qt-dev am: 76cf0dbddd am: c756190b9c
am: 35870d6e5b

Change-Id: I46ef78848acec0f723719fdf778ff9a828d0fb85
2019-05-20 08:24:12 -07:00
Alex Kershaw
29d2bff7e1 Don't display footer text when calling app is DPC.
If the calling app has admin rights (DA/DO/PO), don't display footer
text that the calling app is 'recommending' that a password is set.

Fixes: 131888973
Test: atest com.android.settings.password.SetNewPasswordActivityTest --verbose
Test: atest com.android.settings.password.ChooseLockGenericTest --verbose
Test: manual
Change-Id: I32785d33e6425416fc1dbba24540ece8917b58f3
2019-05-20 12:19:22 +00:00
Narayan Kamath
c756190b9c Merge "Hide AppButtonsPreferenceController for system modules." into qt-dev
am: 76cf0dbddd

Change-Id: Ic097d7c264bbc198c0ef3c0ed9099beb9339a2e0
2019-05-20 05:14:33 -07:00
Narayan Kamath
76cf0dbddd Merge "Hide AppButtonsPreferenceController for system modules." into qt-dev 2019-05-20 07:42:53 +00:00
Kevin Chang
cf2f505b7d Merge "Revert "Change string of switchbar and installed service category title"" into qt-dev am: f508ece42d am: f8baacfe7f
am: d77b10c7de

Change-Id: I203137b6481999ca75be10996dac8a9e0fd4a71a
2019-05-18 05:21:30 -07:00