Commit Graph

344 Commits

Author SHA1 Message Date
Oscar Shu
64328862bd Revert "Wifi MAC Randomization: Developer Options"
This reverts commit 8c6d8daaf0.

Reason for revert: <Enabling feature by default. Global flag moved to OEM
configurable overlay instead.>

Bug: 123408542
Test: unit tests
Test: Manual test to verify dev option is gone
Change-Id: Iae667a331b5d4fb4cb6fe07077eb9f3954f3089e
2019-01-28 14:39:05 -08:00
TreeHugger Robot
88d7797e1b Merge "[Mac Randomization] Change order of Privacy setting in "Add network" page" 2019-01-25 06:03:29 +00:00
cosmohsieh
b521bd6225 [Mac Randomization] Change order of Privacy setting in "Add network"
page

For better UX, making the default option 'Use randomized MAC (default)' as the
first option item in "add network" page.

Bug: 123160090
Test: make RunSettingsRoboTests -j32 ROBOTEST_FILTER=com.android.settings.wifi
Change-Id: Ifdba5a323df21c8d3442f394acdebd1c3f259c69
2019-01-25 12:05:18 +08:00
Cosmo Hsieh
846cacbd0b Merge "[Network Connection] Implement dialog title for new design" 2019-01-25 01:44:28 +00:00
Jason Chiu
36b37de9d6 Fix the consistency of connection status displayed on Wi-Fi card
- Refresh slice in WifiTracker.onConnectedChanged
- Only expose notifySliceChange to child in SliceBackgroundWorker

Fixes: 123270015
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.wifi.slice
Change-Id: Id5540ebae2746e58e14924665c5e62bf437ebcf0
2019-01-24 14:56:04 +08:00
cosmohsieh
6897c55396 [Network Connection] Implement dialog title for new design
Change title to contain app name from intent.

Bug: 123158944
Test: atest NetworkRequestDialogFragmentTest
Change-Id: If3acea5adec8a5e2bbf712735fda9e6975e71984
2019-01-24 09:35:38 +08:00
Cosmo Hsieh
2cea2d4cb3 Merge "[Network Connection] Implement toasting after wifi is connected" 2019-01-23 02:17:21 +00:00
cosmohsieh
b9c4797387 [Network Connection] Implement toasting after wifi is connected
When wifi is connected (onUserSelectionConnectSuccess), making a toast
infos user and closed the dialog.

Bug: 123160958
Test: atest NetworkRequestDialogFragmentTest
Change-Id: I85ab648188018773e1f76541d18903c733bc3e69
2019-01-22 13:49:10 +08:00
Johnson Lu
c706c643a0 Merge "Fix crash issue when click 'Share' button" 2019-01-21 13:08:28 +00:00
Johnson Lu
69b31596a2 Fix crash issue when click 'Share' button
Hide 'Share' button if access point return null wifi config.

Change-Id: I554ce8c3214c94892d57c213d0588c70aad97439
Fixes: 123172888
Test: robotests
2019-01-21 17:43:11 +08:00
cosmohsieh
29140c3a29 [Mac Randomization] Change order of Privacy setting
For better UX, making the default option 'Use randomized MAC (default)' as the
first option item.

Bug: 123160090
Test: make RunSettingsRoboTests -j32 ROBOTEST_FILTER=com.android.settings.wifi.details
Change-Id: I264756778dd8cafea620a0fcb5f57df91c049259
2019-01-21 10:54:48 +08:00
Sunil Ravi
39d372e676 WiFi: Add Tx and rx link speed in network details
current "link speed" in UI is renamed to "Transmit link speed".
Also Added Receive link speed in network details.

Bug: 120497598
Test: Connected to AP and verified the Rx link speed in Network details.

Change-Id: I01cf7362a27ad78ddfaef68efae4d07cbd14fc55
2019-01-14 16:31:01 -08:00
cosmohsieh
c1854cae9a Implement persisting time for onUserSelectionConnectSuccess.
When onUserSelectionConnectSuccess callbacks, holding a second for user
to be aware of success connection. Then, go to destory network request dialog.

Bug: 117399926
Test: make RunSettingsRoboTests -j32 ROBOTEST_FILTER=com.android.settings.wifi.NetworkRequestDialogFragmentTest
Change-Id: I12d8fb2e8955cf24ddad43d1fe8b863682b6ae32
2019-01-08 12:08:11 +08:00
Lei Yu
0e66037fc1 Merge "Add lost prefController to WifiTetherSettings" 2019-01-02 23:07:08 +00:00
jackqdyulei
5ca4e06dfe Add lost prefController to WifiTetherSettings
One controller is lost during a refactor(ag/4774003), this CL adds
it back.

Change-Id: Ie50a3ac009f302d4fd7a179117fe026031cc1ae8
Fixes: 122235175
Test: RunSettingsRoboTests
2019-01-02 11:30:03 -08:00
Arc Wang
1988fb75c6 Implement Wi-Fi QR code scanner flow.
1. Implements WifiNetworkConfig Wi-Fi connection method
2. Shows error message when the QR code is not valid and hides it after 2s
3. In configurator mode, launchs AddDeviceFragment for a valid QR code
4. In enrollee mode, connects Wi-Fi for a valid QR code

Bug: 118794978
Test: manual test
      atest WifiQrCodetest
      atest WifiDppConfiguratorActivityTest
      atest WifiDppEnrolleeActivityTest
      atest WifiDppQrCodeScannerFragmentTest

Change-Id: Ie4731b22df295c60906156d33ea28dad9c084ce4
2019-01-02 07:12:15 +00:00
cosmohsieh
a83b304670 Change privacy setting string
Change privacy setting (mac randomized) string

Test: manual and robotests
Change-Id: I264c89e0b8ccaeff0a057ff7d791d006a5e7d7cd
2018-12-28 10:07:20 +08:00
Johnson Lu
8bc04efd1a Merge "Show QR Code picture for WiFi sharing" 2018-12-28 01:00:37 +00:00
Yanting Yang
1c9b97d537 Clean up assertion methods in SliceTester
Fixes: 120592507
Test: robotests
Change-Id: Ic20fa96aa500d9ab50ef2adcb59f48c328989ec8
2018-12-27 17:24:36 +08:00
Johnson Lu
7414543635 Show QR Code picture for WiFi sharing
Bug: 118794858
Test: make RunSettingsRoboTests
Change-Id: Ic5a489840ba59262eb444f02d77bf066889a4220
2018-12-27 09:55:44 +08:00
TreeHugger Robot
9f7927f6d5 Merge "Hide wifi card sometimes." 2018-12-19 17:42:58 +00:00
Fan Zhang
0db4ead2b3 Hide wifi card sometimes.
When there is a connected wifi, we now hide the wifi slice card.

However, if we initially shows this card but later wifi is connected
while the card is visible, we keep showing this card to avoid janky
animation. The card will be gone if user nagivates to a different UI and
comes back.

- Create a new slice ContextualWifiSlice for homepage use case, all
  special logic for homepage are added here.
- Change reference for WIFI_SLICE to CONTEXTUAL_WIFI_SLICE where make
  sense.

Change-Id: Ibd87f88058f357aabef0f7d68a5bf48350d75b06
Fixes: 121040746
Test: robotests
2018-12-18 10:18:08 -08:00
Cosmo Hsieh
0c4214a200 Merge "Add internal WifiTracker to get correct AccessPoint for WifiNetworkRequestDialog" 2018-12-18 06:15:35 +00:00
cosmohsieh
65c8d1df69 Add internal WifiTracker to get correct AccessPoint for
WifiNetworkRequestDialog

Use WifiTracker to get correct and constantly updated Wifi status of AccessPoint.

Bug: 117399926
Test: RunSettingsRoboTests
Change-Id: I5e4316f6acb7787dcaab150a293068852beb76e0
2018-12-18 10:40:54 +08:00
Johnson Lu
ebbb0bc563 Adjust camera preview area to square
1.Choose the smaller size of both dimensions as its size.
2.Set transform matrix to crop and center the preview picture.

Bug: 118797380
Test: make RunSettingsRoboTests
Change-Id: Ic65fb1fe0c5082995d6903f50dda48eec16c3fb1
2018-12-15 16:07:02 +08:00
cosmohsieh
64b894f81d Implement getConfig() method to get WifiConfiguration
Make a duplicated function of WifiConfigController.getConfig(). This
function could get a new WifiConfiguration from input AccessPoint or
ScanResult.
Should be removed if there is standard one in framework.

Bug: 120827021
Test: RunSettingsRoboTests

Change-Id: Ia5981e8d41f434c097b464a2bfe18e1356f7b087
2018-12-14 09:54:34 +00:00
Fan Zhang
abbc619601 Remove SettingsRobolectricTestRunner
Test: rerun robotests
Change-Id: I7054d8d5cfc4756beb8d3032bc92361534229494
2018-12-13 11:20:40 -08:00
TreeHugger Robot
887fa5c646 Merge "Use binary resource support in robolectric" 2018-12-13 07:44:19 +00:00
TreeHugger Robot
a56b5926a9 Merge "Fix ANR in SliceRelayReceiver" 2018-12-13 06:20:19 +00:00
James Lemieux
f1dade40d2 Use binary resource support in robolectric
The resources available to tests are now exactly the merged resources
located in the APK under test.

Bug: 74359828
Test: make -j56 RunSettingsRoboTests
Change-Id: I050db81a92decefea23314b5ec7a62f77ff4bb2b
2018-12-12 19:53:49 -08:00
Raff Tsai
86a2afe798 Fix ANR in SliceRelayReceiver
The same broadcast are handled in SliceRelayReceiver and WifiScanWorker.
We will only use WifiScanWorker to handle wifi broadcast.

Change-Id: I32c2fcc699ae240f12bd1049ba33e1792ae123b0
Fixes: 120284615
Test: manual
2018-12-13 10:34:45 +08:00
Johnson Lu
d6a40032c1 Merge "Implement receiver flow of WiFi sharing feature" 2018-12-13 00:54:46 +00:00
Cosmo Hsieh
5ac2c048fb Merge "Rename wifi/NetworkRequestTimeoutDialogFragment to wifi/NetworkRequestErrorDialogFragment for extending usage." 2018-12-11 08:21:14 +00:00
Johnson Lu
5aef897e9b Implement receiver flow of WiFi sharing feature
1.Add a button to launch QR code scanner when add a network.
2.Scan button added in AddNetworkFragment / WifiDialog / WifiSettings.

Bug: 120630683
Test: make RunSettingsRoboTests
Change-Id: I340bfa2247e092f586dd90dfea37c355e681ffee
2018-12-11 14:25:07 +08:00
Johnson Lu
8ef2edfe32 Merge "Implement host flow of WiFi sharing feature" 2018-12-11 05:51:32 +00:00
Stanley Wang
b812668679 Merge "Fix carrier-specific Wi-Fi settings appears in search - even on non-carrier phone" 2018-12-11 02:22:07 +00:00
Johnson Lu
43f0d13e1d Implement host flow of WiFi sharing feature
Add share button and authentication screen to confirm credentials
(pin, pattern or password) for the current user of the device.

Bug: 120517242
Test: make RunSettingsRoboTests
Change-Id: Id79833db0d582c401f1371ff60429e42ce1990e0
2018-12-11 09:44:27 +08:00
Stanley Wang
f301f8b216 Fix carrier-specific Wi-Fi settings appears in search - even on non-carrier phone
The preference should be removed from the search result when
the availability status is false.

Change-Id: I979bc70ec7672b137b96a7e02db2e9ba29fbb7a8
Fixes: 112550245
Test: manual and robotests
2018-12-10 15:14:23 +08:00
Fan Zhang
3e107469aa Add a loading text when waiting for wifitracker results
- When there is no result from background worker, a "scanning" text is
displayed instead of a totally empty card.

- Also cleaned up a few minor coding style issues

Change-Id: I73afdb1dd72e7accb387ad9aa493cfbe00bffe66
Fixes: 120051186
Test: robotests
2018-12-07 12:48:31 -08:00
cosmohsieh
38a574173e Rename wifi/NetworkRequestTimeoutDialogFragment to wifi/NetworkRequestErrorDialogFragment for extending usage.
ErrorDialogFragment contains two kinds of error dialog (timeout and onAbort).

Bug: 117399926
Test: RunSettingsRoboTests
Change-Id: Iea82a53baba298de66ae988c75d9fb6daca60160
2018-12-07 01:44:52 +00:00
tmfang
8ad18fb3eb Use SettingsLib's ActionButtonsPreference
Since we moved old ActionButtonPreference into
SettingsLib, we need to update new imports and
declaration in Settings source code.

Test: robotest, manual test
Bug: 120005054
Change-Id: I1e3514ba68a856071c81534d54c99c3d1a11a8ca
2018-12-03 15:12:41 +00:00
Fan Zhang
53f75f0df9 Move all custom slice uris to a registry class.
Change-Id: I192320f95ac81d14c8891ce2531d603912e59f56
Fixes: 119776308
Test: robotests
2018-11-29 16:41:21 -08:00
TreeHugger Robot
d949f7d02a Merge "Remove WifiDetailPreference." 2018-11-29 07:43:15 +00:00
Doris Ling
52552ab0ab Remove WifiDetailPreference.
- use the standard Preference instead to display the wifi details, and
enable sumary copying for the preferences under Wifi Network details.

Change-Id: I5371ac667d9239276f6492896123d617f5193871
Fixes: 62493282
Test: make RunSettingsRoboTests
2018-11-28 15:06:58 -08:00
Cosmo Hsieh
59099f19cb Merge "Add NetworkRequestDialogActivity" 2018-11-28 05:59:11 +00:00
cosmohsieh
da37bb7df7 Add NetworkRequestDialogActivity
Framwork will call this activity to start network requesting process.
This activity is simple activity contained NetworkRequestDialogFragment
and any other dialog generated in this process, aka
NetworkRequestTimeoutDialog.

Bug: 117399926
Test: RunSettingsRoboTests
Change-Id: Ib1df28d12427ed3bd7d4b88ec10e52357564c797
2018-11-27 17:31:25 +08:00
tmfang
dce94bb237 Use SettingsLib's LayoutPreference
- Remove LayoutPreference in Settings source code.
- Remove unused style, layout
- Replace old imports to com.android.settingslib.widget.LayoutPreference
- Replace old XML tag to com.android.settingslib.widget.LayoutPreference

Test: robotest, manual test
Bug: 120005054
Change-Id: I9ae1ae14a16f443e11ac5d75b6038c7c5e253844
2018-11-27 13:12:53 +08:00
TreeHugger Robot
5948259702 Merge "[WPA3] Filter unsupported networks from Add network spinner" 2018-11-26 02:46:15 +00:00
Hai Shalom
1638168336 [WPA3] Filter unsupported networks from Add network spinner
Filter unsupported networks from Add network spinner. Removed entries
from wifi_dialog.xml, adding them dynamically based on device
capabilities. Adding position-to-security table, that decouples spinner
positions from security values.

Bug: 112195778
Test: atest WifiConfigControllerTest + device functional test
Change-Id: I6a814c4d69fbd8d8076db5dbaa5da807b4da4c32
2018-11-21 18:58:38 -08:00
cosmohsieh
75c8805a99 Implement NetworkRequestMatchCallback callback in NetworkRequestDialogFragment
Use this callback to communicate with framework wifi api.
Will get candidates wifi ap list and related callback to select which wifi ap wanted to use, and related operated result status.

Bug: 117399926
Test: RunSettingsRoboTests
Change-Id: Ic8ee678c06f21050761ebb58dc0fe50bc5732e53
2018-11-21 06:33:11 +00:00