Commit Graph

358 Commits

Author SHA1 Message Date
Chaohui Wang
f1b3c2b9c9 Use old getSelectableSubscriptionInfoList
24D1-dev was using the
SubscriptionUtil.getSelectableSubscriptionInfoList().

Change I215b5a4615a3b3da6fc160f76c85c814210cc3ef cherry-pick the new
getSelectableSubscriptionInfoList from main, but not the latest version,
could produce an unexpected subscription order.

Main branch already fixed by I06b6c61304f9e6c9515b5f989294417ac3f82a60
and If7150bd2fa5c1b7d42fe34ef2e814ba540454ed8.

Fix: 341037896
Test: manual - on Mobile Settings
Merged-In: I06b6c61304f9e6c9515b5f989294417ac3f82a60
Change-Id: I5cb16b60a7bf5df5b048e539f89bfedc43aa1582
2024-06-20 16:44:14 +08:00
Pajace Chen
105858cb31 Revert^2 "Fix "Free up space" not clickable issue"
4916f22ad5

Test: http://ab/I09800010279460954
Test: Build Pass
Merged-In: I36062703b7ab5c21083459616234e3a86500719b
Change-Id: Ib5d46196cf5f0326c7bb1686c609be386016f73d
2024-05-22 07:15:32 +00:00
Satish Yalla
4916f22ad5 Revert "Fix "Free up space" not clickable issue"
Revert submission 27450348-cherrypicker-L62500030004014460:N91700030063291466

Reason for revert: Droidmonitor triggered revert due to build breakage in b/342043629. Will be verifying through ABTD before submission.

Reverted changes: /q/submissionid:27450348-cherrypicker-L62500030004014460:N91700030063291466

Change-Id: Ifaf5fbee7f18719e89d5278585ae80bed3808bb5
2024-05-22 03:04:41 +00:00
pajacechen
567f04603d Fix "Free up space" not clickable issue
- Adding CardPreference.java back for "Free up space" item
- Rename CardPreference.kt to TipCardPreference.kt

Bug: 333016642
Test: http://ab/I85800010265092964
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:e5d99fa93d7b7c9034bd492191d781c9f211f051)
Merged-In: I36062703b7ab5c21083459616234e3a86500719b
Change-Id: I36062703b7ab5c21083459616234e3a86500719b
2024-05-22 00:49:43 +00:00
Chaohui Wang
6d5dadfb0d Fix BackupTasksAppsTest
Fix: 341832628
Test: atest BackupTasksAppsTest
Change-Id: I8731604d896d58a9b46b4d0af660a40c34bb905b
Merged-In: Ib01bd6556768a943ae7fae013c6ccb82b1b96697
2024-05-21 06:08:59 +00:00
Chaohui Wang
83aeb45f3c Fix default mode for AlarmsAndRemindersAppList
When app ops permission's app ops mode is default, should check if
permission is grant.

Fix: 339846642
Test: manual - on AlarmsAndRemindersAppList
Test: unit test
Change-Id: Ia0f05211f5774637304502ead79dd98a1cf89886
2024-05-21 03:37:47 +00:00
Chaohui Wang
7a8d8fd091 Reapply "Migrate AppOps"
This reverts commit 19b01bd68b.

Bug: 341016088
Test: manual - on Special app access
Change-Id: I000274ae9c725f848e1c8910120ba886fcc5be95
Merged-In: I000274ae9c725f848e1c8910120ba886fcc5be95
2024-05-21 03:20:04 +00:00
Faye Yan
a7065f4d36 Revert "Add Voice activation apps into Settings->Apps->Special a..."
Revert submission 25108596-va-special-access

Reason for revert: voice activation is not going in V

Reverted changes: /q/submissionid:25108596-va-special-access

Bug: 306447565
Bug: 393727896

Test: presubmit

Change-Id: I4977e7d543cb800fc9fb6962bba3afebb9480dcc
Merged-In: I4977e7d543cb800fc9fb6962bba3afebb9480dcc
2024-05-20 11:56:48 +08:00
ELIYAZ MOMIN
19b01bd68b Revert "Migrate AppOps"
Revert submission 27392016-cherrypick-AppOpsController-AppOps-w48m53c1or

Reason for revert: <Potential culprit for b/341210811- verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.>

Reverted changes: /q/submissionid:27392016-cherrypick-AppOpsController-AppOps-w48m53c1or

Change-Id: Ib9813a48170f4ef38de9eee811c677ad75f5401e
2024-05-17 10:48:57 +00:00
Chaohui Wang
4573df2aaf Migrate AppOps
Bug: 339846642
Test: manual - on Special app access
Change-Id: I988bdf85036478d8e6d87a3b5a1a46a35df38422
2024-05-17 02:57:31 +00:00
Chaohui Wang
99b09df4a8 Fix empty network scan result
Settings use TelephonyScanManager.NetworkScanCallback to scan, and its
onComplete() could happens before onResults().

We will change Settings to fix.

Fix: 338986191
Test: manual - on NetworkSelectSettings
Test: unit test
Change-Id: If41d957f916a99eacc1becb6b460e58722a4dca7
Merged-In: If41d957f916a99eacc1becb6b460e58722a4dca7
2024-05-15 15:29:55 +08:00
Chaohui Wang
12158eb1fe Create NetworkScanRepository
And migrate network scan to flow for better maintenance and prevent ANR.

Fix: 323105271
Test: manual - Choose network
Test: unit test
Change-Id: I5c49d195fc202143c0131ffd78bc3adc168b119c
Merged-In: I5c49d195fc202143c0131ffd78bc3adc168b119c
2024-05-15 14:09:03 +08:00
Treehugger Robot
eb729f283c Merge "Fix flicker of "App data usage"" into 24D1-dev 2024-05-09 05:50:55 +00:00
Chaohui Wang
9e5b389de3 Fix flicker of "App data usage"
Use placeholder to hold the place.

Fix: 323466366
Test: manual - on Mobile Settings
Test: unit test
Change-Id: I3c4d9ff6538a79500318869f01f4b88b55bd9475
(cherry picked from commit 74fe516e09)
Merged-In: I3c4d9ff6538a79500318869f01f4b88b55bd9475
2024-05-08 05:29:27 +00:00
Chaohui Wang
107cca7a77 Fix data usage when policy has no cycle
Fallback to four weeks, as the same as no policy.

Fix: 336108815
Test: manual - on DataUsageList
Test: unit test
Change-Id: I63140a13ea3f3ee790cc911432fbdfd6247f7318
2024-05-07 14:22:35 +00:00
Chaohui Wang
c63f06d4c8 Fix isInCallFlow when no active subscription
Direct emit false in this case to fix.

Fix: 338484668
Test: manual - on SIMs
Test: unit test
Change-Id: I5286701160d95b1c06e577db6232f7e70f040cdb
2024-05-07 10:57:24 +00:00
Chaohui Wang
bbc3a352e3 Merge "Reapply "Create CallStateRepository.isInCallFlow"" into 24D1-dev 2024-04-30 07:47:30 +00:00
Tom Hsu
0a8d830616 Merge "Revert^2 "Add a new warning dialog for Satellite mode"" into 24D1-dev 2024-04-30 07:05:49 +00:00
Chaohui Wang
7bbd8fa4e3 Reapply "Create CallStateRepository.isInCallFlow"
This reverts commit 93e4c65d3d.

Fixed the test by cherry-pick change
I7a3d27cb53c930a56ab0f0896b545807bf4f9dc0.

Bug: 336209156
Test: manual - on MobileNetworkSwitchController
Test: atest SubscriptionInfoListViewModelTest
Change-Id: Id606d6ee90acd8a98de706d8533fed0aac96bff4
2024-04-30 12:33:54 +08:00
Chaohui Wang
f97e76bc3f Fix SubscriptionInfoListViewModelTest
Fix: 329160337
Test: unit test
Change-Id: I7a3d27cb53c930a56ab0f0896b545807bf4f9dc0
(cherry picked from commit 10f5bdabb4)
Merged-In: I7a3d27cb53c930a56ab0f0896b545807bf4f9dc0
2024-04-30 03:32:08 +00:00
Tom Hsu
1b308f5df8 Revert^2 "Add a new warning dialog for Satellite mode"
This reverts commit 15c90207e2.

Reason for revert: ag/27138142 shall fix the crash instead of reverted one.

Change-Id: Icf46fda7af9c9bb6921bc10de0f9c93926f42fac
2024-04-30 02:17:15 +00:00
Priyanka Advani
93e4c65d3d Revert "Create CallStateRepository.isInCallFlow"
This reverts commit 6142ad927e.

Reason for revert: Droid-monitor created revert due to Build breakage in b/337914519. Will be verifying through ABTD before submission.

Change-Id: I300d5397de156fd0815965cfd99f0814f1365ffc
2024-04-29 20:31:15 +00:00
ELIYAZ MOMIN
15c90207e2 Revert "Add a new warning dialog for Satellite mode"
This reverts commit 680d062c77.

Reason for revert: <Potential culprit for b/337796129  - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.
>

Change-Id: I6fbb7a0587fbb474012e1a97a75c036420500f99
2024-04-29 11:37:35 +00:00
Chaohui Wang
6142ad927e Create CallStateRepository.isInCallFlow
Which will emit true if any active sub is in call.

And also create SubscriptionActivationRepository to use isInCallFlow.

Bug: 336209156
Test: manual - on MobileNetworkSwitchController
Test: unit test
Change-Id: I75460bf17961349557ac1e19e7f6b15249f3d7b0
2024-04-29 10:15:13 +00:00
tomhsu
680d062c77 Add a new warning dialog for Satellite mode
Bug: 337154438
Test: atest pass.
Test: Maunal test pass.
Change-Id: I33dbf3502c780cedd5422e2b44678ecb9a22a662
2024-04-29 08:37:28 +00:00
Samuel Huang
316e7bf3e6 Disable SIM On/Off operation when device is in Satellite Enabled Mode
Cherry-picking ag/26965536 into the 24D1-dev branch caused conflicts. Therefore, manually create this CL to migrate the MobileNetworkSwitchController to Kotlin and utilize Compose.

Bug: 315928920
Test: atest, manual
Change-Id: I215b5a4615a3b3da6fc160f76c85c814210cc3ef
Merged-In: I7aaaf43b4c449129197e7cc92565d274ffdd2d8c
2024-04-16 09:52:00 +00:00
Song Chun Fan
844d2f4c67 [Settings/Archive] remove all checks for the archiving system property
No longer needed

BUG: 331165939
Test: builds
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:6ae958abd26ed77ecd4d3fb1720bb912553da2ea)
Merged-In: I24bc9a3d7503da1606d29eb3dfa963b0e6bf9d3e
Change-Id: I24bc9a3d7503da1606d29eb3dfa963b0e6bf9d3e
2024-04-09 18:08:41 +00:00
Chaohui Wang
67579d564b New countryIfOriginLabel
And display this label as fallback when Regulatory Image is missing.

Bug: 329378943
Test: manual - on SIMs
Test: unit test
Change-Id: I0b8851da20face9ca444b3e6456a4a662b944b65
Merged-In: I0b8851da20face9ca444b3e6456a4a662b944b65
2024-03-15 09:23:31 +00:00
Graciela Wissen Putri
a0f573a35e Follow config overlay's order of aspect ratio options
Fix flaky UserAspectRatioAppsPageProviderTest by using advanceUntilIdle
to make sure all coroutines are finished before asserting.

Bug: 325911424
Test: atest UserAspectRatioDetailsTest
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:32815ad699448c5c5b1f38df6d2d2a881d4251c1)
Merged-In: I83e9a7f31536c1a006789722b0310f3364d14337
Change-Id: I83e9a7f31536c1a006789722b0310f3364d14337
2024-03-05 17:11:59 +00:00
Chaohui Wang
bec4c9573e Create isSubscriptionEnabledFlow
To better display the isEnable checked state.

Bug: 318310357
Test: manual - on Mobile Settings
Test: unit test
Change-Id: Ia595e7445650ad67883f1e7c1a0662cb826565ea
2024-03-02 05:01:28 +00:00
Charlotte Lu
7aee673020 Merge "Add WEP warning dialog disconnect." into main 2024-02-29 02:35:33 +00:00
Charlotte Lu
7755dc53b9 Add WEP warning dialog disconnect.
Test: Unit Test
Fix: 318797664
Change-Id: I48dd4ad2783ea4b1f03f2b7c7e0f8716cbb59224
2024-02-28 17:51:20 +08:00
Chaohui Wang
758e3828b3 Disable app data usage if all time usage is 0
Otherwise user can open an empty App data usage page.

Bug: 292346951
Test: manual - on Mobile Settings
Test: unit test
Change-Id: I63c3e06af2606c3e2017f2440addb2ac2d9d775b
2024-02-28 13:17:28 +08:00
Charlotte Lu
88bc924647 Merge "Change Privacy into full page." into main 2024-02-27 10:11:17 +00:00
Chaohui Wang
daa509874f Fix Wi-Fi calling option does not appear
After turning on non-DDS sim.

This is because IMS feature takes time to provisioning, and IMS takes
time to become ready.

Before this fix, we do not observe the status.
After this fix, observe the readiness to fix.

Fix: 325414275
Test: manual - turn DSDS on - off
Test: unit tests
Change-Id: If10abdb331da1ff8310e10681d055d7fbe04eaee
2024-02-27 08:11:31 +08:00
Chaohui Wang
b4ab4144aa Create WifiCallingRepository
Move Wi-Fi calling related feature into it.

Which simplifies the ImsMmTelRepository, so we can put more
ImsMmTelManager related features into ImsMmTelRepository in the future
cl.

Bug: 325414275
Test: manual - on Mobile Settings
Test: unit tests
Change-Id: I391f43cfa3a79e0c44865050c357ac54346c2fb1
2024-02-26 18:49:20 +08:00
Charlotte Lu
8b8a16bc7c Change Privacy into full page.
Test: Visual Test
Fix: 324020620
Change-Id: Ifacbf7eef3b56774c5f891c8cd60ddee2d380632
2024-02-26 04:26:26 +00:00
Manjeet Rulhania
322b905f71 Merge "add sensitive content protection flag to developer option" into main 2024-02-24 00:52:16 +00:00
mrulhania
8925db1c5e add sensitive content protection flag to developer option
Bug: 316955558
Test: atest SensitiveContentProtectionPreferenceControllerTest
Change-Id: Iedbbc9bd3bba00c6aaccc99758abe0b77306da01
2024-02-23 19:50:17 +00:00
Varun Shah
646d052228 Merge "Add new Special App Access screen for Backup Tasks." into main 2024-02-22 21:46:53 +00:00
Hani Kazmi
05427e6903 Merge changes from topics "ecm-manager", "ecm-tests" into main
* changes:
  Replace ECM AppOps call with service
  Wired remaining SpecialAppAccess for ECM.
2024-02-21 19:29:04 +00:00
Hani Kazmi
206300962f Replace ECM AppOps call with service
A new ECM service was introcuded in changeId
I831391e4437b51b3312b5273a2360bd029a3d8ee.

We begin calling it, and update/cleanup method signatures to match.

Note: There are two feature flags:

1. enhancedConfirmationModeApisEnabled - read only, protects the
   mainline API.

2. extendEcmToAllSettings - runtime - gates calls to the above APIs.

We use both so we can ramp up in teamfood as needed.

Bug: 297372999
Test: Tested on device
Test: atest SpaPrivilegedLibTests
Test: atest com.android.settings.applications.specialaccess.notificationaccess
Test: atest com.android.settings.datausage
Test: atest PremiumSmsAccessTest
Test: atest RestrictedPreferenceHelperTest
Change-Id: I945ec51df5cd63de548a8ffdd1acc4f09f2301e5
2024-02-21 14:43:02 +00:00
Chaohui Wang
6664870eb8 Fix cannot update APN settings in new edit page
Fix: 326164397
Test: manual - edit existing APN
Test: unit test - existing tests still pass
Change-Id: I92a2e375b990f0e478dbb30c389371a8e0596608
2024-02-21 18:14:20 +08:00
Yiyi Shen
a2577fd60e [Audiosharing] Impl audio sharing feature provider in Settings
Bug: 324023639
Test: manual
Change-Id: I4005ea8fbc0983a833f5a7dee2815f09eab48d3c
2024-02-20 08:06:55 +00:00
SongFerng Wang
f4d0eff41e Merge "[SimUiEnhancement] Fix Automatic Data switch UI at SimOnboarding" into main 2024-02-20 02:02:22 +00:00
songferngwang
6d0b41af5a [SimUiEnhancement] Fix Automatic Data switch UI at SimOnboarding
- Automatic Data switch can't set value to framework, since
the nonDds is -1
- update the ProgressDialog as compose UI

Bug: 318310357
Bug: 298898436
Bug: 298891941
Test: Build pass
Change-Id: Ifeca38b42b3a51e8a967c0e744eeae06338f6ddc
2024-02-19 03:12:50 +00:00
Chaohui Wang
e9917e2f48 Fallback to NUMERIC when CARRIER_ID is unknown
For some subscription, the carrier id is unknown (-1), which cause the
inserted APN not be displayed.

Fallback to NUMERIC when CARRIER_ID is unknown to fix this issue.

Fix: 324394199
Test: manual with esim test profile - carrier id -1
Test: unit tests
Change-Id: Ic63a3e0c9ab37c8bdf86a2c7155b08778f05deff
2024-02-18 16:26:15 +08:00
Varun Shah
a00a81cc1c Add new Special App Access screen for Backup Tasks.
This new screen shows apps that hold the new RUN_BACKUP_JOBS permission.

Also add a reference to this screen in an app's info page under the
"Advanced" section for apps that have requested this permission.

Bug: 320563660
Test: BackupTasksAppsTest
Test: BackupTasksAppsPreferenceControllerTest
Test: visually via the Settings page

Change-Id: I7136fc74f3b0d0124889e7cf9e1234f917346432
2024-02-17 21:54:12 +00:00
Mark Kim
bf0ea22082 Disable APP_ARCHIVING flag for specific test
APP_ARCHIVING flag was introduced to control archiving feature in
Settings separately from OS.
The broken test was expecting archiving feature flag be disabled but it
didn't take into account a newly introduced flag which was automatically
rolled out in ag/26270549

Test: AppButtonsTest
Bug: 325632047
Change-Id: I02a1f4e2e2bfa1b85f2d993c4127698c8a6195dc
2024-02-17 00:47:05 +00:00
Ahaan Ugale
a4f81032f2 Merge "Update sensitiveNotificationAppProtection reference after move." into main 2024-02-14 19:40:32 +00:00