Commit Graph

15931 Commits

Author SHA1 Message Date
Andrii Kulian
8e3859bc5a Add dev option to force desktop mode
Bug: 112451761
Test: DesktopModePreferenceControllerTest
Test: FreeformWindowsPreferenceControllerTest
Change-Id: I7df995d1bd8731b813cfa0c72c4dc6d35973e939
2018-11-07 13:57:03 -08:00
TreeHugger Robot
b68d244807 Merge "Update new UI of conditional cards" 2018-11-07 17:40:08 +00:00
Mill Chen
0ca7130403 Update new UI of conditional cards
- Add half-width and full-width layouts for conditional cards
- Keep origin strings of conditional cards, that could make conditional
cards truncate its title and summary in half-width card.
- Add default value of isHalfWidth to each condition controller.

Bug: 113451905
Test: robotests, visual
Change-Id: Ib0055f32c4ab9e73c0e0a57c6b0ef586d52942e0
2018-11-07 16:06:31 +08:00
TreeHugger Robot
ebe6774a2c Merge "Use inline radio buttons for Prevent Ringing" 2018-11-07 01:52:47 +00:00
Beverly
c1fd6dc5a3 Use inline radio buttons for Prevent Ringing
Test: atest PreventRingingGesturePreferenceControllerTest
Fixes: 79867902

Change-Id: I3c9f949e038bba98e5be972adc01f35f5513432a
2018-11-06 10:12:08 -05:00
Stanley Wang
5d2a3d23e7 Merge "Architecture review of Copyable Slice" 2018-11-06 05:00:05 +00:00
Stanley Wang
51c9404182 Architecture review of Copyable Slice
Design doc: https://drive.google.com/open?id=1NJPd_282H4195HUGJH5cGJO_Jrcz1Vl6AAw_VQOtGq0

Fixes: 	118398321
Test: manual
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.slice

Change-Id: Ic6762e58698a994d16a5de1778b4035ae430a256
2018-11-06 11:01:17 +08:00
TreeHugger Robot
1d436aade2 Merge changes from topic "refactor-security-location"
* changes:
  Rename title of Security page
  Move LocationSettings to top level page.
2018-11-06 02:01:17 +00:00
TreeHugger Robot
4e8e8ca844 Merge "Clarify notification dots/icons strings" 2018-11-05 22:29:31 +00:00
TreeHugger Robot
9fb79cbe16 Merge "Remove the unnecessary preferenceCategory" 2018-11-05 19:55:55 +00:00
Beverly
0c0f54f48f Clarify notification dots/icons strings
In the Custom Notification DND options, clarify
what notification dots and notification icons are by
adding more information in the strings

Test: manual
Change-Id: I54ef19d46e54ec10da7179fd142043e3a3af0a40
Fixes: 112188372
2018-11-05 10:55:07 -05:00
Sunny Shao
201f1f6146 Merge "Added the icon displayed on no account in search bar" 2018-11-05 05:31:03 +00:00
tmfang
91988d018e Rename title of Security page
Since "Location" was moved to top level,
title shouldn't be "Security&Location"

Bug: 116628158
Test: visual
Change-Id: I9065cae15c014d8826b5473e590177d400666180
2018-11-05 11:28:23 +08:00
tmfang
54a5d37190 Move LocationSettings to top level page.
- Create some location icons for different scenario.
- Remove Location in Security page.
- Move Location Setting to top level page.

Test: robotest, visual
Bug: 116628158
Change-Id: I3f57ef49a396877bfbeaefea7dc4f4051e0ccc65
2018-11-05 11:24:41 +08:00
Sunny Shao
6dc1cc2a77 Added the icon displayed on no account in search bar
Mofidied the search_bar layout and added this icon in the right side of the search_bar.
Added the hasAccount api in AvatarViewMixin and display this icon when there is no any account in device.
Added the test case of the AvatarViewMixin.

Bug: 117509285
Test: robotest
Change-Id: I6ceaa457af4fb20acd0211ca840df5b530c47e0f
2018-11-05 10:52:11 +08:00
Emily Chuang
7d1fc0d3db Update the layout of contextual cards.
Fixes: 118849830
Test: visual
Change-Id: Ia3f7f155271a22f4f6214fad861475442c23c2f6
2018-11-05 10:49:19 +08:00
TreeHugger Robot
d717790c64 Merge "Clean up useless layout" 2018-11-03 06:28:19 +00:00
jackqdyulei
ef79de6ad9 Remove the unnecessary preferenceCategory
In talkback, it counts the untitled preferenceCategory as an visiable
item. This CL remove unnecessary cateogry and add divider line manually.

Bug: 118796245
Test: RunSettingsRoboTests

Change-Id: I77151fdce671cf91322b3c1badc06a3b7861dcc0
2018-11-02 13:24:14 -07:00
Eugene Susla
cabbb1a522 Merge "Add developer option for sms access kill switch" 2018-11-02 18:18:51 +00:00
tmfang
fb84503d64 Clean up useless layout
There is no any reference to this layout

Bug: 116340579
Test: robotest

Change-Id: I1ec97c6e30cb9e39a2a366dbe7f7b52f49390936
2018-11-02 13:43:14 +08:00
Cosmo Hsieh
c842290974 Merge "Implement NetworkRequestDialog architecture" 2018-11-02 01:39:47 +00:00
Kevin Chyn
0e11b18cf0 Merge changes from topic "biometric-cc"
* changes:
  3/n: Make CDCA transparent and add BiometricPrompt
  2/n: Add comments to launchConfirmationActivity parameters
  1/n: Prepare ConfirmDeviceCredentials to use BiometricPrompt
2018-11-02 00:37:24 +00:00
TreeHugger Robot
887564b114 Merge "Dnd settings pages redesign (round 1)" 2018-11-01 23:47:36 +00:00
Kevin Chyn
b3ee23154d 3/n: Make CDCA transparent and add BiometricPrompt
ConfirmDeviceCredentials now uses BiometricPrompt instead of
FingerprintManager

Bug: 111461540

Test: FRP does not display BiometricPrompt (as expected)
      adb shell settings put global device_provisioned 0 && adb shell am start -a android.app.action.CONFIRM_FRP_CREDENTIAL
Test: Using KeyguardManager API to launch, all corner cases seem OK
Test: Tested with work profile + one lock enabled/disabled, seems OK
Test: Enroll normal FP but not work FP, BiometricPromptDemo for both works
      OK
Test: Test CC on work version of BPD, then BP on normal version of BPD,
      both accept correct FP's (no regression from P)

Change-Id: Iacdaf76ab76971850212dc79513bfa3f4b89eb9a
2018-11-01 15:14:04 -07:00
TreeHugger Robot
0af2ade371 Merge "Remove "See more" from wifi/bluetooth slices" 2018-11-01 21:59:45 +00:00
Kevin Chyn
e5a016e076 1/n: Prepare ConfirmDeviceCredentials to use BiometricPrompt
CDC is going to use BiometricPrompt instead. This change
removes FingerprintManager from CDC. BiometricPrompt
will show before pin/pattern/pass is shown.

Bug: 111461540

Test: modified BiometricPromptDemo to use
      KeyguardManager#createConfirmDeviceCredentialIntent,
Test: Fingerprint is gone from CDC, rotation works
Test: atest SettingsRoboTests

Change-Id: I9ce2aad71961af8a0d5ee636600e2fbdb6154e47
2018-11-01 14:11:57 -07:00
TreeHugger Robot
f19a9840d7 Merge "Remove emptry preference category for Talkback" 2018-11-01 20:51:30 +00:00
Emily Chuang
4b08270d8c Remove "See more" from wifi/bluetooth slices
- Also set the height of SliceView back to wrap_content as the space our
content needs can be satisfied with MODE_LARGE.

Change-Id: Ibaa514ac9c022c2723d99e5104f8d5ec63f14661
Fixes: 118763869
Test: robotests, visual
2018-11-01 12:32:51 -07:00
Fan Zhang
e4b4923dd0 Merge "Fix slice card layout so show more button works correctly" 2018-11-01 19:14:40 +00:00
Fan Zhang
303fd8cc1a Merge "Use safe icon when building unavailable slices." 2018-11-01 19:13:37 +00:00
Fan Zhang
08f677d9e0 Merge "Change Google Settings position" 2018-11-01 18:19:08 +00:00
jackqdyulei
ece1219db6 Remove emptry preference category for Talkback
In this way talkback can get correct list size.

Bug: 117198438
Test: Manual
Change-Id: Ie0cd78fb20fe416ee517d6c35458a4805ce9c17f
2018-11-01 10:08:35 -07:00
TreeHugger Robot
c2a07ac938 Merge "Click "Users & Profile" in Settings Search displays a blueline" 2018-11-01 16:58:10 +00:00
Beverly
69d11b2874 Dnd settings pages redesign (round 1)
Test: make RunSettingsRoboTests -j40
Bug: 111475013
Change-Id: Idb6bbfdfe377b61a8fe1f7e81171bbefe23a4ebf
2018-11-01 09:24:46 -04:00
Raff Tsai
2e6f061b76 Change Google Settings position
- PreferenceGroup defines dynamic insert order starts from 0. It is
bigger than System Settings definition -10, therefore Google Settings
will be placed below System Settings.

Fixes: 118735593
Test: Visual
Change-Id: Id2d187810a8539ea50e14ef802db6eae58b846e4
2018-11-01 16:56:57 +08:00
Lei Yu
dd3feeb155 Merge "Rename a bunch of mobile network files" 2018-10-31 20:04:03 +00:00
TreeHugger Robot
d7fb88333f Merge "Import translations. DO NOT MERGE" 2018-10-31 19:40:26 +00:00
Antony Sargent
2cbd720d21 Add a feature flag for new version of Network and internet settings page
In addition to adding the flag, this also adds a new xml layout that is
the same as the existing network and internet page, but will begin to be
changed in subsequent CLs. There is also a change in code to use this
new layout when the flag is turned on.

One other change is to make the list of displayed feature flags in
developer options be in sorted order instead of whatever semirandom
order they come out of the map's key set.

Bug: 116349402
Test: Manual (settings_network_and_internet_v2 flag should should up in
Settings -> System -> Developer options -> Feature flags, and those
flags should be in sorted order)

Change-Id: I5520d286efb6bec50ba4ca99f64aeca94f01d533
2018-10-31 05:29:34 +00:00
Bill Yi
f84d9124c5 Import translations. DO NOT MERGE
Change-Id: I05c3010b112b0f65bf246b73cf482d9722f75648
Auto-generated-cl: translation import
2018-10-30 21:18:57 -07:00
cosmohsieh
cd192209ef Implement NetworkRequestDialog architecture
Bug: 117399926
Test: RunSettingsRoboTests

Change-Id: Ibf0a62a84bc3de080e4537ba084b0ff9a5e0e9a9
2018-10-31 11:26:00 +08:00
Fan Zhang
2fa9b7b652 Fix slice card layout so show more button works correctly
Change padding top/bottom to margin, so the sliceview can use the full
288dp height (4 rows + see more button).

Side effect is that ripple doesn't fill the entire cardview. But it
never did anyway.

Change-Id: Ie57187fbe2b8caa2cf9d0dc31d7678eee07085f4
Fixes: 118398695
Test: visual
2018-10-31 11:09:28 +08:00
Raff Tsai
0be77ac054 Click "Users & Profile" in Settings Search displays a blueline
- It is a preference category, remove it from search result.

Fixes: 118654997
Test: Clear Settings Sugggestion data and search again.
Change-Id: I5a41e03c3fa703913233353a90b65ae18a7ab06b
2018-10-31 10:54:04 +08:00
jackqdyulei
2aae67a061 Rename a bunch of mobile network files
1. Make them have "MobileNetwork" prefix
2. Also update WifiCallingPreference to remove its category
if it is invisible

Bug: 114749736
Test: RunSettingsRoboTests
Change-Id: I25871d579d6495e902e5583030889942ed2506a8
2018-10-30 16:28:56 -07:00
Fan Zhang
f535055e2e Use safe icon when building unavailable slices.
And move ic_a11y_generic from mipmap to drawable. IconCompat doesn't
support mipmap.

Bug: 118691898
Test: robotests
Change-Id: I6799f3d31d2c5654319e5a97bf8ca14992e785a7
2018-10-30 14:48:47 -07:00
Eugene Susla
7edf50fdd2 Add developer option for sms access kill switch
Cleanup tracking bug: b/118694572

Test: ensure switch toggles global setting
Change-Id: I1faa873a91a933a7693a4b799495cf3877d37888
2018-10-30 20:59:00 +00:00
Fan Zhang
0023558ec3 Fix Display settings summary when there is no wallpaper.
Change-Id: I715cef9dc42de1231491b5a7184f0f151d94af11
Fixes: 69905032
Test: robotests
2018-10-30 10:10:30 -07:00
TreeHugger Robot
f93b925588 Merge "Use ImeAwareEditText in FingerprintSettings" 2018-10-29 22:48:29 +00:00
Rakesh Iyer
7ad62ef340 Merge "Misc fixes to TTS settings." 2018-10-29 21:26:26 +00:00
Yohei Yukawa
af4426bb65 Use ImeAwareEditText in FingerprintSettings
Like we did the same thing in the Settings app [1][2][3],
FingerprintSetting is another instance that should use
ImeAwareEditText to make sure InputMethodManager#showSoftInput() is
called after the EditText gains IME focus.

This approach should be more robust and easier to maintain than trying
to control the software keyboard visibility with
SOFT_INPUT_STATE_ALWAYS_VISIBLE, which is more complicated that people
think.

This CL also removes RenameDialog#mTextHadFocus since
RenameDialog#mDialogTextField is always focused when the dialog is
shown [4].

This CL also removes the following fields since they can just be a
local final variables that will be captured into callback.

 * RenameDialog#mFingerName
 * RenameDialog#mTextSelectionStart
 * RenameDialog#mTextSelectionEnd

 [1]: I182b05d3ff59fb3b4732d60d0d5a464f0e0e0235
      f6af093e2d
 [2]: I892d639f3cc5d43db553b682d5278b8ce2fe72da
      4803267106
 [3]: Ib75ba0f361b8b46c3b717cc1ffb864726958ed82
      b0bcbed372
 [4]: I5bb1b7227c1323595bf7f483e11e87e2c3550093
      7a1d52eb06

Fix: 118473687
Test: Manually verified as follows.
      1. Build and flash aosp_taimen-userdebug to Taimen
      2. Set up a fingerprint unlock.
      3. Rotate the device to landscape mode.
      4. Open Settings -> Security & location -> Fingerprint
      5. Re-enter password if necessary
      6. Tap "Finger 1"
      7. Make sure that AOSP Keyboard shows up
Change-Id: I2a137aa8f6a1ee2b67923bcf40e82320a56c7b59
2018-10-29 13:09:12 -07:00
Rakesh Iyer
52fd31c2f3 Misc fixes to TTS settings.
1. Remove an extra PreferenceGroup that was causing some spacing
   issues.
2. Remove the animations when elements resize because this causes
   items to slide around unnecessarily.
3. While we're in the file, lambda-ify some of the older code.

Bug: 77981482
Bug: 79897262
Test: Manually verified.
Change-Id: I9c79beea3a231ba62aeef3543802faebd775e128
2018-10-29 10:20:28 -07:00