Commit Graph

47 Commits

Author SHA1 Message Date
Tsung-Mao Fang
ab914adc00 Remove permission bar chart in Privacy setting
- Because permission hub is already postponed,
we don't need to show this UI in privacy settings.

Test: Rebuild, visual, robotest
Change-Id: I51aca52bc605a3c6b0cafc084e8e491c280d770f
Fix: 143447873
2019-10-28 19:00:44 +08:00
Raff Tsai
ac3e0d0988 Directly use BaseIndexableProvider
- Add function getXmlResourceId, Fragments don't need to write
xml resource id twice.
- Remove getPreferenceControllers from Indexable.java. Because it will
move to SettingsLib later for other apps which don't need this function

Bug: 135053028
Test: robolectric
Change-Id: I1e74519aecdea3dde64a5aea79f08d766dbc0003
2019-09-24 00:35:52 +08:00
Tsung-Mao Fang
12155084d8 Hide a11y usage when there is no enabled a11y service
A11y usage still shows in privacy page after
user disable a11y with a11y usage dialog.

We need to check again whether there is any enabled a11y
after screen comes back to foreground.

Change-Id: Icf7aa7dc9d802765ec49df8651385397f454cd48
Fix: 140207216
Test: robotest
2019-09-20 17:32:19 +08:00
TreeHugger Robot
5cb9f7801c Merge "Fix double divider in Privacy page" 2019-06-18 06:50:24 +00:00
Jason Chiu
f3e3d7a46b Fix double divider in Privacy page
The second divider is shown after we set a background to the pinned
header.

- Simply hide the pinned header instead of its inner views.
- Move setActionBarShadowAnimation to controller and just call it when
  the bar chart is available.

Fixes: 134652710
Test: robotest, visual
Change-Id: I4381e5ca1a042583d3e5874f5600719267b19786
2019-06-18 11:50:45 +08:00
Ivan Podogov
8573d27d31 Merge "Add "Your work policy info" entry in Privacy settings" into qt-dev
am: 9a1c75c57a

Change-Id: Ib61dae6c30e90500aaec381a6eb5f7f7a82bc610
2019-06-17 05:49:13 -07:00
Ivan Podogov
75a10d1fd2 Add "Your work policy info" entry in Privacy settings
Bug: 132904820
Test: manual
Change-Id: Id706d450c3ad6a6a8c1e402d39d18e048cdb6519
2019-06-14 13:07:21 +01:00
Joel Galenson
2118f8a63f Revert "Remove Permissions Hub."
This reverts commit 1e7c172ad5.

Bug: 132292477
Test: None.
Change-Id: Icae2cd4edbb22e2f3ea72e20f0ebd818f1ac6629
2019-05-31 07:55:19 -07:00
Joel Galenson
58246f66db Merge "Remove Permissions Hub." into qt-dev
am: 63088840c4

Change-Id: I59cef5b593630d75b6db51ae324c94f9dc3a8841
2019-05-31 06:07:29 -07:00
Joel Galenson
1e7c172ad5 Remove Permissions Hub.
Bug: 132292477
Test: View all related screens.
Change-Id: Ic0e890e04f210f3be3eb80c95e398a40a8062001
2019-05-30 08:30:49 -07:00
Adam He
83f0d24f67 Profile select only shows with multiple profiles present.
Bug: 133328247
Change-Id: Id5d03a1aa74f1789c41af37562848603a90db84f
Test: manual verification
2019-05-29 14:22:22 -07:00
Joel Galenson
e4c8efe245 Show the accessibility usage preference when Permissions Hub is disabled.
Fixes: 132909181
Test: See dialog with Permissions Hub disabled.
Test: atest AccessibilityUsagePreferenceControllerTest
Change-Id: I56a433d561b0d77d8ece0fd6752871fa79cec850
2019-05-17 10:19:49 -07:00
Adam He
e840691e52 Display profile picker for content capture settings.
Fixes: 131748579
Test: manual verification
Change-Id: Iccce8aab8eb3596cb195d64d5711e9407a844541
2019-05-07 11:31:57 -07:00
Joel Galenson
2102faf3e3 Do not special case the storage permission group.
We are now not showing storage usages in Permission Controller,
including in the API Settings uses.  We can thus remove this code so
that Settings will reflect what Permissions Hub shows.

Bug: 130567526
Test: See the same graph here and in the dashboard.
Change-Id: Iaa7d95b05f4321543ed42833ac3a7babdb9914f0
2019-04-16 15:44:52 -07:00
Svet Ganov
864765f8b4 Update Settings to use the proper DeviceConfig API.
Exempt-From-Owner-Approval: carry over approval from ag/6908306

bug:124769181

Change-Id: If18d0dc5e55dabf82b7c7a2b6df240fb8b24f736
2019-04-07 22:37:02 -07:00
TreeHugger Robot
0a214d31f4 Merge "When filtering permission usages by a single permission, default to last day." 2019-03-28 20:27:50 +00:00
Joel Galenson
9a2017ef57 When filtering permission usages by a single permission, default to last day.
The general link to the dashboard shows only the last day, but
clicking on an individual permission did not.

Fixes: 129471807
Test: Click on permission.
Change-Id: Ice3b5b1ac6e2cb5a49cabf3c56167c9d39d3c3a1
2019-03-28 16:07:54 +00:00
Joel Galenson
2512aa1ed6 Add tiebreak rules for bar chart permissions.
If multiple permissions have been used by the same number of apps, we
apply a stable tiebreak so we can be consistent in different places.
We prefer location, then microphone, then camera, and everything else
is alphabetical.

Test: View chart with ties.
Test: atest PermissionBarChartPreferenceControllerTest
Change-Id: I035ac19391788cc720e1c832bf8bd5a60d31e8ad
2019-03-28 08:38:30 -07:00
Joel Galenson
22ab71c7c6 Change the permission bar chart to use the new design
- Each bar is now labeled with the permission name and the subtitle is
slightly different.
- Change some string for new design

Test: View screen.
Test: atest PermissionBarChartPreferenceControllerTest
Change-Id: Ia82f9cbb6255d93c38a27b038ae5af3f066eec28
2019-03-26 13:50:35 +08:00
TreeHugger Robot
4d33ead8ef Merge "Updated privacy settings to launch custom content capture settings when available." 2019-03-22 18:35:58 +00:00
Felipe Leme
fcf98251f2 Updated privacy settings to launch custom content capture settings when available.
Test: manual verification
Test: atest EnableContentCapturePreferenceControllerTest \
      CtsContentTestCases:android.content.cts.AvailableIntentsTest#testRequestEnableContentCaptureIntent
Test: adb shell am start-activity -a android.settings.REQUEST_ENABLE_CONTENT_CAPTURE

Fixes: 119264902

Change-Id: I2a030c31d966d40feb6ba449e4bbc9ef8cf0565b
2019-03-22 08:10:48 -07:00
TreeHugger Robot
5826f427e2 Merge "Remove shadow from "Apps and Notifications"" 2019-03-22 05:19:36 +00:00
tmfang
aed8f361fc Remove shadow from "Apps and Notifications"
- Also create a util method to reuse it in different class.

Test: visual
Fixes: 128437380
Change-Id: I0e136feed3aead8c37e381095daebded55ef298d
2019-03-22 11:08:15 +08:00
Joel Galenson
f5c985fc65 RuntimePermissionUsageInfo.getName() now returns a String.
Fixes: 128994612
Test: View the bar chart.
Test: atest PermissionBarChartPreferenceControllerTest
Change-Id: I2f21dfae533544e99495bbfab5d1b5eb3e9282fe
2019-03-20 12:19:25 -07:00
Felipe Leme
0d3444a300 Added new toggle for Content Capture on Settings -> Privacy
Test: manual verification
Test: atest EnableContentCapturePreferenceControllerTest

Bug: 119264902

Change-Id: I2e29d7892892e6a0f90a97e35c48df231d67b0b6
2019-03-07 15:00:00 -08:00
Joel Galenson
ca75538d0c Allow Talkback to speak the permission name in the bar chart.
Bug: 127237805
Test: Enable Talkback, click on access
Change-Id: Ib8d5d3b0fe25e1d3ea4f0b969ff03b663ce716f4
2019-03-05 14:16:24 -08:00
tmfang
44e5aeca65 Bar chart preserves data before rotating device
We saw chart view is gone while rotating device.

Fow now, we save the old permission data before
fragment was recreated.
Then, we can initialize the view quickly with
old data.

Test: robotest, visual
Fixes: 123539793
Change-Id: I230fecc6001a17a0c0205f2a1dcb5dd79f32e744
2019-02-27 11:25:35 +08:00
TreeHugger Robot
9e9dc49cb8 Merge "Add progress bar for Privacy screen" 2019-02-18 03:04:05 +00:00
Joel Galenson
858fa64d4a Check flag to see whether to show accessibility usage dialog.
Test: Manually set/unset flag, see/don't see dialog.
Test: atest AccessibilityUsagePreferenceControllerTest
Change-Id: I214cf0bf4c67889f48e43fdf774a943dd11e6c34
2019-02-15 08:16:33 -08:00
tmfang
64f5b796c2 Add progress bar for Privacy screen
We show up top linear progress bar
when Settings is querying permission usage data.

Test: visual, robotest
Fixes: 123539793
Change-Id: I350068856d1708eb054d2a205d9ca857214891ce
2019-02-15 11:01:10 +08:00
Fan Zhang
ed2db4aaa1 Merge "Mass clean up: don't cast class when not needed." 2019-02-14 23:13:44 +00:00
TreeHugger Robot
2bd74f7e50 Merge "Add accessibility usage preference to the Privacy screen." 2019-02-14 21:04:32 +00:00
Fan Zhang
7db118e367 Mass clean up: don't cast class when not needed.
Bug: none
Test: rebuild
Change-Id: Ie3f58a3d5ae99ade28a33dcac80c18de90d4d5b2
2019-02-14 12:26:09 -08:00
tmfang
61ba09776c Remove the drop shadow in Privacy screen
Remove shadow in action bar unless page is scrolling.

Test: visual, robotest
Change-Id: I199c659a7a7beecc3b715916b6829a5a879c4c74
Fixes: 123903344
2019-02-12 13:57:50 +08:00
Joel Galenson
1d3df21699 Add accessibility usage preference to the Privacy screen.
Bug: 123595964
Test: Open Privacy page with one and two accessibility services
enabled and click the preference.
Test: Open Privacy page with zero accessibility services enabled and
do not see the preference.
Test: atest AccessibilityUsagePreferenceControllerTest

Change-Id: Ib1dab374cb53dfbc473b2d5ac49115e608a13ab8
2019-02-08 17:26:52 -08:00
TreeHugger Robot
caecbc30fa Merge "Show permission group icons in dark mode." 2019-02-05 15:23:50 +00:00
Joel Galenson
e59a5102ab Show permission group icons in dark mode.
Apply the proper tint so that the permission group icons appear in
dark mode.

Change-Id: Ief36e69ed8ae70608f1df79a0e2a17eb79b9f467
Fixes: 123750886
Test: Can see icons in light and dark mode.
2019-02-04 10:09:03 -08:00
Joel Galenson
6bf75d288d Check a flag to see whether or not to show permission usage information.
Bug: 122615235
Test: Manually set/unset flag, see/don't see usage information.
Change-Id: I2d743fc28c5676a2304dac73ae96734241f3fe1d
2019-01-31 10:20:05 -08:00
TreeHugger Robot
6bccb4fb14 Merge "Ignore the storage group in the Privacy bar chart." 2019-01-24 16:42:30 +00:00
Joel Galenson
4fa8a61fdf Ignore the storage group in the Privacy bar chart.
We already filter out the storage group in the Permissions Hub because
it's going away and it produces false events.  This also filters it
out in the privacy bar chart so the two are consistent.

Test: Do not see the storage group in the privacy bar chart.
Change-Id: I6d6bc5a767db06a738ae978cb086dad685cff386
2019-01-23 15:28:30 -08:00
Joel Galenson
03729e780d Make links to Permissions Hub only show last day.
Default to showing only the last day of accesses.

Also fix a bug caused by the API changing from seconds to
milliseconds.

Test: Click links and see correct filter.
Change-Id: I8456723a434c7144e9115e1834f48d3c1da24d4b
2019-01-22 14:56:51 -08:00
TreeHugger Robot
5e087b46e2 Merge "Create a permission bar chart in Privacy page" 2019-01-19 04:28:22 +00:00
Fan Zhang
31b210017b Migrate all MetricsProto enums to SettingsEnums
Bug: 122855168
Test: rebuild
Change-Id: I962d9a71179f86b7cae9dc5e9a00e0aa1557dc76
2019-01-17 14:55:42 -08:00
tmfang
d62afd3700 Create a permission bar chart in Privacy page
Using PermissionControllerManager to get the apps
usage of different permission groups.

And then we visualize the result with bar chart.

Test: visual, robotest
Fixes: 116628158
Change-Id: I0442a04c35d74f715418fac0279bb8f36f6d64df
2019-01-17 21:29:25 +08:00
tmfang
e541def5c5 Create "on lock screen notifications" in Privacy
Test: visual, robotest
Bug: 116628158
Change-Id: I056f3734c591f8b300ae1003364ed4c1c2b2f9e3
2018-11-20 20:09:46 +08:00
tmfang
057539f186 Fix App permission doesn't show summary
Since AppPermissionsPreferenceController assigns
a fixed preference key in constructor, so it can't
be used by same controller in Privacy page.

So, we change contructor directly, let controller
read preference key from xml file.

- Also remove unused imports.

Test: visual
Bug: 116628158
Change-Id: I42d6e978e91f0a2fe796d290cb9f34db596aa1f4
2018-11-14 16:25:48 +08:00
tmfang
80d03d1d20 Create a new top level Privacy entry
This CL focuses on building up Privacy entry in
Settings homepage.

And also reuse some preferences in here.
-App permission
-Show password

Test: robotest, visual
Change-Id: I724ba4b4845fac933df0fca23a4e1c6afeb73362
Fixes: 116628158
2018-11-12 10:49:10 +08:00