Change padding top/bottom to margin, so the sliceview can use the full
288dp height (4 rows + see more button).
Side effect is that ripple doesn't fill the entire cardview. But it
never did anyway.
Change-Id: Ie57187fbe2b8caa2cf9d0dc31d7678eee07085f4
Fixes: 118398695
Test: visual
1. Make them have "MobileNetwork" prefix
2. Also update WifiCallingPreference to remove its category
if it is invisible
Bug: 114749736
Test: RunSettingsRoboTests
Change-Id: I25871d579d6495e902e5583030889942ed2506a8
Like we did the same thing in the Settings app [1][2][3],
FingerprintSetting is another instance that should use
ImeAwareEditText to make sure InputMethodManager#showSoftInput() is
called after the EditText gains IME focus.
This approach should be more robust and easier to maintain than trying
to control the software keyboard visibility with
SOFT_INPUT_STATE_ALWAYS_VISIBLE, which is more complicated that people
think.
This CL also removes RenameDialog#mTextHadFocus since
RenameDialog#mDialogTextField is always focused when the dialog is
shown [4].
This CL also removes the following fields since they can just be a
local final variables that will be captured into callback.
* RenameDialog#mFingerName
* RenameDialog#mTextSelectionStart
* RenameDialog#mTextSelectionEnd
[1]: I182b05d3ff59fb3b4732d60d0d5a464f0e0e0235
f6af093e2d
[2]: I892d639f3cc5d43db553b682d5278b8ce2fe72da
4803267106
[3]: Ib75ba0f361b8b46c3b717cc1ffb864726958ed82
b0bcbed372
[4]: I5bb1b7227c1323595bf7f483e11e87e2c3550093
7a1d52eb06
Fix: 118473687
Test: Manually verified as follows.
1. Build and flash aosp_taimen-userdebug to Taimen
2. Set up a fingerprint unlock.
3. Rotate the device to landscape mode.
4. Open Settings -> Security & location -> Fingerprint
5. Re-enter password if necessary
6. Tap "Finger 1"
7. Make sure that AOSP Keyboard shows up
Change-Id: I2a137aa8f6a1ee2b67923bcf40e82320a56c7b59
The default height of sliceView with MODE_LARGE is 240dp which supports
three rows(including the header) above "show more" button. Since WIFI
and Connected devices use cases require four rows + show more button, we
need to expand the height to fulfill it.
Bug: 117868297
Test: visual
Change-Id: I13b29c3f859d1c117c680432f9a6ad8e71c6acf5
Settings have new filter component with settings style.
This CL replaced Spinner to SettingsSpinner in data usage page.
Change-Id: I212b6b6ed203f8bffd094c0180873060b93c39cb
Fixes: 117568930
Test: robotests, visual
- Remove search fab from layout xml
- Change RelativeLayout to CoordinatorLayout so we can use prebuilt
scrolling behavior
- Minor update to theme so search bar background works in dark mode for
the homepage activity.
Change-Id: If7408c12684be65137e04ae3bb4137204c2d77e0
Fixes: 117508596
Test: robotests, visual
* changes:
Remove AdvancedOptionsPreference
Add activity for mobile network page
Fix the complie error of network migration
Copy MobileNetworkSettings to settings app
ChartDataUsageView and ChartNetworkSeriesView are no longer being used.
Remove them to avoid the need to maintain obsolete codes.
Bug: 117433810
Test: rebuild and make RunSettingsRoboTests
Change-Id: I0c99725500926083bee693c102a323d563647c3a
1. Extract the Tabhost to activity level, not fragment level. So
each mobile fragment has a constant subscriptionId
2. Use BottomNavigationView instead of TabHost
Bug: 114749736
Test: RunSettingsRoboTests
Change-Id: I43aebf2ec01a945697c6b2302ab750e715e4bfef
The factory reset page and the reset confirmation page is too old to
follow the style of Setup Wizard design. To change the layout and apply
the style for textviews and header.
Bug: 73738836
Test: make -j SettingsRoboTests RunSettingsRoboTests
Change-Id: I1ee3d09e1ef9cac8e25c60a566363d4f7d537eeb
In the end the UI does not change but the new states:
- Are similar to the "empty" states we use in the print spooler
- Use the system print icon
- Use a translucent background icon which works correctly with dark mode
Test: Looked at all changed Settings pages
Fixes: 115830412
Change-Id: I1f5b005674e7072e989355f01ebd3fdaf56c9355
Many contextual cards will be built as slices, so we need a controller
and a renderer for them.
Change-Id: I3816db09ba0181399810652fb18fbe11ce273267
Fixes: 115709730
Test: robotests
I made it visible by default by accident.
Test: Looked at Settings > Security & locations > Screen pinning
Change-Id: I8ff6dc72e292ba76550edaeeac4d53ef4bd39505
Fixes: 116109852
Some app icons are really small. This is technically a bug in app, but
not handling it well makes settings UI look strange.
So in addition to setting a max size app icon can use, we just set that
as a only supported size (min == max == 36dp)
Change-Id: I4b3a1b83ab67be469ac74e7d4bb382ae855624d0
Fixes: 115788294
Test: visual
Oem can change the left padding and right padding of main text
in below screens by overlay the relative dimens:
- "Network settings reset"
- "Factory data reset"
- "Screen pinning"
Bug: 113607004
Test: manual
Change-Id: Ief1afd6ee05b9723874866a06f1748d9d9987333
- Add BottomNavigationView which has two tabs
- Remove BottomSheet in layout files
Change-Id: I493290fa9dee0566c73c5c9d7fbba10b71b4e2b4
Fixes: 113266753
Test: visual
