Commit Graph

31159 Commits

Author SHA1 Message Date
Varun Shah
8d5cb9a2d0 Add app icons to leasee view in shared data dev options.
Also disable clicking the header view and list items in the same view.

Bug: 156671006
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SharedDataPreferenceControllerTest
Test: manual (visual)
Change-Id: I2821bc6cdc523097283ab44b864088278850be53
2020-06-09 19:04:36 -07:00
Varun Shah
c920a58d5f Add blob size to shared data dev options screens.
Bug: 156671006
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SharedDataPreferenceControllerTest
Test: manual (visual)
Change-Id: Ia98c3d9812f6225ee834b4d1b0f12a1a73a87598
2020-06-05 22:19:26 -07:00
TreeHugger Robot
dbec4552f7 Merge "Use the plural format for "See all COUNT apps"" into rvc-dev 2020-06-05 01:06:16 +00:00
tim peng
f4410d3d4e Merge " “Bluetooth Audio Codec” is not getting listed while searching for it using “keywords” from settings search tab" into rvc-dev 2020-06-04 23:59:37 +00:00
TreeHugger Robot
c9db73b808 Merge "Add keywords for a few settings" into rvc-dev 2020-06-04 22:56:08 +00:00
Tsung-Mao Fang
6b73e0fc97 Add keywords for a few settings
Test: Rebuilt apk, and see the results in settings search.
Fix: 157978733
Change-Id: Ib02adf8b3fd11b619246a2bd050801b9fa5ec7d3
2020-06-04 17:16:23 +08:00
Yi-Ling Chuang
d44a2fe211 Use the plural format for "See all COUNT apps"
Although there will never be only one app on the device, we still have
to use the plural format for the strings.

Fixes: 146513299
Test: rebuild and see the string in Apps&Notifications page.
Change-Id: I326be50cfddb605584390ebba57dbd06c0ac29b0
2020-06-04 17:14:17 +08:00
TreeHugger Robot
f420d0f310 Merge "Hide "Open by default" entirely for browser apps" into rvc-dev 2020-06-04 08:12:11 +00:00
Tim Peng
5a9e58372a “Bluetooth Audio Codec” is not getting listed while searching for it using “keywords” from settings search tab
-Implement PreferenceControllerMixin to decide nonIndexableKeys list according to isAvailable() status

Bug: 156337281
Test: make -j50 RunSettingsRoboTests
Change-Id: I8787acfd50ac351499781d016a3c806a1a6b4f9f
2020-06-04 14:25:31 +08:00
TreeHugger Robot
74755ac915 Merge "Revert "Stop usb tethering when user cancel it"" into rvc-dev 2020-06-04 04:24:55 +00:00
Will Brockman
5c1b9c357d Merge "Statsd UiEvent logging for notification history." into rvc-dev 2020-06-03 17:55:47 +00:00
Julia Reynolds
613e3c4065 Merge "Add entry point for conversation settings" into rvc-dev 2020-06-03 11:17:42 +00:00
Jakub Pawlowski
3185f80f23 Prevent overlay drawing on top of Bluetooth pairing dialog am: 88815d1456 am: 103cc7cf29
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11484060

Change-Id: Ifbdd0f3dabc0b487bfb5155f786cae6a9980557b
2020-06-03 10:18:46 +00:00
Jakub Pawlowski
103cc7cf29 Prevent overlay drawing on top of Bluetooth pairing dialog am: 88815d1456
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11484060

Change-Id: Ib47c1804cbb29942c33152d72e1019c92f0d3856
2020-06-03 09:59:18 +00:00
Yi-Ling Chuang
4ff357addc Hide "Open by default" entirely for browser apps
Browsers are explicitly treated outside the web link infrastructure, so
we shouldn't offer "Open by default" section.

Fixes: 129162570
Test: robotests
Change-Id: Ie63d5fbfb32eaed4bba8a80158b6bb19bb45b380
2020-06-03 16:21:51 +08:00
Hugh Chen
737ec77c4f Revert "Stop usb tethering when user cancel it"
This reverts commit 9546b7fdcb.

Reason for revert: This CL will have side effort, when switch from "USB tethering" to "MTP/PTP/Midi" mode, DUT will jump to "No data transfer".
Revert this CL and have good solution to address b/154933817

Bug: 156318036
Test: build pass
Change-Id: Ia79b7a9f5d71c15244b147f5ef26af47c1c1fc7c
2020-06-03 03:35:48 +00:00
Will Brockman
7f43530a15 Statsd UiEvent logging for notification history.
Events logged:
Notif history on/off/open/close
Notif click (recent/snoozed/older)
Notif delete (older)
Notif package history open/close

Additional background: There are 3 notif history sections: snoozed
notifs, recently dismissed notifs, and older notifs. In the snoozed &
recent sections we still know the notif SBN, so actions on those
events are logged with instance ID. The older-notifs section is
grouped by package, and we no longer know the instance ID.

This change depends on change 11692386 in frameworks/base, which adds
UiEventLogger support for the RankingSelected atom.

Bug: 155061525
Test: Manual (statsd testdrive)
Change-Id: If267fca97c40c1bbd8dfa785814c85927ab36c91
2020-06-02 13:07:05 -04:00
Julia Reynolds
6a88e140fe Add entry point for conversation settings
Test: manually launch to this screen
Bug: 155490513
Change-Id: I2f88ef6dc05f04249f516b60680a55d1f26841f1
2020-06-02 12:59:13 -04:00
Bonian Chen
68cc44bb77 Merge "[Settings] Move mobile data template out of framework" into rvc-dev 2020-06-02 14:36:20 +00:00
Bonian Chen
db6309cae2 Merge "[Settings] Avoid crash when switch SIM during PIN lock" into rvc-dev 2020-06-02 09:19:00 +00:00
Bonian Chen
d40f7f707e [Settings] Move mobile data template out of framework
Move mobile data template out of framework

Bug: 151751844
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=DataUsageLibTest
Change-Id: I5072cd1e673194d00b3ce82242bf5fbad88d23cd
2020-06-02 17:16:53 +08:00
TreeHugger Robot
62ec08f7bd Merge "Suppress battery saver suggestion notification" into rvc-dev 2020-06-02 07:18:54 +00:00
TreeHugger Robot
8ab31819e0 Merge "Add a setting for allowing overlays on Settings app" into rvc-dev 2020-06-02 06:58:26 +00:00
Mill Chen
418c85f139 Suppress battery saver suggestion notification
When users turn on battery saver manually more than 3 times, the "Tap to
schedule Battery Saver" notification will suggest users to enable
scheduling battery saver. But this notification is still shown if users
have already turned on scheduling battery saver, which is caused by no
mechanism to suppress this notification.

Solution:
Adding a mechanism to suppress battery saver suggestion if users
scheduled battery saver.

Bug: 147862112
Test: robotests
Change-Id: I8290d76dac09104e64fb98b8a9f4d783a8177d7c
2020-06-02 13:50:48 +08:00
Tsung-Mao Fang
f6841ef548 Add a setting for allowing overlays on Settings app
In the past, we allowed non system overlays on user-debug rom.
Acoording to the user-debug guildline, we should not have differnt
behavior between the user build and user debug rom.

To maintain the consistency between user and user debug rom,
We're creating a new developer setting for allowing non-system overlay on
Settings. By default, we don't allow any non-system app overlays on
Settings app unless user turns it on explictly.

Test: Run robotest. Turn on setting, see the overlays on Settings.
Turn off setting, do not see the overlays on Settings.
Fix: 144989059

Change-Id: I87f00a2eda91de003c6e542e7ec45a066f46fbf7
2020-06-02 12:32:43 +08:00
TreeHugger Robot
0886e90888 Merge "Remove High usage battery tip from Settings homepage." into rvc-dev 2020-06-02 03:52:52 +00:00
TreeHugger Robot
425f8d235f Merge "Fix output switch will show empty slice" into rvc-dev 2020-06-02 03:22:19 +00:00
SongFerng Wang
4432ac9c7e Merge "Revert "EnabledNetworkModePreferenceController Remove AllowedNetworkType"" into rvc-dev 2020-06-02 02:54:17 +00:00
TreeHugger Robot
56c820fb65 Merge "Some text polish" into rvc-dev 2020-06-01 22:58:03 +00:00
Fabian Kozynski
43527ef8f4 Merge "Use PackageManager.FEATURE_CONTROLS to decide availability" into rvc-dev 2020-06-01 20:21:36 +00:00
Julia Reynolds
e32e6cc981 Some text polish
- Update styles and alignment

Test: manual
Fixes: 157769522
Change-Id: I92113b5e7a918e1ec31acb64aa10457f4c762760
2020-06-01 14:57:30 -04:00
TreeHugger Robot
729c6c64a9 Merge "Hide header if no items present" into rvc-dev 2020-06-01 16:16:53 +00:00
TreeHugger Robot
f1fbba45d3 Merge "Improve multi user functionality for restricted users" into rvc-dev 2020-06-01 15:29:34 +00:00
Julia Reynolds
2545b4aa3d Hide header if no items present
Test: atest
Fixes: 157093918
Change-Id: If4f86ff71fc5e961e36e5485186d247546355174
2020-06-01 09:24:18 -04:00
Yi-Ling Chuang
3e9fb7c765 Remove High usage battery tip from Settings homepage.
Remove this card since it is not actionable.

Fixes: 157131344
Test: robotests
Change-Id: I562e4bec84429f885911bd99461edbe10bad537a
2020-06-01 19:06:16 +08:00
Hugh Chen
bf1de21131 Fix output switch will show empty slice
Use MediaDevice in the list to add row instead of use connectedDevice.
Becauae connectedDevice that got from getCurrentConnectedMediaDevice()
could be null.

Bug: 157611605
Test: make -j42 RunSettingsRoboTests
Change-Id: Ib51e3e436e65a9aaa5a35488191b8b2ad9cb6a4b
2020-06-01 16:31:52 +08:00
SongFerng Wang
893107fc60 Revert "EnabledNetworkModePreferenceController Remove AllowedNetworkType"
This reverts commit 259e6288c9.

Reason for revert: Sooraj will implement another API for power manager.
Bug: 156709797
Change-Id: I15ee2799574cdf0318e593500f0dbfbf135d71f8
2020-06-01 06:25:13 +00:00
Julia Reynolds
73b6bfc1e8 Merge "Only show Bubbles link for messaging apps" into rvc-dev 2020-05-31 18:57:41 +00:00
Julia Reynolds
4029f92f12 Add a bubbles content description
Test: manual with a11y service
Fixes: 155262236
Change-Id: Ib4c9650e1d90c4681ca721df3fde58ffc9430078
2020-05-29 20:47:40 +00:00
Julia Reynolds
3d613bb6c9 Only show Bubbles link for messaging apps
Apps that have sent at least one valid conversation

Test: manual, atest
Fixes: 156033178
Change-Id: If4fff6810f2e390ba0ad0f7587b8d8c2d5819c93
2020-05-29 14:51:06 -04:00
Fabian Kozynski
d0d07ddceb Use PackageManager.FEATURE_CONTROLS to decide availability
Using this features, some of the Preference in Power Menu Settings can
change their availability and their summary.

Test: Robotest Settings
Fixes: 157244528
Change-Id: I704438dda181aa6347c3f168ac5ef6bd16148993
2020-05-29 13:12:08 -04:00
Andras Kloczl
106431e525 Improve multi user functionality for restricted users
- Restricted users can change their name
- Improved App&Content access screen
- Remove "Turn on phone calls" from restricted user detail page

Doc: http://shortn/_Prb3SJ3xJ3
Bug: 142798722
Test: Run robo tests with this command:
  make -j64 RunSettingsRoboTests
Change-Id: I2aadf32aef52ba5ad0db7aa0cd83bac9d9941589
(cherry picked from commit f4759e00d5)
2020-05-29 12:55:18 +00:00
TreeHugger Robot
ff35a3e641 Merge "Fix the janky transition of contextual cards." into rvc-dev 2020-05-29 11:51:51 +00:00
TreeHugger Robot
1e0bb9f528 Merge "Cleanup notification channel slice" into rvc-dev 2020-05-29 10:55:53 +00:00
Rubin Xu
c3b12c3b00 Merge "Allow setting password during provisioning if FRP is not supported" into rvc-dev 2020-05-29 10:44:18 +00:00
Yi-Ling Chuang
bed0f23940 Fix the janky transition of contextual cards.
When contextual cards are being laid out, there are two separate layout
transitions, which brings users the feeling of slowness.

In the current design, we bind slices in the adapter's
onBindViewHolder(), where slice's binding is acutally done in the
background thread and it's time consuming. So before getting the
callback from the slice framework to have actual contents, the view is
empty but the viewholder is already created. So the RecyclerView would
treat it as completed and starts to lay them out. This introduces the
first time transition. Once we get the actual slice content, the view
will be refreshed and laid out, which is the second time transition.

To tackle this, this CL caches slices that are created at pre-check
time, and use them to render before getting updated slices to fill up
the gap.

Fixes: 156372414
Test: robotest and launch settings to see the transition being smooth.
Change-Id: Ic0a27ff36f1824de499b75ec73b2635de9cbe6b5
2020-05-29 18:28:45 +08:00
Jason Chiu
d06333167d Cleanup notification channel slice
Fixes: 144897605
Test: robotest

Change-Id: I1b654f31c6b001ef6f1eed95a87ca0b2dd1afc2e
2020-05-29 17:35:22 +08:00
Bonian Chen
fb4a0c25e0 [Settings] Avoid crash when switch SIM during PIN lock
PIN lock status are stored without subscription ID mapping on it.
Which makes SIM status change can't be processed correctly.

Through storing the subscription ID for PIN lock screen, dialog can be
reset when SIM status changed and crash can be avoided.

Bug: 155852345
Test: manual
Change-Id: Ic520bc34c5a460b4fcd199cd524b180d307e9ab4
2020-05-29 17:09:04 +08:00
TreeHugger Robot
90331c0f20 Merge "Disable anomaly app detection for battery" into rvc-dev 2020-05-29 06:47:00 +00:00
TreeHugger Robot
dd356c5653 Merge "[ANR] Settings froze" into rvc-dev 2020-05-29 06:37:53 +00:00