Commit Graph

6 Commits

Author SHA1 Message Date
menghanli
cb008ccf17 Refactor ToggleAutoclickPreferenceFragment to improve maintainability
Root cause: There is a bunch of different logic of preferences in ToggleAutoclickPreferenceFragment. It’s hard to implement new features and hard to maintain and hard to be testable.
Solution: Move out logic of ToggleAutoclickPreferenceFragment into controllers to reduce the complexity of the relationship between preference and fragment.

Bug: 197695932
Test: make RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.accessibility
Change-Id: I5db18d5a0c577ad67d15c2d0169a36a67e9f13db
2022-07-29 14:50:05 +08:00
Yuri Lin
e9f13fbd5e Rename RadioButtonPreference -> SelectorWithWidgetPreference.
This change is to reduce ambiguity as we're adding the option to style the preference like a checkbox as well.

Bug: 190180868
Test: SelectorWithWidgetPreferenceTest, RunSettingsLibRoboTests
Change-Id: Ie414347bf67ed394ef495604890c5851fc42dbc7
2021-07-20 17:01:21 -04:00
Peter_Liang
c7c1e7d442 Add test cases for ToggleAutoclickPreferenceController.
Bug: 168567356
Test: make RunSettingsRoboTests
ROBOTEST_FILTER=ToggleAutoclickPreferenceControllerTest

Change-Id: I4ea1089ddc9aad8748b950c38617533dc1d5cb02
2020-12-29 21:41:14 +08:00
menghanli
771163f0d3 Fix Auto click (dwell timing) the checked option isn't the same as the option before upgrading the OS
Root cause:
After OS upgrade to R, the original logic only check SP key but does not consider the setting enabled key to cause it cannot not show correctly.

Next:
1) accessibility_autoclick_enabled=1 but does not have SP key, customize layout is checked and show the right value
2) accessibility_autoclick_enabled=1 and have SP key, show according items is checked
3) accessibility_autoclick_enabled=0, off button is checked

Bug: 151123423
Test: local test
Change-Id: I9ebcbb35ee0071dbf8c969d0a70ea6293f4c6edb
2020-04-23 09:22:01 +00:00
ChenJean
62aab02fc5 Support autoclick secondary action (2/n)
Add LayoutPreference to support new seekbar design.

Bug: 146019277
Test: manual
Change-Id: I8bfe3ca1ccee833fb941076ff33e7536392b90f4
2020-02-07 19:16:10 +08:00
ChenJean
7afc1fa6fb Support autoclick secondary action (1/n)
Added radio button preference and control to handle user update value.

Bug: 146019277
Test: Manual
Change-Id: Ie9136f942eec43fc378e7f39d8c2eb7534c531c9
2020-01-17 10:31:07 +00:00