Commit Graph

45297 Commits

Author SHA1 Message Date
TreeHugger Robot
d12d8be502 Merge "Remove FingerprintManagerWrapper" into pi-dev 2018-03-31 01:43:34 +00:00
TreeHugger Robot
e6a18f8105 Merge changes from topic "remove_wrappers" into pi-dev
* changes:
  Remove wrapper class for NotificationGroup.
  Remove more wrappers in favor of new Robolectric support
2018-03-31 01:26:16 +00:00
Fan Zhang
8608f6b000 Merge "Update wi-fi hotspot min length of summary to 2" into pi-dev 2018-03-31 00:45:49 +00:00
TreeHugger Robot
981569f530 Merge "Improve Night Light suggestion criterion" into pi-dev 2018-03-31 00:35:38 +00:00
Phil Weaver
48736a1819 Use touch delegate in SwitchBar
The entire switch bar is supposed to behave as a switch,
so it had logic for clicking the layout that duplicated
the logic for the switch itself.

I'm removing all of this duplicate logic and using a
TouchDelegate instead.

This preserves the same behavior with much simpler code.
The previous approach led to accessibility being confused
about exactly what was clickable and what would happen
when different items were clicked. Workarounds to deal with
that confusion created other problems. Sweeping all of it
aside and using a TouchDelegate seems way cleaner.

Bug: 75962891
Test: make SettingsRoboTests
Change-Id: I4fe17d581b5294d2482392f75bf1607126cf235d
2018-03-30 17:33:05 -07:00
TreeHugger Robot
e33ff4e97c Merge "Remove wrapper class for AutofillManager in Settings" into pi-dev 2018-03-31 00:28:46 +00:00
Lei Yu
824bd92a16 Merge "Update battery strings" into pi-dev am: 7bbc11e87d
am: ab4ebab76c

Change-Id: Ic7bd7ff889bf921cdf3123d5df7a73795f3b734a
2018-03-31 00:21:58 +00:00
TreeHugger Robot
65499ac2a3 Merge "Final (?!?!?!?!) Directory Access improvements." into pi-dev 2018-03-31 00:21:36 +00:00
Tracy Zhou
7bc31e9c21 Update screen pinning instructions for QuickStep.
Change-Id: I786c7a1f4dd5d13d0ea69abe5c56f565a5bb16ae
Fixes: 76317335
Test: N/A
2018-03-30 17:06:02 -07:00
Daniel Nishi
45a587441f Merge "Polish the About Phone page." into pi-dev
am: e645558049

Change-Id: I05a7128ca22960baa8ce19585441864f1d4d8a36
2018-03-30 23:56:52 +00:00
Pengquan Meng
f39ef85653 Fixed ApnEditor issue
The mainly changed:
1. Will not insert invalid apn data to database.
2. Clicking back button will save the APN data to database if the data is valid.

Test: make ROBOTEST_FILTER=ApnEditorTest -j40 RunSettingsRoboTests
Bug: 73745458
Bug: 67327863
Change-Id: Ie2c147cae03ad78d43c351e05add761b2dffac0c
2018-03-30 16:43:56 -07:00
TreeHugger Robot
a1c7bd0640 Merge "Remove more wrappers" into pi-dev 2018-03-30 23:37:15 +00:00
Fan Zhang
1b9b1a2311 Remove FingerprintManagerWrapper
No longer needed after robolectric migration

Bug: 76167422
Test: robotests
Change-Id: I922cde8ac3667081a512cf899af86f68b24485a6
2018-03-30 16:30:31 -07:00
Lei Yu
a5a338dff6 Merge "Remove the obsolete bluetooth code" into pi-dev
am: fa150fca3c

Change-Id: Ie9af21c4f4fcd31466334ba745d0f9e7c75356e5
2018-03-30 23:19:52 +00:00
Fan Zhang
0cad854925 Merge "Remove networkScorer wrapper" into pi-dev
am: 272d3b5096

Change-Id: I37beaa5483ad24cc3c27b4bc73eb26f129fa77bf
2018-03-30 23:18:37 +00:00
Lei Yu
5b8c6c39e9 Merge "Update the battery saver summary" into pi-dev
am: 97dd3c9aac

Change-Id: I9773a5c7fafcad6bbb840949a88f8341812222d1
2018-03-30 23:17:40 +00:00
Lei Yu
5072234808 Merge "Refine the update process of battery tip" into pi-dev
am: 227f056c8b

Change-Id: I01c9da780b587a480a7c3b6ef6bc904b7bd1d38f
2018-03-30 23:17:01 +00:00
Sean Stout
2ae92b541d Improve Night Light suggestion criterion
Night Light suggestion will now show even if the user is using Night
Light in manual mode. If the user has previously tapped or dismissed the
suggestion, the suggestion will not show again.

Bug: 68938869
Test: make ROBOTEST_FILTER=\
"(NightDisplayPreferenceControllerTest|SuggestionFeatureProviderImplTest)" \
RunSettingsRoboTests

Change-Id: Iea838df043d75dfa73a1a383275dc42956374113
2018-03-30 23:12:16 +00:00
Fan Zhang
1781cf2cef Remove wrapper class for NotificationGroup.
It's no longer needed as Robolectric can natively support framework
classes

Bug: 76167422
Test: robotests
Change-Id: If0ac597370240b8efaa8df8783a5c309a2322a3f
2018-03-30 16:09:34 -07:00
Fan Zhang
234854cb04 Remove more wrappers in favor of new Robolectric support
Bug: 76167422
Test: robotests
Change-Id: Ic71a181bee6f90f25f9fa2a748cf708887495394
2018-03-30 15:58:14 -07:00
Lei Yu
ab4ebab76c Merge "Update battery strings" into pi-dev
am: 7bbc11e87d

Change-Id: Iaf0055a9082e3e13314107a290e2bddc0329d2dd
2018-03-30 22:46:42 +00:00
Salvador Martinez
9dc3f74ccf Merge "Update add network dialog to not make networks hidden by default" into pi-dev 2018-03-30 22:22:59 +00:00
Salvador Martinez
2f5292454b Update auto wi-fi to prompt user for permissions
This CL makes it so that auto wi-fi will correctly prompt users
to enable the correct permissions before allowing them to turn
on the setting. Additionally it provides users with important
information regarding each setting.

Bug: 67070896
Test: Robotests
Change-Id: Ieddfa421be6e45ce69f3d6048ae051a7e3ce4c76
2018-03-30 15:05:18 -07:00
Lei Yu
7b9682ce87 In High usage, hide apps without screen time.
If the screen time is less than 1 minute, don't show it in high
usage dialog.

Also sort the list first before cut the list size.

Change-Id: I2f8876dcc16b3d6156cb0aa9e19c7fdd4ceac34e
Fixes: 77303928
Test: RunSettingsRoboTests
2018-03-30 14:48:17 -07:00
Victor Chang
34e0883317 Merge "Remove dead code in time zone picker" into pi-dev am: 93b5d0d3f0
am: 78d61aff2d

Change-Id: I567b56244cee9c72fe6bf17b0a2db4c14d4d244e
2018-03-30 21:40:51 +00:00
Fan Zhang
19b9f120db Remove wrapper class for AutofillManager in Settings
Robolectric now supports new system services. So we no longer need any
wrapper class.

Bug: 76167422
Test: robotests
Change-Id: Ic54b95f747bea933bacec299b00a29f3cc4f7bb5
2018-03-30 14:36:42 -07:00
Jyun LuoLai
56d3c705ee Merge "Modify AddDevicePreferenceController's constructor" into pi-dev am: 11174d3ced
am: b02f7f71a5

Change-Id: Idba6e2791e87b58293e47583884d2eaded02f0a0
2018-03-30 21:30:44 +00:00
Fan Zhang
c0c3eaa66c Remove more wrappers
Bug: 76167422
Test: make RunSettingsRoboTests -j40
Change-Id: I0dc42c483ae92d508dec94e42573b55ced0e4bb0
2018-03-30 14:29:50 -07:00
Pengquan Meng
ae49fee55c [automerger skipped] Merge "Add apn data structure" into pi-dev am: dbf8a678ae
am: 89918e3209  -s ours

Change-Id: I9ba2c1d14a08a187ca702eeb49d0e884e8a6e93d
2018-03-30 21:10:35 +00:00
Lei Yu
b3087c7f1f Make anomaly jobs persistent.
Before this cl, if user turn off device everday(i.e. OTA update), the
every day jobs may never have a chance to run.

This cl make the jobs persistent and don't reschedule it if we already
have one. In this way we can make sure the jobs roughly run everyday.

Bug: 77331929
Test: RunSettingsRoboTests
Change-Id: Ib497aca6b696afd9386515464845c5b0dd3c1207
2018-03-30 13:59:38 -07:00
TreeHugger Robot
861bf93502 Merge "Make metered wifi controller resilient to null config" into pi-dev 2018-03-30 20:50:25 +00:00
Daniel Nishi
e645558049 Merge "Polish the About Phone page." into pi-dev 2018-03-30 20:24:58 +00:00
Lei Yu
fa150fca3c Merge "Remove the obsolete bluetooth code" into pi-dev 2018-03-30 20:24:01 +00:00
Lei Yu
d4482339d5 Update job ids in Settings
Use constant integers instead of ids

Bug: 77331929
Test: RunSettingsRoboTests
Change-Id: Ic6def54aaae4a9ba025161340f1cee210cb2e87f
2018-03-30 13:20:53 -07:00
TreeHugger Robot
272d3b5096 Merge "Remove networkScorer wrapper" into pi-dev 2018-03-30 20:16:06 +00:00
Felipe Leme
68acecff56 Final (?!?!?!?!) Directory Access improvements.
- Hide children items when parent is granted access (and vice versa).
- Added dividers in between volumes.

Test: manual verification
Test: atest CtsAppSecurityHostTestCases:ScopedDirectoryAccessTest#testResetDoNotAskAgain,testResetGranted

Bug: 72055774

Change-Id: Ie4ad117d1f8a53bf7dbf7747e768a301b0d03604
2018-03-30 13:10:53 -07:00
Lei Yu
97dd3c9aac Merge "Update the battery saver summary" into pi-dev 2018-03-30 20:01:50 +00:00
Lei Yu
227f056c8b Merge "Refine the update process of battery tip" into pi-dev 2018-03-30 19:56:46 +00:00
Lei Yu
a8d18b7819 Update the battery string.
Remove the extra new line.

Bug: 73018395
Test: RunSettingsRoboTests
Change-Id: I48555c51ef49aabf1bfd98baa4682a21936bd48e
2018-03-30 12:19:31 -07:00
Victor Chang
78d61aff2d Merge "Remove dead code in time zone picker" into pi-dev
am: 93b5d0d3f0

Change-Id: Icc46d77ae3a4ba1d4f3ad2d5bcba0a1e0a3c289a
2018-03-30 19:17:47 +00:00
Lei Yu
7bbc11e87d Merge "Update battery strings" into pi-dev 2018-03-30 19:12:41 +00:00
Jyun LuoLai
b02f7f71a5 Merge "Modify AddDevicePreferenceController's constructor" into pi-dev
am: 11174d3ced

Change-Id: I28e2aeeda026f7a1268f512a4808bca9cf09e0a3
2018-03-30 19:02:21 +00:00
Pengquan Meng
89918e3209 Merge "Add apn data structure" into pi-dev
am: dbf8a678ae

Change-Id: Ib6f5840689a924b26468c88ef0e68d8e97195e76
2018-03-30 18:56:22 +00:00
Victor Chang
93b5d0d3f0 Merge "Remove dead code in time zone picker" into pi-dev 2018-03-30 18:35:52 +00:00
Lei Yu
dec7a719d1 Remove the obsolete bluetooth code
Also update the shortcut:
1. Change the name to "Devices"
2. Change it point to "Connected device" page

Bug: 74806595
Fixes: 69926683
Test: robo test still pass

Change-Id: Ic57756fc955dc622cc22d0be64f02b5ae07a2915
2018-03-30 11:24:26 -07:00
Rubin Xu
228246d47f Merge "Remove password blacklist check" into pi-dev am: 48283ec44c
am: d982a37476

Change-Id: I0c90b8cfb3dbec57cac00c55666e79dd0d32fc90
2018-03-30 18:24:21 +00:00
Fan Zhang
368c81e97b Remove networkScorer wrapper
Also modified NetworkScorerPickerPreferenceController to register itself
in xml directily

Bug: 76167422
Test: robotests
Change-Id: I4a216b5e6845aecd6aaeed0ed9b3e06c9e0fc590
2018-03-30 11:06:30 -07:00
TreeHugger Robot
11174d3ced Merge "Modify AddDevicePreferenceController's constructor" into pi-dev 2018-03-30 17:23:51 +00:00
Pengquan Meng
dbf8a678ae Merge "Add apn data structure" into pi-dev 2018-03-30 17:00:35 +00:00
Rubin Xu
d982a37476 Merge "Remove password blacklist check" into pi-dev
am: 48283ec44c

Change-Id: I443bf5991b0cd0f859c63c48589eca7e872b4a25
2018-03-30 13:50:19 +00:00