Commit Graph

12312 Commits

Author SHA1 Message Date
Fan Zhang
8b2baed2be Fix a NPE in confirm lock screen.
The NPE happens is when using pin later. It's too late to recover if we
just catch the NPE where it happens, so we should early terminate the
call by adding TextUtil.isEmpty(pin) check.

Change-Id: Id280cd1b8781678540c9ea281b3186edd04d61f9
Fixes: 31895774
Test: make RunSettingsRoboTests
Test: manually enter correct/wrong/empty password/pin in confirm lock UI
(cherry picked from commit 774e1d8443)
2016-10-05 16:51:23 +00:00
Jonathan Nieder
6cab381bc2 Merge "Add condition check for double tap gesture settings." into nyc-mr1-dev 2016-10-05 01:08:04 +00:00
Matthew Fritze
fb42828381 Merge "Fix bug preventing users from clicking settings suggestions twice" into nyc-mr1-dev 2016-10-04 22:51:52 +00:00
Doris Ling
c8b7555fc9 Add condition check for double tap gesture settings.
Only shows the double tap gesture preference if the config is enabled.

Test: manual - launch gesture settings on different devices and check
for double tap preference. Auto test pending.
Bug: 31930457

Change-Id: Id972f60035d0c74f0832395f0229691cd3296d60
2016-10-04 15:31:58 -07:00
Matthew Fritze
f265dbc447 Fix bug preventing users from clicking settings suggestions twice
In an attempt to fix a monkey test crash which would open a
suggestion, click back and tap the same one again. The change
unfortunately prevented this for all users, but was not caught
because of a debug flag set on my device. A unit test will be added
to master to catch such cases, as tracked by this bug:
b/31937112

Change-Id: Ib1cff07e54903df687454bdbf2ed1416485ab34f
Fixes: 31926102
Test: Manual
2016-10-04 13:39:27 -07:00
Jeff Sharkey
7be1b5923f Give CTS the handle it expects to remove PIN.
When the Direct Boot tests go to remove the PIN set in previous
tests, it needs to find the option that will remove the PIN.  Recent
changes for fingerprint caused this "none" option to be hidden, so
assign the "none" ID to the "skip" option.

Test: cts-tradefed run cts-dev --module CtsAppSecurityHostTestCases --test android.appsecurity.cts.DirectBootHostTest
Bug: 31160946
Change-Id: I0b34cbfae45d1db8ee58a5ef66738414f5e2fc27
2016-10-04 20:33:39 +00:00
Lei Yu
9c54a67d66 Merge "Add "FILTER_NOT_HIDE" for all app filters." into nyc-mr1-dev 2016-10-04 19:51:26 +00:00
jackqdyulei
d785a8db78 Add "FILTER_NOT_HIDE" for all app filters.
The "FILTER_NOT_HIDE" is used to filter out apps that "blacklisted"
by the carrier. So when user insert a specific sim card, these apps
are hiden in settings > apps unless user enable them.

Bug: 31823872
Test: Manual
Change-Id: I28a38b5780cb63fe22af12d80cc24e965b2b83cf
2016-10-03 15:14:12 -07:00
Matthew Fritze
7ac78f2daf Prevent monkey tests from crashing with race conditions
Change-Id: I3eb7d5549aba2f9684f97e8ee7c56c469f9daae0
Fixes: 31856366
Test: None, monkey test race conditions.
2016-10-03 13:53:51 -07:00
Philip P. Moltmann
f9ca06b367 Merge "USB restriction is similar to media restriction" into nyc-mr1-dev 2016-10-01 00:16:12 +00:00
Philip P. Moltmann
13ee50be48 USB restriction is similar to media restriction
Bug: 31472955
Change-Id: I3682ccd102565982c434d70fc0d907b1aa779689
(cherry picked from commit 58e2b50292)
2016-09-30 21:18:14 +00:00
Matthew Fritze
703dc60b14 Prevent double tap on suggestions
Change-Id: I963d96b75cb5d464b6f91cf0824aee6e21cfeff0
Fixes: 31856366
2016-09-30 14:13:53 -07:00
Matthew Fritze
cf0f301250 Merge "Support dialog disclaimer text now appears properly" into nyc-mr1-dev 2016-09-30 00:12:55 +00:00
Matthew Fritze
adc5555acf Support dialog disclaimer text now appears properly
The string override between Settings and SettigsGoogle was not properly
distinguishing, and was defaulting to the AOSP version.

Bug: 31827726
Test: Manual
Change-Id: Iebd8681fb4f040e956f05fb0f5d96deae9eec26f
2016-09-29 22:32:10 +00:00
Garfield Tan
493bf348b9 Launch other info in storage in correct user id.
Bug: 31592290
Change-Id: I816668c7ff9d1b443d4b49e17bdcfa39ef335aee
2016-09-29 14:45:50 -07:00
TreeHugger Robot
6cafff3b2c Merge "Tablet Settings Layout is no longer stretched" into nyc-mr1-dev 2016-09-29 00:16:24 +00:00
Meng Wang
2f6eef699d Merge "WiFiCallingSettings: show roaming preferrence" into nyc-mr1-dev 2016-09-29 00:13:53 +00:00
Matthew Fritze
fb0d4c8534 Merge "Settings suggestions now describes expand and collapse in talkback" into nyc-mr1-dev 2016-09-28 22:52:26 +00:00
Matthew Fritze
c4a9b18121 Tablet Settings Layout is no longer stretched
Change-Id: If4a883077f41b859f4e8aaf92a4f397b94814137
Fixes: 31583422
Tests: Visual Inspection
2016-09-28 15:40:55 -07:00
TreeHugger Robot
24d63d17d6 Merge "Add a warning message to the ASM toggle." into nyc-mr1-dev 2016-09-28 18:34:30 +00:00
Steven Ng
2f5ab90e70 Merge "DO NOT MERGE Provide fingerprint options for SET_NEW_PASSWORD intent" into nyc-mr1-dev 2016-09-28 16:55:53 +00:00
Steven Ng
da738b2edc DO NOT MERGE Provide fingerprint options for SET_NEW_PASSWORD intent
Cherry-pick from ag/1444396

1) Added a trampoline activity to display SET_NEW_PASSWORD intent.
2) On devices that have fingerprint sensor and have no enrolled fingerprint,
   ChooseLockGeneric handles the SET_NEW_PASSWORD intent by providing
   fingerprint + {PIN/PATTERN/PASSWORD} and skip fingerprint options.

Test: See below
1) Auto
   make RunSettingsRoboTests
2) Manual
   a) Fingerprint + pattern
      i) $ adb shell am start -a android.app.action.SET_NEW_PASSWORD
      ii) Click Pixel Imprint + Pattern.
      iii) Set a pattern lock.
      iv) Can enroll a fingerprint.
   b) Pattern
      i) $ adb shell am start -a android.app.action.SET_NEW_PASSWORD
      ii) Click Continue without Pixel Imprint
      iii) A list of unlock options, without fingerprint option, is shown.
      vi) Select and enroll a pattern lock
   c) Has an existing password
      i) $ adb shell am start -a android.app.action.SET_NEW_PASSWORD
      ii) Setting app asks for password input.
      iii) Enter password and click "Continue without Pixel imprint".
      vi) No password is asked. A list of unlock options, without fingerprint option, is shown.
      v) Select and enroll a pattern lock
   d) Work profile
      i) Create a work profile
      ii) adb shell am start --user x -a android.app.action.SET_NEW_PASSWORD. X is the work profile user id.
      iii) Click Pixel Imprint + Pattern.
      iv) Set a pattern lock.
      v) Can enroll a fingerprint.

Bug: 23017051
Change-Id: I6384bbffb72a5d3a83972da7474532746e4d06b9
2016-09-28 15:24:14 +00:00
Daniel Nishi
116b95666f Add a warning message to the ASM toggle.
This trigger fires if ASM is not enabled by default for
the device and the toggle is only visible if the ASM visible
flag is enabled.

Bug: 30455784
Change-Id: Id6adf8a75dbd4290f042d743689a75f496efb0c9
2016-09-27 17:46:52 -07:00
Fan Zhang
f8c29641da Connect button click handler for bluetooth forget dialog.
Bug: 31761184
Test: manual
Change-Id: I48aac6899cb9a49bf988d3b9e6480dfd6fe0c1c2
2016-09-27 22:45:58 +00:00
Salvador Martinez
efbe5ec924 Merge "Fixed talkback feedback for wifi menu" into nyc-mr1-dev 2016-09-27 21:52:16 +00:00
Salvador Martinez
7c59e7ab53 Fixed talkback feedback for wifi menu
When you go to add a existing or new access
point for wifi talkback would say the
incorrect thing when you tapped on the
advanced options dropdown menu toggle.
This fixes what talkback says to more
accurately reflect what the widget does.

Test: Accessibility Scanner
Bug: 31623421
Change-Id: I9a00c4e8723014b0b3097f046dbcd1de01636e76
2016-09-27 14:51:10 -07:00
Matthew Fritze
62cf9efd9b Settings suggestions now describes expand and collapse in talkback
Bug: 30314874
Change-Id: I2231148594c8e878111a754e5806c20dd4e289af
2016-09-27 13:31:15 -07:00
Chen Xu
d76a3ed937 Merge "Avoid run RadioInfo activity from non-system users" into nyc-mr1-dev 2016-09-27 18:38:19 +00:00
fionaxu
b54cb2d18c Avoid run RadioInfo activity from non-system users
RadioInfo is hidden from testing menu, but it could be launched
from explicit intents for example. Add system user check to avoid
phone process crash.

Bug: 31219235
Change-Id: I5661fbe0889b1ee9d0dea6810f4a4cde2c9d9e22
2016-09-27 09:51:12 -07:00
Andre Eisenbach
aece754d77 Move Bluetooth device "Forget" button to the left
"Forget" and "OK" actions are too close together.

Bug: 31693959
Change-Id: Iee452347a53b186df7aecad5d971edcfb7645f1d
2016-09-24 00:16:21 +00:00
Daniel Nishi
798a28ace9 Merge "Add storage manager settings activity." into nyc-mr1-dev 2016-09-24 00:15:49 +00:00
TreeHugger Robot
4f8a703d51 Merge "Split Ambient Display settings." into nyc-mr1-dev 2016-09-24 00:00:05 +00:00
Fan Zhang
c5bfd5f5a8 Merge "Fix NPE when trying to refreshes dnd condition." into nyc-mr1-dev 2016-09-23 23:31:43 +00:00
Doris Ling
1ad58d0abf Split Ambient Display settings.
1. Reverting the changes for Display->Ambient Display; this setting
   will control incoming notification pulse.
2. Added 2 separate entries in gestures settings to control pick up
   and double tap gestures-triggered pulsing for Ambient Display.
3. Added automated tests to verify the preference initializes to the
   correct default value, and also verify that toggling the preference
   updates the corresponding settings correctly.

Test: make SettingsTests

Bug: 30595437
Change-Id: I125bf75fc4ccfea126a00ffae4207fcb789f487a
2016-09-23 15:33:37 -07:00
Daniel Nishi
3843dd96f5 Merge "Use a config flag instead of a RO flag for showing Manage Storage." into nyc-mr1-dev 2016-09-23 22:19:12 +00:00
Meng Wang
fe3749dd0b WiFiCallingSettings: show roaming preferrence
Bug: 31492826
Change-Id: I45cd8455e84802d690d074099d6a8e9c9398e157
2016-09-23 12:09:03 -07:00
Doris Ling
2dc974a648 Merge "Use default switch preference view if gesture animations video is not available." into nyc-mr1-dev 2016-09-23 18:49:05 +00:00
Daniel Nishi
3981889d1d Add storage manager settings activity.
Bug: 31621740
Change-Id: I5abc8ef3f12e02488104c0b74f4826d8c4182b2b
2016-09-22 17:43:42 -07:00
Fan Zhang
98487f4d65 Fix NPE when trying to refreshes dnd condition.
Bug: 31685838
Test: manual, will add automated test in master.

The NPE happens when try to refresh dnd condition before the condition
object is created.

Change-Id: Idbd6898472e1ad21a2bbb3be5f0b9c24c03b5c80
2016-09-22 22:13:21 +00:00
Chris Tate
4199a0d3bd Merge "Tell sublaunched backup settings activities about policy state" into nyc-mr1-dev 2016-09-22 21:58:28 +00:00
TreeHugger Robot
727186bd33 Merge "Add remote control of Instant Apps" into nyc-mr1-dev 2016-09-22 16:57:14 +00:00
Christopher Tate
ee564e9cfc Tell sublaunched backup settings activities about policy state
Policy state is not readily observable by subsidiary UI, so we
now tell it explicitly when sublaunching it.

Bug 30126678

Change-Id: Icdd6e39874070d7337b4b0a0d5b80c52bb3e7e40
2016-09-21 17:16:17 -07:00
Doris Ling
08886a0e91 Use default switch preference view if gesture animations video is not
available.

Check to see if animation video is available. If so, use the customized
view. Otherwise, use the default switch preference layout.

Test: make and run SettingsGoogleTests

Bug: 30701118
Change-Id: I0b25f41f8425b92834b45f706690648fb35a885d
2016-09-20 16:34:04 -07:00
Amit Mahajan
7c01344349 Changes to make APN fields uneditable based on carrier config.
Bug: 30457714
Change-Id: I682445eab8eb3ff4ff3eaf036964b467217366f0
2016-09-20 15:25:26 -07:00
Lorenzo Colitti
bd1936e9e9 Add a "Don't ask again" checkbox to the avoid bad wifi dialog.
am: c179f33c87

Change-Id: Ia46300f122a19cf00f81b1f1115d8981f53fc7d9
2016-09-20 17:16:12 +00:00
Lorenzo Colitti
c179f33c87 Add a "Don't ask again" checkbox to the avoid bad wifi dialog.
Also update the settings code to reflect the new tristate
semantics of the NETWORK_AVOID_BAD_WIFI setting.

Bug: 31075769
Change-Id: Icd21d8272abe6afd42ee8a41e2c7e1a6af77f0b3
2016-09-20 14:35:59 +09:00
Daniel Nishi
c0b33f70ed Use a config flag instead of a RO flag for showing Manage Storage.
Bug: 30455784
Test: make SettingsTests; run the instrumentation.
Change-Id: I860192c1c20fcaec2a5cbcdc085ff01dafa7351a
(cherry picked from commit 7f075a3c41)
2016-09-19 20:39:33 +00:00
TreeHugger Robot
9887baecf3 Merge "Changes to support read-only apn types." into nyc-mr1-dev 2016-09-19 16:30:17 +00:00
Paul Stewart
00641d68c3 Bad Wi-Fi: Change strings to carrier specs
am: 49d703319b

Change-Id: I644d183683367280b3653750f84d9d2c9ee4c5ff
2016-09-17 03:47:35 +00:00
Paul Stewart
49d703319b Bad Wi-Fi: Change strings to carrier specs
Also add a checkbox to persist the value.  However, the logic to
pass this persistence to ConnectivityService has not yet been added.

Bug: 31075769
Test: Visual inspection of dialog (upcoming)
Change-Id: I370ab07ea276b024ce4adc61e10ca085be1c5549
2016-09-16 17:51:16 -07:00