PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
146,427 Commits 1 Branch 0 Tags
88548e94cba911a12e9449241c5afa1a61ec7fb5
Commit Graph

8 Commits

Author SHA1 Message Date
Kasia Krejszeff
e0036fc8b2 Remove nested ScrollView in the PrivateSpaceEducation screen. 
It is not needed for the scrolling to work -- GlifLayout from the SUW
library generates a ScrollView. Additional ScrollView causes Talkback to
interpret it as a separate item and read out contents of its all
children. See b/379256039.

Video before: https://drive.google.com/file/d/1H3k5AxlIdgAA15PHUQ9tVq5AechziA4Z/view?usp=sharing&resourcekey=0-ozeQsQSS5jubL0pZ5FAZHA
Video after: https://drive.google.com/file/d/1W_ODgQhbQS6Xf_57A4TcYeJbqMJxYF16/view?usp=sharing&resourcekey=0-zQ0_p3qlIxpBL3rB5SC4vQ

In the before video, talkback is highlighting and (the green frames) and reading out the whole "How it works" section in addition to each element separately. After the fix it only highlights elements separately.

Bug: 379256039
Test: Manually testesd and presubmit.
Flag: EXEMPT bugfix
Change-Id: Idf6772b8772c54c1907d3a12617fcd03451af41b
 2025-01-07 14:52:20 +00:00
josephpv
20758d5cfe Fix RTL alignment issue in private space education 
With this change the RTL mirroring issue is fixed in the private space
education screen where the icons are aligned to the right for languages
requiring mirror support.

Screenshot:
go/ss/7AuF2HYsmTVaW5w.png
go/ss/HazpLiDH92X2X26.png
go/ss/4TueVkQcKmKZrAL.png

Flag: EXEMPT resource only update

Bug: 351141472
Test: Manual
Change-Id: I33d30ad425ae17e7a8653bc6545f640ee5d09706
 2024-07-09 17:33:35 +00:00
josephpv
cbf3dad3f5 Fix to display text properly in PS education screen 
This changes the style for text in private space education screen
bullet point to fix the text not displaying properly in unfolded mode of
Pixel fold.

Recording: b/340231182#comment4

Bug: 340231182
Test: Manual
Change-Id: I4da02da6ddf6b4f048cc58331d14cda389f13dec
 2024-06-07 11:07:11 +00:00
josephpv
b4054cb6a7 Add edu for apps being stopped when PS is locked 
Changes made to Setup intro screen and private space settings dislaimer
that apps are stopped when private space is locked.

Screenshots:
go/ss/8YFWtjjC5pzhyyd.png
go/ss/5pvvo4YodaSiGzr.png
b/343166731#comment4

Bug: 343166731
Test: Manual
Change-Id: I46db598e1e94e210d904ade8b6b0cf498960cc2a
 2024-06-05 10:01:19 +00:00
josephpv
1af33733c6 Add entrypoint for Learn More in PS settings & Setup intro 
Screenshots:
go/ss/RXhN57DSuSj7aQf.png
go/ss/5xcbx3mWeo2sZ37.png

Bug: 326059389
Test: atest PrivateSpaceFooterPreferenceControllerTest
Change-Id: I72beb1a04ea11909643dd6b455575478cfb5d87c
 2024-03-12 16:15:53 +00:00
josephpv
0809d4dee7 Update illustrations in private space setup and settings 
Recording link : b/326391912#comment3
https://drive.google.com/file/d/1Rykqy8iugvVNiE8uW2tgAlFhAypGxhdN/view?usp=drive_link

Bug: 326391912
Test: Manual
Change-Id: Ic53c42ec87fde4f1b8c38634e1e2927b235ff2a3
 2024-02-28 06:47:49 +00:00
josephpv
2a431fe8d9 Change for private space intro screen string changes 
This includes below changes based on latest UX mocks
- Changes the strings and icon in the intro screen
- Updates the title in Auto advance screens

Recording link : b/326391690#comment4
Screenshots:
go/ss/9xbZP5Lp8j9yh6m.png
go/ss/pvKMNdgu6yt2Xtr.png

Bug: 326391690
Test: Manual, verify the strings are updated as in Mocks
Change-Id: I714919ac1f3d45fa0007395bd17cfb340874ed5a
 2024-02-26 14:26:33 +00:00
josephpv
e9f3a0925b Add illustration to final screen in PS setup and update existing illustrations. 
Screenshots:
- go/ss/9KhqUSezFKHnyys.png

Recording link:
- b/321694009#comment2

Bug: 323156268
Bug: 321694009
Test: Verified manually
Change-Id: Ib8abc080f31cad0a9be3b73a1694be744c108a06
 2024-02-13 18:27:17 +00:00