Commit Graph

703 Commits

Author SHA1 Message Date
Owner Cleanup Bot
840197127e Merge "[owners] Remove bonianchen@google.com from src/com/android/settings/datausage/OWNERS" into main am: f7457e99a2 am: 01d42a8f16
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3497483

Change-Id: Ic41a7de069977b7c8109438c9f9a081769133a44
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-02-21 12:08:09 -08:00
Owner Cleanup Bot
c461f99ea4 [owners] Remove bonianchen@google.com from src/com/android/settings/datausage/OWNERS
This suggested change is automatically generated based on group
memberships and affiliations.

Please approve this change and vote the highest CR. This will keep the OWNERs
file tidy.  We ask that you do not ignore this change and approve it
unless you know a reason the OWNER should remain.  It can always be
reverted if needed.

If this change is in error, vote the lowest CR value (i.e. reject the CL)
and the bot will abandon it.

See the owner's recent review activity for context:
https://android-review.googlesource.com/q/bonianchen@google.com

To report an issue, file a bug in the Infra>Codereview component.

Change-Id: I0de09c3d6210d303b37df065f33d38fa3b9b093a
2025-02-18 15:12:32 -08:00
Jacky Wang
afbcf06654 [Catalyst] Move metrics class
NO_IFTTT=Catalyst only

Bug: 389886085
Flag: EXEMPT refactor
Test: atest
Change-Id: I8c24a4edf768aa2286adf66f16077e962080bb48
2025-02-11 20:18:30 +08:00
Sunny Shao
4f2e409a3e [Catalyst] Update the permissions
NO_IFTTT=Catalyst only

Bug: 392691854
Bug: 392691083
Test: devtool
Flag: EXEMPT bugfix
Change-Id: Id7809ab699745fff4ef040d4a7141498a58e04e8
2025-02-06 05:20:47 +00:00
Jacky Wang
d829ec4675 [Catalyst] Implement metrics/tags for "Data Saver"
Bug: 388061003
Flag: com.android.settings.flags.catalyst
Test: devtool
Change-Id: I240e7a1cf5a27dfd686746d0c754d74c1c95d1ab
2025-02-04 18:24:46 +08:00
Jacky Wang
05b678936a [Catalyst] Prevent flicker on "Use Data Saver"
Fix: 383632913
Flag: com.android.settings.flags.catalyst
Test: manual
Change-Id: I9aa9544c4749e543f5a923d166e4268af595a500
2025-01-10 16:32:00 +08:00
Fan Wu
4ca85b1e5c [Catalyst] Update DataChangeReason usages to PreferenceChangeReason
Bug: 388677104
Test: atest and manual
Flag: EXEMPT refactor
NO_IFTTT=refactor
Change-Id: I3c1aae3dc10a1c78e1b2b0ead8ffc83da933e174
2025-01-09 20:03:09 -08:00
Chaohui Wang
d3448f3a91 Migrate all data usage format use case
Now they are all aligned.

Bug: 321861088
Flag: EXEMPT bug fix
Test: unit test
Change-Id: I1981fd32fd24de7c9eff93e0cd638e862f01b9b9
2025-01-02 18:14:10 -08:00
Chaohui Wang
2fdbe30929 Clean up unused DataUsageSummary.formatUsage
Bug: 321861088
Flag: EXEMPT bug fix
Test: atest DataUsageSummaryTest
Change-Id: Idea8401a81d738272a8f7b23d22c1fbd3feb6903
2025-01-02 18:14:10 -08:00
Chaohui Wang
611c62294a Use BytesFormatter for data usage
Change "480 B" to "480 byte".

And no longer use FormattedDataUsage.

Bug: 321861088
Flag: EXEMPT bug fix
Test: manual - App data usage
Test: unit test
Change-Id: I9ed220e2d5b8fc512d7d28f6fa7faebb37beab83
2025-01-02 18:14:10 -08:00
Jacky Wang
cfcf20c70a [Catalyst] Provide screen key to @ProvidePreferenceScreen
NO_IFTTT=Catalyst only

Bug: 386179791
Flag: com.android.settings.flags.catalyst
Test: manual
Change-Id: Ie8106ec45a32e4a61826512fc62746c9ffc47d9c
2024-12-27 17:14:27 +08:00
Jason Chiu
1c0cc38992 [Catalyst] Implement get{Read,Write}Permissions for Data Saver
NO_IFTTT=Catalyst only

Fix: 385050976
Flag: com.android.settings.flags.catalyst_restrict_background_parent_entry
Test: devtool
Change-Id: I3799007586f5a5b26fa20f077a311313bb35e2c3
2024-12-26 17:09:59 +08:00
Yuchen
c7635b1705 [Expressive design] Update AppDataUsage.
Migrate EntityHeader to IntroPReference.
Remove background of SpinnerPreference.

Bug: 349681531
Flag: EXEMPT migration
Test: atest AppDataUsageTest
Change-Id: Icb91c418a67489e3069f958356a9675f279ee5f8
2024-12-16 07:47:29 +00:00
Jacky Wang
821d320051 [Catalyst] Update permission check API signature
NO_IFTTT=Catalyst only

Bug: 374115149
Flag: com.android.settings.flags.catalyst
Test: manual
Change-Id: Ib13a5fddd517e3e260815b753b55c008e24d70d8
2024-12-13 16:09:58 +08:00
Jacky Wang
387753c005 [Catalyst] Refine DataSaverMainSwitchPreference
Export datastore for preference state monitoring.

Bug: 368359883
Flag: com.android.settings.flags.catalyst
Test: devtool
Change-Id: Ie6b001cdd6a8d27f9cb16d563852ad88b7366916
2024-12-09 12:44:55 +08:00
Jacky Wang
8a97245b3d [Catalyst] Add sensitivity level
NO_IFTTT=Catalyst only

Bug: 380457585
Flag: com.android.settings.flags.catalyst
Test: Manual
Change-Id: Ia98a925011723738e1a16cc0e0c3d703d3dbd505
2024-11-29 07:36:13 +08:00
Jacky Wang
83708d4499 [Catalyst] Update PreferenceLifecycleContext.notifyPreferenceChange
Change the signature from metadata to preference key, so that the API
could be used to notify other preferences on the same screen.

NO_IFTTT=Catalyst only

Bug: 332201912
Flag: com.android.settings.flags.catalyst
Test: atest
Change-Id: Ibdf5f9004471d5491a0be1e84365cbe9f136c373
2024-11-19 13:38:06 +08:00
Jacky Wang
e635f1e0ed [Catalyst] Support Getter API for settings service
NO_IFTTT=Catalyst only

Bug: 373895596
Flag: com.android.settings.flags.catalyst_service
Test: devtool
Change-Id: I367f350d2192d1285bf355a9e45c2d9bec11fa44
2024-11-16 08:06:28 +08:00
Jacky Wang
2bab900fa0 [Catalyst] Add Data Saver settings metadata
Bug: 368359883
Flag: com.android.settings.flags.catalyst
Test: manual
Change-Id: I7a4fe8cdd73a551a2b281e3a5a3a0f269b54ee5e
2024-11-13 02:10:48 +08:00
Jacky Wang
d2d5a1c2f9 [Catalyst] Migrate "Use Data Saver" settings
Bug: 368359883
Flag: com.android.settings.flags.catalyst
Test: manual
Change-Id: I2ee30cdd5edbfb13b5bf67e4c3b93b787c52a767
2024-11-13 02:05:01 +08:00
Jacky Wang
3551614baf Implement RestrictedPreferenceHelperProvider for restricted preference
Bug: 377600992
Flag: EXEMPT library
Test: Manual
Change-Id: I73e60ea7a392aac96e701b9d7f0ff617e449f3b2
2024-11-06 11:43:42 +08:00
Jacky Wang
4ad4f35f78 [Catalyst] Specify order in hierarchy
NO_IFTTT=Update preference order

Bug: 332201912
Flag: EXEMPT refactor
Test: Manual
Change-Id: Iae99e699d852229779ea41a1cbc92bba47684a7b
2024-10-29 20:51:51 +08:00
David Liu
d7dec0bf7f Migrate Data Saver
Add the skeleton of the Data Saver

Bug: 368359883
Test: atest DataSaverScreenTest
Flag: com.android.settings.flags.catalyst_restrict_background_parent_entry
Change-Id: I008c1ff7a1ad4ff1eeb95be730680abe5666f26c
2024-10-24 22:27:56 +00:00
Edgar Wang
4dc5a005c8 Update the layout of AppDataUsagePreference
The layout of AppDataUsagePreference including a progressbar, that's not common pattern in SettingsLib.

Bug: 365506467
Bug: 370456736
Change-Id: I28d25724067d85f8d37c3b5273d38055ba7021a6
Test: atest
Flag: EXEMPT bugfix
2024-09-30 16:42:33 +00:00
Chaohui Wang
eff7ddf339 Not set subId for Wi-Fi data usage
Otherwise the DataUsageList page will be closed since no active sub has
id = 0.

Bug: 348118234
Flag: EXEMPT bug fix
Test: manual - on DataUsageSummary
Test: atest DataUsageSummaryTest
Change-Id: Ic8387e4fbfe0f0027e87e545be9d7e92ae771136
2024-09-14 12:43:11 +08:00
Chaohui Wang
b12a4d30ad Settings search for Data warning & limit
Bug: 358238959
Flag: EXEMPT bug fix
Test: manual - search data warning
Change-Id: Ifc29b8979a5ba523e930b0c3a59fcb3d9ab99571
2024-09-04 02:33:23 +00:00
Chaohui Wang
e2f0a6b2d3 Fix the sorting order for restricted
Set the category for the restricted item to fix.

Fix: 357275199
Flag: EXEMPT bug fix
Test: manual - on DataUsageList
Test: atest AppDataUsageRepositoryTest
Change-Id: I63d3fd2ac85748d67ff6194cd60adeadae2aa984
2024-08-07 02:23:23 +00:00
Treehugger Robot
8daa5e4f99 Merge "Migrate to onViewCreated in DataSaverSummary" into main am: 04ed8498ee am: 88f79fe29d
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3188139

Change-Id: Icba45da65537d4af2ad5e109ec5783a2d55ccafa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-28 21:18:22 +00:00
Treehugger Robot
88f79fe29d Merge "Migrate to onViewCreated in DataSaverSummary" into main am: 04ed8498ee
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3188139

Change-Id: Ib0e4725e3b490e70d9518a2f02c418de2216e638
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-28 21:06:34 +00:00
Jyotiraditya Panda
4ff23211dd Migrate to onViewCreated in DataSaverSummary
The onActivityCreated method has been deprecated. This change updates
DataSaverSummary to use onViewCreated instead, which is the recommended
method for initializing views after the fragment's view has been created.

Test: manual
Change-Id: I08daa11b557b05441fa4f7ed0019802d991846e3
Signed-off-by: Jyotiraditya Panda <jyotiraditya@aospa.co>
2024-07-22 20:18:08 +05:30
Chaohui Wang
af56a3ea21 Not use SubscriptionInfoEntity in DataUsageList
Carrier id will be get in DataUsageListAppsController async.

Bug: 348118234
Flag: EXEMPT clean up
Test: manual - on DataUsageList
Change-Id: I06b361f38d04c5020431cd8c6e359aa3a69942e5
2024-06-26 11:58:07 +08:00
Chaohui Wang
ec59cd0c8b Move mobile data logic into MobileDataRepository
Bug: 347224962
Flag: EXEMPT refactor
Test: manual on Mobile Settings
Test: unit
Change-Id: I2b54f9e6c4addafd31d7d96f2a44870cd54fe185
2024-06-20 11:49:06 +08:00
Chaohui Wang
168456c46a Reduce flaky of DataUsageSummaryPreference
- Set SnapshotTimeMs initial value to unknown
- Reserve height for DataUsageSummaryPreference

Bug: 341234382
Test: manual - on Mobile Settings
Change-Id: I9145f666c5f8fd9595bcc047160fd6da17b3091d
2024-05-24 12:14:01 +08:00
Chaohui Wang
513ca3a808 Refresh DataUsageSummaryPreferenceController
When re-enter the page contains it.

Fix: 341234382
Test: manual - on Data usage
Test: unit test
Change-Id: Ib6a4624e11b60d703c35cea07232cc24f1516389
2024-05-23 16:50:54 +08:00
Chaohui Wang
7ca1ceb722 Use DataUsageFormatter to format app data usage
Use the new unitsContentDescription from Formatter.formatBytes()

Fix: 318780411
Test: manual - on AppDataUsage
Test: unit test
Change-Id: I55079c83db2e46a48f49f746f2371825ec0bb029
2024-05-13 12:41:27 +08:00
Chaohui Wang
8c507e871b Catch exception in telephonyRepository.isDataEnabledFlow
And migrate BillingCycleRepository to use it.

Fix: 339197552
Test: manual - on data usage
Test: unit test
Change-Id: Ieac295f37fdbf75d184d66ea11f170652af3ec5f
2024-05-09 15:49:26 +00:00
Chaohui Wang
46a70d0369 Merge "Fix data usage when policy has no cycle" into 24D1-dev am: bb90a2c5c8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/27209264

Change-Id: Ib349fb3eed75dc0d399d9a07355e170e30d1d985
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-08 08:56:39 +00:00
Chaohui Wang
107cca7a77 Fix data usage when policy has no cycle
Fallback to four weeks, as the same as no policy.

Fix: 336108815
Test: manual - on DataUsageList
Test: unit test
Change-Id: I63140a13ea3f3ee790cc911432fbdfd6247f7318
2024-05-07 14:22:35 +00:00
Chaohui Wang
07335514c4 Create AppDataUsageSummaryController
Content description for usage will be added later.

Bug: 318780411
Test: manual - on AppDataUsage
Test: unit test
Change-Id: I3990218395dfd7553554346ea8ef00368ba57589
2024-04-22 04:58:49 +00:00
Manish Singh
01d17b02f5 Merge "Use the filter to filter out the private apps" into main 2024-04-10 17:06:25 +00:00
Chaohui Wang
950091d4a4 Improve content description of data usage chart
Use full month description, and add comma between date and percent.

Fix: 318771241
Test: manual - on DataUsageList
Change-Id: Ice18f162ab7cb908a3582308495bfddbd3dff488
2024-04-07 03:45:51 +00:00
Manish Singh
3c5938bf45 Use the filter to filter out the private apps
in the private profile when the private profile is in quiet mode.

Bug: 323327330
Test: manual
Change-Id: I30b14a843f388a9c83d0439b004f761328b74d64
2024-04-02 16:10:01 +00:00
Chaohui Wang
00c21da30e Correct the data usage warning
- For MATCH_WIFI, only shown non carrier warning when has SIM
- For others, restore the previous operator warning

Bug: 331184249
Test: manual - on DataUsageList
Change-Id: I5d5c6b36c6874a547cc635c025aa77acadf6e1e3
2024-04-02 17:14:42 +08:00
Chaohui Wang
c24af35654 Filter buckets with zero usage
Avoid app with no data usage shows in DataUsageList.

Fix: 318780411
Test: manual - on DataUsageList
Test: unit test
Change-Id: Ieafd761f4c58ca4558f3f526f092e2be33027e3d
2024-04-01 16:52:13 +08:00
songferngwang
be3008e09d Add log for setDataEnabledForReason
To know who change the mobile data

Bug: 331843727
Test: NA Adding log only
Change-Id: I3ef5662102761541cd3e0e4662e0acab07c71937
2024-03-29 09:06:34 +00:00
Olivier Nshimiye
baa7a8c2c8 Add enable_private_space_features flag check for Private Space implementation
Bug: 326060689
Test: Manual
Change-Id: I82105714e74789394a3d46b852aaa3e7b93e5877
2024-03-08 15:36:29 +00:00
josephpv
f668b38489 Handle listing of private space apps in data usage settings
Settings->Network & Internet->Internet->Non-carrier data usage
Settings->Newtork & Internet->SIMs->App datat usage

Screen recording link:
https://drive.google.com/file/d/1vQPunoza_eB0hiqJ-Mu_ylDOz2IbKjYQ/view?usp=drive_link

Bug: 324844478
Test: Manual
Change-Id: I020e6bd2a62a342570f2d33765c75b882be3569d
2024-02-28 10:35:36 +00:00
Hani Kazmi
206300962f Replace ECM AppOps call with service
A new ECM service was introcuded in changeId
I831391e4437b51b3312b5273a2360bd029a3d8ee.

We begin calling it, and update/cleanup method signatures to match.

Note: There are two feature flags:

1. enhancedConfirmationModeApisEnabled - read only, protects the
   mainline API.

2. extendEcmToAllSettings - runtime - gates calls to the above APIs.

We use both so we can ramp up in teamfood as needed.

Bug: 297372999
Test: Tested on device
Test: atest SpaPrivilegedLibTests
Test: atest com.android.settings.applications.specialaccess.notificationaccess
Test: atest com.android.settings.datausage
Test: atest PremiumSmsAccessTest
Test: atest RestrictedPreferenceHelperTest
Change-Id: I945ec51df5cd63de548a8ffdd1acc4f09f2301e5
2024-02-21 14:43:02 +00:00
Hani Kazmi
96ab2b9e25 Wired remaining SpecialAppAccess for ECM.
This change enables the remaining settings for ECM, and adds tests for
both this and previous ECM changes.

Bug: 297372999
Test: Tested on device
Test: atest SpaPrivilegedLibTests
Test: atest com.android.settings.applications.specialaccess.notificationaccess
Test: atest com.android.settings.datausage
Test: atest PremiumSmsAccessTest
Test: atest RestrictedPreferenceHelperTest
Change-Id: I73d39d765dba0c1a75111c37b29ccf1c85d2cdd8
2024-02-15 15:15:23 +00:00
Zhen Zhang
306df3beaa Merge "Rename method name" into main 2024-01-10 13:16:22 +00:00