Commit Graph

43729 Commits

Author SHA1 Message Date
Matthew Fritze
8c48defb52 Expand isAvailable to include DISABLED_DEPENDENT
isAvailable will now return true when getAvailabilityStatus
returns DISABLED_DEPENDENT_SETTING. This is because the setting
should be displayed in the Fragment even if it has a dependent setting,
which matches existing behaviour. Slices will still display the warning
slice without inline content, where the main action brings you to the
setting page. For now, we have to assume the user will be able to figure
out how to enable the setting. In Q, we would like to build a more
intelligent flow so that we can prompt or even help the user fix the
dependency (we just ran out of time in P).

The only setting that had previously used DISABLE_DEPENDENT_SETTING
was a developer option.

Change-Id: I1f774a2e09cb60de01388cf6c35785c8b5dea176
Fixes: 77334915
Test: robotests
2018-04-02 11:59:40 -07:00
Pengquan Meng
519009d3ed Fixed ApnEditor issue
The mainly changed:
1. Will not insert invalid apn data to database.
2. Clicking back button will save the APN data to database if the data is valid.

Test: make ROBOTEST_FILTER=ApnEditorTest -j40 RunSettingsRoboTests
Bug: 73745458
Bug: 67327863
Merged-In: Ie2c147cae03ad78d43c351e05add761b2dffac0c
Change-Id: Ie2c147cae03ad78d43c351e05add761b2dffac0c
(cherry picked from commit f39ef85653)
2018-04-02 18:53:53 +00:00
TreeHugger Robot
e35e00712c Merge "Remove wrapper for device policy manager" into pi-dev 2018-04-02 18:45:53 +00:00
Salvador Martinez
38c4b38740 Update color whitelist for check color repohook
It is blocking cl's being uploaded due to someone skipping the
repo-hooks.

Test: Can build and upload CL's
Bug: 77478756
Change-Id: I3ae4212fb06a5b82c0afe57dcd839f5a55583cce
2018-04-02 11:32:06 -07:00
TreeHugger Robot
5e8a0e2436 Merge changes Ib497aca6,Ic6def54a into pi-dev
* changes:
  Make anomaly jobs persistent.
  Update job ids in Settings
2018-04-02 16:44:51 +00:00
Julia Reynolds
78756b1880 Add app info notification summary
Test: make -j RunSettingsRoboTests
Change-Id: I803b473d994dff4ec8591c43452820b0e702ea0e
Fixes: 72442731
2018-04-02 09:52:20 -04:00
Chalard Jean
42405603c7 Move the Private DNS dialog back to the top level.
Bug: 64133961
Fixes: 74844869
Test: visual test and interaction
      also updated tests and checked they pass
Change-Id: I7c8d50e5941c2a7dd46014932bdace14dc222c80
2018-04-02 09:58:12 +00:00
TreeHugger Robot
27587f7884 Merge "Update auto wi-fi to prompt user for permissions" into pi-dev 2018-04-02 01:36:37 +00:00
TreeHugger Robot
43a325dd05 Merge "Update the battery string." into pi-dev 2018-04-02 01:33:28 +00:00
Jyun LuoLai
ab19293cf4 Merge "Let battery status icon has consist UI in PowerSummaryPage" into pi-dev 2018-04-02 01:27:56 +00:00
TreeHugger Robot
1873faefb8 Merge "Remove wrappers" into pi-dev 2018-03-31 11:00:25 +00:00
Ryan Lin
388907d136 Merge "Add callback onProfileAudioStateChanged()" into pi-dev 2018-03-31 06:23:26 +00:00
TreeHugger Robot
3173e9d103 Merge "Wake notifications to TogglePreferenceController" into pi-dev 2018-03-31 05:15:28 +00:00
Fan Zhang
c9827b4918 Remove wrappers
Bug: 76167422
Test: robotests
Change-Id: Ic673fa2aa815b84da4b522dab85aacbeab6e39ec
2018-03-30 22:05:19 -07:00
TreeHugger Robot
830011bf33 Merge "Import translations. DO NOT MERGE" into pi-dev 2018-03-31 04:11:14 +00:00
Fan Zhang
aab36de0d6 Remove wrapper for device policy manager
Bug: 76167422
Test: robotests
Change-Id: I69dc7341cf1ff408bc24c2a062586cef25b7b918
2018-03-30 20:44:20 -07:00
HJ ChangLiao
5621641c41 Wake notifications to TogglePreferenceController
Convert Wake for new notifications to TogglePreferenceController
Because Slice controller only support Constructor(context)
Move other parameter to setAmbientDisplayConfiguration

Change-Id: I01042b84217ad9592fece966374140dffaf813e4
Fixes:67997460
Test: make RunSettingsRoboTests -j
2018-03-31 03:13:41 +00:00
TreeHugger Robot
76f24ebbaf Merge "Use touch delegate in SwitchBar" into pi-dev 2018-03-31 02:56:16 +00:00
Bill Yi
ca9e5c682a Import translations. DO NOT MERGE
Auto-generated-cl: translation import

Bug: 64712476
Change-Id: I7d6f7e4fa935eb00c198e0ad018faa42ec7dee05
2018-03-30 19:48:05 -07:00
TreeHugger Robot
ef440bd313 Merge "Update screen pinning instructions for QuickStep." into pi-dev 2018-03-31 02:21:15 +00:00
TreeHugger Robot
d12d8be502 Merge "Remove FingerprintManagerWrapper" into pi-dev 2018-03-31 01:43:34 +00:00
TreeHugger Robot
e6a18f8105 Merge changes from topic "remove_wrappers" into pi-dev
* changes:
  Remove wrapper class for NotificationGroup.
  Remove more wrappers in favor of new Robolectric support
2018-03-31 01:26:16 +00:00
Fan Zhang
8608f6b000 Merge "Update wi-fi hotspot min length of summary to 2" into pi-dev 2018-03-31 00:45:49 +00:00
TreeHugger Robot
981569f530 Merge "Improve Night Light suggestion criterion" into pi-dev 2018-03-31 00:35:38 +00:00
Phil Weaver
48736a1819 Use touch delegate in SwitchBar
The entire switch bar is supposed to behave as a switch,
so it had logic for clicking the layout that duplicated
the logic for the switch itself.

I'm removing all of this duplicate logic and using a
TouchDelegate instead.

This preserves the same behavior with much simpler code.
The previous approach led to accessibility being confused
about exactly what was clickable and what would happen
when different items were clicked. Workarounds to deal with
that confusion created other problems. Sweeping all of it
aside and using a TouchDelegate seems way cleaner.

Bug: 75962891
Test: make SettingsRoboTests
Change-Id: I4fe17d581b5294d2482392f75bf1607126cf235d
2018-03-30 17:33:05 -07:00
TreeHugger Robot
e33ff4e97c Merge "Remove wrapper class for AutofillManager in Settings" into pi-dev 2018-03-31 00:28:46 +00:00
TreeHugger Robot
65499ac2a3 Merge "Final (?!?!?!?!) Directory Access improvements." into pi-dev 2018-03-31 00:21:36 +00:00
Tracy Zhou
7bc31e9c21 Update screen pinning instructions for QuickStep.
Change-Id: I786c7a1f4dd5d13d0ea69abe5c56f565a5bb16ae
Fixes: 76317335
Test: N/A
2018-03-30 17:06:02 -07:00
TreeHugger Robot
a1c7bd0640 Merge "Remove more wrappers" into pi-dev 2018-03-30 23:37:15 +00:00
Fan Zhang
1b9b1a2311 Remove FingerprintManagerWrapper
No longer needed after robolectric migration

Bug: 76167422
Test: robotests
Change-Id: I922cde8ac3667081a512cf899af86f68b24485a6
2018-03-30 16:30:31 -07:00
Sean Stout
2ae92b541d Improve Night Light suggestion criterion
Night Light suggestion will now show even if the user is using Night
Light in manual mode. If the user has previously tapped or dismissed the
suggestion, the suggestion will not show again.

Bug: 68938869
Test: make ROBOTEST_FILTER=\
"(NightDisplayPreferenceControllerTest|SuggestionFeatureProviderImplTest)" \
RunSettingsRoboTests

Change-Id: Iea838df043d75dfa73a1a383275dc42956374113
2018-03-30 23:12:16 +00:00
Fan Zhang
1781cf2cef Remove wrapper class for NotificationGroup.
It's no longer needed as Robolectric can natively support framework
classes

Bug: 76167422
Test: robotests
Change-Id: If0ac597370240b8efaa8df8783a5c309a2322a3f
2018-03-30 16:09:34 -07:00
Fan Zhang
234854cb04 Remove more wrappers in favor of new Robolectric support
Bug: 76167422
Test: robotests
Change-Id: Ic71a181bee6f90f25f9fa2a748cf708887495394
2018-03-30 15:58:14 -07:00
Salvador Martinez
9dc3f74ccf Merge "Update add network dialog to not make networks hidden by default" into pi-dev 2018-03-30 22:22:59 +00:00
Salvador Martinez
2f5292454b Update auto wi-fi to prompt user for permissions
This CL makes it so that auto wi-fi will correctly prompt users
to enable the correct permissions before allowing them to turn
on the setting. Additionally it provides users with important
information regarding each setting.

Bug: 67070896
Test: Robotests
Change-Id: Ieddfa421be6e45ce69f3d6048ae051a7e3ce4c76
2018-03-30 15:05:18 -07:00
Lei Yu
7b9682ce87 In High usage, hide apps without screen time.
If the screen time is less than 1 minute, don't show it in high
usage dialog.

Also sort the list first before cut the list size.

Change-Id: I2f8876dcc16b3d6156cb0aa9e19c7fdd4ceac34e
Fixes: 77303928
Test: RunSettingsRoboTests
2018-03-30 14:48:17 -07:00
Fan Zhang
19b9f120db Remove wrapper class for AutofillManager in Settings
Robolectric now supports new system services. So we no longer need any
wrapper class.

Bug: 76167422
Test: robotests
Change-Id: Ic54b95f747bea933bacec299b00a29f3cc4f7bb5
2018-03-30 14:36:42 -07:00
Fan Zhang
c0c3eaa66c Remove more wrappers
Bug: 76167422
Test: make RunSettingsRoboTests -j40
Change-Id: I0dc42c483ae92d508dec94e42573b55ced0e4bb0
2018-03-30 14:29:50 -07:00
Lei Yu
b3087c7f1f Make anomaly jobs persistent.
Before this cl, if user turn off device everday(i.e. OTA update), the
every day jobs may never have a chance to run.

This cl make the jobs persistent and don't reschedule it if we already
have one. In this way we can make sure the jobs roughly run everyday.

Bug: 77331929
Test: RunSettingsRoboTests
Change-Id: Ib497aca6b696afd9386515464845c5b0dd3c1207
2018-03-30 13:59:38 -07:00
TreeHugger Robot
861bf93502 Merge "Make metered wifi controller resilient to null config" into pi-dev 2018-03-30 20:50:25 +00:00
Daniel Nishi
e645558049 Merge "Polish the About Phone page." into pi-dev 2018-03-30 20:24:58 +00:00
Lei Yu
fa150fca3c Merge "Remove the obsolete bluetooth code" into pi-dev 2018-03-30 20:24:01 +00:00
Lei Yu
d4482339d5 Update job ids in Settings
Use constant integers instead of ids

Bug: 77331929
Test: RunSettingsRoboTests
Change-Id: Ic6def54aaae4a9ba025161340f1cee210cb2e87f
2018-03-30 13:20:53 -07:00
TreeHugger Robot
272d3b5096 Merge "Remove networkScorer wrapper" into pi-dev 2018-03-30 20:16:06 +00:00
Felipe Leme
68acecff56 Final (?!?!?!?!) Directory Access improvements.
- Hide children items when parent is granted access (and vice versa).
- Added dividers in between volumes.

Test: manual verification
Test: atest CtsAppSecurityHostTestCases:ScopedDirectoryAccessTest#testResetDoNotAskAgain,testResetGranted

Bug: 72055774

Change-Id: Ie4ad117d1f8a53bf7dbf7747e768a301b0d03604
2018-03-30 13:10:53 -07:00
Lei Yu
97dd3c9aac Merge "Update the battery saver summary" into pi-dev 2018-03-30 20:01:50 +00:00
Lei Yu
227f056c8b Merge "Refine the update process of battery tip" into pi-dev 2018-03-30 19:56:46 +00:00
Lei Yu
a8d18b7819 Update the battery string.
Remove the extra new line.

Bug: 73018395
Test: RunSettingsRoboTests
Change-Id: I48555c51ef49aabf1bfd98baa4682a21936bd48e
2018-03-30 12:19:31 -07:00
Lei Yu
7bbc11e87d Merge "Update battery strings" into pi-dev 2018-03-30 19:12:41 +00:00
Victor Chang
93b5d0d3f0 Merge "Remove dead code in time zone picker" into pi-dev 2018-03-30 18:35:52 +00:00