Commit Graph

2871 Commits

Author SHA1 Message Date
Chaohui Wang
298f65b048 Merge "Finish Mobile Settings if airplane mode is on" into main 2023-11-02 09:06:48 +00:00
Chaohui Wang
4ad7c3c2e6 Finish Mobile Settings if airplane mode is on
Fix: 298940648
Fix: 299256852
Fix: 295408616
Test: manual - on Mobile Settings then turn on airplane mode
Test: unit tests
Change-Id: Ifb4a287f7494ecb8b5040dbae7620fedfc316fdc
2023-11-01 18:05:42 +08:00
Charlotte Lu
d8630aa4d9 Merge "Show "add access point" when the user selects add Apn." into main 2023-11-01 09:02:47 +00:00
Charlotte Lu
8cbffebb89 Show "add access point" when the user selects add Apn.
Fix: 308724447
Test: Visual Test
Change-Id: I7c5a93c426dbb7806e5c21bae22f0dba7f61d870
2023-11-01 14:42:59 +08:00
SongFerng Wang
1742fa2ed0 Merge "To avoid the NullPointerException of UiccSlotInfo" into main 2023-11-01 06:21:49 +00:00
Quang Luong
d30a19395e Merge "Move to non-static WifiTrackerLib isVerboseLoggingEnabled() methods" into main 2023-11-01 03:26:07 +00:00
SongFerngWang
0ba519f1b4 To avoid the NullPointerException of UiccSlotInfo
Bug: 307599094
Test: Build pass
Change-Id: Ia3b8d29b37f2c9616856e9448c9f346b81229534
2023-10-31 19:54:44 +08:00
Chaohui Wang
5ac8a4e281 Merge "Async load eid in SimEidPreferenceController" into main 2023-10-31 10:02:30 +00:00
Chaohui Wang
fe10785679 Merge "Check MOBILE_DATA_POLICY_MMS_ALWAYS_ALLOWED" into main 2023-10-31 07:15:44 +00:00
Chaohui Wang
b6e44ce818 Async load eid in SimEidPreferenceController
Avoid data loading in getAvailabilityStatus() to prevent ANR, override
updateNonIndexableKeys() for search availability.

Fix: 304560734
Test: manual - on "About phone" page
Change-Id: I9994abf3787f5db0edc71ff48d08e549a4b70bf7
2023-10-31 02:44:18 +00:00
Quang Anh Luong
2df8aa26a3 Move to non-static WifiTrackerLib isVerboseLoggingEnabled() methods
Bug: 279512950
Test: build
Change-Id: Id2b7bd9d31efbfb190aaacb8d116842dec5bb168
2023-10-31 09:39:08 +09:00
SongFerng Wang
8557ab051c Merge "Modify the condition of MENU_FIX_CONNECTIVITY" into main 2023-10-30 07:54:34 +00:00
Chaohui Wang
8a5bba1f22 Check MOBILE_DATA_POLICY_MMS_ALWAYS_ALLOWED
To know whether MMS is always allowed, should check
isMobileDataPolicyEnabled(MOBILE_DATA_POLICY_MMS_ALWAYS_ALLOWED)
instead of isDataEnabledForApn(ApnSetting.TYPE_MMS).

Fix: 303759893
Test: manual - toggle "MMS messages" switch
Test: unit test
Change-Id: Id0417e569ff4e3dbac1ecff9327b4a964125c122
2023-10-26 11:07:03 +00:00
SongFerngWang
b271e84e42 Modify the condition of MENU_FIX_CONNECTIVITY
This condition adds checking "whether wifi is enabled"

Bug: 303100761
Test: build pass. local test
make RunSettingsRoboTests ROBOTEST_FILTER=NetworkProviderSettingsTest ->pass

Change-Id: Ib0aa92a77e7fcdbfd2d37e28474e3ef138275ca5
2023-10-26 14:29:05 +08:00
Charlotte Lu
d061ae4c6a Get network type from options.
Fix: 307633026
Test: Visual Test
Change-Id: Ie251eb24196da6fc9ac578a35695368720edf78b
2023-10-25 14:45:04 +08:00
SongFerng Wang
ae7b0b0996 Merge "Add try-catch for set/get wifiCalling mode" into main 2023-10-24 06:40:24 +00:00
SongFerngWang
5ce87cb03d Add try-catch for set/get wifiCalling mode
The APIs can throw IllegalArgumentExceptionm, the UI need the try-catch.

Bug: 299239773
Bug: 287946939

Test: build pass
Change-Id: I4b413abc985dfa871d3c2d39798b51dc1a686313
2023-10-24 13:47:30 +08:00
Chaohui Wang
15ca95a31b Migrate to TwoStatePreference
SwitchPreference and SwitchPreferenceCompat are both TwoStatePreference.

Using TwoStatePreference in Java will helps migration in the future.

Bug: 306771414
Test: manual - check Settings pages
Change-Id: I84e1d7b09451106797c2b23d127855c6976678ca
2023-10-23 09:28:57 +00:00
Treehugger Robot
f7f2f0600b Merge "Only allow clearing of Euicc Data by owner or demo user" into main am: f1cbe74e08 am: ad49e33f01 am: c200d097e9
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2264402

Change-Id: I53046b290eebcfc8647f19e66539dbb84f34afee
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-20 10:12:38 +00:00
Treehugger Robot
ad49e33f01 Merge "Only allow clearing of Euicc Data by owner or demo user" into main am: f1cbe74e08
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2264402

Change-Id: Iaf9eed774382c735bed78f43451b89b61b4e275e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-20 09:08:47 +00:00
Edward Savage-Jones
922fc6067d Only allow clearing of Euicc Data by owner or demo user
Secondary users should not be able to erase downloaded SIMs
is a similar way that they are not be able to factory reset
the device.

Bug: 303488763
Test: On a device with FEATURE_TELEPHONY_EUICC enabled,
      create secondary user, enter Settings->System->Reset Options
      there should be no option to 'Erase downloaded SIMs'
Change-Id: I4f5326732822bc322ab13a00937f94232ca69228
2023-10-20 08:20:01 +02:00
Chaohui Wang
d1577c5e68 Remove NetworkProviderSimsCategoryController
Which no real logic in it, just a proxy of
NetworkProviderSimListController.

Bug: 302628642
Test: manually - on MobileNetworkListFragment
Test: robo test
Change-Id: I4785ac9509f92f5a778e1bda1f8da12e2880589e
2023-10-19 15:56:22 +08:00
Chaohui Wang
dae71fffb4 Dismiss the open dialog if preference is disabled
In EnabledNetworkModePreferenceController, to prevent user changing the
value.

Fix: 304952402
Test: manually - open dialog, then received a call
Change-Id: Ia1be0840b061c796f72bf5053870fa9e90bd215f
2023-10-18 19:50:35 +08:00
Chaohui Wang
17f4fd5a08 BluetoothWiFiResetPreferenceController
Fix: 280864229
Test: manually rotate the screen
Test: unit test
Change-Id: I950ebae1c371ce05dd17710788eda3dc8bdfd2ca
2023-10-17 17:43:19 +08:00
Chaohui Wang
8603782bc5 Optimize DataUsagePreferenceController
Bug: 295260929
Test: manual - on mobile settings
Change-Id: I89a36981771ef21f3c8213ad2039c3577196b493
2023-10-11 20:48:18 +08:00
Charlotte Lu
6a9297df54 Add updateApnType.
Fix: 304457374
Test: Visual Test
Change-Id: I29e1feb6d213a8629e670a4d8f8286f9a8b6082f
2023-10-11 14:13:12 +08:00
Charlotte Lu
7be5d1cc43 Add updateApnDataToDatabase.
Fix: 304672976
Test: Visual Test
Change-Id: If0ed6b8090a37c5a98ab2eeb29fba61c1173c0a7
2023-10-11 13:38:54 +08:00
Charlotte Lu
5b2de59480 Add validateAndSaveApnData.
Fix: 304649927
Test: Visual Test
Change-Id: I900a096a6e27f1db66af204201d4ca2523537c0d
2023-10-11 11:22:39 +08:00
Charlotte Lu
b5b1b48af9 Merge "Add disableInit." into main 2023-10-10 09:43:02 +00:00
Charlotte Lu
7e3b5f4dad Add disableInit.
Fix: 304433155
Test: Visual Test
Change-Id: I61c478a0d21bd321ea806ae9bd5666675e85db73
2023-10-10 14:24:43 +08:00
Charlotte Lu
2faf4cdd57 Use Flags to switch apn insert.
Fix: 304184645
Test: Visual Test
Change-Id: Iedba1343e9987a87b1adf6c1f7a8150e647e73d5
2023-10-10 13:00:58 +08:00
Charlotte Lu
2d029133f2 Telephony.Carriers.MVNO_TYPE is Deprecated.
Fix: 304180380
Test: Visual Test
Change-Id: Ibd1574e2f5004c27a4aafb94a679db5a60113c62
2023-10-10 10:33:15 +08:00
Charlotte Lu
93fb316f01 Add ApnDataInit.
Fix: 298906796
Test: Unit Test
Change-Id: Ibf9e12e4f9c4ee033ad6dc2ca1f2267bf1f21912
2023-10-08 17:54:40 +08:00
Chaohui Wang
4188a571aa Use network type enum for APN
Instead of hardcoded names and values.

Bug: 303971237
Test: unit test
Change-Id: I099a408df7ee35abc886ed5c1d2d09fd31fda7d3
2023-10-08 14:23:37 +08:00
Charlotte Lu
11737b956e Telephony.Carriers.BEARER is deprecated.
Fix: 303971237
Test: Unit Test
Change-Id: Id3257b279421eb9f3544430667dc8ae536476e5c
2023-10-07 17:52:16 +08:00
Charlotte Lu
1735474987 Merge "Add SettingsTextFieldPassword enable." into main 2023-10-07 05:04:50 +00:00
Gil Cukierman
18403f2adc Merge changes from topic "cukie-300248708-hide2gremoval" into main
* changes:
  Stop honoring CarrierConfigManager.KEY_HIDE_ENABLE_2G
  Add feature flag for removal of KEY_HIDE_ENABLE_2G
2023-10-04 20:12:53 +00:00
Gil Cukierman
761fd612c4 Stop honoring CarrierConfigManager.KEY_HIDE_ENABLE_2G
KEY_HIDE_ENABLE_2G is soft removed in Android API level 35
because it hides a security feature. This patch
introduces simplified logic that ignores the
carrier config value. The new behavior is behind a feature flag.

This patch also includes some cleanup.
1. It removes an unneeded check for null carrier config
2. It removes test logic that set the value of KEY_HIDE_ENABLE_2G
   in places where it had no impact on the test.

Bug: 300248708
Test: atest Enable2gPreferenceControllerTest
Change-Id: I892d115d1ae173d2f3cd69e8f8b97bc5bfa7c67b
2023-10-04 13:59:55 +00:00
Hakjun Choi
aa911b312b Changed API name from 'isNtn()' to 'isOnlyNonTerrestrialNetwork()' and updated related methods and variables according to API Council recommendations.
isNtn() -> isOnlyNonTerrestrialNetwork()
No changes in logic.

Bug: 301620244
Test: PreferredSimDialogFragmentTest SimListDialogFragmentTest
Change-Id: I2b64262ed4d9f81f830f76b10a2174ad1e1d649f
2023-10-04 08:23:30 +00:00
Charlotte Lu
6d95d14ea5 Add SettingsTextFieldPassword enable.
Fix: 298906796
Test: Visual
Change-Id: I89754fc27fe0eec4df029c9ec0ba969b5ea85b59
2023-09-28 11:31:58 +08:00
Xin Li
f0ba9c8b60 Merge UP1A.231005.007
Bug: 291102124
Merged-In: I74cde8ebf8214b314a89452e73b834eac7ae8b1e
Change-Id: If0cc9b99ea3e0e6d908d8c1ed476232d3056cb5d
2023-09-27 16:05:12 -07:00
Treehugger Robot
2954c150ef Merge "Add SettingsTextFieldPassword." into main 2023-09-27 09:24:47 +00:00
Charlotte Lu
cfa739350f Add SettingsTextFieldPassword.
Fix: 298906796
Test: Visual
Change-Id: I7dc8c641f93df96a28a57a6f6082abe264680298
2023-09-27 16:19:19 +08:00
Treehugger Robot
90bc26f66d Merge "Fix NullPointerException in NetworkProviderSettings" into main 2023-09-27 08:05:58 +00:00
Treehugger Robot
02427bb6ff Merge "Fix NPE" into main 2023-09-27 05:09:42 +00:00
Weng Su
725a7d2efd Fix NullPointerException in NetworkProviderSettings
- Avoid calling subfunctions when getView returns null

Bug: 301878710
Test: unit test
Change-Id: I8511ded693475468f6dda1d16d040c623097e997
2023-09-27 03:23:13 +08:00
Ling Ma
8dc7d37187 Fix NPE
There could be a rare race condition where getDefaultDataSubscriptionInfo become null during the evaluatin.

Bug: 299242849
Test: manual
Change-Id: I5765bc8fac5362d16aa0976e1f870f91f0de4c2c
2023-09-26 10:40:24 -07:00
Jayachandran C
b4b18cb65e Merge "[Settings] Hide satellite eSIM from users" into main 2023-09-26 07:14:28 +00:00
Jayachandran C
544d7697a9 [Settings] Hide satellite eSIM from users
Bug: 302044287
Test: Manually verified by forcing the eSIM profile to be NTN
Change-Id: Iba4e42778bdf072ceaecc35a2245ea737e552e5c
2023-09-26 06:24:46 +00:00
Tom Hsu
f357f32284 Merge "When device has a call, avoid user inactive/active SIM." into main 2023-09-25 06:59:44 +00:00