Commit Graph

31557 Commits

Author SHA1 Message Date
Bonian Chen
0a7fefde75 Merge "[Settings] Code Refactor" into rvc-dev am: 921ed942c0
Change-Id: Id2158b59998fba83f424c25ab99f3c85a1e80f6e
2020-04-23 06:01:37 +00:00
Bonian Chen
921ed942c0 Merge "[Settings] Code Refactor" into rvc-dev 2020-04-23 05:47:10 +00:00
Bonian Chen
a73cb31f63 [Settings] Fix DataUsageSummaryTest
Fix DataUsageSummaryTest

Bug: 154563784
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=DataUsageSummaryTest
Change-Id: I32f8fc00f01a335950e863d5c9801ee9af0a3f5d
2020-04-23 13:43:27 +08:00
Bonian Chen
3248d004d3 [Settings] Move some work into background thread
1. Move some work into backgroud thread when query data usage status.
2. Fix test case

Bug: 141833767
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=DataUsagePreferenceControllerTest
Change-Id: Ic1496323cd2bbaf794881394565d8d9bb0a89111
2020-04-23 12:55:53 +08:00
Peter_Liang
8cbb44d6f6 Tutorial improvement for Accessibility shortcut (3/n).
Add test cases for tutorial pages.

Bug: 148989018
Bug: 134640159
Test: manual test & run RoboTests
Change-Id: I9bb29f6e61e331c3f9a2408a1eebc3d5e9e16000
2020-04-23 12:18:26 +08:00
Peter_Liang
72aa60ae95 Tutorial improvement for Accessibility shortcut (2/n).
Update UI widgets to meet the new design.

Bug: 148989018
Test: manual test
Change-Id: Ife42995af193db6746135d29f6fa1ad452d265a6
2020-04-23 12:18:26 +08:00
Peter_Liang
cfe3e454ac Tutorial improvement for Accessibility shortcut (1/n).
Because can't save the value into setting keys for the service before version R, and in order to let tutorial dialog can get the consistent value, using alternative that each fragment with shortcut to must implement the new abstract method.

Bug: 148989018
Test: manual test
Change-Id: Iba2a7daa70eb00f0bba37317c9355531fbb77628
2020-04-23 12:18:23 +08:00
Bonian Chen
048d9fe19e [Settings] Code Refactor
Code refactor to provide the capability of method override

Bug: 141833767
Test: manual
Change-Id: I79647a7ff79f1f722bcfdf8190590df61bb3510a
2020-04-23 04:11:55 +00:00
menghanli
8a27603600 Fix formats and internationalization of the string "0.6 seconds" in sk language
Root cause: The OTHER quantity does not require special treatment of the given quantity
Next: Using few quantity for the language requires special treatment of "small" numbers (as with  numbers ending 2, 3, or 4)

Bug: 154085511
Test: Change language to Slovensko to check the UI
Change-Id: I9143d9504cf8f9c5ccf17160e0dc0943fa10d31d
2020-04-23 11:30:17 +08:00
Bonian Chen
761a13700f [Settings] Code refactor for data usage
Code refactor

Bug: 151751844
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=DataUsageSummaryPreferenceControllerTest
Change-Id: I22b323bae0b18cca26c62d047fdb504c012518b5
2020-04-23 11:01:34 +08:00
Julia Reynolds
2980f78e36 Add conversation onboarding
Test: atest
Fixes: 150791002
Change-Id: I51c27300acb8e18b28b5b5e5bf0d2623c65af909
2020-04-22 16:51:34 -04:00
Bonian Chen
57637f19c9 Merge "[Settings] Mobile data usage code refactor" into rvc-dev am: 673251973b am: ea4fc4af4c
Change-Id: I24fdcba009efba736e61ffbe903cdd2f4a7f2052
2020-04-22 14:59:44 +00:00
Bonian Chen
80658af14e Merge "[Settings] Mobile data usage code refactor" into rvc-dev am: 673251973b
Change-Id: If9e385602bfabd19b39f337d3e0f13b5f48e914e
2020-04-22 14:38:45 +00:00
Bonian Chen
ea4fc4af4c Merge "[Settings] Mobile data usage code refactor" into rvc-dev am: 673251973b
Change-Id: Ic7f2ef5a3de5399007ef6828cee712252db31588
2020-04-22 14:37:56 +00:00
Bonian Chen
673251973b Merge "[Settings] Mobile data usage code refactor" into rvc-dev 2020-04-22 14:27:31 +00:00
Tom Hsu
e73f9b8072 Merge "Make ApnEditor can show the customized default value on UI." into rvc-dev am: 49b82f8532 am: 5864a6ba23
Change-Id: I3a02a6f7f092d8696b6b6ae3dc9fa35f2a410ff1
2020-04-22 12:23:57 +00:00
Tom Hsu
2e78494e9d Merge "Make ApnEditor can show the customized default value on UI." into rvc-dev am: 49b82f8532
Change-Id: I701e453ab84ad8b9184fc82427c44f69b339a75c
2020-04-22 12:23:32 +00:00
PETER LIANG
102651fad8 Merge "Uniform the settings enum proto for accessibility tutorial." into rvc-dev am: a83a8e29c3 am: c9be2d385c
Change-Id: I89db6a68b79780c73e1ef52383e4e00fb013e31d
2020-04-22 12:23:24 +00:00
Tom Hsu
5864a6ba23 Merge "Make ApnEditor can show the customized default value on UI." into rvc-dev am: 49b82f8532
Change-Id: I46f5143cde953050041a7b238cb0fa9a856978d7
2020-04-22 12:23:04 +00:00
Tom Hsu
49b82f8532 Merge "Make ApnEditor can show the customized default value on UI." into rvc-dev 2020-04-22 12:16:09 +00:00
tom hsu
fa3c931ab6 Make ApnEditor can show the customized default value on UI.
- Edittext on edittextpreference
 - Summary on edittextpreference

Bug: 142440775
Test: make RunSettingsRoboTests ROBOTEST_FILTER=ApnEditorTest -j
Test: Sanity test pass with customized carrier data
   - data in summary and text of edittext preference correctly correctly
   display on.
Change-Id: I3162de19659df79c5873c730d7d32e4ed998bcbe
2020-04-22 12:15:50 +00:00
PETER LIANG
eaa7d1cc7a Merge "Uniform the settings enum proto for accessibility tutorial." into rvc-dev am: a83a8e29c3
Change-Id: Id69769e1524609ef78f885fd120dd1b166ecdd70
2020-04-22 12:02:28 +00:00
PETER LIANG
c9be2d385c Merge "Uniform the settings enum proto for accessibility tutorial." into rvc-dev am: a83a8e29c3
Change-Id: I888e91c98097372c041a073cafffc5fe2df6bab3
2020-04-22 12:02:02 +00:00
PETER LIANG
a83a8e29c3 Merge "Uniform the settings enum proto for accessibility tutorial." into rvc-dev 2020-04-22 11:42:27 +00:00
Bonian Chen
a7b245c9eb Merge "[Settings] Adopt TelephonyBasePreferenceController to data usage" into rvc-dev am: a4efeb7a0a am: 2538b62bea
Change-Id: I67fbe918b7eb44f534f20b08c9f0d8a6a4508b9f
2020-04-22 10:43:11 +00:00
Bonian Chen
2538b62bea Merge "[Settings] Adopt TelephonyBasePreferenceController to data usage" into rvc-dev am: a4efeb7a0a
Change-Id: I66ef842df28850e193ce81756b2b8a75e6bef27c
2020-04-22 10:25:59 +00:00
Bonian Chen
44ed75bf6b Merge "[Settings] Adopt TelephonyBasePreferenceController to data usage" into rvc-dev am: a4efeb7a0a
Change-Id: Ic0d2ec2bde87fdcd11c68d47a4a85da7bd880441
2020-04-22 10:25:50 +00:00
Bonian Chen
0fef82fbd1 [Settings] Mobile data usage code refactor
Code refactor

Bug: 151751844
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=DataUsagePreferenceControllerTest
Change-Id: Ie1870523ce83e6a1fc56fe9bc4c61708e0e745c4
2020-04-22 18:22:35 +08:00
Bonian Chen
a4efeb7a0a Merge "[Settings] Adopt TelephonyBasePreferenceController to data usage" into rvc-dev 2020-04-22 10:12:24 +00:00
Bonian Chen
2837126e2f Merge "[Settings] Mobile data usage code refactor" into rvc-dev am: 7db5840dfe am: b17c7f9606
Change-Id: I7c14778144ae1290ddf19309f8241130c27072d7
2020-04-22 07:58:22 +00:00
TreeHugger Robot
15c73ee641 Merge "Incorrect checkbox icon in dynamic group panel" into rvc-dev am: 766e060c75 am: 11f9c5bcf8
Change-Id: I24f20a55e2553a3ef2e0fecbcb2e7aa366075832
2020-04-22 07:58:15 +00:00
Bonian Chen
b3145ab148 Merge "[Settings] To avoid from crash when callback" into rvc-dev am: af05f6303d am: 78b9a0c406
Change-Id: I028eb32d8e78e63e5738fa9417c00b4c8cf55cd8
2020-04-22 07:57:57 +00:00
Bonian Chen
354ab264eb Merge "[Settings] Mobile data usage code refactor" into rvc-dev am: 7db5840dfe
Change-Id: I98be2b05bbdcea2dccabc3b5bdf42e0e2e601adf
2020-04-22 07:46:01 +00:00
TreeHugger Robot
46ff5abc5b Merge "Incorrect checkbox icon in dynamic group panel" into rvc-dev am: 766e060c75
Change-Id: I0989c5e7ac206ffe1e339801c4885b2523a2dd36
2020-04-22 07:45:54 +00:00
Bonian Chen
d436727a3e Merge "[Settings] To avoid from crash when callback" into rvc-dev am: af05f6303d
Change-Id: Ica383ae78a7b4b921bcbf2b303f68b65d94da61b
2020-04-22 07:45:47 +00:00
Bonian Chen
b17c7f9606 Merge "[Settings] Mobile data usage code refactor" into rvc-dev am: 7db5840dfe
Change-Id: I4880420c6d6b539662ea2f7e557184058d6c633f
2020-04-22 07:45:43 +00:00
TreeHugger Robot
11f9c5bcf8 Merge "Incorrect checkbox icon in dynamic group panel" into rvc-dev am: 766e060c75
Change-Id: I80a5a31ce703e0ed8d42c280eeff23763df65f0c
2020-04-22 07:45:36 +00:00
Bonian Chen
78b9a0c406 Merge "[Settings] To avoid from crash when callback" into rvc-dev am: af05f6303d
Change-Id: Id17529753ddc58ba458c952f455dac8ef4e896ce
2020-04-22 07:44:32 +00:00
Bonian Chen
7db5840dfe Merge "[Settings] Mobile data usage code refactor" into rvc-dev 2020-04-22 07:17:22 +00:00
TreeHugger Robot
766e060c75 Merge "Incorrect checkbox icon in dynamic group panel" into rvc-dev 2020-04-22 07:16:42 +00:00
Bonian Chen
af05f6303d Merge "[Settings] To avoid from crash when callback" into rvc-dev 2020-04-22 07:00:12 +00:00
Jason Chiu
fe32005e88 Merge "Fix the incorrect title of Panel" into rvc-dev am: 1f91111c3a am: 2fee6f3d1e
Change-Id: I8d1e8c8197025068112a37bd6ae590b3228ff59d
2020-04-22 07:00:05 +00:00
Jason Chiu
499364c9fd Merge "Fix the incorrect title of Panel" into rvc-dev am: 1f91111c3a
Change-Id: Ife2fade68a4cc565111adb773986c45707840a6e
2020-04-22 06:47:16 +00:00
Jason Chiu
2fee6f3d1e Merge "Fix the incorrect title of Panel" into rvc-dev am: 1f91111c3a
Change-Id: I4e7cbf75be6aca6a3573c42c32c27d7338d6b677
2020-04-22 06:46:45 +00:00
Jason Chiu
1f91111c3a Merge "Fix the incorrect title of Panel" into rvc-dev 2020-04-22 06:30:12 +00:00
Jason Chiu
4bbc85eb54 Fix the incorrect title of Panel
Since panel activity is singleInstance, a newer panel will reuse the
same fragment as the previous panel when they are displayed one after
another.

Panel fragment has two kinds of exclusive header layout which shouldn't
be showed at the same time, so we have to reset their visible states
when creating panel content.

Fixes: 154668079
Test: robotest
Change-Id: I701a7cde4b43322fbc63ae1cb74c41dd23b37c0c
2020-04-22 06:29:57 +00:00
Tim Peng
55ce33fbe7 Incorrect checkbox icon in dynamic group panel
-Mutate icon to prevent modifying the original resource

Bug: 154673054
Test: build pass
Change-Id: I0e1a6506cb951f80f316649d27c7728132c05be6
2020-04-22 13:50:46 +08:00
TreeHugger Robot
832fa03fa3 Merge "Fix breadcrumb of search results provided by Settings" into rvc-dev am: d2291d447e am: 6bb86dc6ea
Change-Id: I4ccb256fa4a39fcb2e830bf919c2a048ad73b55b
2020-04-22 05:45:06 +00:00
TreeHugger Robot
607549b764 Merge "Fix breadcrumb of search results provided by Settings" into rvc-dev am: d2291d447e
Change-Id: I83bbce8da2482ca8f3eac6dc83644fc5b5056c2d
2020-04-22 05:31:53 +00:00
TreeHugger Robot
6bb86dc6ea Merge "Fix breadcrumb of search results provided by Settings" into rvc-dev am: d2291d447e
Change-Id: I03245f81a8e5d9be4d369d8b673791b1940956ce
2020-04-22 05:31:20 +00:00