Commit Graph

2961 Commits

Author SHA1 Message Date
jackqdyulei
815f99a84d Fix broken test in NetworkDashboardFragmengTest
Bug: 69314157
Test: RunSettingsRoboTests
Change-Id: I43dbb4c32dec8c17dbab3c7425b390a1bd5a3d8e
2017-11-14 13:18:10 -08:00
jackqdyulei
05cb931a31 Add private dns dialog in wifi settings
This option lives in menu. A dialog will show up once this menu
is clicked.

We reuse most of the logic in go/aog/524415 with the following
updates:
1. Use radioGroup instead of directly control radioButton
2. remove bunch of methods if they are only used once.

Following cl will:
1. Remove this feature in development page
2. Add the help link at the bottom of the dialog
3. Disable "Save" button when hostname is invalid.

Bug: 68030013
Test: add for later

Change-Id: I4c6d359dc9c55675858c20e47953ef677b31c3b5
2017-11-13 14:53:14 -08:00
Julia Reynolds
d0965a21e4 Merge "PreferenceControllers are the way of the future." 2017-11-08 13:33:40 +00:00
TreeHugger Robot
d85cd117c8 Merge "Remove DynamicAvailabilityPreferenceController." 2017-11-08 02:26:16 +00:00
TreeHugger Robot
07e63ea23d Merge "Add ConnectedAccessPointPreference" 2017-11-07 22:48:52 +00:00
Fan Zhang
b5f5ffbece Remove DynamicAvailabilityPreferenceController.
- This class is over complex to use, and get in the way of show/hide
  pref when availability change.
- The function from DynamicAvailabilityPreferenceController can be done
  with PreferenceCategoryController.

Bug: 68956750
Bug: 32953042
Test: robotests
Change-Id: Ia7b7e214c072b8c77f5de3d959fdb1dc79217f76
2017-11-07 12:58:48 -08:00
TreeHugger Robot
2260321fd8 Merge "Move Index provider conversion into Settings provider" 2017-11-07 20:52:51 +00:00
TreeHugger Robot
7036377d72 Merge "Prevent monkey from changing usb settings" 2017-11-07 19:37:03 +00:00
Matthew Fritze
55ce64dcd9 Move Index provider conversion into Settings provider
Pre-patch, settings search provider would push all of its
fragments into to search via SearchIndexableResources with
an implicit contract of if the resource's xml == 0, then
it was a settings fragment with an Index provider.

One, implicit contract is bad. Two, it was messy at indexing time.

So this patch moves htat conversion into the search index provider.
Such that all of the indexables are either real Resources or Raw.

Change-Id: I39f4351c03d123bb9b45edb4df7f924cfaff2b38
Fixes: 65376542
Fixes: 37741509
Test: robotests
2017-11-07 11:18:26 -08:00
jeffreyhuang
7b17780134 Prevent monkey from changing usb settings
- Prevent monkey from revoking usb debugging authorizations
 - Prevent monkey from changing usb configurations

Bug: 68707778
Test: make RunSettingsRoboTests -j40
Change-Id: Idce99d60f0fbce5a9d93aceb0c2a07d27482de10
2017-11-07 09:58:42 -08:00
Jeffrey Huang
a414573d62 Merge "Move iccid number to sim status dialog" 2017-11-07 17:58:01 +00:00
TreeHugger Robot
c41646606d Merge "Fix robolectric test failure" 2017-11-07 02:40:18 +00:00
Fan Zhang
d9f5d1ca06 Merge "Convert SecuritySubSetting into DashboardFragment" 2017-11-07 01:58:42 +00:00
Fan Zhang
a681094e8a Convert SecuritySubSetting into DashboardFragment
Bug: 32953042
Test: robotests
Change-Id: Iecdb0a42695644ff8aa095bcd49b5ccb16aa46d4
2017-11-06 17:26:25 -08:00
Fan Zhang
491e475dfb Fix robolectric test failure
Bug: 36971201
Test: robotests
Change-Id: I5adc98b8bc42b98b39d38bf08e2ac1bfa5139819
2017-11-06 15:12:14 -08:00
Lei Yu
d854eec1a8 Merge "Fix crash in settings robo test." 2017-11-06 21:16:37 +00:00
jeffreyhuang
5b8202a296 Move iccid number to sim status dialog
- Remove iccid number logic from imei dialog
 - Add iccid number log to sim status dialog

Bug: 36458278
Test: make RunSettingsRoboTests -j40
Change-Id: I087688645169b387b9d65264e2c8b70ca565a44e
2017-11-06 12:38:45 -08:00
TreeHugger Robot
5f6c80a288 Merge "Guard against a NPE when disconnecting suggestion service." 2017-11-06 20:29:56 +00:00
jackqdyulei
fbede9c080 Add ConnectedAccessPointPreference
This preference contains:
1. All the logic from AccessPointPreference
2. Gear icon on the right

Bug: 68807544
Test: RunSettingsRoboTests & Screenshot
Change-Id: I128401d81b075c4e9c5ca711562de26e73147745
2017-11-06 12:27:26 -08:00
jackqdyulei
65370d21fd Fix crash in settings robo test.
This is a regression from ag/3120176. In AnomalyDialogFragment when
creating the real dialog, it creates the RuntimePermissionPresenter
which causes the stub error.

In this cl we shadow the RuntimePermissionPresenter since in this
test we only focus on that created dialog has the correct message
(dialog title, dialog message)

Bug: 68941201
Test: RunSettingsRoboTests
Change-Id: I9c09922453f7797f375d0f61b9d8eba660bfbfef
2017-11-06 11:16:36 -08:00
Julia Reynolds
ac3f7e80dc PreferenceControllers are the way of the future.
Migrates Notification settings (app level, group level, and channel
level) into PreferenceControllers (and most importantly:
PreferenceControllerTest)

Note: this removes the 'Advanced' preference group, but does
not yet use the standard system 'Advanced' grouping as it does
not currently support our use case (where we don't know how many
fields to show outside of 'Advanced' until onResume() and also
where we need fields to show below the 'Advanced' group).

Test: make RunSettingsRoboTests
Change-Id: Iddd1b4771922db322e5f73562e9d63ed077c5396
2017-11-06 13:50:26 -05:00
Fan Zhang
f6073fb978 Guard against a NPE when disconnecting suggestion service.
Change-Id: Ib10502b9467365f6e348737655806ef2369a747b
Fixes: 68885411
Test: robotests
2017-11-06 10:30:05 -08:00
TreeHugger Robot
c8b6833e13 Merge "Create a dialog for firmware version" 2017-11-04 01:19:31 +00:00
TreeHugger Robot
9bc65719f3 Merge "Move trust agent helper methods into TrustAgentManager" 2017-11-03 23:03:02 +00:00
jeffreyhuang
3dec170661 Create a dialog for firmware version
- create xml layout files for dialog
 - create some new strings
 - create new FirmwareVersionPreferenceControllerV2
 - create a new dialog fragment for firmware version

Bug: 36458278
Test: make RunSettingsRoboTests -j40
Change-Id: Icc567ff6aa1eedc1ab02c20e0d22529457c33466
2017-11-03 15:17:37 -07:00
TreeHugger Robot
d723394569 Merge "Popup a dialog to display sim status information" 2017-11-03 22:12:43 +00:00
TreeHugger Robot
b0f65ac832 Merge "Move security settings to security package" 2017-11-03 21:24:41 +00:00
TreeHugger Robot
d1a405e053 Merge "Remove duplicate preferences in Accessibility settings." 2017-11-03 19:48:19 +00:00
Fan Zhang
8e3f139cbb Move trust agent helper methods into TrustAgentManager
Bug: 32953042
Test: robotests
Change-Id: Ia8dae2e583f0faf7bded150dac65ed076f4ea576
2017-11-03 11:05:21 -07:00
Fan Zhang
b916456984 Move security settings to security package
Bug: 32953042
Test: robotests
Change-Id: Ibd5a12bdd22825dde723e107050826cce9839926
2017-11-03 11:05:21 -07:00
Fan Zhang
933188d6f9 Move trustagent to security package.
Bug: 32953042
Fixes: 34461256
Test: robotests
Change-Id: I341076ff320ad60081542a96eb588614230cb13e
2017-11-03 08:50:23 -07:00
Doris Ling
024668a2c5 Remove duplicate preferences in Accessibility settings.
- addPreferencesFromResource() call has been added to
InstrumentedPreferenceFragment, and hence sub-class should not call it
again.

Change-Id: Ia016d9d407ac3f838c962d1ced585647382a051a
Fixes: 68820835
Test: make RunSettingsRoboTests
2017-11-02 18:12:27 -07:00
Fan Zhang
b2aae6cd57 Convert the rest of encryption page into pref controller
Bug: 32953042
Test: robotests
Change-Id: I6c1b28314a988e6499065ddaee2aeae0ac28c537
2017-11-02 16:05:58 -07:00
Fan Zhang
c58a88368f Convert encryption status to preference controller
- Move Crypt/Encryption setting into security package.
- Reformat crypt_keeper_settings.xml
- Add controller and test for encryption status

Bug: 32953042
Test: robotests
Change-Id: I1f4b2f97133435c70a49522a59886ac4da6759af
2017-11-02 16:05:58 -07:00
TreeHugger Robot
b1047d1753 Merge "Add flag to not connect in WifiDialogActivity" 2017-11-02 23:01:52 +00:00
Jeffrey Huang
0d4c90913d Merge "Popup a dialog to display user IMEI information" 2017-11-02 20:30:36 +00:00
TreeHugger Robot
5f167f8c9d Merge "Add screen resource for Colors setting." 2017-11-02 18:52:25 +00:00
jeffreyhuang
7d7e98a214 Popup a dialog to display sim status information
- Create layout files for the dialog
 - Create a new controller to launch the dialog activity
 - Create a new controller to update the contents of the dialog
 - Deprecate old files that are no longer used in about phone v2

Bug: 36458278
Test: make RunSettingsRoboTests -j40
Change-Id: Iaf4f5e53c83b27f148acb076f38bfeabff41087e
2017-11-02 10:55:18 -07:00
Maurice Lam
44ce407d00 Add flag to not connect in WifiDialogActivity
Add flag connect_for_caller, which if false will not connect to the
Wi-Fi network on behalf of the caller.

Test: cd tests/robotests && mma
Bug: 34951731
Change-Id: Ie24a8ed1891aea1caec75a2de9a3d2bdb3dad8a7
2017-11-02 10:50:38 -07:00
Doris Ling
5a66ddbd6f Add screen resource for Colors setting.
- each preference fragment should have its own preference screen layout
in order to show the title correctly. Adding the missing data for
ColorModePreferenceFragment.

Change-Id: I172429dc957f94351456d4bc829897a578d7dbf9
Fixes: 68763217
Test: make RunSettingsRoboTests
2017-11-01 17:49:35 -07:00
Fan Zhang
f0b027f4ce Improve settings cold start latency.
- Move view initialization from onViewCreated to onCreateView. This
  doesn't really improve anything, it simply aligns the code more
  with view's lifecycle management.
- Move dashboard category init into background. The init contains logic
  invoking packageManager, which can be very expensive.
  - Remove any call to DashboardFeatureProvider from SummaryLoader, and
    delay the getCategory call until someone calls setListener().
  - call updateCategory() from background thread.

Test: rerun app launch test. Avg latency drops back to pre-suggestion-v2
      level.
Test: robotest
Fixes: 68761512

Change-Id: I5ec85af08e7b610786e439bda93b3651f5975593
2017-11-01 17:24:53 -07:00
jeffreyhuang
c2f8ab587e Popup a dialog to display user IMEI information
- Add new dialog fragment to show imei information
 - Create layout files for the dialog
 - Create a new controller to launch the dialog activity
 - Create a new controller to update the contents of the dialog
 - Deprecate old files that are no longer used in about phone v2

Bug: 36458278
Test: make RunSettingsRoboTests -j40
Change-Id: I6d4273726e2271049a0ab69c2375dac0ac393e04
2017-11-01 14:57:10 -07:00
TreeHugger Robot
910d452874 Merge "Do not start suggestion loader if host isn't attached." 2017-11-01 20:12:44 +00:00
Fan Zhang
6d7aa4e951 Do not start suggestion loader if host isn't attached.
Change-Id: I1ab1de8f0bea6c66d8415e06aedcc7cbc6baf89c
Fixes: 68759380
Test: robotests
2017-11-01 10:34:33 -07:00
Fan Zhang
7b1ab13ddc Merge "Add a readme with instructions on running tests" am: 08217cbd4b am: 931504bb24
am: 45f3c5b261

Change-Id: Ia45d584ab37ae15b4620f00199a477d913040295
2017-11-01 01:29:35 +00:00
TreeHugger Robot
baaea544a5 Merge "Convert EncryptionAndCredential into DashboardFragment" 2017-11-01 00:32:31 +00:00
Fan Zhang
45f3c5b261 Merge "Add a readme with instructions on running tests" am: 08217cbd4b
am: 931504bb24

Change-Id: I5e631e039e1fadd499e70fd7ad8d40acc945a9de
2017-10-31 23:49:31 +00:00
TreeHugger Robot
0955bd7e51 Merge "Vibrate when fingerprint error text is shown" 2017-10-31 21:54:02 +00:00
Fan Zhang
9679dba668 Convert EncryptionAndCredential into DashboardFragment
The logic still lives in fragment for now. They will be moved into
PrefControllers in follow-up changes.

Bug: 32953042
Test: RoboTests
Change-Id: I2b03d26b5f4e6bbb37b42f9dc83a9464eb169868
2017-10-31 14:39:52 -07:00
TreeHugger Robot
f8091755e7 Merge "Switch to use new activity title handling." 2017-10-31 21:16:44 +00:00