Commit Graph

7 Commits

Author SHA1 Message Date
Menghan Li
80f8b87e28 fix(ColorCorrection): Palette preview text contrast Issue
Root Cause: The palette preview's text color inherits dynamic colors from the BC pattern, leading to insufficient contrast against some backgrounds. This wasn't a problem in the original design, as the BC pattern was introduced later.

Solution: Set the palette preview text color to textColorPrimary to ensure the text remains legible against a wider range of background colors.

Bug: 378775277
Flag: EXEMPT bugfix
Test: atest PaletteListPreferenceTest

Change-Id: I8efb9f9d916d618b450df169292202e499d8ac0d
2024-11-14 13:03:17 +00:00
menghanli
95fbb04106 Fix the gradient drawable orientation is not mirrored for RTL alignment
Root cause: The orientation of the gradient drawable follows the view alignment. It should consider the text alignment.
Solution: Use getLayoutDirectionFromLocale# to get the text alignment to
set the correct orientation of the gradient drawable.


Bug: 278950655
Test: Manual test for RTL and LTR language
Change-Id: If94af75172ace137ac5168763f4cb47951f9e943
2023-04-25 05:43:29 +00:00
Peter_Liang
b408e19f4e Update the background of the Daltonizer preview.
Add the corner radii in to be consistent with the Settings style.

Bug: 213440059
Test: manual test
Change-Id: I68edf243ae33e9bb1e39020ad7553451fad66477
2022-01-06 21:02:50 +08:00
Peter_Liang
896e18012d Fix the screen will move by itself when enabled Color correction.
Root Cause:
Using the listener to update the UI dynamically might have some time delay.

Solution:
Refactor to another implementation and avoid using the listener to update it.

Additional condition:
Add height restriction in preference to avoid the palette view to cover whole screen.

Bug: 148785841
Test: make RunSettingsRoboTests ROBOTEST_FILTER=PaletteListPreferenceTest
Change-Id: I6a854e16321b3426e2f8ff65c6404036d55caed4
2020-08-19 11:59:59 +08:00
menghanli
0922c5a292 Fine tunes the color correction layout
Bug: 145968068
Test: Manual test
Change-Id: I291f2669c110ff6571039da2d224015dfef85488
2020-02-13 15:21:43 +08:00
menghanli
35931974eb Create palette preview for color correction (2/n).
Limit the preview measure for one time to avoid unnecessary
measure and draw performance.

Bug: 145968068
Test: make RunSettingsRoboTests ROBOTEST_FILTER=PaletteListViewTest
Test: make RunSettingsRoboTests2
Change-Id: Ib8ea13e511351c71babcbd1376817cea3a47cac4
2020-01-16 17:55:52 +08:00
JasperChang
556687661c Create palette preview for color correction.
Bug: 145968068
Test: make RunSettingsRoboTests ROBOTEST_FILTER=PaletteListViewTest
Test: make RunSettingsRoboTests2

Change-Id: If624c8ab5b6c212b5a3ad97ceac57404d34b9deb
2020-01-07 10:15:32 +08:00