Commit Graph

142689 Commits

Author SHA1 Message Date
Haijie Hong
7cd4a3987f Add device details more settings page
BUG: 343317785
Test: atest DeviceDetailsFragmentFormatterTest
Flag: com.android.settings.flags.enable_bluetooth_device_details_polish
Change-Id: Ia9eff049e73e039ac5d0fb26096ab4e9add60315
2024-08-19 23:41:16 +08:00
Treehugger Robot
4cffde0188 Merge "Use the new inspirational text in mode interstitials" into main 2024-08-16 18:52:44 +00:00
Treehugger Robot
2166d2ff8e Merge "Replace the TYPE_UNKNOWN icon, drop the rabbit, keep the lotus flower" into main 2024-08-16 18:43:18 +00:00
Matías Hernández
70a05ec421 Use the new inspirational text in mode interstitials
Also use the OTHER image for calendar/time, instead of UNKNOWN.

Bug: 332730534
Test: manual
Flag: android.app.modes_ui
Change-Id: I85a36d2d409ad3e9f3d5f70f95d90512443971a7
2024-08-16 19:50:17 +02:00
Matías Hernández
1afff118cd Replace the TYPE_UNKNOWN icon, drop the rabbit, keep the lotus flower
Fixes: 360360424
Test: Manual
Flag: android.app.modes_ui
Change-Id: I9a48453aa27e7610e27cdb62e6dc1a212ade3a75
2024-08-16 19:02:32 +02:00
Matías Hernández
0a5c7530ed Merge "Fix several issues related to CircularIconsPreference" into main 2024-08-16 16:44:24 +00:00
Joshua Mccloskey
bb23b97519 Merge "Split up FingerprintManagerInteractor" into main 2024-08-16 15:55:56 +00:00
Matías Hernández
b676ca3a62 Fix several issues related to CircularIconsPreference
* Sometimes would cause an unending stream of accessibility events (particularly if starting off-screen). This would break TalkBack and anything that depends on UiAutomator (although the system itself took it like a champ).
* Sometimes would not load images (because the ViewTreeObserver would never fire onGlobalLayout after being added because measured width was 0, even though a new width was calculated later).
* Would not recalculate the number of icons that fit if the width changes after the first layout.

Combining ViewHolders with waiting for measuring and/or ViewTreeObservers was always a wonky approach, even though it should've worked in theory. This should be more robust.

Also fixes the unwanted animation on mode screen load related to the absence of the header name being applied a tad too late.

Fixes: 359948417
Fixes: 360072876
Fixes: 360328804
Test: atest SettingsRoboTests + manual + adb shell uiautomator events
Flag: android.app.modes_ui
Change-Id: I7e5dfbdab220d1ebc1c68e5e87ce544ee86b6a65
2024-08-16 16:20:38 +02:00
Joseph Vincent
044d97ddf9 Merge "Removing TODO from test" into main 2024-08-16 13:13:33 +00:00
Weng Su
1a975d6f72 Refine WifiHotspotRepository variable names
- Since the speed of hotspot design was changed to refer to allowed channels rather than usable channels, remove the "Usable" naming to avoid confusion

Fix: 360312024
Flag: EXEMPT refactor
Test: Manual testing
atest -c WifiHotspotRepositoryTest

Change-Id: Ie54a351e0f788e1b6aeec079ccf6671f7f78fb1c
2024-08-16 18:55:36 +08:00
Xinyi Mao
eb1fc8415b Merge "Migrate Spinner on Battery Usage to settingsLib Spinner widget." into main 2024-08-16 07:21:07 +00:00
mxyyiyi
05e857de6a Migrate Spinner on Battery Usage to settingsLib Spinner widget.
Bug: 359429437
Test: visual
Test: atest BatteryUsageBreakdownControllerTest
Flag: EXEMPT bug fix
Change-Id: I71bd1f31db302d407603c71d1a1163ed22fafed8
2024-08-16 13:40:07 +08:00
Treehugger Robot
c9cae8f7a6 Merge "Add flag for the Legal information page migration" into main 2024-08-16 03:55:37 +00:00
Sunny Shao
405251e52f Add flag for the Legal information page migration
Test: compile
Bug: 360061554
Flag: EXEMPT com.android.settings.flags.catalyst_legal_information
Change-Id: Ic5441b27c2663351990b355315cbdb6a11a22aee
2024-08-16 10:17:35 +08:00
Treehugger Robot
4c7e923250 Merge "fix(Color correction): Display default value in slider to match the radio button" into main 2024-08-15 21:40:41 +00:00
Isaac Chai
23258c2b10 fix(Color correction): Display default value in slider to match the radio button
The default value for display in the radio buttons were hard-coded and was not
being reflected to the slider correctly.

Bug: 359379399
Test: locally tested + unit tests added
Flag: com.android.server.accessibility.enable_color_correction_saturation

Change-Id: I95bd0ae1d32561dbbf6b4e87efe70595c9566de8
2024-08-15 19:53:13 +00:00
Hakjun Choi
d80647ea37 Merge "Filter out the satellite PLMNs from the current connected network" into main 2024-08-15 19:46:59 +00:00
Treehugger Robot
c88f990e37 Merge "Remove VibrationAttributes#CATEGORY_KEYBOARD (in Settings)" into main 2024-08-15 19:04:04 +00:00
Matías Hernández
e7c670ea27 Merge "Fix refresh of "apps that can interrupt" segment" into main 2024-08-15 18:53:55 +00:00
Treehugger Robot
42815119ca [automerger skipped] Merge "Merge 24Q3 (ab/AP3A.240905.015) to aosp-main-future" into aosp-main-future am: 05422458fe -s ours
am skip reason: Merged-In I54a12b03ed9be6dc49fb957df0f1f7b31647810d with SHA-1 da21128568 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/28804237

Change-Id: If624403f6926fe5aed1d873388bc0f5d8b3082a9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-08-15 18:24:56 +00:00
Xin Li
20b994799b [automerger skipped] Merge 24Q3 (ab/AP3A.240905.015) to aosp-main-future am: 0b886fe303 -s ours
am skip reason: Merged-In I54a12b03ed9be6dc49fb957df0f1f7b31647810d with SHA-1 da21128568 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/28804237

Change-Id: I47f62c1394d87a8af4d11dcfb34a704c27028c52
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-08-15 18:23:59 +00:00
Treehugger Robot
ea813ef565 Merge "Prevent restricted users from being made admins" into main 2024-08-15 16:59:58 +00:00
Treehugger Robot
05422458fe Merge "Merge 24Q3 (ab/AP3A.240905.015) to aosp-main-future" into aosp-main-future 2024-08-15 16:58:27 +00:00
Matías Hernández
195c698cdf Fix refresh of "apps that can interrupt" segment
Switching from Priority Apps to None would still show the icons of the priority apps. There were several minor things wrong:
* We were keeping the AppSession when a mode switches from "priority apps" to "none", and because onResume always fires the callback, we were loading the icons.
* Even when deactivating the session, its own onResume lifecycle listener was still firing one extra time, before we had a chance to deactivate it.

Also two minor improvements to CircularIconsPreference:
* Update mLoadedIcons when we early exit due to mIconSet having no items. Mostly for testing, since the icons wouldn't be visible anyway.
* Use notifyChanged() when we get a measured view, instead of holding a reference to the view. Technically the previous code violated the "shouldn't keep references to views outside of onBindViewHolder" (although I didn't see this having an effect in practice).

Fixes: 360077747
Test: atest ZenModeAppsLinkPreferenceControllerTest
Flag: android.app.modes_ui
Change-Id: I6d4b7a344542da46f5ebfcd0774f1af27ed113ac
2024-08-15 17:40:36 +02:00
Tetiana Meronyk
c8c5ac7be1 Merge "Read new value of admin status on UserCapabilities update" into main 2024-08-15 15:10:46 +00:00
Ming-Shin Lu
8ec4d71630 Remove VibrationAttributes#CATEGORY_KEYBOARD (in Settings)
Since CL[1], [2] introduced USAGE_IME_FEEDBACK in VibrationAttributes
to be able to specify default / current vibration in VibrationSettings
according to the vibration usage naturally without using this category
attribute + a bypass flag to only support a fixed vibration scaling.

Remove CATEGORY_KEYBOARD attribute and replacing with USAGE_IME_FEEDBACK
in Settings for cleaning up logic.

[1]: I6256c4f47a8bbee4b649d35eabfbc0c94215c0d7
[2]: I764aa8bd72889d4af62b30bff75af9033f22052b

Flag: EXEMPT refactor
Bug: 332661766
Test: atest KeyboardVibrationTogglePreferenceControllerTest
Change-Id: I532e7d184d235bfa266fb590e60802c4e2fa7df2
2024-08-15 15:01:52 +00:00
Alexander Roederer
84cb2f6a02 Merge "Adds Zen metrics categories" into main 2024-08-15 14:39:45 +00:00
Tetiana Meronyk
53058c197c Prevent restricted users from being made admins
Bug: 357704332
Test: manual
Flag: EXEMPT bug_fix

Restricted

Change-Id: I45b31616829134a61bfa587302c5165da192dc8a
2024-08-15 13:10:32 +00:00
Haijie Hong
04f1fea990 Merge "Implement Spatial audio toggle domain layer" into main 2024-08-15 10:54:48 +00:00
Haijie Hong
e3702e9b14 Merge "Rearrange bluetooth device details fragment according to config" into main 2024-08-15 08:13:11 +00:00
Xin Li
0b886fe303 Merge 24Q3 (ab/AP3A.240905.015) to aosp-main-future
Bug: 347831320
Merged-In: I54a12b03ed9be6dc49fb957df0f1f7b31647810d
Change-Id: I473577d5983daafb368afa5523bad948499cb9a2
2024-08-14 23:26:30 -07:00
Treehugger Robot
b9972035bb Merge "Avoid launching details settings after WifiEntry is forgotten" into main 2024-08-15 05:44:24 +00:00
Hakjun Choi
c887a26971 Filter out the satellite PLMNs from the current connected network
Filter out satellite PLMN if current connected network is satellite when user get into the manual select network menuIf Automatically select network is

Bug: 358429071
FLAG: EXEMPT bugfix
Test: manually test if satellite plmn is shown
Change-Id: I79aefc62e897319cae199985e9a63284086f6c2d
2024-08-15 04:23:59 +00:00
Weng Su
a6861564b5 Avoid launching details settings after WifiEntry is forgotten
- Don't launch details settings if WifiEntry isn't saved

Bug: 359584817
Flag: EXEMPT bugfix
Test: Manual testing
atest -c NetworkProviderSettingsTest

Change-Id: Iff1c37b64adef6d136d2aaa6a0a946c22af38193
2024-08-15 12:06:11 +08:00
Zoey Chen
22c4a1e955 Merge "[Settings] Do not create fragment twice" into main 2024-08-15 02:27:14 +00:00
Zoey Chen
6bab5112c4 Merge "[Settings] Should create header again when adding it to the listview" into main 2024-08-15 02:26:58 +00:00
Treehugger Robot
d3fc95aa14 Merge "Update icon picker options, sort order, and descriptions" into main 2024-08-15 01:40:07 +00:00
Treehugger Robot
b3d4b76c69 Merge "Add mandatory biometric prompt to platform surfaces (5/N)" into main 2024-08-15 01:11:42 +00:00
Alexander Roederer
64593a873a Adds Zen metrics categories
Assigns metrics categories to all modes pages under
ZenModesListFragment. Includes new metrics categories where appropriate.

Bug: 332937635
Test: Build and flash
Flag: android.app.modes_ui
Change-Id: Ic19862ec194b40eae294d3c30240fe3f51304665
2024-08-14 20:27:13 +00:00
Matías Hernández
e1dbcfcdb8 Update icon picker options, sort order, and descriptions
Final icon list is ready!

Bug: 359171199
Test: atest IconOptionsProviderImplTest + manual
Flag: android.app.modes_ui
Change-Id: Ia46558fa320bbcc44d19fdda81b14773851a6060
2024-08-14 18:18:19 +00:00
Matías Hernández
1dfc18740e Don't read the +N test of CircularIconsPreference
The description of the segment is already "App 1, App 2, and x more can interrupt", from its text. If the icons don't fit, there's a "+N" at the end. Accessibility services reading this is confusing, especially because the icons that don't fit are not the same as the names that don't fit, so you could get something like "App 1, App 2, and 9 more can interrupt, plus 4".

The whole circular-icons section is irrelevant for a11y so we just mark the container as "noHideDescendants" to save Talkback some work.

Fixes: 359837977
Test: Manual with Talkback
Flag: android.app.modes_ui
Change-Id: I346abcc94e25ef60c5e91f77b8e13f38ade39c71
2024-08-14 17:09:46 +00:00
Tetiana Meronyk
56446fa3b8 Read new value of admin status on UserCapabilities update
Before multiple admins were introduced, only main user could be an admin and that status was not modifiable. But now it can be updated for non-main admins of the device. So it is important to refresh this value to keep it up to date.

Bug: 359466920
Test: atest UserCapabilitiesTest
Flag: EXEMPT bugfix_only
Change-Id: If39ad24b10daf6886f402926b3bab23b50201c98
2024-08-14 15:44:35 +00:00
Treehugger Robot
afa281ce5b Merge "Get available channels allowed by Hotspot" into main 2024-08-14 15:03:56 +00:00
Haijie Hong
df2915bd4e Merge "Add owners for bluetooth settings test folder" into main am: 55834fff02 am: 61a2efc807
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3216259

Change-Id: Idd4a63bea7da0801e963d605d17b751643d1a9d3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-08-14 10:48:35 +00:00
Haijie Hong
61a2efc807 Merge "Add owners for bluetooth settings test folder" into main am: 55834fff02
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3216259

Change-Id: I4835d1b33e1593892054224dec33ea79e64187dc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-08-14 10:32:20 +00:00
Haijie Hong
55834fff02 Merge "Add owners for bluetooth settings test folder" into main 2024-08-14 09:56:42 +00:00
Haijie Hong
6f38de4932 Add owners for bluetooth settings test folder
Change-Id: I1503db974eb271890486581d173c1bde8457f7df
2024-08-14 09:42:21 +00:00
Haijie Hong
c1b24f0a9e Implement Spatial audio toggle domain layer
BUG: 343317785
Test: atest SpatialAudioInteractorTest
Flag: com.android.settings.flags.enable_bluetooth_device_details_polish
Change-Id: Ic73e56a1ca41f9fa58d5219666478a7edc55059d
2024-08-14 17:23:14 +08:00
Matías Hernández
db50368328 Merge "Animate the color transition (active<->inactive) in the mode header icon" into main 2024-08-14 09:11:04 +00:00
Weng Su
6c2158edef Get available channels allowed by Hotspot
- Use getAllowedChannels API instead of getUsableChannels API to avoid corner cases

Bug: 352267181
Flag: EXEMPT bugfix
Test: Manual testing
atest -c WifiHotspotRepositoryTest

Change-Id: I5ae4a4d429924ac2b8676bbbb27016a93ccd9a1b
2024-08-14 17:10:05 +08:00