Commit Graph

899 Commits

Author SHA1 Message Date
Jeremy Joslin
1fed0c6ae7 Merge "New pref toggle for network recommendations." am: a5249906ab am: 2b03ffb264
am: 6061ca1b1a

Change-Id: I05753f7a5d54cd7707531c0a6cd9491c081454b3
2016-12-19 22:09:52 +00:00
Jeremy Joslin
fbcff7a6b2 New pref toggle for network recommendations.
Adding a new toggle to control whether network
recommendations are enabled.

Removed the "Use open networks" pref and its associated strings
and components as it's no longer needed.

Test: Built and ran.
BUG: 33549591
BUG: 33270391
Change-Id: I03069ca30d06089600ca958f8da117564189f839
Merged-In: I7248ac32e0598d82107c150372c1fe4e9e2243a5
Merged-In: I82eed6dc7daef1c622ea4e33ce42c331e0cd786d
2016-12-18 10:33:28 -08:00
Amin Shaikh
409f09b15a Merge "Refactor NetworkScoreAppManager for testing." am: 512368a22e am: 3140bb5ace
am: 7c8af0aedc

Change-Id: I08804d0672ee723f0e6b1278972613a4f11f479d
2016-12-01 02:27:02 +00:00
Amin Shaikh
3140bb5ace Merge "Refactor NetworkScoreAppManager for testing."
am: 512368a22e

Change-Id: I597c960d5e56014b23b280e1e73e324efa77f8fb
2016-12-01 02:11:06 +00:00
Amin Shaikh
f91ac62756 Refactor NetworkScoreAppManager for testing.
Test: manually running app
Change-Id: Icd828886b7181529fa2bf414ba631bce6d1b4d44
2016-11-29 10:17:34 -08:00
Sohani Rao
7fd676ee26 Merge "Add WiFi toggle prompts - settings" am: b4b2c2aa43 am: 6f126a8f5c
am: 6cebca2599

Change-Id: I8cfaadb7dd8df6d81695dea8530a25de69fcce3d
2016-11-14 21:28:16 +00:00
Sohani Rao
6f126a8f5c Merge "Add WiFi toggle prompts - settings"
am: b4b2c2aa43

Change-Id: Idef71123fde9475a549a1ccab136564ccf3d4a4a
2016-11-14 21:14:54 +00:00
Svetoslav Ganov
e06767af78 Add WiFi toggle prompts - settings
If permission review is enabled toggling WiFi on or off
results in a user prompt to collect a consent. This applies
only to legacy apps, i.e. ones that don't support runtime
permissions as they target SDK 22.

Bug: 28715749
Test: Unit tests
Change-Id: I10d1231ea0c47eec5993dbe367cc0c245cba9385
Merged-In: I10d1231ea0c47eec5993dbe367cc0c245cba9385
2016-11-14 10:32:39 -08:00
Stephen Chen
4ba959c7c4 Add subtypes to tron logging for Wifi toggles.
am: b21815e320

Change-Id: Ia08aa862e311dba4af08a1a76c0083519dcdeeb9
2016-11-04 17:22:30 +00:00
Stephen Chen
b21815e320 Add subtypes to tron logging for Wifi toggles.
For ACTION_WIFI_CONNECT, added subtype to specify whether user is
connecting to saved network.
For ACTION_WIFI_OFF, added subtype to specify whether user was connected
to a network at the time.

Bug: 32371451
Test: Verify logs by running:
adb logcat -b events | egrep '(sysui_|notification_)'
Merged-In: I1d4445bda2fbeb062831e6f858ccc711bff65105

Change-Id: I6b87dc10fcfe412f1c72ae944c2dd4d81da12b53
2016-11-03 14:16:06 -07:00
Salvador Martinez
2b55d2f527 Fixed talkback feedback for wifi menu am: 7c59e7ab53
am: ce18d5ea14

Change-Id: I6f1fc0922cfab21da53219e560a46d94156e3533
2016-09-27 21:59:34 +00:00
Salvador Martinez
7c59e7ab53 Fixed talkback feedback for wifi menu
When you go to add a existing or new access
point for wifi talkback would say the
incorrect thing when you tapped on the
advanced options dropdown menu toggle.
This fixes what talkback says to more
accurately reflect what the widget does.

Test: Accessibility Scanner
Bug: 31623421
Change-Id: I9a00c4e8723014b0b3097f046dbcd1de01636e76
2016-09-27 14:51:10 -07:00
Lorenzo Colitti
c2dd47e331 Add a "Don't ask again" checkbox to the avoid bad wifi dialog. am: c179f33c87 am: bd1936e9e9
am: f6a0fda0e5

Change-Id: I6b53930533f9551e77100dba39e150735a09a3ba
2016-09-20 17:42:21 +00:00
Lorenzo Colitti
bd1936e9e9 Add a "Don't ask again" checkbox to the avoid bad wifi dialog.
am: c179f33c87

Change-Id: Ia46300f122a19cf00f81b1f1115d8981f53fc7d9
2016-09-20 17:16:12 +00:00
Lorenzo Colitti
c179f33c87 Add a "Don't ask again" checkbox to the avoid bad wifi dialog.
Also update the settings code to reflect the new tristate
semantics of the NETWORK_AVOID_BAD_WIFI setting.

Bug: 31075769
Change-Id: Icd21d8272abe6afd42ee8a41e2c7e1a6af77f0b3
2016-09-20 14:35:59 +09:00
Paul Stewart
6e488ecf26 Bad Wi-Fi: Change strings to carrier specs am: 49d703319b am: 00641d68c3
am: e089439788

Change-Id: I894960bd05265da4f7dab8028c4fb508e8469cc1
2016-09-17 03:55:06 +00:00
Paul Stewart
00641d68c3 Bad Wi-Fi: Change strings to carrier specs
am: 49d703319b

Change-Id: I644d183683367280b3653750f84d9d2c9ee4c5ff
2016-09-17 03:47:35 +00:00
Paul Stewart
49d703319b Bad Wi-Fi: Change strings to carrier specs
Also add a checkbox to persist the value.  However, the logic to
pass this persistence to ConnectivityService has not yet been added.

Bug: 31075769
Test: Visual inspection of dialog (upcoming)
Change-Id: I370ab07ea276b024ce4adc61e10ca085be1c5549
2016-09-16 17:51:16 -07:00
Hugo Benichi
56e754b446 Add a "Cellular data fallback" pref. am: a317684cfc am: aabd051f50
am: d294f58361

Change-Id: Iceca5357dab0d1a2755070f9b3b2fd7964b6e8ca
2016-09-16 16:53:17 +00:00
Hugo Benichi
aabd051f50 Add a "Cellular data fallback" pref.
am: a317684cfc

Change-Id: I902d4039aefddbe38a7caa20afede7af20d03086
2016-09-16 16:45:15 +00:00
Hugo Benichi
a317684cfc Add a "Cellular data fallback" pref.
Also adjust working of the "lost internet" notification.

Bug: 31075769
Change-Id: I17e18516c9bfdc32b38686191327b6d6f87aed95
2016-09-17 00:30:05 +09:00
Lorenzo Colitti
e4d8284000 Support displaying a dialog when Wi-Fi loses Internet access. am: 1449ecd460 am: a4aa79bb69
am: 0e92ddbc1b

Change-Id: I346f3b3267c3108db8fec585a0d0b7c54934b37e
2016-09-15 16:17:02 +00:00
Lorenzo Colitti
a4aa79bb69 Support displaying a dialog when Wi-Fi loses Internet access.
am: 1449ecd460

Change-Id: I835eeb9165e726e20c26c47fb4e20fbd6d9e3f5a
2016-09-15 16:05:53 +00:00
Lorenzo Colitti
1449ecd460 Support displaying a dialog when Wi-Fi loses Internet access.
Bug: 31075769
Change-Id: Ia0c76d80591937dc40765c437e5779f3b6dde217
2016-09-15 23:43:00 +09:00
Doris Ling
7d16fb0baf Fix NullPointerException when refreshing wifi preferences. am: b8011dbb93 am: 7a15f88912 am: e972a23faf
am: e3f9654ebc

Change-Id: I48da5c628897cb92f47525772fbfa2ee78929f61
2016-09-01 00:08:17 +00:00
Doris Ling
e972a23faf Fix NullPointerException when refreshing wifi preferences. am: b8011dbb93
am: 7a15f88912

Change-Id: I3b04d4d87063f928fa76b4843ca0692c8d0311cb
2016-09-01 00:02:02 +00:00
Doris Ling
7a15f88912 Fix NullPointerException when refreshing wifi preferences.
am: b8011dbb93

Change-Id: Ib77f937b79813351594037eaa424fac33995f336
2016-08-31 23:59:08 +00:00
Doris Ling
b8011dbb93 Fix NullPointerException when refreshing wifi preferences.
AccessPointPreference.refresh() is being called in different threads.
The refresh of the preference should only be updated in the main thread.
When access point updates is received not in the main thread, will post
the refreshing of the preference to the message queue to make the update
on the UI thread.

Test: auto - run monkey to verify there is no ANR or crash
      manual - go to Settings->Wifi, toggle on/off many times and verify
      there is no crash.

Change-Id: I656a70ecf2e7b9446c7b95b6b42ab19a5cc2e51c
Fixes: 30902893
2016-08-31 22:19:19 +00:00
Doris Ling
dc8a2d2b36 Remove preference "Searching for Wi-Fi networks..." am: b8e8485720
am: ba7e57ec06

Change-Id: Ic2e0b0c977cf11dcca4ed87deeb8bc6fe9a27420
2016-08-30 20:07:38 +00:00
Doris Ling
ba7e57ec06 Remove preference "Searching for Wi-Fi networks..."
am: b8e8485720

Change-Id: Ie264fbdddf2aff8b8f5f4d6aac2fc079b98c9747
2016-08-30 20:05:09 +00:00
Doris Ling
925584fb84 Remove preference "Searching for Wi-Fi networks..." am: b8e8485720
am: b7d9f7b83d

Change-Id: I3d21413f7ee61001bae570b478871af6f95d2999
2016-08-30 20:05:08 +00:00
Doris Ling
b7d9f7b83d Remove preference "Searching for Wi-Fi networks..."
am: b8e8485720

Change-Id: I170a0f79c0d7c89de314c81088ac8b5939ddff11
2016-08-30 20:01:40 +00:00
Doris Ling
b8e8485720 Remove preference "Searching for Wi-Fi networks..."
When we add the preference "Searching for Wi-Fi networks...", we didn't
provide a key to the preference. As a result, each time when we get
access point update and try to show such tile, it creates a new one, and
results in multiple entries of such tile. Adding a key to the preference
will prevent the multiple entry from being added.

Test: Manual -
1. Turn wifi off and on several times, verify that there is only one entry
   of "Searching for Wi-Fi networks..." when initializing the wifi access
   point list.
2. Verifies that when the access point list is established, the
   "Searching for Wi-Fi networks..." entry is gone.

Change-Id: Iaad329d89f8e4b52129d0661501aa34fbd956692

Change-Id: I1bfa77051e068926e8c876a89adf14d143970e7e
Fixes: 31143961
2016-08-30 17:41:44 +00:00
The Android Automerger
94473046fb Merge commit '87e59d0' into nyc-dev-plus-aosp 2016-08-30 01:00:30 +00:00
Christopher Wiley
87e59d0e81 Do not use TetherUtil.setWifiTethering
This functionality is replaced by ConnectivityManager.startTethering()
and ConnectivityManager.stopTethering().

Bug: 30147602
Test: Can toggle tethering on/off via all of settings, quick settings,
      and quick quick settings.
Change-Id: I4d190185c473237982b988f898e76d4997dc401c

(cherry picked from commit 9d251279ca)
2016-08-26 13:26:45 -07:00
Fan Zhang
1dda6f6430 Don't remove wifi preferences when updating AP to avoid GC.
am: 9d031f2fbc

Change-Id: I3b589d86fc6ecd1a6caf0db9f3b9f7674dbe046a
2016-08-25 00:44:53 +00:00
Fan Zhang
1330f130d6 Don't remove wifi preferences when updating AP to avoid GC.
am: 9d031f2fbc

Change-Id: I0a4c7204dcb79880aee5db620b9642b8a1314757
2016-08-25 00:44:53 +00:00
Fan Zhang
d96bc5b5a6 Don't remove wifi preferences when updating AP to avoid GC. am: 3f0e1344d3
am: bc6e2c49f0

Change-Id: Id21a0340fd29bee4ee5bdf721d3ec7b44be8a961
2016-08-25 00:30:17 +00:00
Fan Zhang
9d031f2fbc Don't remove wifi preferences when updating AP to avoid GC.
Bug: 30870531

Removing wifi preferences every time will force update create a new set
of preferences, which leads to higher chance of GC.

Change-Id: Ifea2f63a3b54fa0d5861fb34a348d81e99bcab68
2016-08-24 22:49:13 +00:00
Fan Zhang
3f0e1344d3 Don't remove wifi preferences when updating AP to avoid GC.
Bug: 30870531

Removing wifi preferences every time will force update create a new set
of preferences, which leads to higher chance of GC.

Change-Id: Ifea2f63a3b54fa0d5861fb34a348d81e99bcab68
2016-08-24 15:31:10 -07:00
Salvador Martinez
5bbfa0555a Prevent wifi icon from disappearing am: 5c0063af7e
am: 56ebf2a051

Change-Id: I0cf475280dd390e55befd285c33cde593e8c7878
2016-08-23 18:26:33 +00:00
Salvador Martinez
5c0063af7e Prevent wifi icon from disappearing
Made changes to WifiSettings that customizes
the preference icon so that the icon is never
null. This greatly reduces jittering.

Bug: 29979747
Change-Id: I3d2767310513389c09a37e34674a304278f4d0de
(cherry picked from commit 47568de003)
2016-08-19 18:07:46 +00:00
Christopher Wiley
9170100f6c Merge \"Do not use TetherUtil.setWifiTethering\" into nyc-mr1-dev
am: 62edbf484e

Change-Id: I023592acc146cbddb2917556a0fb7c3dade417f4
2016-07-19 16:02:42 +00:00
Christopher Wiley
9d251279ca Do not use TetherUtil.setWifiTethering
This functionality is replaced by ConnectivityManager.startTethering()
and ConnectivityManager.stopTethering().

Bug: 30147602
Test: Can toggle tethering on/off via all of settings, quick settings,
      and quick quick settings.
Change-Id: I4d190185c473237982b988f898e76d4997dc401c
2016-07-18 11:17:14 -07:00
Jason Monk
167f6cc87c Merge \"Remove PreferenceActivity\" into nyc-dev
am: 7f7092c705

Change-Id: I1d7431bd7bf4654f2fbfe8c43344e22d28b5b2f7
2016-06-08 19:15:42 +00:00
Jason Monk
b7e4380cd2 Remove PreferenceActivity
Its broken and isn't worth maintaining, instead port the few things
using it over to SettingsPreferenceActivity with wrapping blank
Activities like the rest of Settings.

Change-Id: Ic82f0dcb63ed9b4078f7da6a79c0c52f0130e8d1
Fixes: 28779941
2016-06-08 09:48:58 -04:00
Paul Stewart
aa5afb18fe Merge "Display connect button in the wifi connection menu" am: 9126cfba19
am: ace9f52725

* commit 'ace9f527253a5464308f8dd3aa97f841d5d2d996':
  Display connect button in the wifi connection menu

Change-Id: Ia72d92c7e50cfb316772609e561b34d0b8c62333
2016-05-27 15:06:06 +00:00
Felipe Leme
5c09184e00 Disable tethering when Data Saver mode is on.
BUG: 28313291
Change-Id: Idbedd440a1baa41f1407b32e86f5ae0080e60798
2016-04-22 14:25:35 -07:00
Jason Monk
623a289b9a Merge "Potential fix for receiver leak problem" into nyc-dev 2016-04-20 13:49:32 +00:00
Jason Monk
8ab081e304 Potential fix for receiver leak problem
The background thread is not stopping listening fast enough and is
resulting in first a receiver leak message followed by a crash when
trying to finally unregister the receiver.

Fix this by adding a registerReceiver to SummaryLoader that will
automatically unregister the receiver on the main thread to ensure
it happens in time.

Change-Id: I0104e929d5505eb53993f6765e4c90120df35cf6
Fixes: 28211606
2016-04-18 15:30:42 -04:00