Commit Graph

589 Commits

Author SHA1 Message Date
Chaohui Wang
4b0090700a Merge "Migrate the "Use this SIM" preference" into main 2024-03-07 12:43:52 +00:00
Graciela Wissen Putri
aed31bb8bd Follow config overlay's order of aspect ratio options am: a0f573a35e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/26456385

Change-Id: I30ff221caba3be36834acb44958cf2aed30c17d1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-07 12:11:14 +00:00
Chaohui Wang
186629aad4 Migrate the "Use this SIM" preference
This will fix the toggle flicker issue.

Fix: 262179656
Test: manual - on Mobile Settings
Test: unit test
Change-Id: Ided2445034a83a8efc11dc97bab8719686d63712
2024-03-07 17:48:09 +08:00
Chaohui Wang
74fe516e09 Fix flicker of "App data usage"
Use placeholder to hold the place.

Fix: 323466366
Test: manual - on Mobile Settings
Test: unit test
Change-Id: I3c4d9ff6538a79500318869f01f4b88b55bd9475
2024-03-07 15:20:01 +08:00
Chaohui Wang
ad611366df Sort the selectable subscription by id
To make sure users always see a fixed order.

Bug: 318310357
Test: manual - on SIMs and turn on / off SIM
Change-Id: I2910d83f5b1d04287afca0e3ba91dedbeb588c14
2024-03-07 11:23:25 +08:00
Graciela Wissen Putri
a0f573a35e Follow config overlay's order of aspect ratio options
Fix flaky UserAspectRatioAppsPageProviderTest by using advanceUntilIdle
to make sure all coroutines are finished before asserting.

Bug: 325911424
Test: atest UserAspectRatioDetailsTest
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:32815ad699448c5c5b1f38df6d2d2a881d4251c1)
Merged-In: I83e9a7f31536c1a006789722b0310f3364d14337
Change-Id: I83e9a7f31536c1a006789722b0310f3364d14337
2024-03-05 17:11:59 +00:00
Chaohui Wang
4dbc23ca28 Create NetworkScanRepository
And migrate network scan to flow for better maintenance and prevent ANR.

Fix: 323105271
Test: manual - Choose network
Test: unit test
Change-Id: I5c49d195fc202143c0131ffd78bc3adc168b119c
2024-03-05 21:45:18 +08:00
Chaohui Wang
bec4c9573e Create isSubscriptionEnabledFlow
To better display the isEnable checked state.

Bug: 318310357
Test: manual - on Mobile Settings
Test: unit test
Change-Id: Ia595e7445650ad67883f1e7c1a0662cb826565ea
2024-03-02 05:01:28 +00:00
Charlotte Lu
7aee673020 Merge "Add WEP warning dialog disconnect." into main 2024-02-29 02:35:33 +00:00
Charlotte Lu
7755dc53b9 Add WEP warning dialog disconnect.
Test: Unit Test
Fix: 318797664
Change-Id: I48dd4ad2783ea4b1f03f2b7c7e0f8716cbb59224
2024-02-28 17:51:20 +08:00
Chaohui Wang
758e3828b3 Disable app data usage if all time usage is 0
Otherwise user can open an empty App data usage page.

Bug: 292346951
Test: manual - on Mobile Settings
Test: unit test
Change-Id: I63c3e06af2606c3e2017f2440addb2ac2d9d775b
2024-02-28 13:17:28 +08:00
Charlotte Lu
88bc924647 Merge "Change Privacy into full page." into main 2024-02-27 10:11:17 +00:00
Chaohui Wang
daa509874f Fix Wi-Fi calling option does not appear
After turning on non-DDS sim.

This is because IMS feature takes time to provisioning, and IMS takes
time to become ready.

Before this fix, we do not observe the status.
After this fix, observe the readiness to fix.

Fix: 325414275
Test: manual - turn DSDS on - off
Test: unit tests
Change-Id: If10abdb331da1ff8310e10681d055d7fbe04eaee
2024-02-27 08:11:31 +08:00
Chaohui Wang
b4ab4144aa Create WifiCallingRepository
Move Wi-Fi calling related feature into it.

Which simplifies the ImsMmTelRepository, so we can put more
ImsMmTelManager related features into ImsMmTelRepository in the future
cl.

Bug: 325414275
Test: manual - on Mobile Settings
Test: unit tests
Change-Id: I391f43cfa3a79e0c44865050c357ac54346c2fb1
2024-02-26 18:49:20 +08:00
Charlotte Lu
8b8a16bc7c Change Privacy into full page.
Test: Visual Test
Fix: 324020620
Change-Id: Ifacbf7eef3b56774c5f891c8cd60ddee2d380632
2024-02-26 04:26:26 +00:00
Manjeet Rulhania
322b905f71 Merge "add sensitive content protection flag to developer option" into main 2024-02-24 00:52:16 +00:00
mrulhania
8925db1c5e add sensitive content protection flag to developer option
Bug: 316955558
Test: atest SensitiveContentProtectionPreferenceControllerTest
Change-Id: Iedbbc9bd3bba00c6aaccc99758abe0b77306da01
2024-02-23 19:50:17 +00:00
Varun Shah
646d052228 Merge "Add new Special App Access screen for Backup Tasks." into main 2024-02-22 21:46:53 +00:00
Hani Kazmi
05427e6903 Merge changes from topics "ecm-manager", "ecm-tests" into main
* changes:
  Replace ECM AppOps call with service
  Wired remaining SpecialAppAccess for ECM.
2024-02-21 19:29:04 +00:00
Hani Kazmi
206300962f Replace ECM AppOps call with service
A new ECM service was introcuded in changeId
I831391e4437b51b3312b5273a2360bd029a3d8ee.

We begin calling it, and update/cleanup method signatures to match.

Note: There are two feature flags:

1. enhancedConfirmationModeApisEnabled - read only, protects the
   mainline API.

2. extendEcmToAllSettings - runtime - gates calls to the above APIs.

We use both so we can ramp up in teamfood as needed.

Bug: 297372999
Test: Tested on device
Test: atest SpaPrivilegedLibTests
Test: atest com.android.settings.applications.specialaccess.notificationaccess
Test: atest com.android.settings.datausage
Test: atest PremiumSmsAccessTest
Test: atest RestrictedPreferenceHelperTest
Change-Id: I945ec51df5cd63de548a8ffdd1acc4f09f2301e5
2024-02-21 14:43:02 +00:00
Chaohui Wang
6664870eb8 Fix cannot update APN settings in new edit page
Fix: 326164397
Test: manual - edit existing APN
Test: unit test - existing tests still pass
Change-Id: I92a2e375b990f0e478dbb30c389371a8e0596608
2024-02-21 18:14:20 +08:00
Yiyi Shen
a2577fd60e [Audiosharing] Impl audio sharing feature provider in Settings
Bug: 324023639
Test: manual
Change-Id: I4005ea8fbc0983a833f5a7dee2815f09eab48d3c
2024-02-20 08:06:55 +00:00
SongFerng Wang
f4d0eff41e Merge "[SimUiEnhancement] Fix Automatic Data switch UI at SimOnboarding" into main 2024-02-20 02:02:22 +00:00
songferngwang
6d0b41af5a [SimUiEnhancement] Fix Automatic Data switch UI at SimOnboarding
- Automatic Data switch can't set value to framework, since
the nonDds is -1
- update the ProgressDialog as compose UI

Bug: 318310357
Bug: 298898436
Bug: 298891941
Test: Build pass
Change-Id: Ifeca38b42b3a51e8a967c0e744eeae06338f6ddc
2024-02-19 03:12:50 +00:00
Chaohui Wang
e9917e2f48 Fallback to NUMERIC when CARRIER_ID is unknown
For some subscription, the carrier id is unknown (-1), which cause the
inserted APN not be displayed.

Fallback to NUMERIC when CARRIER_ID is unknown to fix this issue.

Fix: 324394199
Test: manual with esim test profile - carrier id -1
Test: unit tests
Change-Id: Ic63a3e0c9ab37c8bdf86a2c7155b08778f05deff
2024-02-18 16:26:15 +08:00
Varun Shah
a00a81cc1c Add new Special App Access screen for Backup Tasks.
This new screen shows apps that hold the new RUN_BACKUP_JOBS permission.

Also add a reference to this screen in an app's info page under the
"Advanced" section for apps that have requested this permission.

Bug: 320563660
Test: BackupTasksAppsTest
Test: BackupTasksAppsPreferenceControllerTest
Test: visually via the Settings page

Change-Id: I7136fc74f3b0d0124889e7cf9e1234f917346432
2024-02-17 21:54:12 +00:00
Mark Kim
bf0ea22082 Disable APP_ARCHIVING flag for specific test
APP_ARCHIVING flag was introduced to control archiving feature in
Settings separately from OS.
The broken test was expecting archiving feature flag be disabled but it
didn't take into account a newly introduced flag which was automatically
rolled out in ag/26270549

Test: AppButtonsTest
Bug: 325632047
Change-Id: I02a1f4e2e2bfa1b85f2d993c4127698c8a6195dc
2024-02-17 00:47:05 +00:00
Ahaan Ugale
a4f81032f2 Merge "Update sensitiveNotificationAppProtection reference after move." into main 2024-02-14 19:40:32 +00:00
Chengfei Tao
d1618f94ff Merge "SettingsGoogle: Add ContextualScreenTimeout" into main 2024-02-13 01:44:06 +00:00
chengfeitao
ffb6e7e21b SettingsGoogle: Add ContextualScreenTimeout
Store contextual screen timeout preference when the
corresponding switch is toggled.

Bug: 295232527

Test: atest ExternalSettingsProviderTest
Test: atest ContextualTimeoutPreferenceControllerTest
Change-Id: I093d180f4b11ebb806c4b1949ff5428520c8f40f
2024-02-12 23:14:40 +00:00
Ahaan Ugale
9507e30c5b Update sensitiveNotificationAppProtection reference after move.
Bug: 309564730
Test: builds
Change-Id: I256eb8bd9e80a481ef1bffe22053f6fa668e5ee2
2024-02-12 18:21:00 +00:00
Aditya Choudhary
4f5c1ac5bc [DON'T BLOCK] Test ownership migration rules
This CL is created as a best effort to migrate test targets
to the new android ownership model. If you find incorrect or unnecessary
attribution in this CL, please create a separate CL to fix that.

For more details please refer to the link below,
go/new-android-ownership-model

Bug: 304529413
Test: N/A
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:3f65505208d57fa18be353f815c44fdd6f004f4b)
Merged-In: I7fbd55a92f4302a6e03bcff0283737fd9295165d
Change-Id: I7fbd55a92f4302a6e03bcff0283737fd9295165d
2024-02-09 16:54:41 +00:00
Aditya Choudhary
3f65505208 [DON'T BLOCK] Test ownership migration rules
This CL is created as a best effort to migrate test targets
to the new android ownership model. If you find incorrect or unnecessary
attribution in this CL, please create a separate CL to fix that.

For more details please refer to the link below,
go/new-android-ownership-model

Bug: 304529413
Test: N/A
Change-Id: I7fbd55a92f4302a6e03bcff0283737fd9295165d
2024-02-09 16:14:48 +00:00
SongFerng Wang
5b716c2c6b Merge "SIM Onboarding flow completed" into main 2024-02-07 04:48:55 +00:00
songferngwang
f1ea484425 SIM Onboarding flow completed
- Add the setup flow for switching sim and rename and setup primary sim
  items
- Add the bottom sheet and progress dialog.
Bug: 318310357
Bug: 298898436
Bug: 298891941
Test: build pass. Will upload another cl for testing

Change-Id: Ie9680f0a67afe453c1449c0f2b59e98fd627e215
2024-02-06 10:56:59 +00:00
Richard MacGregor
9ed6467714 Merge "Add developer option for screenshare protections" into main 2024-02-05 18:34:50 +00:00
Mark Kim
6b64e92fc8 Merge "Use a separated flag for archiving feature in Settings" into main 2024-02-05 10:55:37 +00:00
Chaohui Wang
213c998557 Use collectAsCallbackWithLifecycle
Instead of observeAsCallback, since isAllowed is a flow now.

Bug: 322916468
Test: manual - on Toggle Permission page and switch between apps
Test: unit test
Change-Id: Ic33a7d6cd7c71c7cf6cd4a6e353505fa12cf0046
2024-02-03 04:12:39 +00:00
Richard MacGregor
dc15244a5d Add developer option for screenshare protections
Add developer option that allows disabling screenshare protections to
allow for better bug reports and debugging.

Bug: 320757744
Bug: 316955558
Bug: 316954829
Flag: ACONFIG com.android.server.notification.sensitive_notification_app_protection DISABLED
Flag: ACONFIG com.android.server.notification.screenshare_notification_hiding DISABLED
Test: atest SensitiveContentProtectionPreferenceControllerTest
Change-Id: Ibcb9f886aa599fe2442e755653c49f44cfa1830f
2024-02-02 19:33:35 -08:00
Pajace Chen
32587dbdcf Merge changes from topics "low_battery_tip", "new_settings_card" into main
* changes:
  [BatteryTip] Implement new CardPreference to apply new style
  [BatteryTips] Separate the low battery tips
2024-02-03 01:45:21 +00:00
Mark Kim
7adac0459c Use a separated flag for archiving feature in Settings
The new flag will replace the current PM-flag eventually, once they reach the same rollout status. Until then both flags are kept concurrently, to avoid a rollback of the feature.

This is done to reduce risk and potentially enable an isolated rollback
of Settings related logic, while keeping system logic intact.

Additionally, fix bug by replacing `System.getProperty("pm.archiving.enabled")` to `SystemProperties.getBoolean("pm.archiving.enabled", false)`

Test: InstalledAppCounterTest, AppButtonsTest, HibernationSwitchPreferenceTest
Bug: 323164382
Change-Id: I44a41d6a43a12134c4e3aa5df8ad6a9eb91758d4
2024-02-02 17:16:47 +00:00
pajacechen
d171a8b946 [BatteryTip] Implement new CardPreference to apply new style
- Implement a new CardPreference to apply SettingsCard
- Apply CardPreference on battery tips

Bug: 315748218
Test: atest SettingsSpaUnitTests:com.android.settings.widget.CardPreferenceTest
Test: atest SettingsRoboTest:com.android.settings.fuelgauge
Change-Id: I9a57e7739275854278b2c586793af718b0680d23
2024-02-02 22:27:16 +08:00
Joanne Chung
8541c6c4ef Merge "Allow uninstallation of current home app" into main 2024-02-02 05:02:50 +00:00
lpeter
b3e2179531 Allow uninstallation of current home app
Change the behavior to allow uninstallation of the current home app
if it is a non-system app and/or there are other candidate apps
available.

Bug: 131721576
Test: atest com.android.settings.applications.appinfo.AppButtonsPreferenceControllerTest
Test: atest com.android.settings.spa.app.appinfo.AppButtonRepositoryTest
Change-Id: I556966894240aaf91c0e6424dce514b6a35d1001
2024-02-01 23:57:15 +00:00
SongFerngWang
8535539582 [Sim UI enhancement] MobileNetworkSettings UI enhancement
- Add the phone number
- Add the mobile network(SPN)
- Add the IMEI
- Add the EID
- Remove the mobile data
- Remove the Auto data switch
- Remove the calls and SMS default subscription

Bug: 318310357
Bug: 298898436
Bug: 298891941

Test: atest MobileNetworkEidPreferenceControllerTest
atest MobileNetworkImeiPreferenceControllerTest
atest MobileNetworkPhoneNumberPreferenceControllerTest
atest MobileNetworkSpnPreferenceControllerTest
atest MobileDataPreferenceControllerTest
atest MobileNetworkSettingsTest

Change-Id: Ie2767056dd04d1131390e3a03d6d82d56fe5b2dc
2024-01-31 07:45:28 +00:00
Xin Li
6b4b7336bc Merge Android 24Q1 Release (ab/11220357)
Bug: 319669529
Merged-In: If21ca5e914a5ee5aff3fbeeee9595bb77a8fc3d0
Change-Id: I87182e72d0ceb75499528f9011d009d772045e09
2024-01-30 09:24:25 -08:00
Chaohui Wang
745c69b76a Make MoreOptionsScope abstract class
Bug: 321724969
Test: m Settings
Test: unit test
Merged-In: Iced9df83f600c86cc409abc040fb9ace0dcedf1e
Change-Id: Iced9df83f600c86cc409abc040fb9ace0dcedf1e
2024-01-25 20:22:45 +00:00
Chaohui Wang
c909b37221 Merge "Make MoreOptionsScope abstract class" into main 2024-01-23 23:31:28 +00:00
Ling Ma
b6e28eeda5 Merge "Wrap subManager creation with createForAllProfiles" into main 2024-01-23 18:03:11 +00:00
Anubhav Kakkar
1a2774e3d8 Add trunk flag check to prevent changing the special app access settings for 'Change media output' for direct intent based entry when trunk flag is not enabled.
Bug: 321905521
Test: Ensure trunk flag is disabled > Open app specific settings for 'Change media output' > Ensure that settings should not be changeable
Change-Id: Iedfd82d97eb49fc65c56d332bde815ff41e24736
2024-01-23 16:43:16 +00:00