Commit Graph

1907 Commits

Author SHA1 Message Date
TreeHugger Robot
d34b2a9697 Merge "Add SSID to Network Details page for Passpoint" 2019-03-28 22:12:33 +00:00
TreeHugger Robot
23cb22a7f9 Merge "Added null pointer check for mWifiConfig.macRandomizationSetting" 2019-03-28 20:33:23 +00:00
Quang Luong
1859a19302 Added connect listener to startOsuProvisioning()
Updated AccessPoint.startOsuProvisioning() call to accept a connect
listener to display a toast on failure to connect.

Bug: 123697580
Test: build
Change-Id: I0f29b2f5ccc8f2d4b8137639725dca1bcb106b26
2019-03-28 13:09:37 -07:00
Quang Luong
a2297dc1d1 Add SSID to Network Details page for Passpoint
Added SSID to Network Details page under the Advanced portion only
when the network is for Passpoint, whose network title is not the
SSID of the underlying connected AP.

Bug: 129092023
Test: atest RunSettingsRoboTests

Change-Id: I13308d46e727fc01fec7a079d8e32ab9f1763e21
2019-03-28 11:54:19 -07:00
Quang Luong
9f0b00104e Merge "Disable Mac randomization setting for Passpoint networks" 2019-03-28 18:17:22 +00:00
cosmohsieh
e4b3844d0b Show "Disconnect" on forget button for ephemeral network
For app or carrier initiated wifi connections (i.e all "ephemeral networks"),
the detailed page of settings should show "Disconnect" instead of "Forget".

Bug: 123892605
Test: atest WifiDetailPreferenceControllerTest
Change-Id: I1ee7f45ea12fe2ab9ca35cab77de0b1d67efc1db
2019-03-28 14:35:42 +08:00
Quang Luong
d832dcc7c5 Disable Mac randomization setting for Passpoint networks
Mac randomization setting should be greyed out in the network
details page for Passpoint networks.

Bug: 129279500
Test: atest WifiPrivacyPreferenceControllerTest
Change-Id: I4fc89ddbca839c4859f11f8fad212b3e0e4aa7ce
2019-03-27 15:28:34 -07:00
Quang Luong
3c2c658791 Added null pointer check for mWifiConfig.macRandomizationSetting
Without the null pointer check, a passpoint network in the saved
networks page will throw a NullPointerException since there is no
config associated with it.

Bug: 129422562
Test: manual
Change-Id: I4a085a16c4181b7bdfe46c279e579d34ba314d81
2019-03-27 14:53:09 -07:00
TreeHugger Robot
5e1f97ffb6 Merge "[Passpointv2] Fix Network detail page title" 2019-03-27 21:00:17 +00:00
TreeHugger Robot
ade1e095e7 Merge "List reachable access points on top of the list in WifiNetworkListFragment" 2019-03-27 12:17:23 +00:00
cosmohsieh
2213816720 [Passpointv2] Fix Network detail page title
Sets original detail title if the chart header feautre on detail page don't
enable.

Bug: 128569047
Test: manual
Change-Id: I43a7b1bd11294b34b39b46e0d8f63a844af1585e
2019-03-27 09:43:45 +00:00
Arc Wang
b661549b81 List reachable access points on top of the list in WifiNetworkListFragment
Bug: 128942314
Test: manual
Change-Id: I036bf09c066da3a68d6e2fc4685313ccf16bff03
2019-03-27 15:24:51 +08:00
clownshen
936f1f215e Provide connect button in Wi-Fi detail page
User can click connect button to connect this AP at the detail page even
the Wi-Fi disabled. Would turn on Wi-Fi if disabled and then connect to
this saved network.

Bug: 126503889
Test: atest and manual test
Change-Id: I313e290474d6623a6c3e84027e81d0d1ebf16919
2019-03-27 13:08:02 +08:00
TreeHugger Robot
13197e38c2 Merge "Fix inconsistent border width in QR code scanning camera" 2019-03-27 00:47:02 +00:00
jackqdyulei
6aeed0eaa1 Fix broken settings tests(Round 2)
1. Mark a few as Ignore with bug number
2. Remove some tests since they are obsolete.

Bug: 129159331
Test: RunSettingsRoboTests
Change-Id: I801681609c31c1f824c44b49ec89d9d28c716539
2019-03-26 12:46:01 -07:00
TreeHugger Robot
8edea74eda Merge "[WPA3] Initialize Suite-B ciphers correctly based on the CA cert type" 2019-03-26 16:14:17 +00:00
TreeHugger Robot
d9ab124d81 Merge "Add a different Wi-Fi Easy Connect entry point" 2019-03-26 15:12:24 +00:00
Arc Wang
8ae9717226 Fix Wi-Fi Easy Connect QR code scanner problems
1. When camera area overlaps display cutout, it's onLayout size is 0/0.
   To fix it, use ConstraintLayout to specify width and height in layout file.

2. When scanned a QR code and there is an error, set camera area frame line
   back to unfocused color.

Bug: 124399763
Test: manual test
Change-Id: I7575efd0ccfb58d114acc3dcca6978d68b801f91
2019-03-26 16:07:02 +08:00
Arc Wang
8a9ccfd8d9 Add a different Wi-Fi Easy Connect entry point
To separate it further from Wi-Fi sharing as it was
causing some confusion.

Bug: 129031195
Test: manual test
Change-Id: Ia55e3ed91e92c3ec36ae6a9401897c5c960762da
2019-03-26 09:55:38 +08:00
Arc Wang
200fe62814 Merge "Add divider line in Preference for scan QR code button and share hotspot button" 2019-03-26 01:36:26 +00:00
Hai Shalom
566101d166 [WPA3] Initialize Suite-B ciphers correctly based on the CA cert type
Initialize Suite-B ciphers correctly based on the CA cert type. Read the
cert type from key store, parse it and get the signature algorithm.
Enforce SHA384, and initialize AllowedSuiteBCiphers based on the
certificate type: RSA or ECSDA.
Wi-Fi alliance requires the use of both ECDSA secp384r1 and RSA 3072
certificates in WPA3-Enterprise 192-bit security networks, which are
also known as Suite-B-192 netowkrs, even though NSA Suite-B-192 mandates
ECDSA only. The use of the term Suite-B was already coined in the
IEEE 802.11-2016 specification for AKM 00-0F-AC but the test plan for
WPA3-Enterprise 192-bit for APs mandates support for both RSA and ECDSA,
and for STAs it mandates ECDSA and optionally RSA. In order to be
compatible with all WPA3-Enterprise 192-bit deployments,

Bug: 128861164
Test: Verify Suite-B initialized correctly with RSA and ECDSA certs.
Test: Associate to SUITE_B_192 AP with RSA certificate
Test: Associate to SUITE_B_192 AP with ECDSA certificate
Change-Id: I5e8b6794e68ed3af5f8c8beac622fff8076a46a1
2019-03-25 14:40:59 -07:00
cosmohsieh
10d648af3b Fix inconsistent border width in QR code scanning camera
1) Fix border width become larger in the corner.
2) Correct border width

Bug: 127654782
Test: manual
Change-Id: I792ac571b5c59d14af82848698d76cb59a2f4249
2019-03-25 16:37:29 +08:00
Hall Liu
928d2abc57 Merge "Show the disclaimer regarding WFC location privacy policy" 2019-03-23 02:13:33 +00:00
Arc Wang
25595994b7 Add divider line in Preference for scan QR code button and share hotspot button
Use com.android.settingslib.R.layout.preference_two_target in
WifiTetherSsidPreference to add divider line.

Bug: 128940862
Test: manual test
Change-Id: I46dabcee31a91b68b8c2e57c9840a59f8a1be304
2019-03-22 18:06:11 +08:00
TreeHugger Robot
c74577eacf Merge "Revert "Add divider line in Preference for scan QR code button and share hotspot button"" 2019-03-22 08:18:16 +00:00
Arc Wang
8040f4c59f Revert "Add divider line in Preference for scan QR code button and share hotspot button"
This reverts commit 890f3a4340.

Reason for revert: I find a UI defect in this fix.

Change-Id: Icdbb1d2b5319636b8c4c54bcdc0fc3562585a15a
2019-03-22 05:36:59 +00:00
TreeHugger Robot
5ccefd53d1 Merge "Check if enrolled Wi-Fi network is reachable in WifiManager#connect onSuccess callback" 2019-03-22 05:36:45 +00:00
TreeHugger Robot
3a00f3bf81 Merge "Add keywords for wifi slice" 2019-03-22 03:42:17 +00:00
Arc Wang
7599de43f7 Check if enrolled Wi-Fi network is reachable in WifiManager#connect onSuccess callback
WifiManager#connect may callback onSuccess even if the Wi-Fi network is not reachable,
it confuses users.

In onSuccess callback, if the Wi-Fi network is unreachable, shows error message.

Bug: 127980127
Test: manual test
Change-Id: I503d6c77c1f1fcab3a1240d904f1c60aaef63aa1
2019-03-22 10:48:27 +08:00
Arc Wang
d2405c7328 Merge "Improve Wi-Fi Easy Connect lock screen UI information" 2019-03-22 02:19:48 +00:00
Cosmo Hsieh
aaf6e03499 Merge "[Network Connection] Don't dismiss dialog when touching outside of dialog" 2019-03-22 01:45:53 +00:00
Mill Chen
a77a05d5ae Add keywords for wifi slice
Wifi slice didn't have a bunch of keywords for search, so users have to
type full matched text to search for wifi setting. We added keywords for
wifi slice to fix it, in which keywords are defined in strings.xml.

Fixes: 109922806
Test: rebuild
Change-Id: Ibe3b65c186cf6f43ae744c1f478d8985e270374c
2019-03-21 17:21:33 -07:00
Jason Chiu
b056c3a2b6 Show connecting and connected messages on the header subtext of Wi-Fi slice
Fixes: 128631698
Test: robotest
Change-Id: I1ea2a65d09eca9b3dd06f56c4ae69ef7f68ffd86
2019-03-21 18:49:09 +08:00
TreeHugger Robot
b9e6f894c3 Merge "Add divider line in Preference for scan QR code button and share hotspot button" 2019-03-21 06:26:27 +00:00
Arc Wang
abfd8ab726 Improve Wi-Fi Easy Connect lock screen UI information
1. Change lock screen title and remove description
2. In QR code generator screen, change summary and show password under QR code picture

Bug: 128920152
Bug: 128576809
Test: manual test
Change-Id: Id096d7f417308df14ffe50c618644750aa991df8
2019-03-21 14:09:22 +08:00
TreeHugger Robot
4a6b8a608c Merge "[Network Connection] Implement Unavailable callback when the user cancels" 2019-03-21 05:48:17 +00:00
cosmohsieh
3babe9e908 [Network Connection] Don't dismiss dialog when touching outside of
dialog

To Improve user experience, prevent dialog dismissing from touching outside
of the dialog

Bug: 128877712
Test: atest NetworkRequestDialogFragment
Change-Id: Idfa90c3647f5cf766aaa63fdb8a829fec5db5934
2019-03-21 13:22:36 +08:00
Arc Wang
890f3a4340 Add divider line in Preference for scan QR code button and share hotspot button
Bug: 128940862
Test: manual test
Change-Id: If576f0840cc8924b63348f04fe12c3a0d4edcb89
2019-03-21 10:48:55 +08:00
Lucas Lin
f32823bc6d Merge "Modify dialog message for partial connectivity" 2019-03-21 02:34:03 +00:00
cosmohsieh
5944fa9427 [Network Connection] Implement Unavailable callback when the user cancels
UI should invoke NetworkRequestUserSelectionCallback.reject() callback when the user clicks cancel.

Bug: 128876386
Test: atest NetworkRequestDialogFragment
Change-Id: Ia5faedf8cc7113a602a4cda10b3252d02c3c8876
2019-03-21 09:37:49 +08:00
Cosmo Hsieh
64df6a3073 Merge "[Network Connection] Implement new UI changing" 2019-03-20 04:34:25 +00:00
TreeHugger Robot
85c5d73145 Merge "Improve UX of WifiDppChooseSavedWifiNetworkFragment" 2019-03-20 04:07:02 +00:00
lucaslin
7335c594be Modify dialog message for partial connectivity
In some networks, network validation may only get success
result for http probe but fail result for https probe.
For this kind of network, it may still work at some websites
or apps, but user didn't know about that. In order to fix this
issue, we will check if network has partial connectivity and
notify user to make a choice if they want to use this partial
connectivity or not.

Bug: 113450764
Bug: 128489091
Test: 1. Build pass.
      2. make -j44 RunSettingsRoboTests
      ROBOTEST_FILTER=WifiDetailPreferenceControllerTest
      3. Change captive_portal_https_url to https://invalid.com
      to simulate partial connectivity.

Change-Id: I0e87f6f2ede173f45a7b6fcf842b4f9a83d8efa1
2019-03-20 11:41:21 +08:00
Arc Wang
d0ceb83c95 Improve UX of WifiDppChooseSavedWifiNetworkFragment
In WifiDppChooseSavedWifiNetworkFragment, it does not show the saved Wi-Fi
network which is not reachable, users may be confused about why their saved
Wi-Fi network not on the list. This change shows saved networks regardless
of signal reachable or not.

Fix WifiDppChooseSavedWifiNetworkFragment UI overlap problem, remove redundant
ScrollView and adjust ConstraintLayout parameters.

Bug: 124129645
Test: manual test
Change-Id: I86637e8722bb8f40a3b995a617dc1e22b2ae324a
2019-03-20 10:06:40 +08:00
Arc Wang
e4359a9eee Merge "Fix Wi-Fi Easy Connect buttons UI defects" 2019-03-20 01:53:24 +00:00
Clown SHEN
9187906493 Merge "Display more information on network detail page" 2019-03-19 17:37:26 +00:00
Arc Wang
baf002d61a Fix Wi-Fi Easy Connect buttons UI defects
1. Apply attr/colorAccent to button icons for theme UI control
2. Apply attr/selectableItemBackground for button tapping ripple effect
3. Use ConstraintLayout to separate ssid EditText and scan button
4. Remove ButtonPreference and add AddNetworkPreference.
   ButtonPreference's naming and design look like a general purpose UI
   component but it's not. This change refactors the code.
5. In AddNetworkPreference, use settingslib layout file
   'preference_access_point' to fix UI alignment problems.

Bug: 126964552
Bug: 125434239
Bug: 126762937

Test: manual test
      atest com.android.settings.wifi.WifiSettingsTest
Change-Id: Ib899a1e10f96bb8427ff00d6b5dfca37a0642c44
2019-03-19 16:27:04 +08:00
cosmohsieh
b795dcbcd1 [Network Connection] Implement new UI changing
1. Change title to multi-lines display
2. Add "SingleSpecifiedSSID" mode, will have connect button
3. Don't pop error dialog, if there is connection failure. Let user
retry.
4. Hide progress icon if list item exists

Bug: 128586511
Test: atest NetworkRequestDialogFragmentTest
Change-Id: Icc560e4882fbcd941574e44690a27d5082a7c4c7
2019-03-19 10:15:33 +08:00
Yong Shi
a37337349c Show the disclaimer regarding WFC location privacy policy
In some countries the rules is very strict about responsibility and
liability around location data during emergency calls. The purpose of
this feature is to notify end user that the location information will
be shared for calls over wifi calling.

Test: manual - Checked that WFC locatopn privacy policy is shown when
changing wifi calling setting to turned on.
Test: auto - Passed LocationPolicyDisclaimerTest.
Bug: 67872298

Change-Id: I03895743fb8da95269069ad7eda9a7b3e282857e
2019-03-18 20:42:04 +00:00
Jason Chiu
d4ab14969f Merge "Fix the bug of "Connecting" is rarely appearing on Wi-Fi slice" 2019-03-18 10:13:56 +00:00