Commit Graph

10054 Commits

Author SHA1 Message Date
TreeHugger Robot
77573ddec7 Merge "Improve multi user settings screen" into rvc-dev am: e26de87100 am: 7b58b02285 am: 6e771fdf55 am: 539843c31a
Change-Id: I72dc5f0d5d0764903de89bbff745b5466090db78
2020-05-08 03:45:47 +00:00
Arc Wang
ecf20ef23f Merge "[Wi-Fi] Apply WifiTrackerLib objects in wifi/dpp/WifiNetworkListFragment" 2020-05-08 01:02:44 +00:00
Andras Kloczl
4d7d4effa5 Improve multi user settings screen
- Added switch and user delete functionality to details screen.
- Added robo tests.

Screenshots: http://shortn/_S6fbIMhAYO
Bug: 142798722
Test: Run robo tests with this command:
  make -j64 RunSettingsRoboTests ROBOTEST_FILTER="com.android.settings.users.*SettingsTest"
Change-Id: Ied67290e8fed87feb0a60a3f2c40eb91cc57988e
2020-05-07 22:01:33 +01:00
Fabian Kozynski
1cefc2e23b Merge "Fix default for CONTROLS_ENABLED" into rvc-dev am: 64097cbb11 am: 0533f91da7 am: 0f6205e51c am: 8d36410fa5
Change-Id: I52e968e2d8f3bfa63a2b1cef0ca6c38058199de8
2020-05-07 14:38:59 +00:00
Arc Wang
e46081819d [Wi-Fi] Apply WifiTrackerLib objects in wifi/dpp/WifiNetworkListFragment
Bug: 152571756
Bug: 145100890
Test: make RunSettingsRoboTests ROBOTEST_FILTER=WifiNetworkListFragmentTest
Change-Id: I2136b452da4a3008f493c46c8ed14b311cfc9fdd
2020-05-07 22:36:41 +08:00
Fabian Kozynski
64097cbb11 Merge "Fix default for CONTROLS_ENABLED" into rvc-dev 2020-05-07 13:24:04 +00:00
Edgar Wang
214ecd8bd0 Merge "Revert "Improve multi user settings screen"" into rvc-dev am: e13919cf4b am: bbf642d994 am: b846480e48 am: 043510b53f
Change-Id: Ic4fa3990c3de69652d989af8769b32b407577c78
2020-05-07 10:27:03 +00:00
Edgar Wang
e13919cf4b Merge "Revert "Improve multi user settings screen"" into rvc-dev 2020-05-07 09:28:23 +00:00
Edgar Wang
fff8c56de2 Revert "Improve multi user settings screen"
This reverts commit d19dc306dd.

Reason for revert: this CL made Settings the test cases called shadowUserManager.hasUserRestriction()
https://sponge.corp.google.com/target?show=FAILED&sortBy=STATUS&id=07150153-ccb7-4215-a9f8-eed31e44c66f&target=RunSettingsRoboTests1-test-output

Bug: 142798722

Change-Id: I3937a07ee35a472cadd6db8cd0177e08e63516a4
2020-05-07 09:24:47 +00:00
Yanting Yang
b9835b33cd Merge "Hide the app details preference for mainline module apps" into rvc-dev am: cf33b4bc5e am: 2b19585228 am: 1b31829303 am: f37203cd17
Change-Id: Id2ce67830253759790269b87a804157c0f2873dc
2020-05-07 09:06:21 +00:00
Bonian Chen
5d856c1cfd Merge "[Settings] Update EID in background" into rvc-dev am: cae9a9c2fb am: 156ea15bb2 am: a3409e66df am: 1e79e1d398
Change-Id: I2dde3ff7933a9aa466598e58d9ef2d628cefc250
2020-05-07 09:03:09 +00:00
Kevin Maurin
633986bade Merge "Display "Android Auto" in Connected Devices summary text." into rvc-dev am: 56cefaf3d6 am: 637a3ba98f am: b890ed1585 am: 2702c9854c
Change-Id: I8df5851f3d845c16207dc7dccdbac8e2a59b54bc
2020-05-07 08:44:51 +00:00
TreeHugger Robot
d3db94ab0e Merge "[Wi-Fi] Enhance Wifi Settings unit test cases." into rvc-dev am: a76a871653 am: ee755aa059 am: e2db16a44d am: e3ac2ebb4c
Change-Id: Id3cdd5772a23470f506a790f1e2cc264f4ee7f1d
2020-05-07 08:44:32 +00:00
Yanting Yang
cf33b4bc5e Merge "Hide the app details preference for mainline module apps" into rvc-dev 2020-05-07 08:41:39 +00:00
Bonian Chen
cae9a9c2fb Merge "[Settings] Update EID in background" into rvc-dev 2020-05-07 08:20:58 +00:00
Kevin Maurin
56cefaf3d6 Merge "Display "Android Auto" in Connected Devices summary text." into rvc-dev 2020-05-07 07:20:57 +00:00
TreeHugger Robot
a76a871653 Merge "[Wi-Fi] Enhance Wifi Settings unit test cases." into rvc-dev 2020-05-07 07:11:32 +00:00
Bonian Chen
d1c8d2a771 [Settings] Update EID in background
Access EID in background thread to avoid blocking UI.

Bug: 153407357
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=SimStatusDialogControllerTest
Change-Id: Id30851bbd0b0fe080ed703586f9718be8b97abdd
2020-05-07 14:16:59 +08:00
Kevin Maurin
cabe76debc Display "Android Auto" in Connected Devices summary text.
Android Auto will be exposing a Settings tile under Connected Devices -> Connection Preferences.
If the Setting tile is available, then the summary text will reflect that.

Tested with additional unit tests and manually validated the scenarios by
flashing crosshatch-eng and disabling/enabling the relevant features.

Fix: 153896447
Test: Added unit coverage for new scenarios
Test: make RunSettingsRoboTests
Test: manually verified by flashing crosshatch-eng and disabling/enabling relevant components
Change-Id: I5a129c41b98ba435bc159a72c9a7c2dfd646ecd3
2020-05-06 21:42:43 -07:00
govenliu
1e0d40f2bd [Wi-Fi] Enhance Wifi Settings unit test cases.
Add new unit test cases in
1. WifiP2pSettingsTest.java
2. WifiConfigController2Test.java
3. WifiP2PPreferenceControllerTest.java
4. WifiP2pPeerTest.java

the coverage rate of
1. com.android.settings.wifi will raise from 44% to 45%
2. com.android.settings.wifi.P2p will raise from 69% to 85%

Bug: 151696220
Test: make RunSettingsRoboTests ROBOTEST_FILTER=WifiP2pSettingsTest
      make RunSettingsRoboTests ROBOTEST_FILTER=WifiConfigController2Test
      make RunSettingsRoboTests ROBOTEST_FILTER=WifiP2pPeerTest
      make RunSettingsRoboTests ROBOTEST_FILTER=WifiP2PPreferenceControllerTest
Change-Id: I365494e1654376b23b08f18b1a799ffc59323a4c
2020-05-07 12:13:02 +08:00
tim peng
d499737462 Merge "Update "Play media to" to "Play <APP> on"" into rvc-dev am: b8e18b4fb1 am: c5531ce6e8 am: d9370a1e27 am: 143db43ff4
Change-Id: I345f7f76088d9667515da8133315d74c6348e25a
2020-05-07 03:27:11 +00:00
tim peng
b8e18b4fb1 Merge "Update "Play media to" to "Play <APP> on"" into rvc-dev 2020-05-07 02:33:19 +00:00
Fabian Kozynski
69ee49c8d1 Fix default for CONTROLS_ENABLED
The default value for this setting if it doesn't exist is 1.

Test: Robotest PowerMenuPrivacyPreferenceControllerTest
Fixes: 155877682
Change-Id: I9025ea9c4f67492220f9ed67e11a167a65a99ec7
2020-05-06 12:36:18 -04:00
Tim Peng
6598fc8c70 PanelSlicesAdapterTest failure am: 901e1503f5 am: 65986f7eea am: 2b12b0ada7 am: e22e390a97
Change-Id: I69a5d18e6cf72505ca3ce12dffe0758172156ab4
2020-05-06 14:25:11 +00:00
Yanting Yang
172f4064a9 Hide the app details preference for mainline module apps
For mainline module apps, user can not install them from the play store.
We should not provide the play store link for them in app info page.
Therefore, we decide to hide their app details preference which is to
provide the play store link from the app info page.

Bug: 152718521
Test: visual and robotests
Change-Id: I46b64be0d725740c2b80a5251a42e9fc834e4596
2020-05-06 20:56:51 +08:00
TreeHugger Robot
8ca7a534e4 Merge "Stop usb tethering when user cancel it" into rvc-dev am: 53c6c9a672 am: 1659954b04 am: bd4ce318bc am: c27bb24fcf
Change-Id: I22820f66b6620fd29ee6ba76827b0eb87f905017
2020-05-06 11:54:54 +00:00
Yi-Ling Chuang
d5fd1dd2e3 Merge "Revert "Display "Android Auto" in Connected Devices summary text."" into rvc-dev am: 153b336baa am: 17deddb4d4 am: 4c1d3f20a3 am: 78f8150a5c
Change-Id: I401a2eb477ffb64695386e764876819e4ebaa3cb
2020-05-06 11:54:41 +00:00
Tim Peng
901e1503f5 PanelSlicesAdapterTest failure
-Update test cases

Bug: 11390111
Test: make -j50 RunSettingsRoboTests
Change-Id: I6efd6b619eb5bc20b654a73bf1963ea9f446516d
2020-05-06 11:32:57 +00:00
TreeHugger Robot
53c6c9a672 Merge "Stop usb tethering when user cancel it" into rvc-dev 2020-05-06 10:52:09 +00:00
Yi-Ling Chuang
153b336baa Merge "Revert "Display "Android Auto" in Connected Devices summary text."" into rvc-dev 2020-05-06 10:49:53 +00:00
Yi-Ling Chuang
8258eb0327 Revert "Display "Android Auto" in Connected Devices summary text."
This reverts commit 6fb790b092.

Reason for revert: This CL causes test failures. Per Settings convention, revert the CL first.

Bug: 155829041
Change-Id: I486e09b63c9999b56d4359a7ec211fe8a6c89181
2020-05-06 10:37:47 +00:00
hughchen
9546b7fdcb Stop usb tethering when user cancel it
- Call stop tethering to clear entitlement result when user do not want
  using USB tethering on USB menu.
- Add test case

Bug: 154933817
Test: make -j42 RunSettingsRoboTests
Change-Id: Idaaba8df2052f45e710c7959251817e8947a544f
2020-05-06 16:02:35 +08:00
tim peng
bb12a6425d Merge "Add 12dp padding above the first slice item" into rvc-dev am: 4ed5c3aac4 am: ffe907b29c am: 2b8ebacb02 am: 3cbbd6c8ca
Change-Id: Icf66012189bfbb395e0a8a0ccb3a6193bb1cef7f
2020-05-06 05:51:06 +00:00
tim peng
4ed5c3aac4 Merge "Add 12dp padding above the first slice item" into rvc-dev 2020-05-06 05:00:36 +00:00
Tim Peng
2ef5a87f36 Update "Play media to" to "Play <APP> on"
-Update in Volume panel and Sound settings
-Add test cases

Bug: 155345595
Test: make -j50 RunSettingsRoboTests
Change-Id: Id971038ddbf22924a747e4e1be3597face7ec6ed
2020-05-06 10:17:15 +08:00
TreeHugger Robot
ec983e7310 Merge "Remove duplicate result for dark mode" into rvc-dev am: 6e68e34f2a am: 28fa7d030e am: 26aa6f4b20 am: 51c4c9c19f
Change-Id: I1ccc2daa5a2155b1ba071ef6775b0579809b2f79
2020-05-06 01:52:23 +00:00
Tim Peng
2f47d771fb Add 12dp padding above the first slice item
-Add an extra padding in adapter for dedicated panels
-Add test cases

Bug: 154181365
Test: manual test
make -j50 RunSettingsRoboTests
"adb shell am start -a android.settings.panel.action.INTERNET_CONNECTIVITY"

Change-Id: I65bc26c23ca5a7f1b433c36ac7ddf1a658793719
2020-05-06 09:04:25 +08:00
TreeHugger Robot
6e68e34f2a Merge "Remove duplicate result for dark mode" into rvc-dev 2020-05-06 00:42:10 +00:00
Kevin Maurin
5e27487a53 Display "Android Auto" in Connected Devices summary text. am: 6fb790b092 am: 4d66ddb35d am: 3c8d70626c am: 6b609961e1
Change-Id: Ia7f07d8909f82886f260cd18dc1d8de20ddf4452
2020-05-05 23:39:21 +00:00
Kevin Maurin
6fb790b092 Display "Android Auto" in Connected Devices summary text.
Android Auto will be exposing a Settings tile under Connected Devices -> Connection Preferences.
If the Setting tile is available, then the summary text will reflect that.

Tested with additional unit tests and manually validated the scenarios by
flashing crosshatch-eng and disabling/enabling the relevant features.

Fix: 153896447
Test: Added unit coverage for new scenarios
Test: make RunSettingsRoboTests
Test: manually verified by flashing crosshatch-eng and disabling/enabling relevant components
Change-Id: I05e0bca1b4c05939114703f868b1c71b76410532
2020-05-05 14:05:05 -07:00
András Klöczl
190e86fb84 Merge "Improve multi user settings screen" into rvc-dev am: 509ae917a4 am: 2718b93da7 am: ae489cba4d am: 90c5c84a67
Change-Id: I3a517b7a5f8f950bbaec251825751dcd356814e3
2020-05-05 18:29:34 +00:00
András Klöczl
509ae917a4 Merge "Improve multi user settings screen" into rvc-dev 2020-05-05 17:27:42 +00:00
Tsung-Mao Fang
ae9dc54c56 Remove duplicate result for dark mode
We only keep the one in display settings.

Test: robo test and search dark mode in settings search.
Fix: 155735315
Change-Id: I71041f473944e854ef4601063658021bb9411069
2020-05-05 21:08:37 +08:00
Andras Kloczl
d19dc306dd Improve multi user settings screen
- Added switch and user delete functionality to details screen.
- Added robo tests.

Screenshots: http://shortn/_S6fbIMhAYO
Bug: 142798722
Test: Run robo tests with this command:
  make -j64 RunSettingsRoboTests ROBOTEST_FILTER="com.android.settings.users.*SettingsTest"
Change-Id: Id51c12c5470e30e2dffe93f3bd8c22380d8bdc1f
2020-05-05 13:45:01 +01:00
Jason Chiu
06b1205dfa Merge "Reload homepage cards when necessary" into rvc-dev am: 2e5da48c7f am: fcbcc763bf am: d7d22b4a74 am: dad90ed381
Change-Id: I608d8f86ffdfb5042c3740d1656b0b0257ec6c8f
2020-05-05 11:02:52 +00:00
TreeHugger Robot
31b90cb1c6 Merge "Enable some settings pages to use paralleled-loading method" into rvc-dev am: 18490b2dc8 am: 0f9bc18c74 am: acb2927e8c am: 696e693446
Change-Id: I6fab9ee6570b5762fce2bba790880f68dbec2f0f
2020-05-05 10:31:35 +00:00
Jason Chiu
2e5da48c7f Merge "Reload homepage cards when necessary" into rvc-dev 2020-05-05 10:04:09 +00:00
Jason Chiu
e0327ee583 Reload homepage cards when necessary
Many users leave Settings app by pressing Home key, but Settings remains
in the same card status and doesn't update when users come back, which
may lead to a bad UX.

This change reloads cards and resets the UI session for some events,
including home key, recent app key, and screen off.

Fixes: 151789260
Test: robotest
Change-Id: Idb575cef4a58894984cb42238d7b3b43c49389a3
2020-05-05 10:03:49 +00:00
TreeHugger Robot
18490b2dc8 Merge "Enable some settings pages to use paralleled-loading method" into rvc-dev 2020-05-05 09:23:13 +00:00
TreeHugger Robot
4ae38ad03e Merge "Fix broken test cases" into rvc-dev am: 15254e3b5e am: 13f57006fd am: 1bef15bae0 am: 089323e029
Change-Id: Ic1e0ca504a34d351e95bbf7e109619f8bc70797e
2020-05-04 11:59:34 +00:00