Commit Graph

47912 Commits

Author SHA1 Message Date
Emily Chuang
0757e49260 Add a controller and renderer for Slices.
Many contextual cards will be built as slices, so we need a controller
and a renderer for them.

Change-Id: I3816db09ba0181399810652fb18fbe11ce273267
Fixes: 115709730
Test: robotests
2018-09-20 09:50:54 +08:00
Leon Liao
6786e32a73 Rename isConnectable()
LocalBluetoothProfile.isConnectable() checks whether the user can initiate a connection
for a specific profile, not really whether the profile is connectable.

Change-Id: If6c6cd1554acf35db2460ea6ddb65148a7e86e45
Bug: 79982487
Test: atest tests/robotests/src/com/android/settings/bluetooth/BluetoothDetailsProfilesControllerTest.java
2018-09-20 09:23:30 +08:00
Naina Nalluri
6398841434 Developer option to enable CBRS
Add new developer option to enable
or disable CBRS Data

Bug: 113278158
Test: On device
Change-Id: I667a7c90b0bb7e9e0c70f41b28d376c9170e65d9
2018-09-19 17:58:30 -07:00
Lei Yu
aec9fb243d Merge "Fix incorrect API invoke for BT profiles" 2018-09-20 00:13:55 +00:00
TreeHugger Robot
a918e57e82 Merge "Add Settings Search Regression test" 2018-09-19 23:41:43 +00:00
Fan Zhang
d9e1871fde Don't persist device index job across reboot
Change-Id: I9bd25c7f266dded730918ec517e842c2b6ee9b1a
Fixes: 115930605
Test: manual
2018-09-19 16:08:56 -07:00
TreeHugger Robot
6a74a151fd Merge "Add checks before casting entry.extraInfo." 2018-09-19 21:45:44 +00:00
Philip P. Moltmann
1b987511c1 Do not show restricted icon by default
I made it visible by default by accident.

Test: Looked at  Settings > Security & locations > Screen pinning
Change-Id: I8ff6dc72e292ba76550edaeeac4d53ef4bd39505
Fixes: 116109852
2018-09-19 13:45:40 -07:00
TreeHugger Robot
7686eb4f85 Merge "Reset all notification settings on clear app prefs" 2018-09-19 19:51:56 +00:00
Julia Reynolds
ca34a28089 Make the volume slider height 48dp
Change-Id: Ia5852d61adc4bd582e7b0e75f61a05ae3a53ae04
Fixes: 114149194
Test: manual
2018-09-19 19:45:02 +00:00
Julia Reynolds
56966ce8f5 Add checks before casting entry.extraInfo.
Test: make, flash
Change-Id: I1a9d6a51b1f236e711fdb49d9c2f795e7023cfce
Fixes: 113309404
2018-09-19 15:43:08 -04:00
Julia Reynolds
d5ddae8fc4 Reset all notification settings on clear app prefs
Not just the app level 'are these notifications blocked?'
field.

Test: manual
Change-Id: Id77366d0d71e1f0d2507f1a30123d61aa11db252
Fixes: 65476259
2018-09-19 12:18:13 -04:00
Bill Yi
11bf617aa9 Merge "Import translations. DO NOT MERGE" 2018-09-19 15:34:10 +00:00
TreeHugger Robot
186213d70f Merge "Add policy transparency to disallow remove user." 2018-09-19 09:44:24 +00:00
Jonathan Scott
ba3b68686d Add policy transparency to disallow remove user.
On the Settings > System -> Multiple users screen, ensures that the"Delete from this device" menu is always available, but is disabled and includes policy information when DISABLE_REMOVE_USER is set.

Change-Id: Ia6c6cfb360f35a6e447bf9d85d2472ac11dde1ac
Fix: 113807450
Test: m ROBOTEST_FILTER=UserSettingsTest -j40 RunSettingsRoboTests; CTS Verifier Device Owner Tests/Policy transparency test/Disallow remove user.
2018-09-19 09:32:35 +01:00
Matthew Fritze
11fa37ebb4 Add Settings Search Regression test
Take a snapshot of the currently available search results, and
verify that search results aren't accidentally removed.

We use 4 items to identify a search result:
- Title
- Data Key
- Slice Uri

We use Title & Key to identify the search result, since they should not change.
The Slice Uri is used to make sure we don't regress on Slice Availability.

Test: runtest --path packages/apps/Settings/tests/unit/src/com/android/settings/search/SettingsSearchResultRegressionTest.java
Change-Id: I22498229bbcd1e90c9e0a026af9df4367a98190a
2018-09-18 16:42:22 -07:00
jackqdyulei
1bf730093c Fix incorrect API invoke for BT profiles
When hearing aid device has been set active, we shouldn't invoke
1. a2dpProfile.setActiveDevice()
2. hfpProfile.setActiveDevice()

Change-Id: Ie13dea041dd98d0cb9d913e1f28574b300095db9
Fixes: 113625278
Test: RunSettingsRoboTests
2018-09-18 15:19:32 -07:00
jackqdyulei
5b7fc8f3a5 Fix null pointer crash in BT renaming dialog
The dialog may become null after onDestroy has been invoked, so
we need to catch this case.

This CL also moves the listener outside to make it easy to test.

Change-Id: I4ce640c5bdaf1f201f9fecb14b3e5e38e10d4b79
Fixes: 115679393
Test: RunSettingsRoboTests
2018-09-18 14:41:37 -07:00
Bill Yi
e3f94f6926 Import translations. DO NOT MERGE
Change-Id: Ib3aeafee3272f1adf99daac0b15f8dff71867ec3
Auto-generated-cl: translation import
2018-09-18 13:36:56 -07:00
TreeHugger Robot
8347db2458 Merge "Move hasReadyMobileRadio() to DataUsageUtils." 2018-09-18 19:41:41 +00:00
TreeHugger Robot
6fa4dfedd1 Merge "Fix Homepage wrong color in dark theme" 2018-09-18 18:26:47 +00:00
Doris Ling
f7b8505948 Move hasReadyMobileRadio() to DataUsageUtils.
- move the method from DataUsageList to DataUsageUtils where other
utility methods are.

Bug: 111751694
Test: make RunSettingsRoboTests
Change-Id: If7176cb4278d568f890a0c94437c4483bbd472f9
2018-09-18 11:21:59 -07:00
Philip P. Moltmann
b009e89e4f Merge "Make Settings use system-api restricted icon." 2018-09-18 15:27:36 +00:00
Sandeep Gutta
fe6ddaec99 Fix error message shown when SIM PIN enable/disable fails
Current code fails to pass the 3GPP spec test case 27.14.3
'Disabling the PIN'.

An Incorrect toast error message is displayed, when enable/disable
SIM PIN operation fails without checking the error code.

Fix: Display appropriate toast error message based on the SIM PIN
enable/disable error code.

Bug: 73080305
Change-Id: I4219c68c7ebcf450a2f779b2d1f1ce881440753b
2018-09-18 12:21:51 +05:30
TreeHugger Robot
be04ed9e31 Merge "Import translations. DO NOT MERGE" 2018-09-18 02:58:01 +00:00
Mill Chen
cbe56e8b6e Merge "Add a rule to keep classes that implements CustomSliceable" 2018-09-18 00:53:31 +00:00
TreeHugger Robot
134e24d171 Merge "Fix inconsistent icon size in app list." 2018-09-18 00:42:16 +00:00
Doris Ling
ff33e9bc13 Merge "Use the new network stats loader to get usage data for all apps." 2018-09-17 23:55:03 +00:00
Bill Yi
dcc8230713 Import translations. DO NOT MERGE
Change-Id: Idacabf81cf4dae12f8a9f0174a13901088a3a5d1
Auto-generated-cl: translation import
2018-09-17 16:51:13 -07:00
Raff Tsai
0a39e43316 Fix Homepage wrong color in dark theme
Change-Id: Id22f8baff0b97c0e7081fb8c68241bc8d0d01a45
Fixes: 113964702
Fixes: 115789360
Test: manual
2018-09-18 07:14:57 +08:00
Fan Zhang
e5109ce28c Fix inconsistent icon size in app list.
Some app icons are really small. This is technically a bug in app, but
not handling it well makes settings UI look strange.

So in addition to setting a max size app icon can use, we just set that
as a only supported size (min == max == 36dp)

Change-Id: I4b3a1b83ab67be469ac74e7d4bb382ae855624d0
Fixes: 115788294
Test: visual
2018-09-17 16:06:23 -07:00
Philip P. Moltmann
a5918a6a68 Make Settings use system-api restricted icon.
Test: Browsed around settings
Bug: 110953302
Change-Id: I1b19be721719ed8946cb558b93119b1b0e173794
2018-09-17 15:48:31 -07:00
Bill Yi
ea18741986 [automerger skipped] Import translations. DO NOT MERGE am: 1a84e070b3 -s ours
am: 7c6679fac0  -s ours

Change-Id: Ib4dc327c3c76a7d59fbe9b892340d6b546a3ac2f
2018-09-17 15:25:52 -07:00
Lei Yu
16a0e416fd Merge "Revert "call getName() from CachedBluetoothDevice, not CachedBluetoothDeviceManager"" 2018-09-17 22:16:00 +00:00
Lei Yu
499013b05e Revert "call getName() from CachedBluetoothDevice, not CachedBluetoothDeviceManager"
This reverts commit 3029efc5f7.

Reason for revert:
To fix null pointer crash in Pairing dialog. Dialog maybe triggered by intent, in which LocalBluetoothManager couldn't have instance for BluetoothDevice and will return null. As a result, we need to depend on method in CachedBluetoothManager to handle it.

Bug: 115754654
Bug: 112735753
Change-Id: I1ebf1f1c2829cfb75e6c382df5acf785fe54a185
2018-09-17 22:15:14 +00:00
Doris Ling
27ee2f0865 Use the new network stats loader to get usage data for all apps.
- change to use the new NetworkStats.Bucket instead of
NetworkStats.Entry when iterating through the detail data.

Bug: 111751694
Test: make RunSettingsRoboTests
Change-Id: I305cc384320e4a72531d80dd9a00a3034ab12837
2018-09-17 15:02:06 -07:00
Bill Yi
7c6679fac0 [automerger skipped] Import translations. DO NOT MERGE
am: 1a84e070b3  -s ours

Change-Id: I7b757cb1cc4622b05a2b1b2e277f680eb7e19898
2018-09-17 14:51:52 -07:00
Bill Yi
1a84e070b3 Import translations. DO NOT MERGE
Auto-generated-cl: translation import

Bug: 64712476
Change-Id: I0c4b9cded799380c969e2acf1aac3c5a785dc81f
2018-09-17 12:35:35 -07:00
TreeHugger Robot
8dbbb01f19 Merge "Add DataUsageListV2 for showing network stats detail." 2018-09-17 19:20:16 +00:00
Doris Ling
6127d9de4c Add DataUsageListV2 for showing network stats detail.
Initial step: simply duplicate the existing DataUsageList class.

Bug: 111751694
Test: make RunSettingsRoboTests
Change-Id: I4d48405cd127cccb041ba0457638337f6918ce2e
2018-09-17 10:19:39 -07:00
Mill Chen
fb4992111b Add a rule to keep classes that implements CustomSliceable
Bug: 115862774
Test: visual, SliceViewer
Change-Id: Iff52a61423ef6822430a1f269a897b46d46f5253
2018-09-17 22:06:05 +08:00
Raff Tsai
8685c8562e Merge "Fix popup dialog show wrong device name" 2018-09-17 01:31:21 +00:00
Ben Lin
f66f042009 Merge "Follow up comments to 0cdc103e8287d3bd01944cdd2afb5c11897998fe." 2018-09-15 01:25:02 +00:00
TreeHugger Robot
6ca83b53a9 Merge "Fix bug in Add network fragment" 2018-09-15 00:45:17 +00:00
Ben Lin
30ed7c7c72 Follow up comments to 0cdc103e82.
Bug: 74763823
Test: Manually check; sending an Intent with package:// scheme works, if
originated from app of same cert.

Change-Id: I8206197c2147cc91ef72ad89f330320781428bb9
2018-09-14 16:27:24 -07:00
TreeHugger Robot
2508560eeb Merge "Fix a bug where custom cards are not refresh when removed" 2018-09-14 21:57:24 +00:00
Fan Zhang
45fc707474 Fix a bug where custom cards are not refresh when removed
When the last custom card for a specific type is removed,
onContextualCardUpdated should receive the cardtype info so we can
remove it from main data set.

- Reverted onContextualCardUpdated method signature back to before
- Force ConditionContextualCardController to send an empty list if
  everything is removed.

* Note: the update logic is pretty complicated to handle
  add/update/remove all together. In the future we should consider
  spliting the removal logic to simplify this area.

Change-Id: Ied688deb693ec33e0017be02cf5c743a754a6e61
Fixes: 115572494
Test: visual
2018-09-14 12:37:01 -07:00
jackqdyulei
0c6f8065c2 Fix bug in Add network fragment
After we switch secutiry from EAP to WPA, add button will become
disabled forever. Main reason is that we use view visibility to decide
which security type it is. In this case target view is visible while its
parent view is gone. So even though UI shows correctly however we still
think it is in EAP mode.

This CL check the mAccessPointSecurity directly instead of depending on
fragile view.

Fixes: 114689178
Test: RunSettingsRoboTests

Change-Id: I4284d25e6bf86ee7c5e7c0e17f0834c719d8d587
2018-09-14 11:10:31 -07:00
Raff Tsai
b20bfc949a Fix popup dialog show wrong device name
- Current EditText value will set to preference text if we click
OK in EditTextPreferenceDialogFragment. We will set preference
text to default when click cancel in DeviceNameWarningDialog.

Change-Id: Iab9561953b58276e98ee68d9196fa18e0dc3d78c
Fixes: 115693838
Test: make RunSettingsRoboTests
2018-09-14 23:53:30 +08:00
TreeHugger Robot
e5791f3c99 Merge "Prevent non-blockable app from being blocked" 2018-09-14 02:34:20 +00:00