Commit Graph

19938 Commits

Author SHA1 Message Date
Treehugger Robot
c8207de343 Merge "Add a developer option for controlling DNS over TLS" 2017-10-20 14:58:39 +00:00
Jack Yu
2f010230df Refactored area update info support
1. Refactored area update information support so it
   is not limited to channel 50 and Brazil.
2. Added channel 60 for India.

Test: Manual
bug: 37746109
Change-Id: I470cc470f880aadd4f63815e21cdd4a71436a89d
(cherry picked from commit c3cab8ecb8)
2017-10-19 17:36:33 -07:00
jeffreyhuang
f6d360ebb5 Update DeviceModelPreferenceController
- Added serial number to the dialog for about phone v2
 - prefixed model to the preference summary for about phone v2

Bug: 36458278
Test: make RunSettingsRoboTests -j40
Change-Id: Ic2950adcecf940ad8c9256688dc70b662ad5f0d6
2017-10-19 16:50:45 -07:00
Fan Zhang
1389a0c9c9 Catch exception when checking WifiDisplay availability
Change-Id: Ic2f17905babf43e92a825b8b5b4f8aac7d8ff001
Fixes: 68013053
Test: robotests
2017-10-19 16:49:21 -07:00
jackqdyulei
d3ffdc564c Switch the buttons in bt detail page
The forget button should be left and connect button be right.

Bug: 67915643
Test: RunSettingsRoboTests
Change-Id: I71bb99270c4a3d480346db1ded554ecc9b99e706
2017-10-19 16:48:28 -07:00
TreeHugger Robot
7544e115a7 Merge "Misc logging improvements" 2017-10-19 23:18:17 +00:00
jeffreyhuang
931681a633 Add existing controllers in about phone to v2 fork
- Added build number controller
 - Added safety info controller
 - Added regulatory info controller

Bug: 36458278
Test: make RunSettingsRoboTests -j40
Change-Id: Icddb9d352b4f739ca1c7cf562dec09530cb41dac
2017-10-19 15:08:43 -07:00
TreeHugger Robot
a431360dfe Merge "Fingerprint enrolling should update UI while in multi-window mode" 2017-10-19 21:47:21 +00:00
jeffreyhuang
d81622e790 Fork a new about phone layout
- Used a feature flag to hide the new about phone page

Bug: 36458278
Test: make RunSettingsRoboTests -j40
Change-Id: Ie7b6afa58b301128d1c60513ae4ee48d6ec6679b
2017-10-19 14:18:26 -07:00
tiansiming
6744588fd8 Merge "Fix wrong position of cursor in IccLockSettings" am: 3a3044eeef am: 92e77cbd43 am: ecf2bdb46f
am: cca755cfac

Change-Id: Ibe3700977ed96afe09e0b15ceecf125edeb6d23b
2017-10-19 19:29:11 +00:00
tiansiming
cca755cfac Merge "Fix wrong position of cursor in IccLockSettings" am: 3a3044eeef am: 92e77cbd43
am: ecf2bdb46f

Change-Id: I643bffc3f0eaf326b79dd7cebce2fff287396e1e
2017-10-19 19:24:53 +00:00
tiansiming
ecf2bdb46f Merge "Fix wrong position of cursor in IccLockSettings" am: 3a3044eeef
am: 92e77cbd43

Change-Id: Icfa12295c4111766f4c189443b9a6997a1cc0031
2017-10-19 19:22:16 +00:00
tiansiming
92e77cbd43 Merge "Fix wrong position of cursor in IccLockSettings"
am: 3a3044eeef

Change-Id: I26f1c35505538768a7816f038c44437fe9a08f67
2017-10-19 19:20:09 +00:00
Matthew Fritze
9c3c7d8ccd Fix crash from Settings Search
Security Settings was returning a search indexable
resource without an xml resource (in this case id = 0).

Settings search did not handle this exception and crashed.
This patch catches the exception, and adds a TODO to fix
the indexing in security settings.

Change-Id: Ic7f05c98d99cc45fbebbdc672c7e346c27daa0f0
Fixes: 67967367
Test: robotests
2017-10-19 10:58:05 -07:00
tiansiming
64f48b5ce6 Fix wrong position of cursor in IccLockSettings
Position of cursor goes to the front when submit
an error pin.

Bug:https://issuetracker.google.com/issues/67839176
Test:
1) Insert a sim card
2) Go to Settings -> Security -> Set up SIM card lock
3) press Lock SIM card checkbox
4) enter 123 and press OK button

Change-Id: I90655f3fa4cb3e4bda251cd0fc62e66300a4b66f
Signed-off-by: tiansiming <tiansiming@xiaomi.com>
2017-10-20 01:26:40 +08:00
TreeHugger Robot
ccee4218ea Merge "Cleanup Controllers/Fragments" 2017-10-18 23:35:13 +00:00
TreeHugger Robot
2dda5a567d Merge "Convert more loadIcon() to IconDrawableFactory" 2017-10-18 23:27:38 +00:00
Maurice Lam
ac8024ef44 Update confirm button label
Test: Existing tests pass
Bug: 65123475
Change-Id: Ib730507db54fe2bab881fa040ead737c6736ee1a
2017-10-18 16:16:35 -07:00
TreeHugger Robot
5604f9bb4f Merge "Use correct flags on ACTION_TIME_CHANGED broadcast" 2017-10-18 23:10:12 +00:00
Malcolm Chen
d089db8d6e Revert "Delete unused classes"
This reverts commit 2fa45c92e6.
It bring back SlidingTabLayout.java which will be used for
multi-SIM configurations.

Bug: 65648147
Test: unittest
Change-Id: I84c75a2e1d33fc89f58165c662d82a8ad3d6ef20
2017-10-18 16:08:41 -07:00
Fan Zhang
5c4780f799 Misc logging improvements
- Log ACTION_SEARCH_RESULTS whenever a search query is performed.
  eg, type "qu" will result 2 such logging events.
- Remove historam logging to search result click count (already logged
  as ACTION_CLICK_SETTINGS_SEARCH_RESULT)

Change-Id: Ia207b34702e0f24a7885e47d093f6cce1314ebc4
Fixes: 67743512
Fixes: 64939544
Test: robotests
2017-10-18 15:44:38 -07:00
jeffreyhuang
bb451a38e4 Cleanup Controllers/Fragments
- Removed extra comments in DevelopmentSettingsDashboardFragment
 - Removed unused methods from controllers
 - Clean up method names

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Ibe7a0921926d4529f62a212b55c8fa2f14ecb18b
2017-10-18 15:03:41 -07:00
Fan Zhang
abdeead114 Convert more loadIcon() to IconDrawableFactory
- AppGridView: used by preview chart in display size setting.
- DefaultBrowserPreferenceController: default browser icon in default
  apps settings
- Enterprise application list
- Accessibility search result loader

Change-Id: Ibd12cd8854c68760ea3428fffa735bcbba48a277
Fixes: 64336923
Test: robotests
2017-10-18 15:03:19 -07:00
Kweku Adams
19f896e073 Adding new methods to FakeUid.
Test: built and flashed to device
Bug: 65750808
Change-Id: Iddc198ce5b971105a44d15b8490138c18fc0f065
2017-10-18 13:56:04 -07:00
TreeHugger Robot
25deda5129 Merge "Fix a monkey crash: guard against position -1." 2017-10-18 20:27:45 +00:00
Fan Zhang
5d80fd2966 Fix a monkey crash: guard against position -1.
When handling onClick in ManageApplications, skip getAppEntry if
position is -1.

Change-Id: I565c42b2c9f742445e49fd4c2e7db539d0f6f8ad
Fixes: 67940121
Test: manual
2017-10-18 11:47:01 -07:00
TreeHugger Robot
5317e70be1 Merge "Use IconDrawableFactory to load icons for default apps." 2017-10-18 17:47:33 +00:00
TreeHugger Robot
63f32fcbf1 Merge "Fix a bug: applied wrong layout for advanecd button flag" 2017-10-18 17:30:47 +00:00
TreeHugger Robot
b73a67c7a0 Merge "Switch to recyclerview in ManageApplications" 2017-10-18 02:20:06 +00:00
Fan Zhang
78369d91bc Switch to recyclerview in ManageApplications
- Replace ListView with RecyclerView in layout
- Replace ApplicationAdapter's superclass to be RecyclerView.Adapter
- Change adapter interfaces (where necessary) to work with RecyclerView
- Replace fast scroll with Recycler's mechanism (all in xml)
- Removed section indexer (text bubble when fast scroll) because
  recyclerview doesn't support it.

Bug: 64804294
Test: robotests
Change-Id: I55b221836ce6abdeddf4568c8a8a5632cbddbd3b
2017-10-17 17:41:44 -07:00
Fan Zhang
efa763624a Use IconDrawableFactory to load icons for default apps.
Bug: 64336923
Test: robotests
Change-Id: I2a4ca05a866784f97e247bad1c1679a6ec0f5efa
2017-10-17 15:56:16 -07:00
Jeffrey Huang
d50363b496 Merge "Hide dev options v1 under feature flag" 2017-10-17 22:30:58 +00:00
Christopher Tate
020ff8a390 Use correct flags on ACTION_TIME_CHANGED broadcast
When Settings changes the display format for 12/24 hour time, it fakes
an ACTION_TIME_CHANGED broadcast to provoke apps to update their display.
It needs to use the right flags on that broadcast to match the way the
OS sends it when the time actually changes.

Bug: 67881917
Test: calendar widget, Deskclock, QCT timeservice
Change-Id: I46ce261c36d9c7180f6b8eae806ef9fbf271fa53
2017-10-17 14:49:15 -07:00
Fan Zhang
aee173142f Fix a bug: applied wrong layout for advanecd button flag
Change-Id: I5a44bb5e910bc73e46087820e5ccf76e220fa834
Fixes: 3076430
Test: robotests
2017-10-17 14:49:04 -07:00
TreeHugger Robot
db60997f2a Merge changes I145c2e25,I4abe87dd,I86575d17,I90a0e583
* changes:
  Introduce BluetoothAudioQualityPreferenceCtrl
  Introduce BluetoothAudioChannelModePreferenceCtrl
  Introduce BluetoothAudioBitsPerSamplePrefCtrl
  Introduce BluetoothAudioCodecPreferenceController
2017-10-17 21:31:27 +00:00
jeffreyhuang
142682c19c Hide dev options v1 under feature flag
- Cutover to DevelopmentSettingsDashboardFragment
 - Add dev_option_v1 feature flag

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I2ff7b5c55f1f27cd24b4e276d3d81a73f67dcf88
2017-10-17 13:49:19 -07:00
TreeHugger Robot
47775667b8 Merge "Add work-only-category controller" 2017-10-17 19:10:29 +00:00
jeffreyhuang
af3ec754dd Introduce BluetoothAudioQualityPreferenceCtrl
- Create new BluetoothAudioQualityPreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I145c2e2554f5e9f5e7cfa79b3f6198a8b81105ec
2017-10-17 11:18:06 -07:00
jeffreyhuang
2335b1fef4 Introduce BluetoothAudioChannelModePreferenceCtrl
- Create new BluetoothAudioChannelModePreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I4abe87dd70be83c8b3cf2a3ad43b8856a01eadbb
2017-10-17 11:18:06 -07:00
jeffreyhuang
483dc97998 Introduce BluetoothAudioBitsPerSamplePrefCtrl
- Create new BluetoothAudioBitsPerSamplePreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I86575d171a005f62f731d9001f08ddcf976ad826
2017-10-17 11:18:06 -07:00
jeffreyhuang
0ef326f365 Introduce BluetoothAudioCodecPreferenceController
- Create new BluetoothAudioCodecPreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I90a0e58328196315fccbecd6d46531b4f0fcaef1
2017-10-17 11:18:06 -07:00
Pavel Grafov
24ff765731 Preserve old password when handling SET_NEW_PASSWORD. am: 40e187b364
am: 51f15da8e6

Change-Id: I9b46697d14579ab8aedfffcdfd14ddc02cad5cf0
2017-10-17 17:35:30 +00:00
Fan Zhang
1bde0d84b0 Add work-only-category controller
The controller will hide category if there is no child in it.

Change-Id: I9bbcc4115b991574e608933f98857b0b4eb2ed7d
Fixes: 62185871
Test: robotests
2017-10-17 10:34:36 -07:00
Pavel Grafov
51f15da8e6 Preserve old password when handling SET_NEW_PASSWORD.
am: 40e187b364

Change-Id: I45a464c244b6de3a4ea491d28db620425733b5a8
2017-10-17 17:33:23 +00:00
Jeffrey Huang
9b117ef690 Merge "Lazy load SettingsObserver" 2017-10-17 17:22:31 +00:00
Pavel Grafov
40e187b364 Preserve old password when handling SET_NEW_PASSWORD.
Currently the only way mUserPassword can be set is when it comes
from onActivityResult. This way when the user chooses "Continue
without Pixel Imprint", and we switch ChooseLockGeneric->InternalActivity,
mUserPassword becomes null (it is not preserved in intent extras).
And then this null is used in getLockPasswordIntent which causes the issue.

Another issues is that when the user chooses to use fingerprint,
mHasChallenge is set to true and password is not forwarded to
ChooseLock(Password|Pattern). I changed the intent builders so that both
old password and challenge can be sent at the same time, so the password
is not lost when fingerprint is set.

Bug: 67672081
Test: cd packages/apps/Settings/tests/robotests/ && mma
Test: manual, adb shell am start -a android.app.action.SET_NEW_PASSWORD,
      tried setting pin/password with and without fingerprint.
Test: manual, tried to change lock via Settings -> Security&Location
Test: manual, set pin + fingerprint in Setup Wizard, FBE and FDE devices
Test: manual, set pin + added account, used pin to unlock FRP in SUW
Change-Id: I38d56d84f95c63fef24c2aa1a031d629f22756a1
2017-10-17 13:19:35 +01:00
TreeHugger Robot
ffa3095aca Merge "Add advanced button to security & location page" 2017-10-17 02:09:45 +00:00
TreeHugger Robot
84f1e3003a Merge "Reorder default app summary to match subpage ordering" 2017-10-17 01:15:45 +00:00
Fan Zhang
069830012f Add advanced button to security & location page
Change-Id: I45977105d6ddabef8f2d9bdc7b46959af9cbbf0f
Fixes: 36657221
Test: visual
2017-10-16 17:39:27 -07:00
jeffreyhuang
17edf20fa5 Lazy load SettingsObserver
- Lazy load the SettingsObserver in StayAwakePreferenceController
 so that search indexing works properly

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I1e2afb106ce293f616143da3f37fbde3829f414f
2017-10-16 16:56:26 -07:00