Commit Graph

350 Commits

Author SHA1 Message Date
Yasin Kilicdere
4564bce03c Singularization of duplicated multi user strings.
Many multi-user strings were duplicated between SettingsLib, Settings,
System UI and Car projects. This CL removes those duplicates.

List of singularized strings: "Guest", "Remove guest", "Add user",
"Remove guest?", "Too many incorrect attempts...."

Bug: 191386817
Test: NA
Change-Id: I8d9629a1a9628cab9f049df84f706bd04ee75cc2
2022-03-23 19:20:34 +00:00
Eric Biggers
98ac6a6c01 Merge "Remove EXTRA_KEY_TYPE intent data" am: d106ae0f82 am: 465363a312 am: b79a82260c
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2031423

Change-Id: I46e1ca934dff648e8730d445046fa3150913891b
2022-03-22 18:04:27 +00:00
Eric Biggers
b79a82260c Merge "Remove EXTRA_KEY_TYPE intent data" am: d106ae0f82 am: 465363a312
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2031423

Change-Id: Ieb1bf012ee0f735dcfc4d579eee9fc587bfbdbe1
2022-03-22 17:47:03 +00:00
Eric Biggers
1cc85062cf Remove EXTRA_KEY_TYPE intent data
This intent data was only used by CryptKeeperSettings, which has been
removed.  This is also one of the only remaining users of the
StorageManager.CRYPT_TYPE_* constants which were only ever intended to
be used with vold's Full Disk Encryption APIs, which have been removed.

Bug: 208476087
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.password
      (No regressions seen; 2 tests fail both before and after.)
Change-Id: Id6e2c0f5ecc79f7372b29393e66ffbd66d52d7a2
2022-03-21 05:09:48 +00:00
kholoud mohamed
de78149c16 RESTRICT AUTOMERGE Refactor device policy resource APIs to a separate class
Bug: 217388602
Bug: 218875965
Test: atest EnterpriseResourcesTests
Test: manual
Change-Id: I4775d7741c7819fd811c3fc4eda1636b1e04b398
2022-03-17 17:37:45 +00:00
Eric Biggers
c300a01bf4 Remove FDE support from accessibility settings
With FDE (Full Disk Encryption), secure start-up (i.e. requiring a PIN /
pattern / password to boot the device) was incompatible with
accessibility services.  Thus, the accessibility settings would ask the
user to disable secure start-up when enabling an accessibility service.

Now that FDE support has been removed in favor of FBE (File Based
Encryption), this is no longer necessary.  Remove it.

Bug: 208476087
Change-Id: I5f6e512f223df63e1b4d1c181fc8b3fe683dcd5f
(cherry picked from commit b4060ef65b)
Merged-In: I5f6e512f223df63e1b4d1c181fc8b3fe683dcd5f
2022-03-08 17:13:22 +00:00
Eric Biggers
1d48df59e5 Remove FDE support from accessibility settings
With FDE (Full Disk Encryption), secure start-up (i.e. requiring a PIN /
pattern / password to boot the device) was incompatible with
accessibility services.  Thus, the accessibility settings would ask the
user to disable secure start-up when enabling an accessibility service.

Now that FDE support has been removed in favor of FBE (File Based
Encryption), this is no longer necessary.  Remove it.

Bug: 208476087
Change-Id: I5f6e512f223df63e1b4d1c181fc8b3fe683dcd5f
(cherry picked from commit b4060ef65b)
Merged-In: I5f6e512f223df63e1b4d1c181fc8b3fe683dcd5f
2022-03-07 22:18:48 +00:00
Presubmit Automerger Backend
e39120e45c [automerge] Use android.app.AlertDialog in SetupChooseLockGeneric 2p: cd517a654a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17052922

Bug: 216442969
Change-Id: I8b98a48ad8d34b965f0d3dadb06247fdb84572bf
2022-03-03 23:37:07 +00:00
Edgar Wang
cd517a654a Use android.app.AlertDialog in SetupChooseLockGeneric
androidx.appcompat.app.AlertDialog will cause postiveButton and negativeButton become too close when the texts are longer.

Bug: 216442969
Change-Id: I39e84c1007c817399902034e853b2aeee1343adc
Test: visual verify
2022-03-03 23:36:55 +00:00
Edgar Wang
ca258ccd33 Use android.app.AlertDialog in SetupChooseLockGeneric
androidx.appcompat.app.AlertDialog will cause postiveButton and negativeButton become too close when the texts are longer.

Bug: 216442969
Change-Id: I39e84c1007c817399902034e853b2aeee1343adc
Test: visual verify
2022-03-02 13:35:03 +00:00
Marie Matheson
9f7374b045 On Settings lockscreen changes send new safety status to Safety Center.
Bug: 215518847
Test: atest SettingsUnitTests
Test: make RunSettingsRoboTests
Change-Id: Id8e957e58c45195260157b2b61b93ecbc203164b
2022-02-28 16:36:46 +00:00
Jonathan Scott
269f97d960 Allow overriding of strings referenced in XML files.
Test: manual
Bug: 188414370
Change-Id: Ice45b1808530c14c4efff16795cac7b2cb81516e
2022-02-07 21:00:05 +00:00
Jonathan Scott
e0d439472f Allow Device Management Role Holder to update Settings strings.
Test: manual
Bug: 188414370
Change-Id: I6e1a06619799a9e99382d791e72e2e4518f93cac
2022-01-25 19:03:24 +00:00
Lais Andrade
c50f9d5528 Remove setTactileFeedbackEnabled from LockPatternView
This property was copying the HAPTIC_FEEDBACK_ENABLED deprecated user
setting. Starting from Android T this setting will be applied by the
Vibrator service for vibration with USAGE_TOUCH.

Bug: 185351540
Test: manual
Change-Id: Ifeee5a56b80a04bcf605defe9a310374dce68146
2022-01-14 23:49:07 +00:00
Eric Biggers
b4060ef65b Remove FDE support from accessibility settings
With FDE (Full Disk Encryption), secure start-up (i.e. requiring a PIN /
pattern / password to boot the device) was incompatible with
accessibility services.  Thus, the accessibility settings would ask the
user to disable secure start-up when enabling an accessibility service.

Now that FDE support has been removed in favor of FBE (File Based
Encryption), this is no longer necessary.  Remove it.

Bug: 208476087
Change-Id: I5f6e512f223df63e1b4d1c181fc8b3fe683dcd5f
2022-01-11 18:53:51 -08:00
TreeHugger Robot
10593796f0 Merge "Remove subtext from work challenge screens" 2021-12-09 22:51:33 +00:00
Rubin Xu
70172863a7 Remove subtext from work challenge screens
Bug: 201045654
Test: manual
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.password
Change-Id: Ibd65e27d5ed2762d04aa7750908506d0353a0727
2021-12-09 13:27:03 +00:00
Joe Bolinger
ad86e310c9 Merge "Update biometrics OWNERS." am: fe99de597e am: 7c939b9e4f am: 687bccdd6f am: ecb88bace4
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1901117

Change-Id: I4161bb84f1528ec10df95cbfe4eebb760d2b7ea0
2021-12-08 23:56:04 +00:00
Joe Bolinger
ecb88bace4 Merge "Update biometrics OWNERS." am: fe99de597e am: 7c939b9e4f am: 687bccdd6f
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1901117

Change-Id: I871c18cedf70a2cd608b1401fee7f1a139a675f0
2021-12-08 23:30:58 +00:00
Joe Bolinger
7c939b9e4f Merge "Update biometrics OWNERS." am: fe99de597e
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1901117

Change-Id: I8cd2a34eed6b830896d1370b877dbfdac15221a8
2021-12-08 18:37:58 +00:00
Pavel Grafov
e8d755061d Merge "Check user validity before retrying authentication" 2021-11-30 14:48:00 +00:00
Pavel Grafov
3a48226af1 Merge "Launch ForgotPasswordActivity in a new task." 2021-11-30 14:47:22 +00:00
Joe Bolinger
bf6a68f779 Merge "Prevent scrolling when interacting with confirm pattern prompt." into sc-v2-dev am: 710622d818 am: 89ac835d2e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16332073

Change-Id: Id9b8c3b32b8fac490da0708906304fb5ee49c904
2021-11-24 18:22:06 +00:00
Joe Bolinger
89ac835d2e Merge "Prevent scrolling when interacting with confirm pattern prompt." into sc-v2-dev am: 710622d818
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16332073

Change-Id: I2390634fede31fa796d4130f22e8cc3bd0da5ff9
2021-11-24 18:03:22 +00:00
Pavel Grafov
a8c12b4298 Check user validity before retrying authentication
When managed profile gets wiped Settings may crash with SecurityException
when trying to retry authentication for no longer valid user.

Test: manually with TestDPC
Bug: 201513984
Change-Id: Ib7309abf89be76fcc1bf756c37c09d6b60c6b95c
2021-11-24 16:24:38 +00:00
Joe Bolinger
78e700fd31 Update biometrics OWNERS.
Test: N/A
Change-Id: Ia9e71da5fd13b46c3a897b8aabaca0865b3fb87c
2021-11-23 15:36:53 -08:00
Joe Bolinger
ebbb5c277e Prevent scrolling when interacting with confirm pattern prompt.
This uses the same fix as related commit e55568a7ba

Fix: 207325277
Test: manual (set pattern via settings in dual pane mode)
Change-Id: Ic56829df23442df45d47d60ea5b8319e4ab58931
2021-11-23 21:37:46 +00:00
Makoto Onuki
694d374a9c Merge "Use different exceptions for different crash reasons" into sc-v2-dev am: fcb067b577 am: 0fefda6870
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16276438

Change-Id: I81b0c86610090a295801fb13295b15b94a501ba6
2021-11-17 18:11:17 +00:00
Makoto Onuki
0fefda6870 Merge "Use different exceptions for different crash reasons" into sc-v2-dev am: fcb067b577
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16276438

Change-Id: I8629b6ad36ffc18364a09f859497fecd93368b98
2021-11-17 18:05:05 +00:00
Makoto Onuki
baacfd7985 Use different exceptions for different crash reasons
Always throwing RemoteServiceException would make it impossible to
tell the cause of a crash without the string message.

Let's use a different exception type so developers can cluster crashes
without the exception message.

Bug: 124137635
Test: Treehugger
Change-Id: Ibae57bdb1b8965241c41249a89c728d224e4e995
2021-11-16 11:59:05 -08:00
Pavel Grafov
dcd6fc593d Launch ForgotPasswordActivity in a new task.
This way the notificaiton about locked profile can function as
expected. Prior to this change ForgotPasswordActivity was launched
in the same task as initial profile credential confirmation. As a
result, when ForgotPasswordActivity was in the foreground, the
notification tap won't do anything since a task for
CONFIRM_DEVICE_CREDENTIAL_WITH_USER was already in the
foreground.

Bug: 157554361
Test: manual, with TestDPC
Change-Id: Ifc9d8e1fb8658c3f22926d7fa35da1e60eadb3db
2021-11-11 11:53:09 +00:00
Joe Bolinger
c0906cfee7 Merge "Set a min height for pattern setup." into sc-v2-dev am: 774c2181ea am: ba9f4f66a8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16194774

Change-Id: Ib94e00609e0b29d7e9480152883870fabb58e327
2021-11-05 03:13:50 +00:00
Joe Bolinger
ba9f4f66a8 Merge "Set a min height for pattern setup." into sc-v2-dev am: 774c2181ea
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16194774

Change-Id: I18756d98be500c0337278161909766ad157aec81
2021-11-05 03:01:18 +00:00
Joe Bolinger
e55568a7ba Set a min height for pattern setup.
Fix: 194022156
Test: manual (set pattern in SUW with largest font/display size)
Change-Id: I82a0bb5aec122e9d65e4b17ea45166091deea02a
2021-11-05 00:24:36 +00:00
Pavel Grafov
b01b2ba4d0 Merge "Respect PASSWORD_QUALITY_MANAGED for biometrics" into sc-qpr1-dev am: 1ecc3166f0 am: fc67167c93 am: 0e72224c38
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15778274

Change-Id: I44c3cbd651e59cc195a25f5ce06c4ea5b4fa441e
2021-09-13 14:33:14 +00:00
Pavel Grafov
0e72224c38 Merge "Respect PASSWORD_QUALITY_MANAGED for biometrics" into sc-qpr1-dev am: 1ecc3166f0 am: fc67167c93
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15778274

Change-Id: Ic295385f6cb70c2caecff6679336dd757cde513b
2021-09-13 14:18:44 +00:00
Pavel Grafov
6b3e240d20 Merge "Respect PASSWORD_QUALITY_MANAGED for biometrics" into sc-qpr1-dev am: 1ecc3166f0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15778274

Change-Id: Iaee401d8cc88e9c5a48d5fee445ae44980eacdd1
2021-09-13 14:09:29 +00:00
Pavel Grafov
36120b8a4c Respect PASSWORD_QUALITY_MANAGED for biometrics
Bug: 195488124
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=\
    com.android.settings.password.ChooseLockGenericControllerTest
Test: manual with a modified TestDPC
Change-Id: Ifa15877c735bb0f396051af04a4e012a606bf9e1
2021-09-13 11:50:06 +01:00
Xin Li
7d646a5182 Merge "Merge sc-dev-plus-aosp-without-vendor@7634622" into stage-aosp-master 2021-08-17 18:14:14 +00:00
Treehugger Robot
4056b335ce Merge "Update OWNERS." am: 0544dc7b92 am: b294717b4c am: 78ed3bb6ee am: 5f69669adb am: bba477b3ed
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1797467

Change-Id: Id2ad6188daec7edc8eadd67aaa8d7e9a52ff8208
2021-08-17 05:01:37 +00:00
Treehugger Robot
78ed3bb6ee Merge "Update OWNERS." am: 0544dc7b92 am: b294717b4c
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1797467

Change-Id: I3d44a009fc1fb653a074c0b5075b673dcbee82d8
2021-08-17 04:28:48 +00:00
Curtis Belmonte
a0847b6130 Merge changes from topic "presubmit-am-50cf8052ea594bbfb9d45e820e7b72cd" into sc-mainline-prod am: 562d29d081
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15585467

Change-Id: Ia95f2c062c6dcdbd40ed5f51bcb7c4fa96dc3f88
2021-08-17 01:01:21 +00:00
Curtis Belmonte
7fb2316a21 Merge "Remove/replace old fingerprint icon in SUW/Settings" into sc-dev 2021-08-17 00:47:58 +00:00
Joe Bolinger
6e1ecbd617 Update OWNERS.
Test: N/A
Change-Id: I6646a2b7dda95f458b95c0fed331b1cb213fcae8
2021-08-16 17:12:53 -07:00
Curtis Belmonte
5cf728d2fc [automerge] Remove/replace old fingerprint icon in SUW/Settings 2p: dc9b53c446
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15585467

Change-Id: Ib847b70e4bc427d4f3c3b78f67a68b63b71d74c8
2021-08-16 21:44:39 +00:00
Curtis Belmonte
dbef2415d3 [automerge] Remove/replace old fingerprint icon in SUW/Settings 2p: dc9b53c446
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15585467

Change-Id: Ief92774377376ea11b4e099f7c0cf5764cbf7f31
2021-08-16 21:44:39 +00:00
Curtis Belmonte
dc9b53c446 Remove/replace old fingerprint icon in SUW/Settings
Replaces instances of the old fingerprint icon shown during Setup Wizard
or in Settings with either an updated version or an entirely different
icon.

Test: Manual

Fixes: 196600265
Change-Id: If78e8f0dbdb033f557614a019d4c9dde4493b6c6
2021-08-16 14:44:15 -07:00
Ayush Sharma
8851afb8ff Merge "Remove refs of isSeparateProfileChallengeAllowed" 2021-08-13 15:49:11 +00:00
Beverly
c9a609eb6d Use pattern subtitle string on all enroll stages
So the views won't relayout and cause the pattern
to render in a strange way.

Test: manual
Bug: 194368020
Change-Id: If6fd7ade4fd6783fe5d1ef78acc847928e01bd29
2021-08-05 17:17:30 +00:00
“Ayush
41873bd7a4 Remove refs of isSeparateProfileChallengeAllowed
Remove this API usage as this API is being removed from DPMS.

Bug: 189502721
Test: N/A
Change-Id: I395a48cd78c8fb93bfd54c94794de5a680ba6f5d
2021-08-03 21:21:16 +00:00