In the original design, we only set title description for
view holder, this is wrong. It causes talkback can't
speak subtext info.
Currently, we set the title content description in the title
view directly, so talkback can say the title and subtext now
when talkback focus on an app view.
Test: Talkback speaks full information for an app entry
Fix: 177873163
Change-Id: I94996d596a85cc2813ed1b10cdd4ed2bee62f4a9
In this cl, we migrate origin files/method from framework into settings app.
So, we can control layout and drawble without impacting other app.
And we only remove to set a tint color in app_permission_item.xml.
Currently, it won't tint color for dot now.
Test: See the screen and dot's color is correct.
Fix: 188188444
Change-Id: I18054b47ba07e7864e7c238f2bec5fbe1d3feeea
- Make the transition logic simpler in SettingsBaseActivity.
- Remove the redundant transition code in SettingsActivity.
Bug: 177479937
Test: rebuild and click on pages.
Change-Id: I65cae59d4eae99e3b9c324c9b6ce89f2349aaf8b
Set not searchable for top intro of credential page
Test: No top intro result in settings app.
Fix: 188491690
Change-Id: Ia7c4b33f72e3ea962073a552a7f57fa2072a2aa6
The content of Activate device admin app is overlapping with the title
while scrolling up. That is because the collapsing toolbar needs to
work with the view that supports nested scrolling feature, and this page
hasn't updated the layout to use NestedScrollView. So that caused the
overlapping problem.
Fix: 188184864
Test: visual verified
1) Navigate to Settings > Security > Device admin apps > pick up one to
activate
2) Scrolling the content and see if the content is overlapping with the
title
Change-Id: Ide5ff9ed40202c3b217934db93c82a4861983416
Remove android:textColorHint from Theme.Settings to fix the regression.
This is a quick fix, each EditText should set its hintTextColor
attribute before there is a fix to apply the attribute globally in
Settings APP.
Bug: 188405076
Test: manually launch 'Font size' and 'Display size'.
Change-Id: If3313be47e0c3e8ce9d41a6e87cdf2e7067ce54b
- Show restricted text in guest mode
- Screenshot:
https://screenshot.googleplex.com/6nYcmazMM46TxaB
Bug: 177573895
Test: manual test
make RunSettingsRoboTests \
ROBOTEST_FILTER=WifiNetworkDetailsFragmentTest
Change-Id: I5f857b2079e0f550e4be601d27dd54dac56b2f57
(cherry picked from commit d4cec9b628)
Bluetooth app will indicate BluetoothOppReceiver to receive
device picker intent. But for fix the security issue we
removed the setClassName() method in ag/14111132 to avoid attack.
It causes BluetoothOppReceiver cannot receive the intent.
This CL will compare to calling package name with launch package name.
If they are not equal, the setClassName() will not invoke.
Bug: 186490534
Bug: 179386960
Bug: 179386068
Test: make RunSettingsRoboTests -j56
Change-Id: Ia51528f2a44ab73edbc86899ca0846d3262fe1f0
(cherry picked from commit bb5be240c0)
(cherry picked from commit c556938807)
BluetoothPermissionActivity and DevicePickerFragment will send
broadcast to return the result to calling apps. As this broadcast
intent is from Settings with uid 1000, it will be sent to any
protected BroadcastReceivers in the device. It can make an attacker
send broadcast to protected BroadcastReceivers like factory reset intent
(android/com.android.server.MasterClearReceiver) via
BluetoothPermissionActivity or DevicePickerFragment.
This CL will not allow to set package name and class name to avoid
the attacker.
Bug: 179386960
Bug: 179386068
Test: make -j42 RunSettingsRoboTests and use test apk to manually test
to verify factory reset not started and no system UI notification.
Change-Id: Id27a78091ab578077853b8fbb97a4422cff0a158
(cherry picked from commit 8adedc6249)
(cherry picked from commit e21d06f6ee)
The root issue is that CharSequence is an interface.
String implements that interface, however, Spanned class
too which is a rich text format that can store HTML code.
The solution is enforce to use String type which won't include
any HTML function.
Test: Rebuilt apk and see the string without HTML style.
Bug: 179042963
Change-Id: I53b460b12da918e022d2f2934f114d205dbaadb0
Merged-In: I53b460b12da918e022d2f2934f114d205dbaadb0
(cherry picked from commit 0bf3c98b2f)
(cherry picked from commit 52f9039d5c)
In Screen Timeout Settings, preferences should not be initialized in
onAttach() because the setting style hasn't been loaded yet. This change
defers the initialiaztion of those preferences so that they appear
correctly.
Test: manually tested.
Test: make RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.display
Bug: 183909540
Change-Id: I86cfe196549d709ed763faa004fff7b631365b1e
- Display "Tap a network to connect" on sub-title when Wi-Fi networks is
not empty
- Screenshot:
https://screenshot.googleplex.com/5TzpJDLghpCQnDP
Bug: 188594439
Test: manual test
atest -c InternetConnectivityPanelTest
Change-Id: I0e3f0eb269fb4fe040a62be9ee84105879af82f7
