Commit Graph

28864 Commits

Author SHA1 Message Date
Bonian Chen
5e65da0c2f [Settings] Apply proxy design to data usage
Enable proxy to subscription manager in data usage UI.

Bug: 141833767
Test: manual
make RunSettingsRoboTests -j ROBOTEST_FILTER=BillingCyclePreferenceTest
make RunSettingsRoboTests -j ROBOTEST_FILTER=CellDataPreferenceTest
make RunSettingsRoboTests -j ROBOTEST_FILTER=DataUsageListTest
make RunSettingsRoboTests -j ROBOTEST_FILTER=DataUsageSummaryTest
make RunSettingsRoboTests -j ROBOTEST_FILTER=DataUsageUtilsTest
make RunSettingsRoboTests -j ROBOTEST_FILTER=MobileDataEnabledListenerTest

Change-Id: Id119738dc16ece8767c088b9a0794997e4b0334f
2019-11-11 13:03:03 +08:00
David Su
d4f077f1e2 Settings: Clean up WifiManager APIs
Promoting WifiManager#registerSoftApCallback() and
WifiManager#registerNetworkRequestMatchCallback()
to @SystemApi.

Changed method signatures to conform to API guidelines.

Also removed dead code: WifiManager#getWifiState()
never returns WifiManager#ERROR.
Remove reference to it, since it is an @hide API.

Bug: 143970861
Test: compiles
Change-Id: If4294d106f0acb5c67b5eab1f6f99bc52efc10f2
2019-11-09 14:54:15 -08:00
Bernardo Rufino
897a0e0470 Ignore "package:<package>" in MANAGE_OVERLAY_PERMISSION intent
Before this change, intents with action = MANAGE_OVERLAY_PERMISSION and data =
URI "package:<package>" would redirect the user to the specific app screen with
the toggle to grant SYSTEM_ALERT_WINDOW (SAW) permission.

This makes it too easy for malicious apps to fool the user into enabling
it and we know that exist malware attempts to do so.

This CL redirects that intent to the screen that list all the apps
requesting SAW permission, introducing some friction for the user, which
hopefully will allow more time for consideration.

This is consistent with how other access permission intents work.

Test: Working on CTS
Test: adb shell am start -a
      android.settings.action.MANAGE_OVERLAY_PERMISSION -d package:<package>
      goes to list of apps screen
Test: adb shell am start -a android.settings.action.MANAGE_OVERLAY_PERMISSION
      also goes there
Bug: 135920175

Change-Id: I02fb842106602dab7fc285d0741edb58432ac7ad
2019-11-08 16:55:19 +00:00
James Mattis
4a18957c2d SoftApCallback using executor vs handler
Updating classes to support making SoftApCallback methods available to @SystemAPI including
the API for registration of a SoftApCallback which includes a change to
now use executor vs handler.

Bug: 143564153
Test: make RunSettingsRoboTests ROBOTEST_FILTER=WifiTetherPreferenceControllerTest
Also tested manually on a Hawk.

Change-Id: I952ad10dd88b7d97b3cd86b269b8f67b00b1fa15
2019-11-08 08:44:35 -08:00
Jay Aliomer
b499cc5643 Merge "Don't disable DND permission settings for apps that have disabled NLS" 2019-11-08 16:38:12 +00:00
Jay Aliomer
8754d40124 Don't disable DND permission settings for apps that have disabled NLS
ZenAccessController.getPackagesRequestingNotificationPolicyAccess
was including disabled packages.
We change this behavior to exclude any disabled package

Test: make -j64 RunSettingsRoboTests ROBOTEST_FILTER="com.android.settings.applications.specialaccess.zenaccess.ZenAccessControllerTest"
Change-Id: I354b8f0bdbf602d1f35233d5003ce09f01df3cb2
Fix: 141318822
2019-11-08 16:21:15 +00:00
Julia Reynolds
31dc1fd806 Add NLS specific screens for notification listener approval
Fixes: 141689199
Fixes: 143639217
Test: atest

Change-Id: I4ead087e0015ad33d6be4f9357de50a4298b3347
2019-11-08 14:13:24 +00:00
TreeHugger Robot
f9b41559b6 Merge "Use the getBidiFormattedPhoneNumber to replace getFormattedPhoneNumber" 2019-11-08 11:47:21 +00:00
Sunny Shao
ac3b465e96 Fix the MMS messages toggle preference not working
am: b377713547

Change-Id: I8f37573cca361a826d786d2d9693185b051d266c
2019-11-08 02:55:28 -08:00
Sunny Shao
0f844d168b Use the getBidiFormattedPhoneNumber to replace getFormattedPhoneNumber
Fixes: 123698996
Test: make RunSettingsGoogleRoboTests -j ROBOTEST_FILTER=com.android.settings.deviceinfo.PhoneNumberPreferenceControllerTest
Test: make RunSettingsGoogleRoboTests -j ROBOTEST_FILTER=com.android.settings.deviceinfo.simstatus.SimStatusDialogControllerTest
Test: make RunSettingsGoogleRoboTests -j ROBOTEST_FILTER=com.android.settings.network.telephony.RenameMobileNetworkDialogFragmentTest
Test: make RunSettingsGoogleRoboTests -j ROBOTEST_FILTER=com.android.settings.homepage.contextualcards.deviceinfo.DeviceInfoSliceTest
Change-Id: I5dfb71ceb87a8f658ef7fbceacf460ef8d35593a
2019-11-08 16:36:33 +08:00
Raff Tsai
1ade809ff9 Filter invalid uid from Battery list
- Normally uid is start from 0. That was a bug in framework during
some time period, and was not reproduced later. We just remove this
kind of invalid item from UI.

Fixes: 141404334
Test: manual
Change-Id: I964a8b8af18ac6a5d8d2dea89722ea466e27e6ad
2019-11-08 08:30:38 +00:00
TreeHugger Robot
9aded56b70 Merge "Remove duplicate layout mobile_network_settings_container_v2" 2019-11-08 08:22:15 +00:00
TreeHugger Robot
7aa1aa4c5f Merge "Fix the NPE in the AnimationController" 2019-11-08 05:46:37 +00:00
Raff Tsai
8fe35bff52 Remove duplicate layout mobile_network_settings_container_v2
- MobileNetworkActivity can use settings_base_layout.xml as layout.
- MobileNetworkActivity need to use Theme.Settings.Home because
it requests Window.FEATURE_NO_TITLE. Otherwise MobileNetworkActivity
will show title defined in xml first then change to new title.

Fixes: 123794771
Test: rebuild, manual
Change-Id: I39ae25b6d335437ffddb2f1562e7a0347db97108
2019-11-08 12:04:16 +08:00
TreeHugger Robot
504d2d3cba Merge "Modify account page multiple profile UI" 2019-11-08 03:48:32 +00:00
Sunny Shao
b808eb0464 Fix the NPE in the AnimationController
Add the null checking in onBindViewHolder

Fixes: 144099781
Test: compilation
Change-Id: Iafb8f758d7d71ce9fa67f4ad94d5a8a417ad674a
2019-11-08 10:53:53 +08:00
Roshan Pius
adfdb0ddf1 Merge "Settings: Use public API for mac randomization support" 2019-11-07 23:17:57 +00:00
TreeHugger Robot
1a3a50bceb Merge "Remove unused resources" 2019-11-07 11:27:36 +00:00
Raff Tsai
4992919d95 Remove unused resources
Bug: 123794771
Test: rebuild, robolectric
Change-Id: I22f43220cc9ad4ec2074af425b0da75f59e470a4
2019-11-07 18:12:34 +08:00
Raff Tsai
f5277ba54a Modify account page multiple profile UI
- Extend the tab width to 50%
- Hide category title in two tab mode

Bug: 141601408
Test: manual
Change-Id: I73a1a64c704f7a74c200803efef97cdac5534aa7
2019-11-07 14:53:54 +08:00
Stanley Wang
79eaa655ef Refactor SettingsSearchIndexablesProvider.
- Extract the adding raw indexable columns
  to createIndexableRawColumnObjects method.
- Refactor the getInjectionIndexableRawData
  method for query injection data.

Test: manual
Fixes: 144007045
Change-Id: I9c028818dcaff165c3b7f8d495f6002370cd30fa
2019-11-07 10:36:04 +08:00
Roshan Pius
f13145b323 Settings: Use public API for mac randomization support
Also, don't directly reference the default tether ssid overlay. This info
should always be retrieved from wifiManager.
This ensures that we don't use wifi overlays in settings.

Bug: 143464763
Test: atest com.android.server.wifi
Change-Id: I893a4ca0f4243e1eb6f9c8bef810d0b4a493fb88
2019-11-06 07:58:19 -08:00
Sunny Shao
b377713547 Fix the MMS messages toggle preference not working
- MMS messages toggle preference doesn't work while the default Mobile data is on then switches off.
- Recall the displayPreference to execute the preference.setOnPreferenceChangeListener
  in the AbstractPreferenceController.

Fixes: 143204818
Test: make RunSettingsGoogleRoboTests -j ROBOTEST_FILTER=com.android.settings.network.telephony.MmsMessagePreferenceControllerTest
Change-Id: Ida65d04b095b7d2556fa5bdd93be7a67cba77206
Merged-In: Ida65d04b095b7d2556fa5bdd93be7a67cba77206
(cherry picked from commit 054e0eab87)
2019-11-06 06:19:35 +00:00
Bonian Chen
38701ed7ea Merge "[Settings] Hidden API remove - WFC mode settings" 2019-11-06 06:05:21 +00:00
TreeHugger Robot
07e39a6246 Merge "Remove mobile network v1" 2019-11-06 05:01:41 +00:00
TreeHugger Robot
0b0f25c1f5 Merge "Fix Settings crashed on tapping on notification animation video" 2019-11-06 04:50:52 +00:00
Bonian Chen
c3b94292ea [Settings] Hidden API remove - WFC mode settings
Change API from getWfcMode/setWfcMode into APIs within ImsMmTelManager.

Bug: 140542283
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=WifiCallingPreferenceControllerTest
make RunSettingsRoboTests -j ROBOTEST_FILTER=WifiCallingSettingsForSubTest
make RunSettingsRoboTests -j ROBOTEST_FILTER=WifiCallingSliceHelperTest
atest WifiCallingSettingUiTest

Change-Id: I2ee01852cb4ee90fe9db256d3333f461cc070da5
2019-11-06 12:17:09 +08:00
TreeHugger Robot
3ca3f15572 Merge "Integrated SearchIndexableResources interface in Settings" 2019-11-06 01:21:38 +00:00
Rahul Sabnis
c5a039a89f Merge "Refactor usages of getAliasName to use getAlias in Settings" am: eed0f8816b am: 4f85f36e7d
am: 2a60040d29

Change-Id: If24afc1a316da64fbf49ad08ee761e5af7dde4b7
2019-11-05 11:47:05 -08:00
Rahul Sabnis
2a60040d29 Merge "Refactor usages of getAliasName to use getAlias in Settings" am: eed0f8816b
am: 4f85f36e7d

Change-Id: I726b2cd3025d2bee79320b420af570ee30eb3700
2019-11-05 10:49:43 -08:00
Rahul Sabnis
4f85f36e7d Merge "Refactor usages of getAliasName to use getAlias in Settings"
am: eed0f8816b

Change-Id: Icb70620c2bc7e84fb19196c26d8c576220eefe13
2019-11-05 10:42:41 -08:00
Treehugger Robot
eed0f8816b Merge "Refactor usages of getAliasName to use getAlias in Settings" 2019-11-05 18:20:50 +00:00
Raff Tsai
1eccd55a70 Remove mobile network v1
Fixes: 142920912
Test: rebuild, robolectric
Change-Id: Ib365ba712af62729ca35abbc370aef087ce52a90
2019-11-05 17:54:54 +08:00
Raff Tsai
c5e1fc677c Integrated SearchIndexableResources interface in Settings
- New SearchIndexableResources interface returns SearchIndexableBundle,
we don't need reflection to get SearchIndexableProvider

Bug: 135053028
Test: robolectric, check database search_index.db items
Change-Id: I5ed3416ccf72ef3d38db817fcb4aff7502649ed4
2019-11-05 17:38:32 +08:00
Raff Tsai
9547fa73cc Fix Settings crashed on tapping on notification animation video
- When preference goes back from pause state, it doesn't call through
onBindViewHolder, caused surface view doesn't attach to Mediaplayer.
Call attachView in initAnimationController and set SurfaceView to
MediaPlayer when onSurfaceTextureUpdated to fix the issue.

Fixes: 143905693
Test: manual, robolectric
Change-Id: I0eceead2e4c90ca176ef0f35937898f9b9be6232
2019-11-05 16:41:35 +08:00
Raff Tsai
5d0c49e9ef Merge "Fix Battery page animation" into qt-qpr1-dev
am: 8b348f1f30

Change-Id: I922be1ac21e17c9ae71d7721401a08bbd56ca020
2019-11-04 22:15:20 -08:00
TreeHugger Robot
8b348f1f30 Merge "Fix Battery page animation" into qt-qpr1-dev 2019-11-05 05:34:41 +00:00
Bonian Chen
d7e52888b4 Merge "[Settings] Manual network select without aggregate" 2019-11-05 05:33:53 +00:00
Bonian Chen
ef1481f589 [Settings] Manual network select without aggregate
Remove the feature of aggregation when performing manual network
selection.

Bug: 141287649
Test: Manual
make RunSettingsRoboTests -j ROBOTEST_FILTER=NetworkSelectSettingsTest
make RunSettingsRoboTests -j ROBOTEST_FILTER=NetworkOperatorPreferenceTest

Change-Id: I813ad31f9d5cf310877442f5558e236671ab5d23
2019-11-05 04:19:30 +00:00
Raff Tsai
6a3433b67a Fix Battery page animation
TextView summary1 has default height 2 line. If the content is longer
than 2 line, the TextView increases itself which causes the animation.
By increasing minLines to 3, it can avoid the animation. And remove
summary2 because it is only for debug purpose, the debug information
can be merged to summary1.

Fixes: 139554919
Test: visual, make RunSettingsRoboTests
Change-Id: I167ac87c9bd83035e00d4991961599e76f4f69e1
(cherry picked from commit 648ada031d)
Merged-In: I167ac87c9bd83035e00d4991961599e76f4f69e1
2019-11-05 12:11:51 +08:00
Arc Wang
5474667892 Merge "[Wi-Fi][A11Y] Fix TalkBack lose focus in WifiSettings & WifiSettings2" 2019-11-05 02:01:36 +00:00
TreeHugger Robot
ee9f1be50a Merge "Schematize Telephony System Properties" 2019-11-04 23:44:33 +00:00
David Su
5545f54e8a Rename WIFI_P2P_PERSISTENT_GROUPS_CHANGED_ACTION intent
Rename WIFI_P2P_PERSISTENT_GROUPS_CHANGED_ACTION intent
to ACTION_WIFI_P2P_PERSISTENT_GROUPS_CHANGED to conform
to naming conventions.

Bug: 143892817
Test: compiles
Change-Id: I8fce665af122969a63dc6fafed137f349c12eb58
2019-11-04 20:20:08 +00:00
TreeHugger Robot
1d9a7b3fa3 Merge "Remove redundant code in certificate pref controllers" 2019-11-04 18:42:52 +00:00
Bonian Chen
0adbf36657 Merge "[Setting] MobileNetwork UI performance" 2019-11-04 14:18:50 +00:00
Bonian Chen
7dcfb7baf0 [Setting] MobileNetwork UI performance
1. Create a singleton to reduce number of SubscriptionManager accessing
2. Listening to Airplane mode change to clear cache value

Bug: 141833767
Test: Manual
make RunSettingsRoboTests -j ROBOTEST_FILTER=MobileNetworkActivityTest
make RunSettingsRoboTests -j ROBOTEST_FILTER=GlobalSettingsChangeListenerTest

Change-Id: Icd76fd9bcef7a7822400bfe42b0d40f5bd920eed
2019-11-04 12:37:31 +00:00
TreeHugger Robot
4d8e980637 Merge "Fix the crashed problem at the AccountSyncSettings" 2019-11-04 12:09:30 +00:00
TreeHugger Robot
79dda90792 Merge "Fix Weird floating "add language" item" 2019-11-04 10:41:40 +00:00
Raff Tsai
29c15273b5 Fix Weird floating "add language" item
- Base theme has android:clipToPadding=false attribute. It let user
UI draw under navigation bar but also cause this problem. Add
android:clipToPadding=true in layout to fix the problem.

Fixes: 142108980
Test: manual
Change-Id: Ibe60b348a3c7c01d9786612ceac23a47a78a208a
2019-11-04 17:34:02 +08:00
Bonian Chen
5fe90a3f5a Merge "[Settings] MobileNetworkActivity Refactor" 2019-11-04 09:20:43 +00:00