Commit Graph

28864 Commits

Author SHA1 Message Date
Antony Sargent
136a0f53f6 Merge "Make MobileNetworkActivity support onNewIntent" into qt-r1-dev am: 20ec6a4b6f
am: f61428cf1d

Change-Id: I21991a0d06bf861d6a0fd6906b455a36d8b10c55
2019-07-18 20:06:19 -07:00
Antony Sargent
f61428cf1d Merge "Make MobileNetworkActivity support onNewIntent" into qt-r1-dev
am: 20ec6a4b6f

Change-Id: I72317d0d45103cbc4791e1f9d67e726d7426b758
2019-07-18 19:57:18 -07:00
Antony Sargent
dd874eeb54 Merge "Make MobileNetworkActivity support onNewIntent" into qt-r1-dev
am: 20ec6a4b6f

Change-Id: I512000e6041c3611d4c7715355d8564aa3261b01
2019-07-18 19:57:18 -07:00
Arc Wang
a12b372dd2 [Wi-Fi DPP] Refine code
Remove unused code.
Rename some variables and methods for better readability.
Fix typos.
Reduce unnecessary variable scope and method scope.
Simplify some code logic.

Bug: 120645817
Test: atest com.android.settings.wifi.dpp
Change-Id: I8f30b3e445f25ada927e995befee1783d2270b91
2019-07-19 10:29:06 +08:00
TreeHugger Robot
20ec6a4b6f Merge "Make MobileNetworkActivity support onNewIntent" into qt-r1-dev 2019-07-19 02:26:19 +00:00
Mehdi Alizadeh
1aaf41b2dc Removes logic to disable gesture nav when default home app changes
Bug: 137197916
Test: Manual test with setting a 3P launcher as default
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SystemNavigationGestureSettingsTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SystemNavigationPreferenceControllerTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=RadioButtonPreferenceWithExtraWidgetTest
Change-Id: Id397cfa1c2439222aa21a7b7fe5f69818bf1fe97
2019-07-18 15:27:05 -07:00
Mady Mellor
22c920cc01 Use the Global value rather than the Secure value
Fixes: 137876221
Test: manual - have setting in dev options turned off, post a bubble
               => no bubble appears
             - have setting in dev options turned on, post a bubble
               => bubble appears

Change-Id: I4490b978059a73b45fa8d09bf28e05965f42eec1
2019-07-18 14:40:04 -07:00
Lyn Han
d39e874570 Merge "Secure => global bubble settings pt 2" into qt-r1-bubbles-dev 2019-07-18 14:30:16 +00:00
Kevin Chang
8c17c2f588 Merge "Add new reminder in "Magnify with shortcut" page" into qt-r1-dev
am: 6bfc381173

Change-Id: Ic0b481b5306a91c58f1aeea4cb125874d6b77d2e
2019-07-18 00:53:02 -07:00
Kevin Chang
42f6f19216 Merge "UI change in caption preferences in Settings" into qt-r1-dev
am: af447c17b8

Change-Id: I5b669681267875963d9b91471bdb63a57b1c84b0
2019-07-18 00:52:00 -07:00
Kevin Chang
6bfc381173 Merge "Add new reminder in "Magnify with shortcut" page" into qt-r1-dev 2019-07-18 06:59:45 +00:00
Kevin Chang
af447c17b8 Merge "UI change in caption preferences in Settings" into qt-r1-dev 2019-07-18 06:59:41 +00:00
cosmohsieh
a5e0148c7a [NetworkRequest] Implement Single Specified SSID ALTERNATE FLOW V2
Implement new flow for Single SSID mode of NetworkRequestDialog.
There is a new design for single SSID mode of NetworkRequestDialog.

Bug: b/132904234
Test: make RunSettingsRoboTests -j32 ROBOTEST_FILTER=com.android.settings.wifi
Change-Id: Ice19842243ea6f24a3ea74cf6e90a473080b8983
2019-07-18 12:04:02 +08:00
Raff Tsai
f7e3095464 Fix Disabled text color in dark theme
Fixes: 137639665
Test: manual
Change-Id: Ie3786c446ea0b9ca484069db65dcefda45ac28c8
2019-07-18 10:12:21 +08:00
Kevin Chang
04dea2b5c2 Add new reminder in "Magnify with shortcut" page
Add new reminder string in "Magnify with shortcut" page when
it's under gesture navigation mode.

Reference link of screenshot:
https://drive.google.com/file/d/1uo31FZebhXKcCR8QY_WrgEPiInzARmIl/view?usp=sharing

Bug: 134645913
Test: Visual
Change-Id: Ibbaa162d4acf0fdeed8c98b2aa1d83953880e6a6
Merged-In: Ibbaa162d4acf0fdeed8c98b2aa1d83953880e6a6
2019-07-17 11:27:37 +00:00
Kevin Chang
ef9cd2ac95 UI change in caption preferences in Settings
Move the switch after the caption preview and change the oreder of the
settings inside in caption preferences in Accessibility settings.

Reference link for screenshot:
https://drive.google.com/file/d/1EQLpfQFnJTwU1F8vLAOSHPYqSXKWL_ap/view?usp=sharing

Bug: 130755332
Test: Visual
Change-Id: Icb4dabdef71be165a21d1bde474872ee0bb35bfa
Merged-In: Icb4dabdef71be165a21d1bde474872ee0bb35bfa
(cherry picked from commit fd1f1c0f82)
2019-07-17 11:27:06 +00:00
Stanley Wang
d2b2d9898e Merge "Fix app uninstalling/stopping possible in screen pinning mode" 2019-07-17 10:17:32 +00:00
Stanley Wang
161c359508 Fix app uninstalling/stopping possible in screen pinning mode
Bug: 135604684
Test: maunal & robotest
Change-Id: I96eddb11ff32c6c46915682eb58857be7d24ed99
2019-07-17 10:58:52 +08:00
Yi Jiang
06f0bd6d4e Don't show suggestion slice if 'Screen attention' is already on
Bug: 137259771
Test: Manually

Change-Id: I5568b569ecd4db943f1a239c7ddcd2923bec4028
2019-07-16 17:17:31 +00:00
TreeHugger Robot
932c8eaa68 Merge "Remove deprecated code" 2019-07-16 06:11:40 +00:00
Raff Tsai
58cd356273 Remove deprecated code
Fixes: 137106225
Test: rebuild
Change-Id: I7c757fc39197d2b6166fc8cbd9ad585ba16a7e2e
2019-07-16 10:35:04 +08:00
Antony Sargent
6dd874305e Make MobileNetworkActivity support onNewIntent
The launchMode for MobileNetworkActivity specified in the android
manifest is "singleTask", which means that when an intent to it is
launched, if there is an existing instance we will reuse that instead of
creating a new one. But to handle this properly we need to know when it
happens by implementing onNewIntent, which we weren't doing.

Implementing this fixes a bug we noticed that if you have multiple SIMs
and recently visit the details page for SIM 1 but then click on a SIM
selection notification that should bring you to the details for SIM 2,
we'd just bring up the details page for SIM 1 again.

Fixes: 133447239
Test: make RunSettingsRoboTests
Change-Id: Ia9106b15ffde437f6dd6fd2da23336ec5b28f75e
2019-07-15 17:11:19 -07:00
TreeHugger Robot
2e9c4c4978 Merge "Remove Settings from recents after app uninstall" 2019-07-15 22:57:06 +00:00
Lyn Han
c44efcb3e4 Secure => global bubble settings pt 2
Follow up to http://ag/8222583
- Replace references to Secure.NOTIFICATION_BUBBLES with
Global.NOTIFICATION_BUBBLES

Fixes: 136034310
Bug: 129158983
Test: m RunSettingsRoboTests
Test: atest SystemUITests
Test: manual - work profile bubbles show up
Change-Id: Ifa71206353237b837cfcda6d23ea6a6ec2c146d0
2019-07-15 13:51:18 -07:00
Joshua Mccloskey
b441c8ab91 Merge "Fixed Settings Crash" into qt-r1-dev am: 800e8a485f
am: d5cac4a3f6

Change-Id: I4cbc1adb869d6ca988827c6bdbd2106ab089c82c
2019-07-15 13:22:30 -07:00
Joshua Mccloskey
d5cac4a3f6 Merge "Fixed Settings Crash" into qt-r1-dev
am: 800e8a485f

Change-Id: If6bba47ee6c16b035453c5f4a3fee38c0b1a0a1a
2019-07-15 13:10:52 -07:00
Joshua Mccloskey
800e8a485f Merge "Fixed Settings Crash" into qt-r1-dev 2019-07-15 19:40:23 +00:00
Lyn Han
ca77022900 Revert "Secure => global bubble settings pt 2"
This reverts commit a978ab4526.

Reason for revert: fix test

Change-Id: Id6b49106ab7d8a42ea5de8b16a0dd3ed49d58817
2019-07-15 18:06:32 +00:00
Raff Tsai
55459042ae Merge "Add wifi calling slice to settings search and AGSA" 2019-07-13 04:14:55 +00:00
TreeHugger Robot
8a78972349 Merge "Remove obsolete broadcast behavior" 2019-07-12 22:52:57 +00:00
joshmccloskey
6a3012f21d Fixed Settings Crash
Fixes: 137319680
Test: Manual
Change-Id: I0e22bd561787b1a141bf2e3060b23fe70a6d96ce
2019-07-12 15:49:24 -07:00
Lyn Han
a978ab4526 Secure => global bubble settings pt 2
Follow up to http://ag/8222583
- Replace references to Secure.NOTIFICATION_BUBBLES with
Global.NOTIFICATION_BUBBLES

Fixes: 136034310
Bug: 129158983
Test: atest SystemUITests
Test: manual - work profile bubbles show up
Change-Id: I03ffd7f1126f2c20d819f741cd4f7dcced81a405
2019-07-12 11:32:39 -07:00
Soonil Nagarkar
533a17f1f5 Remove obsolete broadcast behavior
There is no need to broadcast when a footer is displayed/removed. The
broadcasts were added specifically for gmscore to know when the footer
was visible, so that GLS consent could be given. However, this
was only very briefly actually used within GmsCore, and has been
obsolete for several releases.

Test: CTS
Change-Id: I1df6c6214fe79c943cabd7b04357c8ab7d1c1c39
2019-07-12 11:06:05 -07:00
Raff Tsai
85e1218b31 Add wifi calling slice to settings search and AGSA
Fixes: 121041498
Test: test if wifi calling slice is appeared in Settings Search
Change-Id: I4892da6e7d396f28bb232f8e520a8c946f35570d
2019-07-12 23:40:27 +08:00
TreeHugger Robot
1f18ca5021 Merge "Add whitelist in ResetAppsHelper" 2019-07-12 11:02:11 +00:00
Sunny Shao
b54d2f90f2 Add whitelist in ResetAppsHelper
Add "com.android.systemui" into the whitelist and skip the clear data.

Fixes: 137037930
Test: manual test
Change-Id: Ie2f527309f9159babe79636a69ff13fe3ceb64d9
2019-07-12 15:43:18 +08:00
TreeHugger Robot
eb97f54928 Merge "Check FaceManager before get system service" 2019-07-12 07:24:32 +00:00
Andrew Sapperstein
f6219c0242 Merge "Fix erasing of eSIMs for some devices" into qt-dev am: 1f942d9857 am: 44f731c1c7
am: b07cee3139

Change-Id: I4e8deaf89a5cb0327e38866b9c205871057fdd92
2019-07-11 21:39:30 -07:00
Raff Tsai
b848474b91 Check FaceManager before get system service
Bug: 136788181
Test: adb shell am start -a android.settings.FACE_SETTINGS is not
      crashed

Change-Id: If727ab4aa3b4043fa2e4e8c13392e32d566b1bbb
2019-07-12 12:18:16 +08:00
Andrew Sapperstein
b07cee3139 Merge "Fix erasing of eSIMs for some devices" into qt-dev am: 1f942d9857
am: 44f731c1c7

Change-Id: I34bb2383b9f14e624ab93caa0108d2a2510f4439
2019-07-11 21:10:41 -07:00
Antony Sargent
8d2baf64c7 Fix erasing of eSIMs for some devices
Doing a factory data reset used to always erase eSIMs. Then a few months
ago we added a default-on checkbox to let users opt out of erasing the
eSIM during this process, but only had it show for some devices (ones
which support the "fastboot oem esim_erase" command) by adding a system
property named masterclear.allow_retain_esim_profiles_after_fdr.

When recently updating the strings shown in the factory data reset
screen and the confirmation dialog, we changed the code so that if that
the checkbox is hidden we'll pass false for the ERASE_ESIMS_EXTRA
parameter sent to the factory data reset confirmation dialog. This had
the unintended side effect of making devices that don't specify true for
masterclear.allow_retain_esim_profiles_after_fdr skip erasing the eSIM.

This CL fixes that by removing the "is the checkbox hidden" check, going
back to the previous behavior of just using the checkbox value, which is
on by default even if hidden.

Fixes: 135284765
Test: make RunSettingsRoboTests
Change-Id: Ia9f335920e4e3c4a90f0a6a49d1722a0c19ea83d
(cherry picked from commit 5f612a4b44)
2019-07-12 04:10:26 +00:00
Andrew Sapperstein
8c6b2bafb0 Merge "Fix erasing of eSIMs for some devices" into qt-dev
am: 1f942d9857

Change-Id: I04bc60ed040546a64ea157840b76d815169d32a3
2019-07-11 20:51:33 -07:00
Andrew Sapperstein
44f731c1c7 Merge "Fix erasing of eSIMs for some devices" into qt-dev
am: 1f942d9857

Change-Id: I44e11b7a63c329883b01dc03f820e807c15953cf
2019-07-11 20:51:32 -07:00
Andrew Sapperstein
1f942d9857 Merge "Fix erasing of eSIMs for some devices" into qt-dev 2019-07-12 03:13:39 +00:00
Vinit Nayak
f7d423d106 Remove Settings from recents after app uninstall
SettingsActivity now calls finishAndRemoveTask
instead of only finish() to prevent blank
recent task from showing in overview.

Test: Visually inspected bug doesn't exist. Wrote
Roboelectric tests

Fixes: 129733119

Change-Id: I5b73c1b611e6eb52bb6665c215276efdc85c19b2
2019-07-11 16:09:49 -07:00
joshmccloskey
c9e680edac Ensure feature is supported and enabled. am: a96a84e256
am: 00c05fc246

Change-Id: I524966c3163a9dff1c1d7f7a4da496e8a08fb66e
2019-07-11 15:06:11 -07:00
joshmccloskey
00c05fc246 Ensure feature is supported and enabled.
am: a96a84e256

Change-Id: I5a1870ed55326fb9e8a5616ffa279bccc42b04ff
2019-07-11 14:56:10 -07:00
joshmccloskey
a96a84e256 Ensure feature is supported and enabled.
Fixes: 137285390
Test: Verified that SecuritySettings no longer crashes.
Test: Verified that this PrefenceController no longer shows up
if the device does not support it.
Test: Verified that this PreferenceController no longer
shows up when the work profile is disabled.

Change-Id: I10f015e18491b203db6f942f07034d55f620cfe5
2019-07-11 21:31:31 +00:00
joshmccloskey
d670b80d84 Update FaceSlice to use correct pref & FaceManager am: 365beaebdb
am: 5dbcfc9d27

Change-Id: I290d6a89e372f6c70e25aa6c44c2308682ef1049
2019-07-11 14:17:00 -07:00
joshmccloskey
5dbcfc9d27 Update FaceSlice to use correct pref & FaceManager
am: 365beaebdb

Change-Id: I3762f68d4f16ad529ad7a1cc56891812daad7016
2019-07-11 14:08:02 -07:00