Commit Graph

840 Commits

Author SHA1 Message Date
Fan Zhang
65da3306f6 Merge changes If1b263df,I95afbcf0
* changes:
  Move instantiation-through-reflection method to controller
  Minor cleanup in DashboardFragment: remove unused code
2018-02-21 20:53:49 +00:00
TreeHugger Robot
302cf35914 Merge "Update launch component for work mode condition." 2018-02-21 20:19:59 +00:00
Fan Zhang
b297abc1fe Minor cleanup in DashboardFragment: remove unused code
Bug: 73668763
Test: n/a
Change-Id: I95afbcf03987123e4ed8b76efbed299a7beb4448
2018-02-21 09:48:50 -08:00
Doris Ling
34200fb19e Update launch component for work mode condition.
- start accounts dashboard instead of users settings.

Change-Id: I1365e6c32ac3de23c24b75e33262957e4a4224a9
Fixes: 73651609
Test: make RunSettingsRoboTests
2018-02-20 17:43:46 -08:00
Doris Ling
5b3332547a Update suggestion/condition UI
- reduce top padding for suggestion container
- match condition card corner radius with suggestion card.
- change condition card background color to white
- update suggestion title font from medium to regular.

Change-Id: I0267b37822facf4bd389e2b21c47a1fcf0d00264
Fixes: 70573674
Test: visual
2018-02-20 15:30:47 -08:00
Fan Zhang
47854c2945 Migrate more places to subsetting launcher
Bug: 73250851
Test: robotests
Change-Id: Iaf29df45ddb42fd58f181cb01e10998a97cb7c34
2018-02-19 14:21:05 -08:00
Fan Zhang
970bacd8cb Remove IA mapping for old connected device page
Change-Id: I201c09facb9e21d452c58ff3d257bdd37e6b854d
Fixes: 69471219
Test: robotest
2018-02-15 10:36:16 -08:00
TreeHugger Robot
373a33bb87 Merge "Fix double search icon in wifi calling page" 2018-02-09 22:39:30 +00:00
Fan Zhang
710ef64873 Increase timeout waiting for suggestions
- Experimenting timeout value to figure out what's most common
  end-to-end latency for loading suggestions

Change-Id: Icaa3d4d7a45a05380a9521c961e7213e020601a9
Fixes: 69068691
Test: visual
2018-02-09 12:24:04 -08:00
Fan Zhang
b91db42100 Fix double search icon in wifi calling page
- Moved fragments into wifi sub-package.
- Cleaned up inheritance for WifiCallingSettings
- Attach help and search action menu controller correctly.

Change-Id: I0bc8ab99df5d8c5ea64fb64de5ae70c2c9bd6f31
Fixes: 72958674
Test: robotest
2018-02-09 11:26:16 -08:00
TreeHugger Robot
a33144b841 Merge "Pre-fixup for nav up button" 2018-02-07 22:05:39 +00:00
Fan Zhang
f11c885766 Pre-fixup for nav up button
- Remove SettingsDrawerActivity.EXTRA_SHOW_MENU and force up nav button
  to always show. The button doesn't do anything yet. It just finishes
  current activity.
- Remove dead code about suggestions

Change-Id: I61fa9fefbaa9bced841a05969544b1c824c564ce
Bug: 72337421
Test: rebuild
2018-02-07 10:27:18 -08:00
Lei Yu
f8caf69d46 Merge changes from topic "battery_saver_step_1"
* changes:
  Add preference controller for battery seekbar
  Revamp the battery saver page
2018-02-07 02:07:54 +00:00
TreeHugger Robot
f504294b12 Merge "Update suggestion card width." 2018-02-06 22:14:29 +00:00
Doris Ling
c627161ca6 Update suggestion card width.
- instead of using hard-coded width for 1 or 2 cards, they should take
up the whole screen width minus the defined padding, so that when the
device is in landscape mode, they look better.

Change-Id: Ic6485c858c7742a154a6d9b05fff180f161be323
Fixes: 72850225
Test: make RunSettingsRoboTests
2018-02-06 12:18:34 -08:00
Ben Lin
845e213514 Set categories to the adapter if suggestion is not available.
If there's no suggestion, we should set the category to the adapter
before returning.

Bug: none
Test: robotests
Change-Id: I73bb248d17edb3c398a9fb0a8f3913e7233fcc0b
2018-02-05 16:20:56 -08:00
jackqdyulei
7e999df6d9 Revamp the battery saver page
1. Make BatterySaverSettings extend from DashboardFragment
2. Add new layout
3. Add battery saver controller

Future cl will add controllers for seekbar and button

Bug: 72228477
Test: RunSettingsRoboTests
Change-Id: I21fb62aef874c04eca2988271f2fd9d7aacb0c6c
2018-02-05 13:32:48 -08:00
TreeHugger Robot
36952523bb Merge "Update suggestion UI" 2018-02-02 21:23:24 +00:00
Doris Ling
7fa083ece9 Update suggestion UI
- reduce space above and below the suggestion header
- reduce space around the suggestion cardview
- set the font family for the suggestion header and title.

Change-Id: Ief6247005f1e69fe5025af60f3c9627d357d94a4
Fixes: 72710227
Test: visual
2018-02-02 11:34:03 -08:00
Beverly Tai
7142be5630 Merge "Zen Condition text and primary click changes" 2018-02-02 15:27:04 +00:00
Beverly
c5ae162768 Zen Condition text and primary click changes
- Zen condition in settings has same secondary text as dnd qs tile
- Zen condition's primary click brings user to DND settings instead of
ZenPanel

Test: manual
Change-Id: I0090c09e19376d3aafff45a893485d19cd7b91da
Fixes: 72570739
2018-02-01 17:24:49 -05:00
Doris Ling
0e96107ddc Check icon tintable flag of the Suggestion.
- instead of checking the icon resource package, check the icon tintable
flag to see if we should tint the suggestion icon.

Bug: 72330968
Test: make RunSettingsRoboTests
Change-Id: I4767df05bebf815774dbd8e528c7ac0f5b902d44
2018-01-31 16:55:10 -08:00
Doris Ling
a5d0c3e36e Remove suggestion UI v1 codes.
- remove the check for feature flag for suggestion UI v2 and switch to
use the v2 codes.
- remove all code related to v1 of suggestion UI

Fixes: 70573674
Test: make RunSettingsRoboTests

Change-Id: I99ab318c1c0192508a9c5e9e708e86319120d55b
2018-01-31 10:59:40 -08:00
Fan Zhang
0ec6b02fe4 Re-add isSuggestionEnabled check
It was accidentally removed previously

Test: robotest
Change-Id: I5b7707e746d6b825d835a007727b29c9a81a7fc1
2018-01-30 15:41:33 -08:00
TreeHugger Robot
0be5e81526 Merge "Update suggestion card UI." 2018-01-30 03:55:28 +00:00
TreeHugger Robot
d3ee4e260d Merge "Dismiss suggestion when close button is clicked." 2018-01-30 01:26:23 +00:00
Doris Ling
c04163a76e Update suggestion card UI.
- adjust suggestion card width and padding
- tint icon if it is from settings package.

Bug: 72330968
Test: visual
Change-Id: I4b82d51b3013ad0656d297305e0000958b71e94d
2018-01-29 16:39:31 -08:00
Doris Ling
0e32252111 Dismiss suggestion when close button is clicked.
- add handling to the suggestion card to dismiss the suggestion when
the close button is clicked.

Bug: 70573674
Test: make RunSettingsRoboTests
Change-Id: I8155efc326242abde753a633009e2579a9b3aa9b
2018-01-29 13:20:32 -08:00
Fan Zhang
73dc479ab5 Remove security settings v1 code
Change-Id: I958ed1588009b91f64cd8ecb98208e72a891903e
Fixes: 32953042
Test: robotests
2018-01-29 13:17:05 -08:00
TreeHugger Robot
7cfd0bfe43 Merge "Misc fixes for User page and my device info page" 2018-01-26 22:35:35 +00:00
Fan Zhang
881d579620 Misc fixes for User page and my device info page
- Rename UserAndAccountDashboard* to AccountDashboard*
- Move emergency info from account to device info page

- Move auto sync data toggles (4 of them) from Account page to user page
   - Move the controllers too. UserSettings is a not a DashboardFragment
     so I had to manually call each controller method.
     TODO: refactor UserSettings to a DashboardFragment

- Move legal information/regulatory info above advance button within device info page.

Fixes: 72523158
Bug: 71871075
Test: robotests
Change-Id: I1b8af8af61e49d17926f984978a09a974b6c62e1
2018-01-26 12:39:34 -08:00
Zhizhi Liu
1b0d7f14e3 Merge "Migrate some suggestions related classes SettingsLib(II)" 2018-01-26 18:16:42 +00:00
TreeHugger Robot
adf781c8a0 Merge "Add a generic blue background on some homepage tiles" 2018-01-26 00:13:22 +00:00
Fan Zhang
d62835a5d4 Add a generic blue background on some homepage tiles
If a homepage tile is injected from external packages, we can't
control what their icons look like, so we put a generic blue circular
background to make it consistent with the other icons.

Change-Id: I2a935db37fff097ae15540262bff94efea55179a
Fixes: 69314641
Test: robotests
2018-01-25 14:18:55 -08:00
Zhizhi Liu
caeb1720da Migrate some suggestions related classes SettingsLib(II)
Remove classes from Settings.

Test: mm Settings/tests/robotests

Change-Id: I0f046d6a750bc53251deb44887e8665e6d545515
2018-01-25 14:00:12 -08:00
Fan Zhang
f6c0d1c3ae Misc fixes
- remove useless intent-filters on a few activities
- Fix condition layout (icon size too big)
- clicking airplane condition card no longer crashes

Fixes: 72314527
Test: logcat | grep -i "TileUtils" and observe no more warning log
Change-Id: I3c6f9fb4f4e480ade220bc8602c04de5332d551c
2018-01-25 12:41:33 -08:00
Leif Hendrik Wilden
28dee1f086 Migrate to use instrumentation classes from settingslib.
Test: Compiles. Manually tested.
Change-Id: I70a6e76cc8440547746ecc008c32bd06a7de8161
2018-01-24 12:30:39 -08:00
Fan Zhang
372789b46d Remove all gesture suggestions
They are already removed from first 14 days category, now removing
permanently.

Change-Id: I1740d3bff59ff56142c10cce3b9617009c58f47d
Fixes: 72224790
Test: robotests
2018-01-23 14:26:30 -08:00
TreeHugger Robot
e3f187a4a9 Merge "Revert "Migrate to use instrumentation classes from settingslib."" 2018-01-23 01:58:18 +00:00
Leif Wilden
cab0ee611d Revert "Migrate to use instrumentation classes from settingslib."
This reverts commit 1546cca529.

Reason for revert: Broke fingerprint setup flow. b/72267201

Change-Id: I8321265ae64732c526325882ddea51080decddf5
2018-01-22 20:57:36 +00:00
Leif Wilden
de7135fbb1 Merge "Migrate to use instrumentation classes from settingslib." 2018-01-19 17:58:00 +00:00
TreeHugger Robot
dc660045bc Merge "Remove more things from search v1" 2018-01-19 02:50:24 +00:00
Fan Zhang
74706b6ed1 Remove more things from search v1
Test: robotests
Change-Id: Ide54d1cec69ae3a6782a979d3eeb7f3fc44f09b3
2018-01-18 15:43:34 -08:00
Doris Ling
964b36d415 Update suggestion card layout
- set card corner radius
- update card margin according to number of card and card position
- update text alignment for title and summary

Bug: 70573674
Test: visual
Change-Id: Icfceed5614ded97ce2a7767667ae97f92b89b2fa
2018-01-18 11:36:21 -08:00
Leif Hendrik Wilden
1546cca529 Migrate to use instrumentation classes from settingslib.
Test: Compiles. Manually tested.
Change-Id: Ie5515bb0fe3e621fc7723a9b04ba23e4bfa9c401
2018-01-18 11:13:24 -08:00
Doris Ling
a213bf0839 Separate suggestions and conditions.
This is the initial change for updating the suggestion cards:
- add a feature flag to swap between the new and current UI
- change suggestions to a standalone dashboard item. It becomes a
  horizontal scroll list that won't collapse/expand.
- the expand/collapse logic now only control the conditions list
- add draft for the new suggestion UI elements, but detail to fine-tune
to match the UI spec will come in following changes.

Bug: 70573674
Test: make RunSettingsRoboTests
Change-Id: I00c901e2598b26a34288fc73fd6031cc26a29ac6
2018-01-17 11:08:53 -08:00
Tony Mak
3e81ae7748 Rename trySetQuietModeEnabled to requestQuietModeEnabled as per ...
the feedback from API council

Fix: 71818127

Test: Build
Change-Id: Iab976fefcf00e0d5abada123b7c19344241b928a
2018-01-12 12:12:30 +00:00
TreeHugger Robot
bd261ff8b1 Merge "Remove support v1" 2018-01-08 18:29:18 +00:00
Salvador Martinez
616397d28c Remove support v1
Support v1 is no longer used and we want to keep the codebase clean.

Test: robotests still pass
Bug: 70620533
Change-Id: Ic8af0f34aab510a533bd7a7ec5c059834395baf5
2018-01-05 16:34:33 -08:00
Fan Zhang
361e55bb4c Use proper DashboardFragment APIs for SecuritySettingsV2
Next CL will add tests.

Bug: 32953042
Test: TODO
Change-Id: I0cb0e4eb216d3e9408675486f1cd73ba82d8ca36
2018-01-05 11:20:59 -08:00