Commit Graph

21960 Commits

Author SHA1 Message Date
Chaohui Wang
74fe516e09 Fix flicker of "App data usage"
Use placeholder to hold the place.

Fix: 323466366
Test: manual - on Mobile Settings
Test: unit test
Change-Id: I3c4d9ff6538a79500318869f01f4b88b55bd9475
2024-03-07 15:20:01 +08:00
Chaohui Wang
c038d58bef Merge "Sort the selectable subscription by id" into main 2024-03-07 06:40:34 +00:00
Wilson Wu
4406de67e0 Merge "Add fixed amplitude check for keyboard vibration" into main 2024-03-07 04:30:36 +00:00
Chaohui Wang
ad611366df Sort the selectable subscription by id
To make sure users always see a fixed order.

Bug: 318310357
Test: manual - on SIMs and turn on / off SIM
Change-Id: I2910d83f5b1d04287afca0e3ba91dedbeb588c14
2024-03-07 11:23:25 +08:00
Chaohui Wang
bdfae3a3bf Merge "Create NetworkScanRepository" into main 2024-03-07 02:47:30 +00:00
Treehugger Robot
1b3c21ef1b Merge "Fixed NPE in FingerprintEnrollIntro" into main 2024-03-07 02:24:40 +00:00
Joshua McCloskey
3c57fcde32 Fixed NPE in FingerprintEnrollIntro
Test: atest FingerprintEnrollIntroductionTest
Fixes: 317515741
Change-Id: Icc4e5cd4fbfea6828684ce6c8fc30acaabe5d315
2024-03-07 00:33:49 +00:00
Chun-Ku Lin
8b67c17a7b Show QS shortcut option if the a11y feature provides a tile.
Bug: 314852953
Test: atest com.android.settings.accessibility
Test: atest com.android.settings.accessibility.shortcuts
Test: manual
Flag: ACONFIG android.view.accessibility.a11y_qs_shortcut STAGING
Change-Id: Id7a6b3adfd4c4f3cb2b9f7fe15269b57a3d00543
2024-03-06 20:26:28 +00:00
Manish Singh
eb840e23f7 Merge "Return the correct position for the profile tab" into main 2024-03-06 19:33:41 +00:00
Wilson Wu
fd45101eee Add fixed amplitude check for keyboard vibration
Make sure the keybaord vibration settings only show
up when fixed amplitude provided to avoid any unsync
behavior with platform.

Bug: 326027376
Test: atest KeyboardVibrationTogglePreferenceControllerTest
Change-Id: I3b4e06660e3eaa6ce537b72831073f092cba37e2
2024-03-06 12:33:07 +00:00
Sudheer Shanka
07251c8262 Remove the developer option to control Quarantine app state.
Bug: 305256093
Test: manual
Change-Id: I28cfb3f1e6c5d3bdab77b7eae2262a03909c45f7
2024-03-06 06:02:38 +00:00
Fan Wu
757633223e Fix AppInfoWithHeaderTest
Use any() in getPackageInfoAsUser() to make the tests more robust regarding PackageManager flags change.

Bug: 315135755

Test: atest
Change-Id: I3857ca3bf2ee23424c78716ed3669fbe87c786f8
2024-03-06 03:30:40 +00:00
Manish Singh
8ca4f47292 Return the correct position for the profile tab
The existing code returns the fixed tab values, which doesn't work
now that the ordering is determined by the user manager's ordering.

Bug: 302278487
Test: manual
Test: atest ProfileSelectFragmentTest
Change-Id: I87b393b8e12e21dc1b38ee75bb43ca9133785c81
2024-03-05 19:50:29 +00:00
Isaac Chai
46369353ed Adding Settings preference for single finger panning feature
Test: Locally tested on device +
MagnificationOneFingerPanningPreferenceControllerTest
Bug: 282039824

Change-Id: I1d1a649060cba862c8f333e6e76184fade2dcdce
2024-03-05 19:10:59 +00:00
Manish Singh
ea341bdf98 Merge "Add controller for location for private profile" into main 2024-03-05 18:48:35 +00:00
Graciela Wissen Putri
a0f573a35e Follow config overlay's order of aspect ratio options
Fix flaky UserAspectRatioAppsPageProviderTest by using advanceUntilIdle
to make sure all coroutines are finished before asserting.

Bug: 325911424
Test: atest UserAspectRatioDetailsTest
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:32815ad699448c5c5b1f38df6d2d2a881d4251c1)
Merged-In: I83e9a7f31536c1a006789722b0310f3364d14337
Change-Id: I83e9a7f31536c1a006789722b0310f3364d14337
2024-03-05 17:11:59 +00:00
Manish Singh
dd5a8e610c Add controller for location for private profile
Bug: 303196278
Test: manual
Change-Id: I0997918e5046ac803c2c2d117c2e027b4aacc2c2
2024-03-05 16:27:28 +00:00
Chaohui Wang
4dbc23ca28 Create NetworkScanRepository
And migrate network scan to flow for better maintenance and prevent ANR.

Fix: 323105271
Test: manual - Choose network
Test: unit test
Change-Id: I5c49d195fc202143c0131ffd78bc3adc168b119c
2024-03-05 21:45:18 +08:00
SongFerng Wang
b321e4ca34 Merge "Fix the test case failed" into main 2024-03-05 10:02:02 +00:00
Manish Singh
0d1d483d7c Merge "Return true only if the userManager belongs to private profile" into main 2024-03-05 09:46:40 +00:00
Fan Wu
739647a46d Merge "Fix settings/widget test failures" into main 2024-03-05 02:13:10 +00:00
Roy Chou
79ee7bc941 Merge "chore(magnification): remove onResume overrides for controllers in ToggleScreenMagnificationPreferenceFragment" into main 2024-03-05 01:32:33 +00:00
songferngwang
29286ec8c3 Fix the test case failed
-Add flag FLAG_IS_DUAL_SIM_ONBOARDING_ENABLED
-Add mock for SubscriptionManager.createForAllUserProfiles

Bug: 323652989
Test: atest NetworkProviderCallsSmsFragmentTest
atest SubscriptionsPreferenceControllerTest
atest DefaultSubscriptionControllerTest
atest DisableSimFooterPreferenceControllerTest
atest MobileDataPreferenceControllerTest
atest MobileNetworkSwitchControllerTest
atest MobileNetworkUtilsTest
atest NetworkSelectSettingsTest

Change-Id: I4d473140f291daec0f8e56c01bd8f7cfa2d0c82e
2024-03-04 22:35:38 +00:00
Manish Singh
55e9f41bda Return true only if the userManager belongs to private profile
The existing code asks the main user's userManager if there's a
private profile belonging to it. If a private profile exists then the
answer to that question will always be true. So, we always end up
showing the apps from the private profile for the personal case.

We should instead ask the userManager if it belongs to the private
profile or not.

Bug: 327598131
Test: manual
Change-Id: I7bc9d58c371341235579d3456b54ea85f598892b
2024-03-04 18:26:58 +00:00
Olivier Nshimiye
b4e6f20567 Add Private Space features flag check to Settings tests
Adding this flag check since we are putting all the implementations of Private Space features behind this flag.

Bug: 326060689
Test: Run presubmits and verify that nothing breaks
Change-Id: I2c0e9a1afc3787232425f79d06d4aeba001283ec
2024-03-04 15:43:47 +00:00
SongFerng Wang
71c6c3e557 Merge changes I96574a79,I74681222 into main
* changes:
  Fix the testcase failed
  Add the log for SidecarFragment
2024-03-04 12:27:37 +00:00
songferngwang
c9a3eeb792 Fix the testcase failed
Add mock for SubscriptionManager.createForAllUserProfiles

Bug: 323652989
Test: atest MobileNetworkPreferenceControllerTest
Change-Id: I96574a79eba581db95d387f0d9c9fde2e004c41c
2024-03-04 10:58:22 +00:00
Fan Wu
8c8d310767 Fix settings/widget test failures
Also ignore color checker complain introduced by ag/26310215

Bug: 315133235

Test: atest SettingsRoboTests
Change-Id: I88081ab4bb1b01dfbd7b7a0045e2031e7170028a
2024-03-04 16:55:55 +08:00
SongFerng Wang
d94a556939 Merge "Fix SimDialogActivityTest" into main 2024-03-04 08:48:11 +00:00
Angela Wang
6089d3edd6 Merge "Replaces HearingDevicePairingDetail with HearingDevicePairingFragment" into main 2024-03-04 06:53:19 +00:00
Jacky Wang
16a99aecae Merge "[DataStore] Migrate BatteryBackupHelper to BackupRestoreStorage" into main 2024-03-04 03:58:29 +00:00
Weng Su
1a2d60a867 Merge "Ignore failed Wi-Fi unit tests" into main 2024-03-04 03:47:47 +00:00
Roy Chou
654e43b2e8 chore(magnification): remove onResume overrides for controllers in ToggleScreenMagnificationPreferenceFragment
As b/186731461, so far MagnificationModePreferenceController and other
magnification preference controllers are only used in
ToggleScreenMagnificationPreferenceFragment, which is DashboardFragment.
Since DashboardFragment already updates preference state in its
onResume, so we can remove the onResume overrides in those controllers.
Besides, we can also remove the LifeCycle dependency for the controllers
since it's not used anymore.

Bug: 186731461
Flag: NA
Test: manually
      atest ToggleScreenMagnificationPreferenceFragmentTest
      atest MagnificationAlwaysOnPreferenceControllerTest
      atest MagnificationFollowTypingPreferenceControllerTest
      atest MagnificationJoystickPreferenceControllerTest
      atest MagnificationModePreferenceControllerTest
Change-Id: I379a6a3a985c9d8b7a37bbb878b84cee1bd6adfb
2024-03-04 03:44:59 +00:00
Weng Su
777157b5b4 Ignore failed Wi-Fi unit tests
Bug: 323645528
Flag: None
Test: unit test
atest -c SettingsUnitTests:RequestToggleWiFiActivityTest \
         SettingsUnitTests:WifiDialog2Test \
         SettingsUnitTests:WifiUtilsTest

Change-Id: I8d3ddb1eb775b8758cb359cac4dac39bb9c8dfed
2024-03-04 06:07:40 +08:00
Jacky Wang
006bf17c4f [DataStore] Migrate BatteryBackupHelper to BackupRestoreStorage
Bug: 325144964
Test: Manual tests
Change-Id: I19f7c78969d70648d1e45f1627827d98b1fdd1e0
2024-03-03 22:42:00 +08:00
songferngwang
3f6d1dc3e5 Fix SimDialogActivityTest
Can't create handler inside thread

Bug: 323649089
Test: atest SimDialogActivityTest
Change-Id: I678a1a1841ab1e1cd87c358fbb3d52cbfb55dbe4
2024-03-02 14:45:47 +00:00
Chaohui Wang
bec4c9573e Create isSubscriptionEnabledFlow
To better display the isEnable checked state.

Bug: 318310357
Test: manual - on Mobile Settings
Test: unit test
Change-Id: Ia595e7445650ad67883f1e7c1a0662cb826565ea
2024-03-02 05:01:28 +00:00
Treehugger Robot
29e984b13a Merge "settings(dev): Remove NFC stack logging control" into main 2024-03-02 02:16:24 +00:00
Treehugger Robot
14f9f67df6 Merge "Make SmartBatterySettings unsearchable when it's not available." into main 2024-03-01 17:56:59 +00:00
Yiling Chuang
93c0dbf98d Make SmartBatterySettings unsearchable when it's not available.
Bug: 323915905
Test: robotest
Change-Id: I5adc9d19b482b8e07237f5c7d62d315556095c38
2024-03-01 16:28:12 +00:00
Shaowei Shen
624e1beca8 Merge "[A11y Setting] Add keyboard keys preferences under A11y page" into main 2024-03-01 13:37:03 +00:00
shaoweishen
a5f5ff4add [A11y Setting] Add keyboard keys preferences under A11y page
Bug: 325851068
Test: make RunSettingsRoboTests
Change-Id: Ic7eb1ec9e260a95d040bee784cbff479a4f087d0
2024-03-01 12:05:30 +00:00
Treehugger Robot
64f740e599 Merge "Revert "Re-enable failed tests under settings/widget/"" into main 2024-03-01 05:02:25 +00:00
Fan Wu
4826dd8c10 Revert "Re-enable failed tests under settings/widget/"
This reverts commit cfb73e2dd3.

Reason for revert:
Still failing when running the entire test suite.

Change-Id: I1783265ca8362a2e1d4b89a1d577e1c0a35bd535
2024-03-01 02:28:07 +00:00
Marcus Ge
12108acc07 Merge "[Accessibility] Add basic metrics logging for color contrast" into main 2024-02-29 21:04:23 +00:00
Kangping Dong
830d4c0b1e Merge "[Thread] add Thread toggle in settings" into main am: 522e193947 am: abd5f23fe9
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2909326

Change-Id: If086f510fe5d3b3f67b4f168f2e0d3f5e0ef98bd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-02-29 18:25:13 +00:00
Roshan Pius
a5bd1cf34f settings(dev): Remove NFC stack logging control
We are now turning on verbose logging by default.

Bug: 327517842
Test: Compiles
Change-Id: I3c6026e230c7d35f04d9771442fadbf040a84b94
2024-02-29 09:44:37 -08:00
Kangping Dong
abd5f23fe9 Merge "[Thread] add Thread toggle in settings" into main am: 522e193947
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2909326

Change-Id: I8640f2cf4a90203972a5db703ebb3e027224c746
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-02-29 17:43:51 +00:00
Kangping Dong
5fc01ddd6e [Thread] add Thread toggle in settings
Allows a user to disable or enable Thread network / radio from
settings.

In this commit, a toggle is added to Settings > Connected devices >
Connection preferences to control Thread state. See the screenshots
below:
1. Thread is on: https://screenshot.googleplex.com/7FqqbzRX6rGwvSb
2. Thread is off: https://screenshot.googleplex.com/AmfRAhzuukULAAG
3. Thread is disabled by airplane mode: https://screenshot.googleplex.com/7zcesyomrveCqFE
4. Thread is searchable: https://screenshot.googleplex.com/9yFL2jeSuEhJwrS

Requirements:
1. the in-take bug: b/327098435
2. See the screenshot above
3. Test with `atest SettingsUnitTests` and manual tests
4. +2 from Yuwen
5. Flagged by "com.android.net.thread.platform.flags.Flags.thread_enabled_platform"
6. It doesn't need B&R, no preferences are added (the state is in
   Android framework (mainline module))
7. Confirmed searchable
8. Code written in Kotlin

Bug: 296990038
Bug: 319077562
Test: atest SettingsUnitTests
Change-Id: Ifa2264b8e59a5112290fd0224cb75ad228732077
2024-02-29 18:05:49 +08:00
Yiyi Shen
e5302bc1f1 Merge "[Audiosharing] Gates legacy le audio sharing UI in sound Settings." into main 2024-02-29 09:50:42 +00:00