Commit Graph

45375 Commits

Author SHA1 Message Date
hughchen
b6ac12eed4 Update DialogFragment UI when BT device is add/remove/rename
* Add AudioSwitchCallback() in AudioSwitchPreferenceController.
  This callback is used to notify SoudSettings to update the dialogFragment UI.
* Add UpdatableListPreferenceDialogFragment that updates the available
  options when dialog is shown
* Add test to verify the adapter count when
  onListPreferenceUpdated() is called.

Bug: 77783217
Test: make -j50 RunSettingsRoboTests
Change-Id: I8cac1b30ec50df026f4b7722dd1cd2f69e77a4cb
Merged-In: I8cac1b30ec50df026f4b7722dd1cd2f69e77a4cb
2018-05-17 07:40:52 +00:00
Nathan Harold
16f37ed5f0 Merge changes from topic "pi-telephonydebugmenu" into pi-dev
am: 0cf2e41bf8

Change-Id: I21d57ebf1930cf69fed2525c5b0f12e2bc3b1953
2018-05-16 22:02:33 -07:00
Nathan Harold
1c99f9bb7e [Telephony Debug Menu] Add Physical Channel Config
am: 433ca4427c

Change-Id: I38b16e9cf6f96fd6a508141fcd8f45ccf79e25d5
2018-05-16 22:01:50 -07:00
Nathan Harold
5b861ee7d0 [Telephony Debug Menu] LTE BW and Serving CellInfo
am: 6e16fdf399

Change-Id: I9a258017786483a8c7b1f463b3ddf2468738f294
2018-05-16 22:00:56 -07:00
TreeHugger Robot
0cf2e41bf8 Merge changes from topic "pi-telephonydebugmenu" into pi-dev
* changes:
  [Telephony Debug Menu] Add Link Capacity Estimate
  [Telephony Debug Menu] Add Physical Channel Config
  [Telephony Debug Menu] LTE BW and Serving CellInfo
2018-05-17 04:45:41 +00:00
hughchen
615becb392 Update UI when BT device is rename
* Using getAliasName() instead of getName()
* Add BluetoothDevice isConnected check, when BluetoothDevice is
  disconnected. Do not add to the show list.

Bug: 77783217
Test: make -j50 RunSettingsRoboTests
Change-Id: I183fc693eaefd690568ba2f1ec740258b2bb62c8
2018-05-17 11:29:54 +08:00
Lei Yu
c409db681d Merge "Update method isSmartBatteryEnabled()" into pi-dev
am: 3feb2f87ff

Change-Id: Ia4a5ca96a43eb4b9c2ad03f1f89c3bb4e6dfa632
2018-05-16 19:56:01 -07:00
Nitin Shivpure
a7914f54df [automerger skipped] Merge "Bluetooth: Fix to avoid BluetoothPan ServiceConnection leak" am: 2d523f4e99
am: 606f1d02eb  -s ours

Change-Id: Ia68afc7be0c8a2cdb0c4cc977e7f2735cf4b9c8a
2018-05-16 19:53:26 -07:00
Nitin Shivpure
606f1d02eb Merge "Bluetooth: Fix to avoid BluetoothPan ServiceConnection leak"
am: 2d523f4e99

Change-Id: I792ff3b090d59851c459066dd00d6fdbcb6e3a26
2018-05-16 19:44:41 -07:00
TreeHugger Robot
3feb2f87ff Merge "Update method isSmartBatteryEnabled()" into pi-dev 2018-05-17 02:43:22 +00:00
Treehugger Robot
2d523f4e99 Merge "Bluetooth: Fix to avoid BluetoothPan ServiceConnection leak" 2018-05-17 01:28:02 +00:00
hjchangliao
55e51376b1 Merge "Convert Magnify controller to TogglePrefController" into pi-dev
am: cd28a977ca

Change-Id: Ic118ddc1915e26c9317f0c53edbf60539fc78534
2018-05-16 18:10:56 -07:00
TreeHugger Robot
cd28a977ca Merge "Convert Magnify controller to TogglePrefController" into pi-dev 2018-05-17 00:43:04 +00:00
Matthew Fritze
4381e162f2 Merge "Clean-up settings slices" into pi-dev
am: d0888e9e5b

Change-Id: I673981e5f200b0d97649d4efcfbe69eb73bbd765
2018-05-16 17:33:28 -07:00
TreeHugger Robot
d0888e9e5b Merge "Clean-up settings slices" into pi-dev 2018-05-17 00:26:32 +00:00
Daniel Nishi
a224cb4aaa Merge "Darken the secondary text on storage items." into pi-dev
am: 0226c4d39d

Change-Id: Ie3b9acaa9b4390ecb4ec21e3bc19a4456b8b31cb
2018-05-16 17:25:09 -07:00
TreeHugger Robot
0226c4d39d Merge "Darken the secondary text on storage items." into pi-dev 2018-05-17 00:13:05 +00:00
Andreas Terzis
4b31e19522 Merge "Increase the char limit of carrier_and_update_now_text to 34." into pi-dev
am: 6eb1d9ed90

Change-Id: I0451cda170f6e286dda1213ebaec3bc846e49022
2018-05-16 16:49:50 -07:00
Andreas Terzis
6eb1d9ed90 Merge "Increase the char limit of carrier_and_update_now_text to 34." into pi-dev 2018-05-16 23:44:35 +00:00
Mehdi Alizadeh
84586334b2 Merge "Moves Swipe Up overlay from Settings app to android.internal" into pi-dev
am: 9a93a1dbe9

Change-Id: I07e9841b959cc1332d51312671bbdfaaef844c7c
2018-05-16 16:42:52 -07:00
Nitin Shivpure
75787c8a77 Merge "Bluetooth: Fix to avoid BluetoothPan ServiceConnection leak" into pi-dev
am: d924894652

Change-Id: Ia7a01f35e8a231cf53b481e71266982359a810cf
2018-05-16 16:41:43 -07:00
TreeHugger Robot
9a93a1dbe9 Merge "Moves Swipe Up overlay from Settings app to android.internal" into pi-dev 2018-05-16 23:38:31 +00:00
TreeHugger Robot
d924894652 Merge "Bluetooth: Fix to avoid BluetoothPan ServiceConnection leak" into pi-dev 2018-05-16 23:28:28 +00:00
Matthew Fritze
caf745ea13 Merge "Set slice summary text to screentitle first" into pi-dev
am: e7f321c3c0

Change-Id: Ib351491d18ef9fb057fffebf7c1bc2b90c3a917b
2018-05-16 16:08:00 -07:00
TreeHugger Robot
e7f321c3c0 Merge "Set slice summary text to screentitle first" into pi-dev 2018-05-16 22:51:55 +00:00
Nathan Harold
f10ea32d55 [Telephony Debug Menu] Add Link Capacity Estimate
Register for the Link capacity estimate for the
cellular default data connection and report it
in the debug menu.

Bug: 78791811
Test: manual
Change-Id: I73d945dfa192873936107902e0de6d58fc69059b
2018-05-16 15:44:27 -07:00
Nathan Harold
433ca4427c [Telephony Debug Menu] Add Physical Channel Config
Add a field to display the PhyChanConfig and register
for this event as part of the PhoneStateListener.

Bug: 78791811
Test: manual
Change-Id: Ic038aa65655f8efa98bf1d6388e7c61761d2eb4a
2018-05-16 15:44:24 -07:00
Nathan Harold
6e16fdf399 [Telephony Debug Menu] LTE BW and Serving CellInfo
Add debug menu support for the serving cell status
indication and the LTE bandwidth in the CellInfo
display.

Bug: 78791811
Test: manual
Change-Id: Ic51858131af671317431e0970bdcaeebcb460931
2018-05-16 15:40:59 -07:00
Daniel Nishi
e5a006f61b Darken the secondary text on storage items.
This darkens the X.XX GB text on the storage items to improve the
contrast between the text and the background color.

Bug: 79754437
Test: Manual
Change-Id: Icc44a97d810cd1aea22438f38e5e97ddb7b8e43d
2018-05-16 15:34:34 -07:00
Nitin Shivpure
5ba33d1fd3 Bluetooth: Fix to avoid BluetoothPan ServiceConnection leak
Usecase:
1.) Make sure BT is turned off.
2.) Go to Settings -> Network & Internet
3.) Press back  from Network & Internet.
4.) Repeat above step 2000 times

Expected Result:
No ANR/Crashed should be seen.

Observed Result:
ServiceConnection leak is happening & android setting app get crashed.

Root cause: TetherPreferenceController tries to get
pan Proxy object, when BT is oFF, which is leaking one
service connection each time

Fix: getProfileProxy for Pan must only be called, when BT is
      turned on.

Test: lifeCycle_onCreate_shouldNotInitBluetoothPanWhenBluetoothOff

Bug: 79561076
Change-Id: I85208f48ce4dded94020cb156fcdb98b2cc873f9
Merged-In: I85208f48ce4dded94020cb156fcdb98b2cc873f9
2018-05-16 15:25:36 -07:00
Nitin Shivpure
1b0afb9d1c Bluetooth: Fix to avoid BluetoothPan ServiceConnection leak
Usecase:
1.) Make sure BT is turned off.
2.) Go to Settings -> Network & Internet
3.) Press back  from Network & Internet.
4.) Repeat above step 2000 times

Expected Result:
No ANR/Crashed should be seen.

Observed Result:
ServiceConnection leak is happening & android setting app get crashed.

Root cause: TetherPreferenceController tries to get
pan Proxy object, when BT is oFF, which is leaking one
service connection each time

Fix: getProfileProxy for Pan must only be called, when BT is
      turned on.

Test: lifeCycle_onCreate_shouldNotInitBluetoothPanWhenBluetoothOff

Bug: 79561076
Change-Id: I85208f48ce4dded94020cb156fcdb98b2cc873f9
(cherry picked from commit 31bcf6225cdabee4f810d4fe55ea32d0d43a9c5c)
(cherry picked from commit 31c799305b480e56bd083a48c6acca11572ebe16)
2018-05-16 15:22:56 -07:00
Fan Zhang
afb17b6ed1 Merge "Move app setting link from Entity header to pref controller" into pi-dev
am: e3319d0449

Change-Id: I5cbc1dc4dfab9df74bca3bda824d38d3b4b778f6
2018-05-16 14:08:25 -07:00
TreeHugger Robot
e3319d0449 Merge "Move app setting link from Entity header to pref controller" into pi-dev 2018-05-16 20:51:17 +00:00
Fan Zhang
4b04ba5903 Do not perform device index before device provision.
Bug: 79841744
Test: robotests
Change-Id: I74243b6f31364220156e91fe63b56138a0240714
2018-05-16 13:26:24 -07:00
Fan Zhang
cac18e12ac Move app setting link from Entity header to pref controller
Change-Id: I13a27486a9c9b4c4fb358715d678473e63c1b624
Merged-In: I13a27486a9c9b4c4fb358715d678473e63c1b624
Fixes: 79688822
Test: robotest
2018-05-16 19:56:33 +00:00
Andreas Terzis
251bcbec13 Increase the char limit of carrier_and_update_now_text to 34.
The translation of the carrier_and_update_now_text field
in some European languages requires 34 characters. To
accomodate these requirements increase the character
limit from 30 to 34.

Bug: 76443102
Test: manual
Change-Id: I61c95fc6c30bd98d6b418047ae7cc1f2423a12e0
2018-05-16 12:35:25 -07:00
joeshih
421b0cf526 Merge "Support Vibrate for calls in Settings Slices" into pi-dev
am: a0f9241400

Change-Id: Ib77fc8257bfb4a00368735504558c6b27a95ec17
2018-05-16 11:58:11 -07:00
TreeHugger Robot
a0f9241400 Merge "Support Vibrate for calls in Settings Slices" into pi-dev 2018-05-16 18:48:14 +00:00
Beverly
3f42a23816 Get rid of divider above ringtone selector
Change-Id: I939d1ab061fb55853fbc0505b8d9025715b9df97
Fixes: 79480349
Test: manual
2018-05-16 14:28:15 -04:00
hughchen
14ce329377 Merge "Change string from "Add device" to "Pair new device"" into pi-dev
am: 46338558e1

Change-Id: I5fa291ba3677398efcfe0f5b89f10df24463a3fa
2018-05-16 10:47:40 -07:00
TreeHugger Robot
46338558e1 Merge "Change string from "Add device" to "Pair new device"" into pi-dev 2018-05-16 17:32:38 +00:00
Joshua Mccloskey
c7123d4b0e Merge "Fixed accessibility bug in choose_lock_pattern_common.xml where title was not always read" into pi-dev
am: d819dbacb6

Change-Id: I4041083c976c506ed1848c91c6a19e470b4d2766
2018-05-16 10:03:45 -07:00
hughchen
52feedf354 Bluetooth and NFC added back to Connection preferences
* Bluetooth and NFC added back to "Connection preferences"

Bug: 79299421
Test: make -j50 RunSettingsRoboTests
Change-Id: I8f4c389c28c7cc752f198be2b59b28b6e9af2c90
Merged-In: I8f4c389c28c7cc752f198be2b59b28b6e9af2c90
2018-05-16 17:03:31 +00:00
Joshua Mccloskey
d819dbacb6 Merge "Fixed accessibility bug in choose_lock_pattern_common.xml where title was not always read" into pi-dev 2018-05-16 16:49:14 +00:00
hjchangliao
a92271c26d Convert Magnify controller to TogglePrefController
Convert below to TogglePreferenceController:
MagnificationNavbarPreferenceController
(Magnify with Button)
MagnificationGesturesPreferenceController
(Magnify with triple-tap)

The two controllers share the same fragment,
Add static method for set/get state in fragment,
And use them in controllers and fragment.

Change-Id: I2bdbdb36be71e1a3ffb557abc5a6115d48de53cf
Merged-In: I2bdbdb36be71e1a3ffb557abc5a6115d48de53cf
Fixes: 67997698
Fixes: 67997726
Test: make RunSettingsRoboTests
2018-05-16 16:45:47 +00:00
Matthew Fritze
7d565e97a3 Clean-up settings slices
- Set TTL to Infinity
- Set color of each slice to color accent

Change-Id: I7de4530880725ba3282602135bdc1fa85d786905
Fixes: 79780418
Test: robotests
2018-05-16 08:20:05 -07:00
Matthew Fritze
f9c13fc305 Set slice summary text to screentitle first
To improve context on search surfaces where the
setting may be ambiguous, we set the screentitle
as the summary text as the top priority. If there is
no screentitle or the it matches the title, then we
try to use the controller summary. If the controller
summary is not valid, then we show nothing.

Bug: 79780762
Test: robotests
Change-Id: If4f7f8d4a072125604ede14e3df2afd667fa24b7
2018-05-16 08:13:22 -07:00
Beverly
df1614f7f1 Merge "DO NOT MERGE Update zen onboarding" into pi-dev
am: b7b355a1c5

Change-Id: Ia5360d8576f97db9b2eb8db6b3b9dff029811e2b
2018-05-16 06:33:05 -07:00
TreeHugger Robot
b7b355a1c5 Merge "DO NOT MERGE Update zen onboarding" into pi-dev 2018-05-16 13:24:39 +00:00
hughchen
4e0e3c83e8 Change string from "Add device" to "Pair new device"
Change string from "Add device" to "Pair new device"

Bug: 79298886
Test: Build pass
Change-Id: Iac4e251d5fab794f90e98911208f026d62b91659
2018-05-16 19:17:06 +08:00