handlePreferenceTreeClick() goes after setChecked() however
configuration may have been altered within setChecked().
Follow same design within MobileDataPreferenceController to fix this
issue. A boolean state will be maintained as the condition when warning
dialog is required when click.
Bug: 148491064
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=RoamingPreferenceControllerTest
Change-Id: I63c4e2149b0e9efa16fd9ee402652c67eb9c5a4d
When we get an empty or null slice parameter,
we see it as a vulnerability. It will cause
null point exception.
Bug: 122836081
Test: See adb logcat event log
Change-Id: Id5ff11dd18b19184792be466aabb65229f777e81
These preferences are for user to toggle a specific tethering option,
like USB, BT or WIFI.
Bug: 147323306
Test: CodeInspectionTest, AllInOneTetherSettingsTest, TetherEnablerTest
Change-Id: I1229ffd2dd12b39e9c6e48dc29c6e46ce9ad7634
Adjust the ordering of accessing to avoid the rule checks
isVoLteProvisioned() when not required.
Bug: 140542283
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=Enhanced4gLteSliceHelperTest
Change-Id: I8604a27d211895a6b33e0f6d0d78f5772912ee01
ag/10257734 change band convert to general design.
Fix test to match new design
Bug: 149251992
Test: make RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.wifi
Test: make RunSettingsRoboTests ROBOTEST_FILTER=CodeInspectionTest
Change-Id: I6f09d9d4f440515fb51a237d966327e232fe5928
This reverts commit 0149363a39.
Reason for revert: Droidcop: Potential culprit for Bug 149209670- verifying through Forrest before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.
Change-Id: Ia1f1ce35ef5d93664cf665bea86a472376b84aab
Redirect some SubscriptionManager access to ProxySubscriptionManager.
This will reduce some access latency.
Bug: 141833767
Test: manual
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=DataUsageSummaryPreferenceControllerTest
Change-Id: I2cb30dd0570a09543a13ca01cf054ba2d18d70d4
Fix IllegalStateException: Credential or HomeSP are not initialized
by setting credential to PasspointConfiguration.
Bug: 149180590
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.wifi
Change-Id: I14edefaa938f1aeb43b493d24aca3f810ab89593
This CL before, the bt device still showing on
"previously connected devices" after forgot that bt device.
It because the list of getMostRecentlyConnectedDevices()
will not include BOND_NONE device. We need to remove the
device that not include in list of getMostRecentlyConnectedDevices() .
This CL add removePreferenceIfNecessary() to check the device whether
is contained in getMostRecentlyConnectedDevices(). If not, remove the
preference.
Bug: 149193092
Test: make -j42 RunSettingsRoboTests
Change-Id: I94bedf222b64d9f05dc6f979b79dbc8794c0f97d
Summary appends "and more" while the items of permission are larger
than 3.
Change-Id: Ic3c16404237fb0cb81f0ed5d2cbdff32cf23c452
Fix: 136258315
Test: Robo test and visual
This reverts commit 94b8055f1c.
Reason for revert: Revert this cl and fix broken test cases.
Change-Id: I61a190b4beba8db2fe2faab45e5dd6921dc681ec
Fix: 149112222
Fix: 149090275
Test: Run all Setting robo tests
Fix broken test: com.android.settings.wifi.WifiSettingsTest.
PasspointConfiguration objects require both HomeSp and Credential
objects initialized, and since today it is enforced in the Wi-Fi API.
Updated the test mocks to initialize the Credential object which was
missing.
Bug: 149175146
Test: make RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.wifi.WifiSettingsTest
Change-Id: I709a6bc104141ac88b2c88bdac4f3a9a3d296ec9
This CL include following change:
- Add null check of cacedBluetoothDevice, cachedBluetooth could be null
if the input BluetoothDevice can't found in
CachedBluetoothDeviceManager.
- Move addPreference() and removePreference() to update() method,
because update() will be called to update UI when recevice Bluetooth
device change event.
- Add test case to test CachedBluetoothDevice null check.
Bug: 149068434
Test: make -j42 RunSettingsRoboTests
Change-Id: I90016bf1175925821b0d9b634c62cf796289a734
This CL before, the volume bar will shown on the top device.
In this CL, the volume bar will shown on the active device.
Bug: 148765806
Test: manually
Change-Id: Id261201a4227151667c67ab91864cc349941372e
