PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
44,509 Commits 1 Branch 0 Tags
60aa99a95c26c5aec541ae346f6b072fc914b0c7
Commit Graph

7 Commits

Author SHA1 Message Date
Julia Reynolds
e2897aedf5 Fix crash on rotation 
Load app/channel data early so that any open dialogs can be properly
reconstructed. Never call done on an entityheadercontroller with
an activity that's not yet started.

Test: robotests
Change-Id: Ib2b9f8f1985ef038959062204aaceff686f4ebcf
Fixes: 74114917
 2018-04-19 10:17:23 -04:00
Julia Reynolds
d7815fe18f Notification settings updates 
- smaller icons
- text update
- fx header
- fix category header

Test: make -j RunSettingsRoboTests

Change-Id: If822d6db31a8dccf20ee88182cda1aee34aa7675
Fixes: 77325154
Fixes: 77323406
Fixes: 77324677
Fixes: 74408368
 2018-04-09 17:24:09 -04:00
Fan Zhang
1781cf2cef Remove wrapper class for NotificationGroup. 
It's no longer needed as Robolectric can natively support framework
classes

Bug: 76167422
Test: robotests
Change-Id: If0ac597370240b8efaa8df8783a5c309a2322a3f
 2018-03-30 16:09:34 -07:00
Fan Zhang
04f1423bfa Remove custom updateState() if it's just setting summary 
Change-Id: I6311d67d6ba11961a6814b91dcd8e37a2e17df40
Fixes: 73950519
Test: rerun robotests
 2018-02-28 15:22:09 -08:00
Fan Zhang
906572b127 Change PreferenceController#getSummary return type. 
Return CharSequence instead of String.

All user visible string should be modeled as CharSequence.

Bug: 73950519
Test: robotest
Change-Id: I30befef0c33f94351d4a2774e283bd1ed804aa8b
 2018-02-27 22:30:12 -08:00
Matthew Fritze
c69f73f4d1 Support getDynamicSummary in BasePreferenceController 
Adds dynamic summary getter in relevant BasePreferenceControllers.
Preferece controllers that don't have dynamic summaries or which
are not yet BasePreferenceControllers are not changed right now.

Change-Id: I435ccab7758d90515583fd8ca10a9b1ef0c858b9
Fixes: 71514936
Test: robotests
 2018-01-04 13:58:01 -08:00
Julia Reynolds
ac3f7e80dc PreferenceControllers are the way of the future. 
Migrates Notification settings (app level, group level, and channel
level) into PreferenceControllers (and most importantly:
PreferenceControllerTest)

Note: this removes the 'Advanced' preference group, but does
not yet use the standard system 'Advanced' grouping as it does
not currently support our use case (where we don't know how many
fields to show outside of 'Advanced' until onResume() and also
where we need fields to show below the 'Advanced' group).

Test: make RunSettingsRoboTests
Change-Id: Iddd1b4771922db322e5f73562e9d63ed077c5396
 2017-11-06 13:50:26 -05:00