Commit Graph

77692 Commits

Author SHA1 Message Date
Neil Fuller
94a64d6139 Fix search test using location_settings
Second attempt to proactively fix a search test.

SearchIndexableResourcesTest uses the FakeIndexProvider, which
implicitly assumes that the
robotests/res/xml-mcc999/location_settings.xml xml is in use. Without
it, the test is accessing the real location_settings.xml / real
preference controllers. This  was working until now, but by luck and
probably not intent.

There is an upcoming change which will break the test, so this fixes the
test ahead of time.

This change updates the test to use the "mcc999" config, and improves
the docs around FakeIndexProvider to try to make the requirements for
use clearer.

Bug: 171371424
Test: m RunSettingsRoboTests
Change-Id: I868d191281a2030fa49134893bcd6720f757ea91
2020-10-22 15:46:39 +01:00
Neil Fuller
d11f93babe Revert "Stop search tests using location_settings"
This reverts commit b71f7af512b506ee74f75f92a1cc254018c3c924.

Bug: 171371424
Test: m -j30 RunSettingsRoboTests
Change-Id: Id483ca41d3aced0893f0eff370270b5010eb8a7a
2020-10-22 15:38:23 +01:00
Tsung-Mao Fang
757e756896 Refine search ui and avatar based on spec am: ebc3a3e881
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12898361

Change-Id: I4fb8835f9b4964332bca7fc0a9cdac346a88bbd7
2020-10-22 14:12:22 +00:00
Bill Yi
b0cb20f643 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I44ced221aa06d7e94415837f7ebeb9cc188113e0
2020-10-22 10:18:58 +00:00
Tsung-Mao Fang
ebc3a3e881 Refine search ui and avatar based on spec
This is the first version, we will keep tweaking
the details later.

Bug: 171278055
Test: Screenshot - https://screenshot.googleplex.com/ApRgDZknkvX9PWo
Change-Id: Ie99cf9e187aa2440486cc2eae90e04287daf0a1d
2020-10-22 18:07:20 +08:00
Bill Yi
eeaa6e4eaf Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: If13f8df62726ec63be5165fa8c8ee55d24c958c4
2020-10-22 09:38:52 +00:00
Hall Liu
17ba8166a3 Replace TelephonyManager methods for mobile data
TelephonyManager had a minor refactor of some of the methods revolving
around mobile data. Change code in Settings to use the new ones instead.

Exempt-From-Owner-Approval: Cherry-picked from internal
Bug: 169367013
Test: existing unit tests, manual
Change-Id: I7ebae37373d53fb2c59b6b546232dbddf77398d4
Merged-In: I7ebae37373d53fb2c59b6b546232dbddf77398d4
2020-10-21 23:38:20 +00:00
Sally
9fe91b9ac8 Add activity for directly navigating to Reduce Bright Colors setting
page

This will be used by the QS tile

Test: builds
Bug: b/128465252
Change-Id: Icdc5d96f4f931b825fa0dd33a0ec20936d9ce4ea
2020-10-21 23:09:03 +00:00
Sally
b9ff672a31 Add a setting page for Reduce Bright Colors under A11y
This is essentially a copy page of ToggleDaltonizerPreferenceFragment.
We extend ToggleFeaturePreferenceFragment to maintain consistency with
other shortcut assignable a11y feature.

UI is a draft

This CL:
1) allows users to enabled/disable RBC with the a11y shortcut (button,
gestures, volume keys), if assigned
2) adds a slider and persist switch to the template
ToggleFeaturePreferenceFragment page (which already contains a feature
switch, shortcut preference, and footer description)
3) enables/disables the intensity slider when RBC is on/off
4) sets placeholders for calling into ColorDisplayService in
controllers and tests
5) follows convention set by other color transformations settings and
places feature under Experimental section in A11y settings page if
transformations can't be efficiently performed by hardware

Test: A11y setting and page appears, tested activation with shortcut,
preference controller tests
Bug: b/128465252

Change-Id: I291bb86ce3d855ce052ca70dc7a941a888e2c723
2020-10-21 23:08:53 +00:00
Julia Reynolds
0aef57d67e Add 'Recent Conversations' to the conversation page
Test: atest
Bug: 171191376
Change-Id: Id7208312dff0cc022c2f16b3872fae1a9dc09ed7
2020-10-21 16:39:04 -04:00
Weng Su
f914e34d28 Fix the Wi-Fi detailed settings un-editable issue.
- The WifiEntry info might not be ready in early stage. (ex:
WifiEntry#canSetPrivacy())

- The Wi-Fi detailed setting listens to the WifiEntry callback to
refresh the preferences, it should first update the preference status to
be editable or not, and then display preferences to the UI.

- The privicy preference should be able to set back to selectable when
WifiEntry#canSetPrivicy() change from false to true.

Bug: 170148009
Test:
make RunSettingsRoboTests
ROBOTEST_FILTER=WifiNetworkDetailsFragment2Test
make RunSettingsRoboTests
ROBOTEST_FILTER=WifiPrivacyPreferenceController2Test

Change-Id: I48ca060e6b468232f19c82e9de0ce4fce39cba7f
Merged-In: I567b2b80163631a01d165c0ac5c0aba392e014ef
2020-10-21 16:39:58 +00:00
Neil Fuller
bf8f57e53c Merge "Stop search tests using location_settings" am: c79680cbae
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12884935

Change-Id: Ia41d2bff5aa5e239bd21fba69057427629099abf
2020-10-21 11:30:13 +00:00
Neil Fuller
c79680cbae Merge "Stop search tests using location_settings" 2020-10-21 11:21:29 +00:00
Neil Fuller
c970f4d79c Stop search tests using location_settings
Stop robolectric search tests using location_settings, use
sound_settings instead.

The choice of location_settings.xml seems arbitrary, and there's a
commit coming which means one of the controllers doesn't just use
settings to check availability. When the unconfigured mock returns null
from a method, that causes the test to fail in a non-obvious way.

Bug: 171371424
Test: m RunSettingsRoboTests
Change-Id: I4d3386e3c62fb4151e4a4e27625edccec89316d9
2020-10-21 09:25:57 +00:00
Bonian Chen
702e099f64 Merge "[Settings] Only display 1 SIM UI when multiple with same group UUID" am: d682b2cc57
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12886476

Change-Id: I38cc482ef22287d245f2a899ec1ecbf67feba4f4
2020-10-21 09:01:50 +00:00
SongFerng Wang
1882643152 Merge "To fix bug, summary is wrong if nr_enabled_bool=false" into rvc-qpr-dev am: 3e5defe561 am: 9493731935 am: c023d49669
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12875667

Change-Id: Ib134155bba21109b38c997e4af5c15132498849c
2020-10-21 09:01:38 +00:00
Bonian Chen
d682b2cc57 Merge "[Settings] Only display 1 SIM UI when multiple with same group UUID" 2020-10-21 08:37:37 +00:00
SongFerng Wang
c023d49669 Merge "To fix bug, summary is wrong if nr_enabled_bool=false" into rvc-qpr-dev am: 3e5defe561 am: 9493731935
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12875667

Change-Id: I3b06b785b0ae6d907f7cd6f09d7830c5b8cdb0c3
2020-10-21 08:36:22 +00:00
SongFerng Wang
9493731935 Merge "To fix bug, summary is wrong if nr_enabled_bool=false" into rvc-qpr-dev am: 3e5defe561
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12875667

Change-Id: I2b69a34d035e70cbc1bea9a2482be876eeabda66
2020-10-21 08:19:13 +00:00
SongFerng Wang
3e5defe561 Merge "To fix bug, summary is wrong if nr_enabled_bool=false" into rvc-qpr-dev 2020-10-21 08:05:48 +00:00
Bonian Chen
a6b249d625 [Settings] Only display 1 SIM UI when multiple with same group UUID
Some carrier(s) expand their service through providing eSIM in companion
with pSIM. Group UUID is designed to group them together as an single
SIM.

Bug: 165363542
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SubscriptionsPreferenceControllerTest
Change-Id: I0934a45a2917ab106627c733162efbee9a13f216
2020-10-21 13:31:04 +08:00
Jeremy Goldman
f8cd4e183c Merge "Update JUnit test readme to include atest command." am: 29c4b84312
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12888277

Change-Id: I4e19a3a763e58a57c1310f16cc2e2f5b0c5bdfa8
2020-10-21 04:17:40 +00:00
Treehugger Robot
8d73b29cec Merge "Highlight the MMS messages preference for ACTION_MMS_MESSAGE_SETTING" am: 21846b228b am: 0a2c406023 am: d719de84c1 am: e3dd9644b6 am: ce272a0bb0
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1405190

Change-Id: Ice7698f46f653483b61c14462b5eb258a93ab75c
2020-10-21 04:14:48 +00:00
Jeremy Goldman
29c4b84312 Merge "Update JUnit test readme to include atest command." 2020-10-21 04:08:21 +00:00
Treehugger Robot
ce272a0bb0 Merge "Highlight the MMS messages preference for ACTION_MMS_MESSAGE_SETTING" am: 21846b228b am: 0a2c406023 am: d719de84c1 am: e3dd9644b6
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1405190

Change-Id: Ie12fb48d3d17f6299ecc8be2000bc8e9142275aa
2020-10-21 04:02:19 +00:00
Yanting Yang
35a4b76108 Merge "Remove subtitles for the homepage IA" am: 3f92484ce8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12846875

Change-Id: I6007bea78716652c95abfd56775e198c002c4328
2020-10-21 03:53:15 +00:00
Treehugger Robot
e3dd9644b6 Merge "Highlight the MMS messages preference for ACTION_MMS_MESSAGE_SETTING" am: 21846b228b am: 0a2c406023 am: d719de84c1
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1405190

Change-Id: I3005a83ba8d27238d2fbd883d77b4a20432cabc6
2020-10-21 03:53:00 +00:00
Yanting Yang
3f92484ce8 Merge "Remove subtitles for the homepage IA" 2020-10-21 03:24:31 +00:00
Treehugger Robot
d719de84c1 Merge "Highlight the MMS messages preference for ACTION_MMS_MESSAGE_SETTING" am: 21846b228b am: 0a2c406023
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1405190

Change-Id: I91608590cc7b0255706d0ea4bdc896a778e72b8b
2020-10-21 03:21:48 +00:00
Treehugger Robot
0a2c406023 Merge "Highlight the MMS messages preference for ACTION_MMS_MESSAGE_SETTING" am: 21846b228b
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1405190

Change-Id: I195b2215ba250f7831de87d6b325560712fa8112
2020-10-21 02:52:54 +00:00
Treehugger Robot
21846b228b Merge "Highlight the MMS messages preference for ACTION_MMS_MESSAGE_SETTING" 2020-10-21 02:40:55 +00:00
Jeremy Goldman
8ab555fbde Merge "Move JUnit tests not from telephony settings into legacy directory." am: ce3f58cc68
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12876818

Change-Id: Ie4c4deb593cd7a5cf3af82d7d26776ef4064792e
2020-10-21 02:31:33 +00:00
TreeHugger Robot
5d1e33a9d7 Merge "Fix the Wi-Fi detailed settings un-editable issue." am: 7eac52422e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12875664

Change-Id: Ibea7671490cb650254a4121b3fe5d232de34f6aa
2020-10-21 02:30:38 +00:00
Jeremy Goldman
ce3f58cc68 Merge "Move JUnit tests not from telephony settings into legacy directory." 2020-10-21 02:25:27 +00:00
Jeremy Goldman
ce46d9be6b Update JUnit test readme to include atest command.
Test: N/A
Change-Id: I4c4521ad8077ce120e415afe2907cc26f63e3206
2020-10-21 02:21:54 +00:00
TreeHugger Robot
7eac52422e Merge "Fix the Wi-Fi detailed settings un-editable issue." 2020-10-21 02:07:48 +00:00
Treehugger Robot
978e1ac879 [automerger skipped] Merge "Merge redfin/bramble support." am: 7881b23f1f -s ours am: bda0c67436 -s ours am: 9d867703c5 -s ours am: f2f13ca90a -s ours am: bde04e31cd -s ours
am skip reason: Change-Id I600c63a996b1684a2b801787d88974501062c073 with SHA-1 38747f76f3 is in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1465940

Change-Id: I21581a274588f2b2501244ff2c63bd536b903e88
2020-10-20 21:18:54 +00:00
Treehugger Robot
bde04e31cd [automerger skipped] Merge "Merge redfin/bramble support." am: 7881b23f1f -s ours am: bda0c67436 -s ours am: 9d867703c5 -s ours am: f2f13ca90a -s ours
am skip reason: Change-Id I600c63a996b1684a2b801787d88974501062c073 with SHA-1 38747f76f3 is in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1465940

Change-Id: Iaafef64fa7464e64ecc985ccdeb2632745f68990
2020-10-20 21:08:05 +00:00
Weng Su
3a45d054eb Fix the Wi-Fi detailed settings un-editable issue.
- The WifiEntry info might not be ready in early stage. (ex:
WifiEntry#canSetPrivacy())

- The Wi-Fi detailed setting listens to the WifiEntry callback to
refresh the preferences, it should first update the preference status to
be editable or not, and then display preferences to the UI.

- The privicy preference should be able to set back to selectable when
WifiEntry#canSetPrivicy() change from false to true.

Bug: 170148009
Test:
make RunSettingsRoboTests
ROBOTEST_FILTER=WifiNetworkDetailsFragment2Test
make RunSettingsRoboTests
ROBOTEST_FILTER=WifiPrivacyPreferenceController2Test

Change-Id: I567b2b80163631a01d165c0ac5c0aba392e014ef
2020-10-21 04:30:09 +08:00
Treehugger Robot
f2f13ca90a [automerger skipped] Merge "Merge redfin/bramble support." am: 7881b23f1f -s ours am: bda0c67436 -s ours am: 9d867703c5 -s ours
am skip reason: Change-Id I600c63a996b1684a2b801787d88974501062c073 with SHA-1 38747f76f3 is in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1465940

Change-Id: I3886e4ba36d6361c60f65e28cde49fc7dd83cd1f
2020-10-20 20:18:23 +00:00
Treehugger Robot
9d867703c5 [automerger skipped] Merge "Merge redfin/bramble support." am: 7881b23f1f -s ours am: bda0c67436 -s ours
am skip reason: Change-Id I600c63a996b1684a2b801787d88974501062c073 with SHA-1 38747f76f3 is in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1465940

Change-Id: Ie60eb5b5524b59ab0f8b2aa4079c08a685b02577
2020-10-20 19:34:05 +00:00
Treehugger Robot
bda0c67436 [automerger skipped] Merge "Merge redfin/bramble support." am: 7881b23f1f -s ours
am skip reason: Change-Id I600c63a996b1684a2b801787d88974501062c073 with SHA-1 38747f76f3 is in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1465940

Change-Id: I70a4a5ebc491947ec7d9205d54301eb5dc28f4b9
2020-10-20 19:03:54 +00:00
Yanting Yang
9aa4a5463f Remove subtitles for the homepage IA
Remove the summary of the homepage IA if silky home enabled.

Fixes: 170933968
Test: robotest & visual with turning on/off silky home
Change-Id: I502b6590cece9b80e9923109fe0582cc4d9a1c56
2020-10-20 23:54:03 +08:00
TreeHugger Robot
524119e2e8 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" am: 58a2df3eae -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12884480

Change-Id: I1ba970e20bb4867f351361f68dbb057f4386eb2b
2020-10-20 15:53:31 +00:00
Bill Yi
6d93ee65a1 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 0e41e1a5d4 -s ours am: 1300825559 -s ours am: 13afb7d70d -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12883569

Change-Id: I532269acfcd554f816775f754069cb13cfbf1b06
2020-10-20 15:53:18 +00:00
TreeHugger Robot
58a2df3eae Merge "Import translations. DO NOT MERGE ANYWHERE" 2020-10-20 15:48:56 +00:00
Bill Yi
13afb7d70d [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 0e41e1a5d4 -s ours am: 1300825559 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12883569

Change-Id: I9b1e907f8e193d55f6962a0fa6a7ef4618b8797a
2020-10-20 15:32:33 +00:00
Bill Yi
1300825559 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 0e41e1a5d4 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12883569

Change-Id: I5148aa870c196f4dc41af2fd397db38ca6a03fe9
2020-10-20 15:26:42 +00:00
Bill Yi
8995e8b9e9 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I60fe8a4ec1b33665a298365ac74d7622825d3ba7
2020-10-20 06:19:23 -07:00
SongFerngWang
706036e5b3 To fix bug, summary is wrong if nr_enabled_bool=false
The carrier config nr_enabled_bool is false, preferred network mode
should hide 5G UI. This bug is that the summary show 5G item when
nr_enabled_bool is false.
Solution: if nr_enabled_bool is false, it checks capability and then
removes 5G capability of network mode.

Bug: 170460943
Test: make RunSettingsRoboTests ROBOTEST_FILTER=\
EnabledNetworkModePreferenceControllerTest   (PASS)
Change-Id: I3f7d41c196569c0cb61e89cfc270b957e2f0add5
2020-10-20 13:07:59 +00:00