Commit Graph

25270 Commits

Author SHA1 Message Date
TreeHugger Robot
5d0d664ae2 Merge "Bar chart preserves data before rotating device" 2019-02-27 06:39:07 +00:00
TreeHugger Robot
3776476764 Merge "Use ThemedBatteryDrawable in settings" 2019-02-27 06:02:49 +00:00
tmfang
44e5aeca65 Bar chart preserves data before rotating device
We saw chart view is gone while rotating device.

Fow now, we save the old permission data before
fragment was recreated.
Then, we can initialize the view quickly with
old data.

Test: robotest, visual
Fixes: 123539793
Change-Id: I230fecc6001a17a0c0205f2a1dcb5dd79f32e744
2019-02-27 11:25:35 +08:00
Rich Cannings
03908ded19 Merge "Refactor passwords/pins/patterns to byte[]" 2019-02-27 03:21:57 +00:00
Kevin Chang
40d496471a Merge "Duplicate dark mode settings to accessibility display settings" 2019-02-27 03:15:39 +00:00
TreeHugger Robot
b80a409a21 Merge "Create a preference controller for "App info"" 2019-02-27 03:02:46 +00:00
TreeHugger Robot
db6e6629b4 Merge "Guard NPE in RingtonePrefController" 2019-02-27 01:51:18 +00:00
Kevin Chang
a78b9222b0 Duplicate dark mode settings to accessibility display settings
Bug: 123227114
Test: Manual
      make RunSettingsRoboTests ROBOTEST_FILTER=AccessibilitySettings
Change-Id: Icb60bc18e31377a2e73780004bd1bdea7bc96eea
2019-02-27 09:18:40 +08:00
Sunny Shao
d5a04e1912 Merge "Handle the IllegalStateException" 2019-02-27 00:25:46 +00:00
Fan Zhang
f1b5989706 Guard NPE in RingtonePrefController
Fixes: 126416474
Test: robotests
Change-Id: I02d0279ae107e7c03668849beaea8aa0463b4da6
2019-02-26 15:45:17 -08:00
Rich Cannings
b27c4308a2 Refactor passwords/pins/patterns to byte[]
Relating to packages/apps/Settings

Bug: 120484642
Test: manual - test setting and unlocking passwords/pins/patterns.
      automated - 20 of about 500 tests fail due to fragile synthetic
      password test code.

Change-Id: Idec8338d141c185bef67ade12035fdb2fa9d17ea
2019-02-26 14:46:12 -08:00
Fan Zhang
98f58f9102 Merge "Make Serial number preference a copyable slice." 2019-02-26 22:36:18 +00:00
TreeHugger Robot
1d3dbbce85 Merge "Include uid in device admin pref id." 2019-02-26 22:14:56 +00:00
Fan Zhang
7c261409d2 Make Serial number preference a copyable slice.
Fixes: 73769621
Test: robotests
Change-Id: Ic20d8865bc26c1acc7db74e665f92fe388d62f74
2019-02-26 13:14:03 -08:00
TreeHugger Robot
3329ead489 Merge "Remove NFC Slice jank" 2019-02-26 19:28:58 +00:00
TreeHugger Robot
8e32fa1972 Merge "Make PreventRingingSwitch preference clickable" 2019-02-26 19:15:13 +00:00
Evan Laird
35e35622d9 Use ThemedBatteryDrawable in settings
Changed out BatteryMeterDrawable to inherit from ThemedBatteryDrawable
instead of BatteryMeterDrawableBase. Also removed warning text paint
because it seemed unused and simplified the interface.

Bug: 123705805
Test: visual
Change-Id: I30496e3d8881803d9d3d8a316c10387482a8f610
2019-02-26 14:11:58 -05:00
Fan Zhang
71d5e90a6e Include uid in device admin pref id.
Fixes: 124979213
Test: robotests
Change-Id: I50114db79e9b5278bc916fbbba6353c5f19df24f
2019-02-26 10:49:53 -08:00
Matthew Fritze
9e50419c75 Remove NFC Slice jank
The NFC Slice would jank on enable and disable, because of the
intent filter it registered with SysUI. The intent filter would
broadcast an update for four states:
1) On
2) Off
3) Turning On
4) Turning off

The first two caused no problems. The third and fourth caused jank,
since when clicked, the switch in the NFC slice would turn on / off
asynchronously - that is, it turned on or off based on the previous
state of the switch, rather than on the actual value of NFC. It does
this to feel fluid in the app in which it is rendered.

From the off state, the order of events is:
1.  Switch clicked
2.  Switch animates on
2.  Background intent is fired to settings to turn on Nfc (happens at
       the same time as animation)
3.  Settings calls the NFC enable API
4.  A broadcast for Turning On is sent
5.  The receiver in SysUI gets the broadcast and forwards it to settings
6.  Settings tells the Slice to make sure it is up to date
7.  The Slice checks for the current value - IMPORTANTLY - which is
        currently off, it is only in the process of being enabled.
8.  The Slice flips back off
9.  Nfc finishes getting enabled in the background
10. The framework pushes the NFC ON broadcast
11. SysUI gets the broadcast, and forwards it to settings
12. Settings tells the slice to update
13. The slice checks again and finds that NFC is on, flipping on.

This CL creates a new background slice worker for NFC and registers
the intent filter there, rather than in SysUI. When the background
worker gets the broadcast, it checks if it is in state 3/4, and if so,
it drops the update silently.

Fixes: 115737701
Test: robotests
Change-Id: I17043828ad3a67a2a5acdf5c75d9cc51ff7e91d0
2019-02-26 08:20:38 -08:00
Fabian Kozynski
c2d7bb7965 Merge "Add summary to Notification Assistant picker" 2019-02-26 14:11:56 +00:00
tmfang
826879ed63 Create a preference controller for "App info"
We try to avoid managing too many preferences in a controller.
So, we create another controller to manage all apps info preference.

RecentAppsPreferenceController and AllAppsInfoPreferenceController
share same state of recent apps in order to improve the performance.

Test: visual, robo test
Fixes: 126134996
Change-Id: I1d8a175b213831415797437c64fd9d432864f9d3
2019-02-26 19:34:46 +08:00
Sunny Shao
57a3c8bff7 Handle the IllegalStateException
Handle the attempt to re-open an already-closed object: SQLiteDatabase problem

Bug: 124451874
Test: robotest
Change-Id: I750b2ce98cc2551c80c3bb4f25928e0e5a615cd9
2019-02-26 17:51:17 +08:00
TreeHugger Robot
cabe72cf7b Merge "Improve launch time for Apps & notifications page" 2019-02-26 08:50:20 +00:00
TreeHugger Robot
6dcb6a35c3 Merge "Update strings for Wi-Fi DPP handshake running state" 2019-02-26 07:15:27 +00:00
Joe Onorato
a4819527b7 Merge "Add additional anomaly types." am: 64bf0a791e am: e709ac7a4c
am: d3b25ae1f5

Change-Id: I7a45359cb344f0dee4046e556b599e7646c7fd17
2019-02-25 23:10:52 -08:00
tmfang
ac74050a7c Improve launch time for Apps & notifications page
In original design, we reload usage data at least thrice
for showing recent apps.

For now, we only reload usage data once in constuctor.
And we reload data again when we are calling updateState.

Test: Open App & notifications page, and then I compare the lauch time
with P platform device.
Fixes: 126013076

Change-Id: Ida769f28a4419125e1948e36658686ee55bf51a5
2019-02-26 15:08:22 +08:00
Joe Onorato
e709ac7a4c Merge "Add additional anomaly types."
am: 64bf0a791e

Change-Id: Iebe3695669e87b3109b43becaf869c4b2f9a4b48
2019-02-25 22:48:39 -08:00
TreeHugger Robot
9d741c4f47 Merge "Improve UX of Wi-Fi QR code scanner enrollee flow" 2019-02-26 05:48:56 +00:00
TreeHugger Robot
2b0611cec4 Merge changes I9f1edb0a,Iaba7077c
* changes:
  Make model & hardware UI full screen.
  Merge Copyable into Sliceable.
2019-02-26 04:00:13 +00:00
Kiyoung Kim
cf6757a72f Merge "Schematize Crypto state system property" 2019-02-26 01:44:28 +00:00
Arc Wang
827a0fe6ae Merge "Add "Share" button for saved Wi-Fi network" 2019-02-26 01:42:15 +00:00
Lei Yu
2c1672c482 Merge "Add Bluetooth metadata listenr" 2019-02-26 01:30:13 +00:00
Fan Zhang
8ae1514299 Make model & hardware UI full screen.
Bug: 112427717
Test: robotests
Change-Id: I9f1edb0ab377aff142b57d86f4fa218b755356b1
2019-02-25 16:36:04 -08:00
Fan Zhang
e0a722e130 Merge Copyable into Sliceable.
It's only a slice concept. Regular preference copyability is handled in
xml.

Bug: 112427717
Test: rebuild
Change-Id: Iaba7077c320cd03a5963797916a60e0dc80fdbbe
2019-02-25 16:36:04 -08:00
jackqdyulei
344d761e60 Add Bluetooth metadata listenr
If it is updated, we need to refresh UI to display latest information

Fixes: 124455912
Test: RunSettingsRoboTests
Change-Id: I73b03f4931e3c2b0d367bbd2d3b2057b26c84b59
2019-02-25 15:02:10 -08:00
Beverly
986f2ecc55 Make PreventRingingSwitch preference clickable
- Talk back says the preference is clickable

Test: make ROBOTEST_FILTER=PreventRingingSwitchPreferenceControllerTest RunSettingsRoboTests -j40
Bug: 124827588
Change-Id: Ia409bbc6516f6aa11975726691131f1fad1518fd
2019-02-25 16:36:45 -05:00
Fabian Kozynski
d565d7a505 Add summary to Notification Assistant picker
Test: manual
Test: atest
Fixes: 126200103
Change-Id: I9569ca7dd58184242fe740e3db63bd7958042cfb
2019-02-25 15:52:40 -05:00
Fan Zhang
aef472d0ca Merge "Convert android version dialog into a full screen UI" 2019-02-25 20:33:36 +00:00
Joe Onorato
f51826853b Add additional anomaly types.
Test: Treehugger
Bug: 115540658
Change-Id: I369f5bfadfe10810aa33d4127fb9ce69c9c57e7e
2019-02-25 14:51:10 +00:00
TreeHugger Robot
c4383213cc Merge "Settings UI fix for missing secure lock screen feature." 2019-02-25 11:41:03 +00:00
Lenka Trochtova
bb8e81770b Settings UI fix for missing secure lock screen feature.
Bug: 123737250
Bug: 111072170
Bug: 111071972
Test: manual both with and without the feature flag
Test: make RunSettingsRoboTests

Change-Id: Iacefa95dce85d860633315e074cbf2772691cfdd
2019-02-25 10:18:35 +00:00
Jason Chiu
dcedd4e2e2 WiFi Slice Polish - Searching for WiFi state
1. Change the font color to be secondary
2. Align the left to the AP list title
3. Update the font for Wi-Fi list to be body font - Roboto regular 14dp

Fixes: 124468947
Test: robotest
Change-Id: I9f41925f7e3938bdf3f444b09eab33d6bf479f57
2019-02-25 17:35:16 +08:00
Arc Wang
957ce7f7aa Update strings for Wi-Fi DPP handshake running state
Bug: 125987679
Test: manual test
Change-Id: I55eddee5f3c0c28d1be23b5b9d8c0b56280be797
2019-02-25 15:06:16 +08:00
Arc Wang
12d431e683 Add "Share" button for saved Wi-Fi network
Bug: 124700405
Test: manual test
Change-Id: I58140dbc7bef1214c2323c1c37f9c87e94b94088
2019-02-25 13:51:24 +08:00
TreeHugger Robot
0d8d233a3d Merge "Remove hardcoded Uri to get slice settings" 2019-02-25 02:22:39 +00:00
Lei Yu
d5e653e4f2 Merge "Fix issues in BT detail header" 2019-02-25 01:15:26 +00:00
TreeHugger Robot
85ead953f3 Merge "Do not trigger card loader reloading upon screen rotation." 2019-02-24 18:31:16 +00:00
TreeHugger Robot
b87ff78c30 Merge "Replace Banner with App Title Text" 2019-02-23 08:44:18 +00:00
TreeHugger Robot
3921f97467 Merge "Create settings screen for Notification Assistant" 2019-02-23 04:30:23 +00:00
Arc Wang
13f37337ed Improve UX of Wi-Fi QR code scanner enrollee flow
1. Do not start WifiSettings after enrollee success
2. Return WifiConfiguration to the calling object after enrollee success
3. In WifiDialog, do not show scan button if Save button is not visible to users
4. Fix scanner button may not respond problem by setting listener for scanner
   button of ssid field and password field
5. If SSID is assigned, only allow to enrollee for the network of assigned SSID

Bug: 124416152
Test: manual test
Change-Id: Ic5241c4767eaa8ea01782817d8302d8b0572ab36
2019-02-23 11:59:53 +08:00