Commit Graph

77267 Commits

Author SHA1 Message Date
PETER LIANG
d981c2b142 Merge "Add test cases for legacy components." am: 24e31fa068
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12652523

Change-Id: I00dd5061a718b1ee611e79c20b6efd69f3c24276
2020-09-26 09:51:09 +00:00
PETER LIANG
24e31fa068 Merge "Add test cases for legacy components." 2020-09-26 09:22:01 +00:00
jasonwshsu
60e77ff307 Modify flow in ToggleFeaturePreferenceFragment am: 1a1ae82460
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12188902

Change-Id: I42af381014da62d237969aec542bdee0b879d351
2020-09-26 06:15:18 +00:00
jasonwshsu
1a1ae82460 Modify flow in ToggleFeaturePreferenceFragment
* Show edit shortcut dialog should belong to the basic feature, so move
them back to ToggleFeaturePreferenceFragment
* Add test cases for UserShortcutType to prepare to further refactor

Bug: 158540780
Test: atest ToggleFeaturePreferenceFragmentTest
Change-Id: Ia84bea5581f85d199f395b2065652ce69738abbf
2020-09-26 04:30:04 +00:00
Peter_Liang
96ea49a38b Add test cases for legacy components.
Bug: 168567356
Test: make RunSettingsRoboTests ROBOTEST_FILTER=AnimatedImagePreferenceTest
&& make RunSettingsRoboTests ROBOTEST_FILTER=DividerAllowedBelowPreferenceTest
&& make RunSettingsRoboTests ROBOTEST_FILTER=DividerSwitchPreference

Change-Id: Ibe1add4ac6509f456ea76a6053f43c894e410eeb
2020-09-26 11:03:13 +08:00
Tyler Gunn
293e6cfa1e [automerger skipped] Fix issue where "learn more" link on 5G NR settings doesn't work. am: d3d88afee7 am: ce636284ec -s ours am: 1044467d33 -s ours
am skip reason: Change-Id I5d22c665b0d6fb842bc54dc55a2eb3045e0092a2 with SHA-1 97d8711d84 is in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12700756

Change-Id: I723c3868c9267f6b6122166b06ef8ed02cdec583
2020-09-25 22:29:52 +00:00
Tyler Gunn
1044467d33 [automerger skipped] Fix issue where "learn more" link on 5G NR settings doesn't work. am: d3d88afee7 am: ce636284ec -s ours
am skip reason: Change-Id I5d22c665b0d6fb842bc54dc55a2eb3045e0092a2 with SHA-1 97d8711d84 is in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12700756

Change-Id: I0c837aed712305ce138e34ea2abd920e2a31886e
2020-09-25 22:07:41 +00:00
Tyler Gunn
ce636284ec Fix issue where "learn more" link on 5G NR settings doesn't work. am: d3d88afee7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12700756

Change-Id: I64aae8431da809ce109d68a0663c6c663235693e
2020-09-25 21:54:18 +00:00
Tyler Gunn
d3d88afee7 Fix issue where "learn more" link on 5G NR settings doesn't work.
Issue is due to the fact the footer text is a spannable string which
although different from the original text loaded when the preference
was constructed, is the same in terms of object equality.
Clearing the preference title before assigning the footer text fixes this.

Fixes: 162011372
Test: Manual test; open settings and verify link is clickable now.
Merged-In: I5d22c665b0d6fb842bc54dc55a2eb3045e0092a2
Change-Id: I5d22c665b0d6fb842bc54dc55a2eb3045e0092a2
(cherry picked from commit 97d8711d84)
Exempt-From-Owner-Approval: Straight cherry-pick.
2020-09-25 21:18:29 +00:00
Tyler Gunn
a1c49ea1a3 Fix issue where "learn more" link on 5G NR settings doesn't work. am: 97d8711d84
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12663175

Change-Id: I86ff6181b10052cd7d6b4a5cc33d08b621a6a12e
2020-09-25 18:50:56 +00:00
TreeHugger Robot
d9c100c8b7 Merge "Fix adb qr scanner text in dark mode." am: acfc3997cc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12693457

Change-Id: Id79beda6f7233c7bd99d271e6a927db11730f8de
2020-09-25 18:40:40 +00:00
Tyler Gunn
97d8711d84 Fix issue where "learn more" link on 5G NR settings doesn't work.
Issue is due to the fact the footer text is a spannable string which
although different from the original text loaded when the preference
was constructed, is the same in terms of object equality.
Clearing the preference title before assigning the footer text fixes this.

Fixes: 162011372
Test: Manual test; open settings and verify link is clickable now.
Change-Id: I5d22c665b0d6fb842bc54dc55a2eb3045e0092a2
2020-09-25 18:40:23 +00:00
TreeHugger Robot
acfc3997cc Merge "Fix adb qr scanner text in dark mode." 2020-09-25 18:29:18 +00:00
TreeHugger Robot
3bc238606d Merge "[adbwifi] wireless debugging qstile long-press to WirelessDebuggingFragment." into rvc-qpr-dev am: 39baa4a821 am: f6bcf2334e am: 296ef10de7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12654737

Change-Id: I562214460e385301ead2bf6173d7408d5cc89c9e
2020-09-25 17:11:37 +00:00
Joshua Duong
7e67816cc6 Merge "Fix adb qr scanner text in dark mode." into rvc-qpr-dev am: cfcc133467 am: 09e131b52d am: 0f5dc20a9a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12654736

Change-Id: I645c165a5b157f6daf07405513615fc994f0a3bf
2020-09-25 17:10:21 +00:00
TreeHugger Robot
296ef10de7 Merge "[adbwifi] wireless debugging qstile long-press to WirelessDebuggingFragment." into rvc-qpr-dev am: 39baa4a821 am: f6bcf2334e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12654737

Change-Id: If3f75285d5bc2a04cd1b23d87c4c14232c364151
2020-09-25 16:49:04 +00:00
Joshua Duong
0f5dc20a9a Merge "Fix adb qr scanner text in dark mode." into rvc-qpr-dev am: cfcc133467 am: 09e131b52d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12654736

Change-Id: Id5e5212ef6f8f75830e3bdd7b1284fb7e56d8a37
2020-09-25 16:48:56 +00:00
TreeHugger Robot
f6bcf2334e Merge "[adbwifi] wireless debugging qstile long-press to WirelessDebuggingFragment." into rvc-qpr-dev am: 39baa4a821
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12654737

Change-Id: I64e85bea61395c43b57521c2ad4463b27b432468
2020-09-25 16:27:50 +00:00
TreeHugger Robot
a2dd6a2f3f Merge "[adbwifi] wireless debugging qstile long-press to WirelessDebuggingFragment." am: f57f184f55
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11010533

Change-Id: Ic7088c958d96bc17acdf70efddef465374c53845
2020-09-25 16:17:29 +00:00
TreeHugger Robot
39baa4a821 Merge "[adbwifi] wireless debugging qstile long-press to WirelessDebuggingFragment." into rvc-qpr-dev 2020-09-25 15:55:55 +00:00
TreeHugger Robot
f57f184f55 Merge "[adbwifi] wireless debugging qstile long-press to WirelessDebuggingFragment." 2020-09-25 15:41:00 +00:00
Joshua Duong
09e131b52d Merge "Fix adb qr scanner text in dark mode." into rvc-qpr-dev am: cfcc133467
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12654736

Change-Id: I5d4c0ec55535b318e8e668f579453b9c3a70e33e
2020-09-25 15:30:51 +00:00
Joshua Duong
cfcc133467 Merge "Fix adb qr scanner text in dark mode." into rvc-qpr-dev 2020-09-25 14:58:17 +00:00
Joshua Duong
b6b49680e7 Fix adb qr scanner text in dark mode.
The text color is not right when in dark mode, which makes the text
invisible.

Bug: 168845829

Test: In dark/light mode, scan adb QR code and verify text is visible.
Exempt-From-Owner-Approval: Already approved in ag/12640175
Change-Id: I6d8e16fd2d848d09b49673db041c97d667fea6a9
2020-09-25 14:57:41 +00:00
TreeHugger Robot
e09ab5b85f [automerger skipped] Merge "Disable entry point of output switcher" into rvc-qpr-dev am: faf7a2ad78 am: e71dc5640e -s ours am: d46ff8c6d3 -s ours
am skip reason: Change-Id I8906878e1ba769d6940041f17d83b5de6b2a32c0 with SHA-1 b6840ced0d is in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12686593

Change-Id: I23e2e24c187ef42b69e21a1f53e270a6c9249eb7
2020-09-25 10:16:28 +00:00
TreeHugger Robot
f850386a22 [automerger skipped] Merge "Fix output switcher will display previous media session" into rvc-qpr-dev am: 27a7be8a24 am: 0306995bbd -s ours am: 61956e9575 -s ours
am skip reason: Change-Id Iebfc7904609e243d5bf0222307bae98a952a3331 with SHA-1 c3fe8d87d6 is in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12660648

Change-Id: I9f195a59efb73a46da119a427588255f182b5f2d
2020-09-25 10:16:07 +00:00
TreeHugger Robot
d46ff8c6d3 [automerger skipped] Merge "Disable entry point of output switcher" into rvc-qpr-dev am: faf7a2ad78 am: e71dc5640e -s ours
am skip reason: Change-Id I8906878e1ba769d6940041f17d83b5de6b2a32c0 with SHA-1 b6840ced0d is in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12686593

Change-Id: Ia415edfd5886cfaf700f3d0362a52d488c3fe0e0
2020-09-25 09:59:34 +00:00
TreeHugger Robot
61956e9575 [automerger skipped] Merge "Fix output switcher will display previous media session" into rvc-qpr-dev am: 27a7be8a24 am: 0306995bbd -s ours
am skip reason: Change-Id Iebfc7904609e243d5bf0222307bae98a952a3331 with SHA-1 c3fe8d87d6 is in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12660648

Change-Id: I4ced6e84f7f87c2114296c63fb1bbbf543121bf1
2020-09-25 09:59:10 +00:00
TreeHugger Robot
e71dc5640e Merge "Disable entry point of output switcher" into rvc-qpr-dev am: faf7a2ad78
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12686593

Change-Id: I981a5fdc4356e41ceaf353b005077765568c6944
2020-09-25 09:31:06 +00:00
TreeHugger Robot
0306995bbd Merge "Fix output switcher will display previous media session" into rvc-qpr-dev am: 27a7be8a24
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12660648

Change-Id: Ia152136adbbf6a32ee79d08a06ba23a75b948ddc
2020-09-25 09:30:08 +00:00
TreeHugger Robot
faf7a2ad78 Merge "Disable entry point of output switcher" into rvc-qpr-dev 2020-09-25 09:04:36 +00:00
TreeHugger Robot
27a7be8a24 Merge "Fix output switcher will display previous media session" into rvc-qpr-dev 2020-09-25 09:03:50 +00:00
Jason Chiu
6f1e5fd397 [automerger skipped] Merge "[DO NOT MERGE] Fix the blank space on contextual card loading timeout" into rvc-qpr-dev am: e8b34c64f4 am: 21b7365c8f -s ours am: c39bf6fd64
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12533604

Change-Id: Id8cf26b9e7951152905efcbd80113c5a78834b8f
2020-09-25 07:50:38 +00:00
Jason Chiu
3dac023682 [automerger skipped] [DO NOT MERGE] Fix the blank space on contextual card loading timeout am: 4753adfb52 am: cad3c395da -s ours am: 248a187c83
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12533604

Change-Id: Ie022b067e29542e1622d354fffa262f36dce205a
2020-09-25 07:50:37 +00:00
Jason Chiu
c39bf6fd64 [automerger skipped] Merge "[DO NOT MERGE] Fix the blank space on contextual card loading timeout" into rvc-qpr-dev am: e8b34c64f4 am: 21b7365c8f -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12533604

Change-Id: I246af174a27b666b28cfa60c80bed4df149be22c
2020-09-25 07:35:25 +00:00
Jason Chiu
248a187c83 [automerger skipped] [DO NOT MERGE] Fix the blank space on contextual card loading timeout am: 4753adfb52 am: cad3c395da -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12533604

Change-Id: I0e0a5483008a645da1f7bfa96907381c67e2e752
2020-09-25 07:35:22 +00:00
Pihuei Wang
c486b724cd Merge "deprecated applyPartnerCustomizationStyle" am: 6a553f7214
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12682504

Change-Id: I5b03faf44ed6b881d13f4cc57001dd6e7f89e724
2020-09-25 07:26:46 +00:00
Jason Chiu
21b7365c8f Merge "[DO NOT MERGE] Fix the blank space on contextual card loading timeout" into rvc-qpr-dev am: e8b34c64f4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12533604

Change-Id: I7781d02a644e089685c3673619114de334defdc9
2020-09-25 07:18:17 +00:00
Jason Chiu
cad3c395da [DO NOT MERGE] Fix the blank space on contextual card loading timeout am: 4753adfb52
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12533604

Change-Id: I974883a20ebcac94cf72ccbfdd9cab18b23d1690
2020-09-25 07:18:13 +00:00
Pihuei Wang
6a553f7214 Merge "deprecated applyPartnerCustomizationStyle" 2020-09-25 07:06:58 +00:00
Jason Chiu
e8b34c64f4 Merge "[DO NOT MERGE] Fix the blank space on contextual card loading timeout" into rvc-qpr-dev 2020-09-25 07:05:25 +00:00
Joshua Duong
2972bfa646 [adbwifi] wireless debugging qstile long-press to WirelessDebuggingFragment.
Previously, long-pressing any developer options quick settings tiles
redirects to the application info page for Settings app. The manifest
change makes the long-press by default, go into the developer options
page.

Also, there's a check if the long-press came from the wireless debugging
tile so it can launch the WirelessDebuggingFragment.

Bug: 153275926

Test: Enable the wireless debugging qstile in developer options.
Then long-press the wireless debugging tile, which should direct you to
the WirelessDebuggingFragment. Also, enable any other qstile and
long-press them. It should direct you to the developer options page
instead of the application info page.

Change-Id: Id495e5c978005c21d0f33b949d7c410100bf3cf5
2020-09-25 05:35:06 +00:00
Joshua Duong
69aa456be1 Fix adb qr scanner text in dark mode.
The text color is not right when in dark mode, which makes the text
invisible.

Bug: 168845829

Test: In dark/light mode, scan adb QR code and verify text is visible.
Change-Id: I6d8e16fd2d848d09b49673db041c97d667fea6a9
2020-09-25 05:33:20 +00:00
TreeHugger Robot
83ab3536b8 Merge "Disable entry point of output switcher" am: bbdb762140
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12682509

Change-Id: If00f1c191bb2c90752c4aa682d49812962d4bfbd
2020-09-25 05:33:16 +00:00
Bill Yi
3a6bd451aa [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 434bffe9e2 -s ours am: dca9841ca2 -s ours am: 505e290f56 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12686851

Change-Id: I305c899030d2691bae39cd4b89aa6945c29a5139
2020-09-25 05:30:19 +00:00
Hugh Chen
455a0a3186 Disable entry point of output switcher
It adds a minimum value if it shows only one available
cast device in the output switcher. Because users can only
change the volume slider or stop control in the output switcher.
It's too hidden to have the user stop cast in the UI.

- This CL will disable the entry point of the output switcher
  if there is only one available cast device in the list.
- Update test cases.

Bug: 163095048
Test: make -j42 RunSettingsRoboTests
Change-Id: I8906878e1ba769d6940041f17d83b5de6b2a32c0
Merged-In: I8906878e1ba769d6940041f17d83b5de6b2a32c0
(cherry picked from commit b6840ced0d)
2020-09-25 03:18:05 +00:00
TreeHugger Robot
bbdb762140 Merge "Disable entry point of output switcher" 2020-09-25 03:13:55 +00:00
Hugh Chen
b6840ced0d Disable entry point of output switcher
It adds a minimum value if it shows only one available
cast device in the output switcher. Because users can only
change the volume slider or stop control in the output switcher.
It's too hidden to have the user stop cast in the UI.

- This CL will disable the entry point of the output switcher
  if there is only one available cast device in the list.
- Update test cases.

Bug: 163095048
Test: make -j42 RunSettingsRoboTests
Change-Id: I8906878e1ba769d6940041f17d83b5de6b2a32c0
2020-09-25 02:38:19 +00:00
Bill Yi
505e290f56 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 434bffe9e2 -s ours am: dca9841ca2 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12686851

Change-Id: I1a8537c8739b2e608adc27b16aebe90490ae780b
2020-09-24 23:46:23 +00:00
Bill Yi
dca9841ca2 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 434bffe9e2 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12686851

Change-Id: Ie40fdb3891e27f7c43766ed324422fde6b56e11f
2020-09-24 21:31:25 +00:00