Commit Graph

45678 Commits

Author SHA1 Message Date
hughchen
8dcd550d36 Remove the gear icon and change tapping event
* Remove the gear icon in "currently connected" section.
* Change the tapping event in "currently connected" section.
  When tapping device in this section, take user to device detail page.

Bug: 78490845
Test: make -j40 RunSettingsRoboTests
Change-Id: I25f8455def3c38e24dea9af9e9e29ba37c250f67
Merged-In: I25f8455def3c38e24dea9af9e9e29ba37c250f67
2018-05-02 07:15:35 +00:00
Bill Yi
bc58a9ad53 Import translations. DO NOT MERGE
Change-Id: Ic54f94e9a80d85c1264d5aa3da5e4b7dfa861e72
Auto-generated-cl: translation import
2018-05-01 22:27:03 -07:00
jyhshiangwang
4d015b17b3 Use ListFormatter to join strings
Currently in Settings we are using R.string.join_many_items_first, R.string.join_many_items_middle and R.string.join_many_items_last to manually join strings. The join code is messy and the joined string is incorrect in some languages, so we migrate all string join to just use ListFormatter.getInstance().format().

Bug: b/78248791
Test: robotests
Change-Id: I898339978e6e2027587e28994b0280fa46821fd6
2018-05-02 11:15:32 +08:00
android-build-team Robot
7c45f59478 Merge "Update cellular data condition icon and padding." into pi-dev am: 1a38390728
am: 8907b93d07

Change-Id: I1f6c63ad8c8d3a3d020a7ece8fd540ac77427650
2018-05-01 17:24:43 -07:00
android-build-team Robot
8907b93d07 Merge "Update cellular data condition icon and padding." into pi-dev
am: 1a38390728

Change-Id: I2372af3d9e40cf3d0d4bcc1f13dffe6d856af18f
2018-05-01 17:17:41 -07:00
android-build-team Robot
1a38390728 Merge "Update cellular data condition icon and padding." into pi-dev 2018-05-02 00:08:11 +00:00
android-build-team Robot
c66613306a Merge "Workaround task-resolution bug in AM" into pi-dev am: bb5a46fabd
am: f22e98e7c7

Change-Id: I0c2407144a87accaa8e884b31ecc0af2893b6d6e
2018-05-01 16:21:13 -07:00
android-build-team Robot
f22e98e7c7 Merge "Workaround task-resolution bug in AM" into pi-dev
am: bb5a46fabd

Change-Id: Ie3def1978876a5429dc6888de69c2b7c51ed0faa
2018-05-01 16:16:52 -07:00
android-build-team Robot
bb5a46fabd Merge "Workaround task-resolution bug in AM" into pi-dev 2018-05-01 23:08:15 +00:00
Fan Zhang
2b9f8c96d1 Update cellular data condition icon and padding.
Change-Id: I01fcdcc09a81758eb12e898aea5d64fa1dc6ef06
Fixes: 79090390
Test: visual
2018-05-01 15:27:01 -07:00
Eran Messeri
f61ccf3fa3 Require work profile to be unlocked for changing notification settings in a different way
Rather than check for the state of the work profile in
LockScreenNotificationPreferenceController#handlePreferenceTreeClick, do so in
the RestrictedListPreference#performClick.
The drawback of checking the state in handlePreferenceTreeClick is that the
preferences are displayed first and then the requirement to unlock/enable the
work profile is displayed on top of it.

This is rather poor UX, so switch to doing the check in performClick and
returning early if the work profile needs to be unlocked/enabled.
This is similar to Patchset 1 from ag/3805482.
The main difference is that the user is returned to the settings screen
both after enabling the work profile and unlocking it.

Test: Manually with TestDPC
Test: atest SettingsRoboTests:RestrictedListPreferenceTest
Bug: 77408805
Merged-In: Id168911b082fffac193cd7c7a658ab92d6ce2c15
Change-Id: I0a3a4ec4dda78e28ee88a11d383eda49e9cf50a6
2018-05-01 21:55:56 +01:00
Eran Messeri
7b36ccdd9b Merge "Require work profile to be unlocked for changing notification settings in a different way" 2018-05-01 20:51:39 +00:00
android-build-team Robot
7424cbbbe0 [automerger skipped] Merge "Import translations. DO NOT MERGE" into pi-dev am: a020cc9c0a -s ours
am: 71a0e324f4  -s ours

Change-Id: Ia074dd1613cb9e1f9417c926f7d26e7d4ac50926
2018-05-01 13:24:37 -07:00
android-build-team Robot
71a0e324f4 [automerger skipped] Merge "Import translations. DO NOT MERGE" into pi-dev
am: a020cc9c0a  -s ours

Change-Id: I4417e943078fd0f831b583736951bf42e96b1e55
2018-05-01 13:21:05 -07:00
android-build-team Robot
a020cc9c0a Merge "Import translations. DO NOT MERGE" into pi-dev 2018-05-01 20:16:51 +00:00
Doris Ling
61909b5af1 Merge "Fix crash in ExternalSourceDetailPreferenceController." into pi-dev am: 5ddff9371d
am: 674fec7f3c

Change-Id: I0c9610bb467a9443480def643bb96135478473e5
2018-05-01 13:10:23 -07:00
Doris Ling
674fec7f3c Merge "Fix crash in ExternalSourceDetailPreferenceController." into pi-dev
am: 5ddff9371d

Change-Id: I26b3122b17b71e9729d198bcbaa8f1620c40e06e
2018-05-01 13:06:04 -07:00
Doris Ling
5ddff9371d Merge "Fix crash in ExternalSourceDetailPreferenceController." into pi-dev 2018-05-01 19:58:56 +00:00
android-build-team Robot
979ece432a Merge "Disable 'remove' option while setting is selected" into pi-dev am: 24cfa88e19
am: 035e2006e8

Change-Id: Ibae065e51330af2c7abb72a10ac84d284666e4d2
2018-05-01 12:45:07 -07:00
android-build-team Robot
035e2006e8 Merge "Disable 'remove' option while setting is selected" into pi-dev
am: 24cfa88e19

Change-Id: I2f737729d9525623bc4b5edb5ff84cae07ee007e
2018-05-01 12:41:31 -07:00
android-build-team Robot
24cfa88e19 Merge "Disable 'remove' option while setting is selected" into pi-dev 2018-05-01 19:34:15 +00:00
Fan Zhang
10b4bc01f1 Merge "Add a test to verify lifecycle events are triggered" into pi-dev am: 139ebd91c0
am: cd3e50d4a5

Change-Id: I01d49c423c5ef56d59a51a2f03b4f11d956e19bc
2018-05-01 12:33:06 -07:00
Fan Zhang
cd3e50d4a5 Merge "Add a test to verify lifecycle events are triggered" into pi-dev
am: 139ebd91c0

Change-Id: Ia8ce612d5daa6bb17114188729a295c684eef2e0
2018-05-01 12:25:44 -07:00
Fan Zhang
139ebd91c0 Merge "Add a test to verify lifecycle events are triggered" into pi-dev 2018-05-01 19:04:44 +00:00
Bill Yi
20473e54ab Import translations. DO NOT MERGE
Auto-generated-cl: translation import

Bug: 78510764
Change-Id: I675f55ab20567796d3580e386fecc87d4f8c3d78
2018-05-01 18:50:02 +00:00
Julia Reynolds
5c19e7b6b0 Update zen onboarding ui am: 29ba3601b0
am: fa6482c4a4

Change-Id: I9010987409185d91ff039657cf2b20aeaefd01ad
2018-05-01 11:05:14 -07:00
Julia Reynolds
ded64625f4 Disable 'remove' option while setting is selected
Test: robotests
Bug: 78916709
Change-Id: Id1dfc3b61a80c2e0677472ae84dc7425116825f0
2018-05-01 13:45:53 -04:00
Julia Reynolds
fa6482c4a4 Update zen onboarding ui
am: 29ba3601b0

Change-Id: I2c1769f683dd464c96e758b61bd5e47b4a538c44
2018-05-01 10:33:18 -07:00
Winson Chung
7bfc62f562 Workaround task-resolution bug in AM
- Keep launching notification settings in the Settings task. This is not
  the expected behavior, but only a workaround until b/72420153 is
  fixed.

Bug: 72420153
Test: Enter PIP, go to app > notifications > additional settings, ensure
      that it doesn't start in the PIP task

Change-Id: I73e704a283285462d4884db21923818cfb6deead
2018-05-01 10:23:59 -07:00
Julia Reynolds
29ba3601b0 Update zen onboarding ui
Test: robotests
Bug: 78448988
Change-Id: I1e70bf8d28f392b93bb102622340da0af65f4718
2018-05-01 15:11:03 +00:00
android-build-team Robot
d3ff522a0b Merge "Fix a NPE where developer options page crash sometimes." into pi-dev am: d940a680a5
am: aee1191c72

Change-Id: Iac0d2a8551d9c1ba230890dadb1bdf2b6edb12b9
2018-04-30 20:51:39 -07:00
android-build-team Robot
aee1191c72 Merge "Fix a NPE where developer options page crash sometimes." into pi-dev
am: d940a680a5

Change-Id: Ida116e1bedb08795077991c391426fce5d820bca
2018-04-30 19:40:16 -07:00
android-build-team Robot
6451b7b91b Merge "Migrate PaymentSettings to DashboardFragment" 2018-05-01 01:37:34 +00:00
Fan Zhang
1f1c7042f5 Add a test to verify lifecycle events are triggered
- Added a footer in feature flags, displaying "Experimental" during
  onStart.
- Ui test to verify the text shows correctly.

Change-Id: Ibf4f79cb3c12e460384e83201a16005a18d6437d
Fixes: 78887450
Test: atest
2018-05-01 01:32:49 +00:00
android-build-team Robot
d940a680a5 Merge "Fix a NPE where developer options page crash sometimes." into pi-dev 2018-05-01 01:30:41 +00:00
Doris Ling
c3e4619af1 Fix crash in ExternalSourceDetailPreferenceController.
- Add null check for the package info when trying to retrieve the
install app state. During package update, the package info might becomes
null. The App info activity will finish in that case, but this method
might be called before the activity actually finishes.

Change-Id: I18ff448666dfb403bb6693fccd3e54276db36f37
Fixes: 78257414
Test: make RunSettingsRoboTests
2018-04-30 17:38:29 -07:00
chiujason
ff244c0e40 Migrate PaymentSettings to DashboardFragment
- Move preference related logic to controllers.
- Add some test cases for controllers.

Test: manual
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.nfc
      make RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.core
      atest SettingsGatewayTest UniquePreferenceTest
Change-Id: I061a194c170f63fab51974f26c24be43d67d6f6f
2018-04-30 17:24:58 -07:00
android-build-team Robot
ecb74eb273 Merge "Update the color of security status icons" into pi-dev am: c883db167a
am: 07187fb9b9

Change-Id: I8d5476ee6673e253494a58d984b3196018b0f3ef
2018-04-30 17:03:49 -07:00
Fan Zhang
ecadd0119d Fix a NPE where developer options page crash sometimes.
Developer options page crash for restricted users because the page
removes all preferences while DashboardFeatureProvider tries to
manipulate preferences on screen.

Added a null check to skip changin prefs in DashboardFeatureProvider
because the pref is going to be removed either way.

Change-Id: Ic83fd0dfb2a906605fb1d992d7b36c2163630e89
Fixes: 78655710
Test: robotests
2018-04-30 16:54:10 -07:00
android-build-team Robot
07187fb9b9 Merge "Update the color of security status icons" into pi-dev
am: c883db167a

Change-Id: I738495f88c1655b0e3e479eb56812a670ab785f6
2018-04-30 16:54:02 -07:00
android-build-team Robot
c883db167a Merge "Update the color of security status icons" into pi-dev 2018-04-30 23:49:41 +00:00
android-build-team Robot
bd825f408b Merge "Fix NPE during unit test" 2018-04-30 23:44:27 +00:00
android-build-team Robot
db9c8d3b16 Merge "Fix fingerprint suggestion icon color." into pi-dev am: 6590f6948d
am: 92ad34d76a

Change-Id: I607af41645c8dd9ddf6209d741d19a78dff946e6
2018-04-30 15:40:05 -07:00
android-build-team Robot
92ad34d76a Merge "Fix fingerprint suggestion icon color." into pi-dev
am: 6590f6948d

Change-Id: Iacdf068f690d31c3e37a91e9cacb7a3810b4a9ef
2018-04-30 15:30:20 -07:00
android-build-team Robot
6590f6948d Merge "Fix fingerprint suggestion icon color." into pi-dev 2018-04-30 22:17:30 +00:00
Fan Zhang
16de45d8ec Fix NPE during unit test
As of ag/3932176 the slice indexer now queries getSummary() for each
controller. So we need to create all necessary objects before
getSummary(). In this case, the PSCD object.

Change-Id: I0162996be37d740f1e450880bf4698acd94ca0ad
Fixes: 78897071
Test: atest
2018-04-30 15:17:22 -07:00
Antony Sargent
779292bcde Update the color of security status icons
Also update res/drawable/ic_ota_update_none.xml to have the same
contents as res/drawable/ic_ota_update_stale.xml.

Bug: 74255242
Test: manual (go to Settings->Security & location; the icons in the
Security status section at the top should be colorful)

Change-Id: I1c54c5b6803268e3acf9720c7c555476405d624e
2018-04-30 15:11:19 -07:00
android-build-team Robot
bf9c07cb59 Merge "Revert "Get rid of charging sounds toggle"" into pi-dev am: 8e55299f98
am: 72cedc72a4

Change-Id: Ib15d341f90072be2fbe3d6b5cb1bfd9c4fcbb938
2018-04-30 14:29:58 -07:00
android-build-team Robot
72cedc72a4 Merge "Revert "Get rid of charging sounds toggle"" into pi-dev
am: 8e55299f98

Change-Id: I58e93b9c70d57224c01bd62fa47640badd1febaf
2018-04-30 14:22:42 -07:00
Doris Ling
ea85c0a2cc Fix fingerprint suggestion icon color.
- add tintable flag to the suggestion metadata so that it will be
displayed in correct tint color.

Change-Id: I29b6d3a8b7c47354d6022aea4d4f01986f5ce2b3
Fixes: 78655925
Test: visual
2018-04-30 14:08:55 -07:00