Commit Graph

47034 Commits

Author SHA1 Message Date
TreeHugger Robot
f878183582 Merge "Remove unused battery strings" 2018-07-18 00:59:41 +00:00
TreeHugger Robot
1fea2cbc48 Merge "Remove ListView from preference_list_fragment." 2018-07-18 00:25:26 +00:00
jackqdyulei
5977b1fe38 Remove unused battery strings
Change-Id: Ic463c353837078e6d5b960b458e210174b50fa37
Fixes: 36738738
Test: Build
2018-07-17 16:27:46 -07:00
Fan Zhang
fe93bd9c1e Remove ListView from preference_list_fragment.
As part of it, Use RecyclerView in PrintServiceSettingsFragment, which
still depends on the old preference_list_frag layout.

Also remove some unused pngs

Test: manual

Change-Id: I3189bd0dee5b6a74209eb1e707eb40427c96e312
2018-07-17 15:47:33 -07:00
Salvador Martinez
210ddd075a Fix dialogs in Theme.Settings
Theme.Settings was explicitly using a Light theme. This CL
changes it to DayNight so that it properly changes colors in
night mode.

Test: visual inspection, screenshot
Bug: 111397440
Change-Id: I20088a9021ddfe7d6e92c3b52ce4ca65ada07983
2018-07-17 15:45:29 -07:00
jackqdyulei
35015741b2 Hook up anomaly active hour to BatteryTipPolicy
So we can control it from server side.

Bug: 80192137
Test: RunSettingsRoboTests
Change-Id: Ic9a4db44029bdcd7e45f4f9fb6b7d71c8c07c429
2018-07-17 15:42:52 -07:00
TreeHugger Robot
203bb7e876 Merge "Fix the title mismatch bug of Languages sub-settings page." 2018-07-17 22:00:15 +00:00
TreeHugger Robot
d3e18dcf0a Merge changes from topic "rm_odr_anomaly"
* changes:
  Move anomaly code to BatteryTipUtils
  Remove the anomaly detection added in O-DR
2018-07-17 21:09:36 +00:00
jackqdyulei
5918cd5ff9 Move anomaly code to BatteryTipUtils
Then we could reuse it across settings.

Bug: 74529048
Test: robo test that cover each components still pass
Change-Id: Ied0bbc6e6a1dca9628c2c084c3284ffab2f85160
2018-07-17 12:42:57 -07:00
jackqdyulei
dd9b8af6b9 Remove the anomaly detection added in O-DR
1. Remove unused class and resources
2. Update function in AdvancedPowerUsageDetail since
we don't need pass in anomaly anymore

Change-Id: I96fbe5ddaae902b34b756c7aae0338e49afef1f3
Bug: 74529048
Test: 1. manual test in settings page. 2. robo test still pass
2018-07-17 12:42:43 -07:00
TreeHugger Robot
2e246bb66c Merge "Allow activity to delegate onActivityResult to fragments" 2018-07-17 19:30:39 +00:00
Yanting Yang
8086d15347 Fix the title mismatch bug of Languages sub-settings page.
- modify the title of Language sub-settings page.
- remove the unused string id, pref_title_lang_selection.

Change-Id: I445493f6769c9888a27b72471fc9282df3655406
Fixes: 111322494
Test: manual
2018-07-18 02:56:48 +08:00
Fan Zhang
af32e726e6 Allow activity to delegate onActivityResult to fragments
Change-Id: Iac388f1726269239313d666f3123f28348e0c90a
Fixes: 111531567
Test: rototests
2018-07-17 10:59:02 -07:00
jackqdyulei
c7867c80d4 Add scrollview for dns dialog
Also update dialog to appcompat to avoid the crash

Change-Id: Ide6483f1160713dae8111de533a8b3345a3420c2
Fixes: 111351793
Test: Manual
2018-07-17 10:47:32 -07:00
tmfang
c0ed614252 Remove LocalePickerWithRegion class in Settings.
This class is too complex, we can't afford maintaining this long term.
We need a new Activity that wraps the framework version of LocalePickerWithRegion.

Bug: 111373939
Test: manual test & make RunSettingsRoboTests -j56

Change-Id: I93c719246b84350d2eee4e8ce1ffd97cd168925b
2018-07-17 17:34:00 +08:00
Jason Chiu
baea63bf72 Fix a test broken by fragment migration.
Test: make ROBOTEST_FILTER=SettingsLicenseActivityTest RunSettingsRoboTests
Bug: 111194177
Change-Id: Ifd2d980bbf397ad9875b43d654ab4fc52c4627c2
2018-07-17 15:46:48 +08:00
Jackal Guo
6490923251 Change the order of preferences in a11y
Some preference items have the same order, and it makes these items
be sorted in different position per languages. Use unique order for
each items instead.

Bug: 77949267
Test: atest CtsAccessibilityTestCases
Test: manual check the order in different languages
Change-Id: Ibfcb316c4299266b053053d9d88819a7dcc158fa
2018-07-17 11:19:05 +08:00
TreeHugger Robot
0c605c80a7 Merge "Move non-theme styles to styles.xml" 2018-07-17 02:33:50 +00:00
Fan Zhang
a122be1c35 Move non-theme styles to styles.xml
1. Move SUW related themes into its own theme file.
2. Move non-theme styles into styles.xml
3. Move theme styles to themes.xml
4. Group all TextAppearence together in styles.xml
5. And remove some unused resources

Bug: 111454230
Test: manual
Change-Id: I1067a01cf1960bc72ec92528177ac5fcbd4faa3a
2018-07-16 17:59:07 -07:00
TreeHugger Robot
20f85d2a27 Merge "Remove more unused theme customization" 2018-07-17 00:23:46 +00:00
TreeHugger Robot
e64a75812e Merge "Add a back-up icon resource to icon-less Slices" 2018-07-17 00:21:23 +00:00
Fan Zhang
dec6b8cd38 Remove more unused theme customization
Bug: 111454230
Test: manual
Change-Id: I704247ffe1092165365f7604f17372c79afd46ed
2018-07-16 16:14:56 -07:00
Matthew Fritze
c38f7e1d0a Add a back-up icon resource to icon-less Slices
Currently, when a Settings Slice dosen't have an icon, we add an IconCompat
object with the resource 0x0 - which gives an empty icon. This is from the UX
direction that we should only have icons for Settings Slices when the
corresponding Settings have icons in the Settings UI.

However, this causes an issue with a recent change to SliceView, which crashes
the UI when a Slice is rendered without an icon. Previously, the icon code path
was only exercised when the Slice Shortcut view was being used, but after the
change, the icon path is always used and thus crashes when trying to fetch a
resource with id 0x0 from Settings or another provider.

About 2/3rds of Settings Slices do not have icons.

This change adds the Settings App icon as the back-up icon for any Slice which
would otherwise not have an icon.

The impact of missing this change is:
- Settings Slices cannot be shown in launcher spaces until a post-P update comes
from the support library.
- If Settings launches with the bug, Slices cannot patch the API which would require
all Slices to have a non empty icon (b/111438616)

Bug: 111082093
Test: Robotests, Settings Search UI testing, Slice browser testing
Change-Id: I6f326b6b41bf59011a211c6340dd639f68e754e1
2018-07-16 15:34:24 -07:00
TreeHugger Robot
cd489ea2d5 Merge "Clean up theme part 1: move attrs to attrs.xml" 2018-07-16 22:12:05 +00:00
Brad Ebinger
c30af9b8d1 Merge "IMS: Use the slot based ImsManager factory reset API." am: 9e4ff6fca6 am: 15ca33865c
am: aca1e304bd

Change-Id: I0b3b6198e895caf4c33354ffb2fc20b599540387
2018-07-16 14:21:57 -07:00
TreeHugger Robot
9eb270e15e Merge "Fix a incorrect type cast for alert dialog" 2018-07-16 21:08:21 +00:00
Fan Zhang
612fc1ea40 Clean up theme part 1: move attrs to attrs.xml
And remove unused theme and layouts.

Bug: 111454230
Test: rebuild
Change-Id: Iaf418a9a3dc014fc0eac096e60b0e4581c6ededb
2018-07-16 14:00:20 -07:00
Brad Ebinger
aca1e304bd Merge "IMS: Use the slot based ImsManager factory reset API." am: 9e4ff6fca6
am: 15ca33865c

Change-Id: I5fcdcb5b74a828d4377d2bc4e8e567f61ff9a899
2018-07-16 13:55:25 -07:00
Brad Ebinger
15ca33865c Merge "IMS: Use the slot based ImsManager factory reset API."
am: 9e4ff6fca6

Change-Id: I42b0a06ed5707475d105646233ac49958de29d75
2018-07-16 13:32:55 -07:00
Brad Ebinger
9e4ff6fca6 Merge "IMS: Use the slot based ImsManager factory reset API." 2018-07-16 19:57:31 +00:00
Fan Zhang
420f385a18 Fix a incorrect type cast for alert dialog
Change-Id: I2265c4510785f88ef7950cd29779848eb2e58dc4
Fixes: 111488148
Test: manual
2018-07-16 12:23:57 -07:00
Doris Ling
ed2486a6c1 [automerger skipped] DO NOT MERGE Fix summary text for advanced button. am: 20e7c9d0ba -s ours
am: ca9617ac6b  -s ours

Change-Id: I163ccd679b9321013ec064172442146e732d8e3e
2018-07-16 11:51:46 -07:00
Doris Ling
ca9617ac6b [automerger skipped] DO NOT MERGE Fix summary text for advanced button.
am: 20e7c9d0ba  -s ours

Change-Id: I357656196bb6d24404aa797f380e1935264c1ac6
2018-07-16 11:46:54 -07:00
TreeHugger Robot
9bd5b318fc Merge "Remove custom style for preferenceFragmentStyle" 2018-07-14 02:46:16 +00:00
Fan Zhang
1b11c68642 Remove custom style for preferenceFragmentStyle
Bug: 111454230
Test: manual
Change-Id: I84d3ba3876c636461afaeb6d77a8a759b339f733
2018-07-13 18:13:41 -07:00
TreeHugger Robot
64f0a05471 Merge "Fix incorrect imports for AlertDialog" 2018-07-13 22:56:18 +00:00
Fan Zhang
33bef3748e Merge "Fix a crash when trying to find fingerprint sensor" 2018-07-13 21:51:18 +00:00
TreeHugger Robot
c5e51f0317 Merge "Disallow VoiceInteractionService as assist on LowMemDevice" 2018-07-13 21:27:19 +00:00
Fan Zhang
fb5bc069e7 Fix incorrect imports for AlertDialog
Test: robotests
Change-Id: Ic17121cfd4dbe2d15f6d2250649cc71b82aa2c15
2018-07-13 14:21:15 -07:00
TreeHugger Robot
1f8efc14c9 Merge "Clean up: fix incorrect @VisibleForTesting imports" 2018-07-13 21:11:26 +00:00
Jordan Liu
a9ec524463 Merge "Preserve leading 0s in mcc mnc" 2018-07-13 20:57:52 +00:00
Fan Zhang
1b7ab5b40d Fix a crash when trying to find fingerprint sensor
Change-Id: I5bd237fde6d08ace7f8910808a88ba7b62610cba
Fixes: 111443778
Test: manual
2018-07-13 13:32:57 -07:00
Fan Zhang
176ccd0c35 Clean up: fix incorrect @VisibleForTesting imports
Test: rebuild and robotests
Change-Id: I33d7ee1c0622c01f592920baaf01d44ad19d9a13
2018-07-13 13:08:53 -07:00
Fan Zhang
b918f226d7 Disallow VoiceInteractionService as assist on LowMemDevice
Bug: 111443156
Test: robotests
Change-Id: Ic3413af2b5450c43c4749b7748b676a01209a5ac
2018-07-13 12:55:50 -07:00
Doris Ling
20e7c9d0ba DO NOT MERGE Fix summary text for advanced button.
- the resource for the summary text is in the support library. However,
the prebuilt version in the build does not contain the latest change for
the summary text. Add the overlay for the summary resource here with the
updated translation to remove the redundant summary prefix in the
advanced button.

Change-Id: Ib6db0c402d79a2d965e6060b1851d7b898ae3f94
Fixes: 111195268
Test: manual
2018-07-13 12:32:00 -07:00
Hall Liu
ae1bac1837 Fix usage of SubscriptionInfo ctor am: f0072b7345
am: f9b76dfda1

Change-Id: I73d41c06ee5006310ccc5b0ece5b73919370231f
2018-07-13 11:41:21 -07:00
Hall Liu
f9b76dfda1 Fix usage of SubscriptionInfo ctor
am: f0072b7345

Change-Id: I0ec1335abfef8fc30c638636e3bb1ac24a221743
2018-07-13 11:27:19 -07:00
Jordan Liu
21d5942006 Preserve leading 0s in mcc mnc
Fixes: 79408450
Test: ApnEditorTest.java
Change-Id: Iad7ffe04f23b30857588e50d7f5f0dd307bd2c6e
2018-07-13 10:44:39 -07:00
TreeHugger Robot
3889acd53f Merge "Fix 2 tests broken by fragment migration." 2018-07-13 17:20:48 +00:00
Hall Liu
f0072b7345 Fix usage of SubscriptionInfo ctor
Use string arguments instead of ints for mcc/mnc

Bug: 35064313
Test: manual, unit
Change-Id: Ib460d6294d8fb86de7c2fee065defb0a890af15a
(cherry picked from commit 02c5f3c7ac)
2018-07-13 10:13:46 -07:00