Commit Graph

47218 Commits

Author SHA1 Message Date
Neil Fuller
37996acd7c Further status logic tweaks
Change the SettingsUI logic slightly: All other things being equal, pick
the "worst" location dependency status to show. Some renaming and
annotations for clarity.

Also fixes the mocking behavior in the tests around resources, which
were accidentally using the real strings and therefore dependent on real
resource string values. Tests are made more explicit.

Bug: 266921482
Test: atest tests/robotests/src/com/android/settings/datetime/LocationProviderStatusPreferenceControllerTest.java
Change-Id: Ifd96c543dad692884be23bf94e3f1294eed291d5
2023-02-13 15:03:32 +00:00
Neil Fuller
fc4f2ce81d Tweak status display logic and tests
The existing logic and tests looks incorrect. Tests have been tidied up
to reflect real cases. For example, it's not really possible for the
provider to report being "blocked", but for it to report it is "certain"
at the same time.

Bug: 266921482
Test: atest tests/robotests/src/com/android/settings/datetime/LocationProviderStatusPreferenceControllerTest.java
Change-Id: I1a0faa44ed7dd09828ff758db9e40f5d5e010ab0
2023-02-13 15:03:15 +00:00
Behnam Heydarshahi
236bbcb8bc Propagate mute event to both ring volume slices
Fix a bug where introduction of a separate_ring_volume slice meant that
the original ring_volume slice would not get notified of ring stream
muting event.

Bug: b/266855922

Test: make DEBUG_ROBOLECTRIC=1 ROBOTEST_FILTER=VolumeSliceHelperTest RunSettingsRoboTests -j40
Change-Id: Ifb5ebe4e7d9bde3d14336891cce3fbee167a5911
2023-02-13 14:50:27 +00:00
Arc Wang
5ccbb3ee4d Merge "Allow save by AddNetworkFragment itself" 2023-02-13 14:23:19 +00:00
Jakub Rotkiewicz
2a82a4f3b1 Merge "SnoopLogger: Debug enhancements added settings" am: cfde422f91 am: bd2f353f8b
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2362495

Change-Id: I948bc2e08e3044d20a9d3ce5b081c940bea54811
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-13 14:19:30 +00:00
Jakub Rotkiewicz
bd2f353f8b Merge "SnoopLogger: Debug enhancements added settings" am: cfde422f91
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2362495

Change-Id: I3c138106ebdaaf6b5597c6a79054915a04098117
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-13 13:35:37 +00:00
Jakub Rotkiewicz
cfde422f91 Merge "SnoopLogger: Debug enhancements added settings" 2023-02-13 13:01:01 +00:00
Bonian Chen
0996decc69 Merge "[Settings] User restriction should be applied" 2023-02-13 12:38:41 +00:00
Bonian Chen
6d225b22f1 Merge "[Settings] Unified the source of phone number" 2023-02-13 12:38:14 +00:00
Bonian Chen
dc82f0a0ee Merge "[Settings] Avoid from Guest user to access UI which requires permission for changing mobile networi configurations" 2023-02-13 12:37:45 +00:00
Jakub Rotkiewicz
5a1b8a11a6 SnoopLogger: Debug enhancements added settings
Bug: 247859568
Tag: #feature
Test: make RunSettingsRoboTests3
Test: make RunSettingsRoboTests4

Change-Id: I132a1558ea67400d9c10dda523456f99eb815b92
Merged-In: I132a1558ea67400d9c10dda523456f99eb815b92
2023-02-13 11:35:55 +00:00
Jakub Rotkiewicz
dce72966fb Merge "SnoopLogger: Debug enhancements added settings" 2023-02-13 11:29:16 +00:00
Nikhil Kumar
6c3f1df8ff Merge "SettingsActivity: Get profile parent using UserManager.getProfileParent" 2023-02-13 09:59:01 +00:00
Nikhil Kumar
71214f0457 Merge "SettingsHomepageActivity: Get profile parent using UM.getProfileParent" 2023-02-13 09:58:44 +00:00
Arc Wang
da01d199c1 Allow save by AddNetworkFragment itself
Before this change, the calling Activity needs to
check result and get WifiConfiguration to save
data by WifiManager API.

This change allows callings app to specify an auto
save extra to save WifiConfiguration by
AddNetworkFragment itself.

Bug: 268411305
Test: manual
Change-Id: I83002c3de3d6726e9be363d5ac057b4ae9e1707e
2023-02-13 17:24:02 +08:00
TreeHugger Robot
7c7e235730 Merge "Update battery usage app list filter logic:" 2023-02-13 09:05:01 +00:00
Bonian Chen
ceaa5cd7ae [Settings] User restriction should be applied
Simply verify isAdminUser() could be insufficient, since there're some
other use cases (such as managed device).

Bug: 228079419
Test: local

Change-Id: Ic9f27deafada31dacef03e27bf02ecbc9a8b3231
2023-02-13 09:04:04 +00:00
Bonian Chen
b6aae6cc3e Merge "[Settings] Avoid from accessing deprecated API getLine1Number()" 2023-02-13 07:36:12 +00:00
Zaiyue Xue
7fad47a8d7 Update battery usage app list filter logic:
(1) Add app screen on time thrshold 100 ms.
(2) Change app battery comsuption threshold from 0.1 mA to 1 mA.
Apps meet one of above conditions will be shown.

Bug: 264840285
Test: manual
Change-Id: Icfb304f09c49248397350ebe55bf06f3eb82d639
2023-02-13 15:30:03 +08:00
Bonian Chen
c9ace54b03 [Settings] Unified the source of phone number
Route UI access to phone number into a unified util class within
Settings app.

Bug: 265940535
Test: local

Change-Id: Ic747b0044217101d9a6a1e2cd6e59bbdbcd88021
2023-02-13 04:57:18 +00:00
Bonian Chen
8f4e1ace9d [Settings] Avoid from accessing deprecated API getLine1Number()
Migrate to new APIs.

Bug: 269052593
Test: build pass

Change-Id: I76705ec303fa9a593dd3a63d5cac3bdf65258315
2023-02-13 04:42:57 +00:00
Lili Zou
1da516bc2c Merge "Support search for work profile settings page." 2023-02-13 03:32:27 +00:00
Bonian Chen
6fa898d709 [Settings] Avoid from Guest user to access UI which requires permission
for changing mobile networi configurations

1. Confirm eSIM deletion should not be accessible by the end user
2. Erase eSIMs UI should should not be accessible by the end user

Bug: 260726944
Test: local

Change-Id: I45792fd451dbdc8a0788922480a7fa51f1267a68
2023-02-12 14:19:06 +00:00
Zoey Chen
1278cb5f87 [Settings] Fix the error of checking the null point
Change-Id: Ied5d9d5268d9d6d83b2995ae0e56bf5f0276ad22
Test: manual
2023-02-11 17:22:21 +00:00
Bonian Chen
1430ebce77 Merge "[Settings] Close UI when accessed from guest user" 2023-02-11 15:26:08 +00:00
TreeHugger Robot
34b7835a50 Merge "Hide "no thanks" button when enrollment completed." 2023-02-11 02:34:19 +00:00
Tyler Freeman
35def91fcc Merge "feat(#MagnificationJoystick): add preference for enabling Joystick to Settings" 2023-02-11 01:04:00 +00:00
Bonian Chen
131ca6ca75 Merge "[Settings] Close UI when accessed from guest user" 2023-02-11 00:55:08 +00:00
Becca Hughes
04fe12449e Add back dialog when disabling provider
Adds back a dialog that will ask the
user to confirm their choice when
disabling the last credman provider.

Test: ondevice & make
Bug: 267816757
Change-Id: Icefde62efe7daa9aad2da7ad9d3fd37e40b4376b
2023-02-10 21:19:57 +00:00
Tyler Freeman
43d5042ff9 feat(#MagnificationJoystick): add preference for enabling Joystick to Settings
Hide behind feature flag so no one sees the preference unless its enabled.

Bug: b/265688847

Test: atest MagnificationJoystickPreferenceControllerTest

Change-Id: Id5cc9385f25395f53809a79ba70c84205f9758c2
2023-02-10 19:19:11 +00:00
Bonian Chen
76cd5d3c27 [Settings] Close UI when accessed from guest user
Avoid from guest user access.

Bug: 262242953
Test: local

Change-Id: Ifdc6d7ea7f65a945b2111a391eb53de6c1a3f52b
2023-02-10 18:09:09 +00:00
Bonian Chen
9d3bb818bf [Settings] Close UI when accessed from guest user
Avoid from guest user access.

Bug: 262242953
Test: local

Change-Id: Ib49693d083f42194575f958a1a238d6dfbba55d2
2023-02-10 17:51:00 +00:00
Josep del Rio
8411d1c663 Use InputSettings in Settings app
At the moment the settings app will make use of certain exposed
functions in InputManager that are being moved to a separate
class. This CL migrates those usages to the new internal API.

Bug: 267758905
Test: compiles, and should pass presubmit
Change-Id: I30dcb83aa1cc8830650fe856775a462ed37c2dda
2023-02-10 16:37:49 +00:00
Bonian Chen
eb8ec1b1e4 Merge "[Settings] Avoid from user without sufficient permission to change WiFi calling" 2023-02-10 16:22:46 +00:00
Ioana Alexandru
4c5231324e Remove method to change allowed NAS adjustments.
Bug: 268604587
Test: NotificationBackendTest

Change-Id: I5184c73c7ac9a49c5195021319065200f74c4ff4
2023-02-10 15:52:43 +00:00
Alex Johnston
2747dc6e8c Implement OP_SYSTEM_EXEMPT_FROM_POWER_RESTRICTIONS exemption
OP_SYSTEM_EXEMPT_FROM_POWER_RESTRICTIONS details:
* An app with this appop will be made exempt from all
  power restrictions, including app standby and doze.
* In addition, the app will be able to start fgs from
  the bg, and the user will not be able to stop fgs
  run by the app.

Changes:
* Implement the OP_SYSTEM_EXEMPT_FROM_POWER_RESTRICTIONS

Bug: 246330879
Test: atest PowerAllowlistBackendTest

Manual testing:
- Give OP_SYSTEM_EXEMPT_FROM_POWER_RESTRICTIONS appop to TestDPC app
- Verify the app can start fg services from the bg
- Verify fgs started by the app cannot be stopped
- Verify the app cannot be put into background restricted via Settings

Change-Id: If9e76076c59195f1e6e5f3eee3c8e7a0c754d8de
2023-02-10 13:37:38 +00:00
Bonian Chen
a1d3fe061e [Settings] Avoid from user without sufficient permission to change WiFi
calling

Enhance security control through close UI when accessing by user with
restriction.

Bug: 262390632
Bug: 262243015
Test: local

Change-Id: I4fadaf2bdc55b97419f9e6abbd3cfa63af034f6a
2023-02-10 12:58:36 +00:00
Jakub Rotkiewicz
934b0bb739 SnoopLogger: Debug enhancements added settings
Bug: 247859568
Tag: #feature
Test: make RunSettingsRoboTests3
Test: make RunSettingsRoboTests4

Change-Id: I132a1558ea67400d9c10dda523456f99eb815b92
2023-02-10 09:59:52 +00:00
Candice Lo
4eea038c26 Merge "Move font size related resources to SettingsLib (1/2)" into tm-qpr-dev am: b0087167e0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/21312036

Change-Id: Ie07b89f7f2095c42cd30e20d4a9a3031b679b26b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-10 09:19:51 +00:00
Nikhil Kumar
69bc7b0438 SettingsHomepageActivity: Get profile parent using UM.getProfileParent
In the headless system user mode(hsum) non-primary users can also have a profile.
The existing implementation in SettingsHomepageActivity always gets the primary user as the profile parent, refactored the implementation to get profile parent using UserManager.getProfileParent.

Get parent user id instead of primary user as profile parent

Bug: 267299459
Test: croot && make RunSettingsRoboTests -j40
ROBOTEST_FILTER=SettingsHomepageActivityTest

Change-Id: I36845eb5b1a09b0ff3d87c7d08b120c95f59783b
2023-02-10 09:15:03 +00:00
Nikhil Kumar
cb5dcaee3b SettingsActivity: Get profile parent using UserManager.getProfileParent
In the headless system user mode(hsum) non-primary users can also have a profile.
The existing implementation in SettingsActivity always gets the primary user as the profile parent, refactored the implementation to get profile parent using UserManager.getProfileParent.

Test: NA
Bug: 267162079
Change-Id: I2af581a4b7e3320f9351b862b7be3ef141b744b7
2023-02-10 09:12:33 +00:00
Candice Lo
b0087167e0 Merge "Move font size related resources to SettingsLib (1/2)" into tm-qpr-dev 2023-02-10 09:12:05 +00:00
Bonian Chen
b73369e874 Merge "[Settings] User with restriction should avoid from having entries through Settings search" 2023-02-10 08:52:55 +00:00
My Name
2e552331e9 Show Bluetooth dialog in a specific case
If the application that initiate the bonding with
BluetoothDevice#createBond is in foreground, then should dialog only
instead of showing the notification & dialog

Bug: 175931562
Tag: #refactor
Test: manual
Change-Id: I3673a0b58cbf9caabf62c951b84b49e17cfb13b8
2023-02-10 08:31:34 +00:00
Lili Zou
2a445bb89e Support search for work profile settings page.
Test: manual, robotest
Bug: 254192800
Change-Id: Id8ec76557fc170fcf727da1971cd90f494c7ecd4
2023-02-10 15:51:34 +08:00
Candice Lo
3fb6e69f88 Move font size related resources to SettingsLib (1/2)
Since creating the seekbar for changing font size in SystemUI requires
the size of the value entry array and the values in the array.
Therefore, we move the related resource to SettingsLib to share the usage.

Bug: 242326166
Test: make RunSettingsRoboTests ROBOTEST_FILTER=FontSizeDataTest
Test: Maually test the availability of changing font size through
Settings page

Change-Id: Ia2621e3b4c71f900e6591644d0e3f93bedbe4ee8
Merged-In: If630bd9c9c27823c210410b53342b921a11bbfb9
2023-02-10 06:36:50 +00:00
Candice Lo
9aabfafb4c Merge "Move entryvalues_font_size to SettingsLib (1/2)" 2023-02-10 06:33:40 +00:00
Tom Hsu
d3ff83eb4f Merge "[Regional Preferences] Remove u extension for subtitle of Language" 2023-02-10 03:57:51 +00:00
Hao Dong
54003698b1 Do not show udfps enrollment page in multi window mode.
In multi window mode, finish FingerprintEnrollEnrolling activity
and show a toast.

Test: atest FingerprintEnrollEnrollingTest
Bug: 184118847
Change-Id: I8cfa61b334c029185e1bbf46fdbf158bb493a1e0
2023-02-10 01:30:30 +00:00
Daniel Norman
56f1eb0fbf Merge "Adapt to moved ACCESSIBILITY_MENU_IN_SYSTEM location." 2023-02-09 23:05:18 +00:00