Commit Graph

119886 Commits

Author SHA1 Message Date
Chengfei Tao
08ac9c1246 Accessibility toggle button small tappable area fix
Revert part of the layout change from b/233835795 fix so that
the issue of small tappable area in b/265859032 is fixed while
we continue to look at a better fix for b/233835795

Test: Manually change different Display & Font size to test UI
Test: m RunSettingsRoboTests ROBOTEST_FILTER="com.android.settings.biometrics.face.FaceEnrollEducationTest"

Bug: 265859032

Change-Id: I90ba7cc11dc61380dfdf0c3bcd2c59a17b43ee0e
2023-02-02 15:14:28 +08:00
Chaohui Wang
8e403533ad Merge "Add AppPermissionPreferenceTest" 2023-02-02 07:06:36 +00:00
danielwbhuang
f43c358b50 Integrate UI with APIs for physical keyboard settgins.
Integrate UI with these APIs.
1. getKeyboardLayoutListForInputDevice
2. getKeyboardLayoutForInputDevice
3. setKeyboardLayoutForInputDevice

Demo: go/pk_with_final_api_demo

Bug: 247079681
Test: local test

Change-Id: I5478e2c344a47e692e7c524f8c1e96d9dda52796
2023-02-02 14:52:38 +08:00
Chaohui Wang
87257eccac Move product specific strings to res-product
Move the followings,
- lockpassword_confirm_your_pattern_details_frp
- lockpassword_confirm_your_pin_details_frp
- lockpassword_confirm_your_password_details_frp

Product specific strings need to be put in res-product.

Bug: 250807976
Test: Make Settings
Change-Id: I5916a254a9e42ed365f6d26deedd9879636606f7
2023-02-02 14:15:05 +08:00
Bonian Chen
211920bc7c [Settings] Fix about phone crash no leave
Avoid from crash when LifecycleOwnerLiveData reports null during
destroy.

Bug: 267513122
Test: local

Change-Id: Ie541b0e5b81aa14bd064087c5343716b6bc066a3
2023-02-02 06:10:55 +00:00
George
abe460f88b Update strings for Nfc Tag App Preference
Bug: 244272155
Test: manual
Change-Id: I82d5c89d1b2e4dd611d512b21d192ad8a8d0220b
2023-02-02 14:05:40 +08:00
Lyn
685f1e4771 Settings page to manage FSI permission
Apps > Special App Access > Manage Full Screen Intents > App Specific page

Follows new Settings Platform Architecture that the Settings team
is migrating to for UDC.

Bug: 243421660
Test: make SettingsGoogle -j40
adb install -r out/target/product/$TARGET_PRODUCT/system_ext/priv-app/SettingsGoogle/SettingsGoogle.apk

Change-Id: Id2ca18480ddf788bee18b67a3689ef9593059a24
2023-02-02 05:36:52 +00:00
Chaohui Wang
e4c9959fd7 Add AppPermissionPreferenceTest
Unit test for AppPermissionPreference.

Bug: 236346018
Test: Unit test
Change-Id: I83e19bd8d4d667fb6cb2be8aed85ba7f0a8f149e
2023-02-02 13:34:09 +08:00
TreeHugger Robot
6ef43a4c2c Merge "Update illustration for tablet" into tm-qpr-dev am: a50ca10f33 am: 8d75b9c6d4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/21187563

Change-Id: If9b5c5fe4814ab8cf46c754884c2b261378b0c7d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-02 04:42:53 +00:00
TreeHugger Robot
8d75b9c6d4 Merge "Update illustration for tablet" into tm-qpr-dev am: a50ca10f33
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/21187563

Change-Id: Iecd7bf4950b5ea60d0abc648fe7df7ab790ebd3b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-02 03:45:23 +00:00
Hao Dong
24f8463af4 Add udfps/ and support a11y for the udfps enroll view.
This CL calls methods in UdfpsEnrollUtils.java to announce a11y
message. Besides, scale factor calculation and UdfpsOverlayParams.java
are removed since they are added in settingslib/.

Test: manually tested on device:
      Turn on talkback and turn this flag on via adb command
      adb shell setprop
        sys.fflag.override.settings_show_udfps_enroll_in_settings true
Bug: 186873966, 260617060
Change-Id: I408ac6a36352aa4bfd4ac1374e3922163dbc2199
2023-02-02 11:25:14 +08:00
TreeHugger Robot
a50ca10f33 Merge "Update illustration for tablet" into tm-qpr-dev 2023-02-02 03:09:34 +00:00
Josh Hou
6bbe735831 [automerger skipped] Fix the security vulnerability issue in AppLocalePickerActivity am: 33ef83795e am: 406abc4d62 -s ours am: 576564873f -s ours am: 0333fd29a5 -s ours
am skip reason: Merged-In I2e25a308bcba6ea0edee89c7a78465f766bdbeac with SHA-1 5d7d1665fe is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/21152842

Change-Id: I6026bbef3f00a9adff5b7f0b566fb707116a5584
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-02 02:58:04 +00:00
Victor Truong
71fd373fd0 Merge "Replace SystemUser checks with MainUser." 2023-02-02 02:51:26 +00:00
TreeHugger Robot
376bb8d606 Merge "No screen lock notification" 2023-02-02 02:23:16 +00:00
Josh Hou
0333fd29a5 [automerger skipped] Fix the security vulnerability issue in AppLocalePickerActivity am: 33ef83795e am: 406abc4d62 -s ours am: 576564873f -s ours
am skip reason: Merged-In I2e25a308bcba6ea0edee89c7a78465f766bdbeac with SHA-1 5d7d1665fe is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/21152842

Change-Id: I0d19fee172000f2be5a0eae55d63d26ec5267f1e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-02 02:02:51 +00:00
Daniel Huang
d0e737cf86 Merge "Add Trackpad settings tests" 2023-02-02 01:45:26 +00:00
Automerger Merge Worker
87bd497510 Merge "[automerger skipped] Fix the security vulnerability issue in AppLocalePickerActivity am: 33ef83795e am: 30c88f6ff3 -s ours" 2023-02-02 01:33:48 +00:00
Edgar Wang
296f4c4a6f Update illustration for tablet
Fixes: 244271773
Test: visual
Change-Id: Ic8968a951fc6c9b8023aa522aabdac3f1bcb84d3
2023-02-02 01:33:06 +00:00
Josh Hou
7d33817ae2 [automerger skipped] Merge "Fix the security vulnerability issue in AppLocalePickerActivity" into tm-qpr-dev am: 1739114d44 am: 3f4d63b943 -s ours
am skip reason: Merged-In I2e25a308bcba6ea0edee89c7a78465f766bdbeac with SHA-1 ed9cbdea18 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/21052003

Change-Id: I737a086ecc2474da9550690c66d7b523dfdae2ee
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-02 01:29:46 +00:00
Josh Hou
576564873f [automerger skipped] Fix the security vulnerability issue in AppLocalePickerActivity am: 33ef83795e am: 406abc4d62 -s ours
am skip reason: Merged-In I2e25a308bcba6ea0edee89c7a78465f766bdbeac with SHA-1 5d7d1665fe is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/21152842

Change-Id: I19bad7bb7aa3f25ecc76494082a4a725c690a039
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-02 01:28:45 +00:00
Josh Hou
d5c65e7ef1 [automerger skipped] Fix the security vulnerability issue in AppLocalePickerActivity am: 33ef83795e am: 30c88f6ff3 -s ours
am skip reason: Merged-In I2e25a308bcba6ea0edee89c7a78465f766bdbeac with SHA-1 ed9cbdea18 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/21152842

Change-Id: I5d7d6fd19f153baf3b4a62ccc04906fc20b35d96
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-02 01:28:41 +00:00
Josh Hou
406abc4d62 Fix the security vulnerability issue in AppLocalePickerActivity am: 33ef83795e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/21152842

Change-Id: Ic0ff8ade7897052d04c118dc0a8f67312f5d0ebf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-02 00:50:59 +00:00
Josh Hou
3f4d63b943 Merge "Fix the security vulnerability issue in AppLocalePickerActivity" into tm-qpr-dev am: 1739114d44
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/21052003

Change-Id: Iab6296f2dcdef8a25c0cb514bce478afcc70d67d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-02 00:50:04 +00:00
Josh Hou
30c88f6ff3 Fix the security vulnerability issue in AppLocalePickerActivity am: 33ef83795e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/21152842

Change-Id: I53a4279eb0dc9044a97fd15e193e95fd0c16ec9f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-02 00:49:52 +00:00
Diya Bera
55dd3a4f6d Merge "Tests for SUW in work mode" into tm-qpr-dev am: 31406c042d am: 4d67530e85
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/20505465

Change-Id: Ib6259a7897a43bc326410c17c4baa5f681edc7b8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-02 00:33:16 +00:00
Josh Hou
1739114d44 Merge "Fix the security vulnerability issue in AppLocalePickerActivity" into tm-qpr-dev 2023-02-02 00:15:12 +00:00
Diya Bera
4d67530e85 Merge "Tests for SUW in work mode" into tm-qpr-dev am: 31406c042d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/20505465

Change-Id: Ida39801c898a529725f3fc7484e8907a2591e348
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-01 23:59:37 +00:00
Diya Bera
31406c042d Merge "Tests for SUW in work mode" into tm-qpr-dev 2023-02-01 23:29:35 +00:00
Edgar Wang
0fd7e6e3e7 Merge "Update lottie illustration for tablet" into tm-qpr-dev am: b5215abde7 am: 366ed57197
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/21154459

Change-Id: I7ba454aa3a58ec6c8f848ac5d09ea2385fdb3a33
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-01 23:06:50 +00:00
Diya Bera
1021b58ae5 Tests for SUW in work mode
Bug: 247049655
Test: m RunSettingsRoboTests -j30 ROBOTEST_FILTER=MultiBiometricEnrollHelperTest
Change-Id: Ifabb96a90c340bc9306cc0f033ba103c614f32a9
2023-02-01 22:05:09 +00:00
Victor Truong
f3c9a09cac Replace SystemUser checks with MainUser.
Bug: 257333623
Test: atest CommunalPreferenceControllerTest, atest UtilsTest, atest
TimeoutToDockUserPreferenceControllerTest

Change-Id: I5d2a818f9f35968ced1db7f9fa4b79432a502023
2023-02-01 15:16:48 -05:00
TreeHugger Robot
afb30cdd08 Merge "Make pre-upgrade footer appear more consistently" 2023-02-01 18:30:13 +00:00
Neil Fuller
8e727b4dba (Re)Introduce "enabled by admin" UI state
(Re)Introduce "enabled by admin" / "disabled by admin" SettingsUI state.

ag/18665634 changed behavior: When enterprise policy restricts the
user's ability to change the "auto time" and "auto time zone" toggle,
the toggle was hidden rather than "visible but disabled".

Bug 266693620 demonstrates testers are checking for the behavior.

This commit returns the old behavior for the "auto time" and "auto time
zone" SettingUI behavior, i.e. the user can see the toggle and its
setting value, but is told that it is under admin control and the
current setting value.

See the bug for more info / historic behavior analysis.

Bug: 266693620
Test: Manual testing with TestDPC
Test: atest to confirm existing tests do not fail
Change-Id: I0a605054312547fbd44fc34025ee36b075e05e01
2023-02-01 14:02:17 +00:00
Thomas Lin
76fc4a3c65 Add thomasli to a11y settings OWNERS
Test: N/A

Change-Id: I9bf9e92f9612baee686fcd81487a731d927a662a
2023-02-01 19:17:51 +08:00
Jason Chang
4e03bc2133 Merge "Fix string was shown with "Phone" in the tablet device" 2023-02-01 10:53:45 +00:00
Edgar Wang
366ed57197 Merge "Update lottie illustration for tablet" into tm-qpr-dev am: b5215abde7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/21154459

Change-Id: If11468af414a092695276e4040f735fc88245828
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-01 10:45:19 +00:00
Edgar Wang
b5215abde7 Merge "Update lottie illustration for tablet" into tm-qpr-dev 2023-02-01 10:22:46 +00:00
Jason Chang
01c8438223 Fix Face and Fingerprint setting page's title
"Use face or fingerprint to" is missing

Add a new title string for biometrics settings page title.

Bug: 264902889

Test: manually local build then using issue reproducible steps to
verify Face and Fingerprint Settings page category tiile strings

Change-Id: Ifeb3529e0ff444fc75b81ef9bbafc66c3de41956
2023-02-01 08:17:57 +00:00
Josh Hou
33ef83795e Fix the security vulnerability issue in AppLocalePickerActivity
Examine whether the packages is allowed to display app locales list when creating the AppLocalePickerActivity, and examine whether the target user is the same as the calling user.

Bug: 257954050
Test: Follows the test step listed in b/257954050#comment14
Change-Id: I2e25a308bcba6ea0edee89c7a78465f766bdbeac
Merged-In: I2e25a308bcba6ea0edee89c7a78465f766bdbeac
2023-02-01 15:49:20 +08:00
Josh Hou
5d7d1665fe Fix the security vulnerability issue in AppLocalePickerActivity
Examine whether the packages is allowed to display app locales list when creating the AppLocalePickerActivity, and examine whether the target user is the same as the calling user.

Bug: 257954050
Test: Follows the test step listed in b/257954050#comment14
Change-Id: I2e25a308bcba6ea0edee89c7a78465f766bdbeac
Merged-In: I2e25a308bcba6ea0edee89c7a78465f766bdbeac
2023-02-01 15:42:22 +08:00
Edgar Wang
2f5f6d4ee6 Update lottie illustration for tablet
Bug: 243889662
Bug: 243889643
Test: visual
Change-Id: Icac10e4401da3d704350aef6ef2723ff92ca34f8
2023-02-01 07:27:18 +00:00
Jason Chang
c144de0b9d Fix string was shown with "Phone" in the tablet device
Add string "product" attribute for "tablet" and "device" strings.

Bug: 233295460

Test: build ROM then using issue reproducible steps to verify
screen lock strings

Change-Id: I912364fd54e7100c8a7e59c5b49e26467cec8142
2023-02-01 06:58:00 +00:00
danielwbhuang
6007a4bc0c Add Trackpad settings tests
1. TrackpadBottomPreferenceControllerTest
2. TrackpadPointerSpeedPreferenceControllerTest
3. TrackpadReverseScrollingPreferenceControllerTest
4. TrackpadTapToClickPreferenceControllerTest

Bug: 247080509
Test: manual, make RunSettingsRoboTests ROBOTEST_FILTER="com.android.settings.inputmethod.*"
Change-Id: I61d6dd9bb807ec636e4103efc5b9ccc28d5bc2c1
2023-02-01 14:37:04 +08:00
George
2c5d1f8d29 Adding Nfc Tag App Preference setting to special_access settings
In the settings app, allow users to change the preference of the Nfc Tag apps.

Bug: 244272155
Test: make RunSettingsRoboTests ROBOTEST_FILTER=NfcTagAppsPreferenceControllerTest
Change-Id: I28903fae8935613a0e8618da21ca44e98b8801d5
2023-02-01 14:10:04 +08:00
Chaohui Wang
a72e62b3a3 Merge "Use SettingsAlertDialog for app button dialogs" 2023-02-01 02:43:24 +00:00
Yong Zhang
a5cdbee7b9 Merge "Adjust AlwaysExpand List so that face detail settings will show in side panel while posture guidance will show full-screen" into tm-qpr-dev am: 6cb1a7ce5a am: f691b4302d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/21135024

Change-Id: I45505e8c798e51b36b828f31d0b31046c0c8c0ce
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-01 00:52:55 +00:00
Derek Jedral
1e43f8f22d Merge "Fix NPE with registering content listener" 2023-02-01 00:24:00 +00:00
Yong Zhang
f691b4302d Merge "Adjust AlwaysExpand List so that face detail settings will show in side panel while posture guidance will show full-screen" into tm-qpr-dev am: 6cb1a7ce5a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/21135024

Change-Id: I64554550e193357bc8e7061888e771f1e1d27b44
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-01 00:11:05 +00:00
Florian Mayer
e3031c98ba Use bootloader_override from boot namespace
Bug: 267234468
Change-Id: I6e6229504a452d8a82f8928a79e10b342478524c
2023-01-31 23:52:03 +00:00