Commit Graph

483 Commits

Author SHA1 Message Date
Jason Chiu
4e7229c440 Merge "[Settings] Add a metric for time spending in each Settings page" 2019-12-25 08:23:48 +00:00
Jason Chiu
9c628ee945 [Settings] Add a metric for time spending in each Settings page
Add elapsed time in the target page hidden metric

Bug: 146610928
Test: robotest
Change-Id: If045a203e3ca64e36ec5d764b3488d10f26c4408
2019-12-25 11:06:16 +08:00
Edgar Wang
08f2a58459 Settings search - Navigate user to exact page
- remove duplicate index preference
- default set searchable = false when the preference has fragment
- make some fragments indexable

Bug: 143057584
Test: robotest & manual

Change-Id: I4d64f6106d2f92f0a45e8c7e26388677f593f412
2019-12-24 21:04:11 +08:00
Mehdi Alizadeh
035559615b Adds a new activity for Gesture Navigation settings
Bug: 146004827
Test: WIP

Change-Id: Id2732a94e7e1469575aa8204c727379a829bccf8
2019-12-19 17:37:27 -08:00
TreeHugger Robot
2e2532077d Merge "Fix UI issue in LocationSettings" 2019-12-17 09:06:38 +00:00
Raff Tsai
5ec8efe7e0 Fix UI issue in LocationSettings
- Add WorkPreferenceController to support directly use work profile
related feature in xml
- Get only work/personal infos in RecentLocationRequestPreferenceController
and RecentLocationRequestSeeAllPreferenceController
- Remove ProfileSelectStorageFragment

Bug: 141601408
Fixes: 146080649
Test: manual, robolectric
Change-Id: Ide39c7a3796e16421f3a5690309c3d746a956de8
2019-12-17 04:25:49 +00:00
Paul Chang
df9501ba62 Merge "Have a setting in Developer Options to choose bug report handler" 2019-12-17 03:20:19 +00:00
Jason Chiu
d955ebcd61 Merge "[Settings] Add preference click metric log" 2019-12-16 08:58:35 +00:00
Jason Chiu
1281e595e4 [Settings] Add preference click metric log
- Move the log point of onPreferenceTreeClick from DashboardFragment to
  it's super class InstrumentedPreferenceFragment for better coverage.
- Write the preference click metric log in PreferenceController handling
  case in DashboardFragment which will skip super class's log point.

Bug: 137559984
Test: robotest
Change-Id: I67178f613c74f755e20fc9dc41319974cb02e83c
2019-12-16 10:57:09 +08:00
Yi-Ling Chuang
cf0fbde078 Add a feature flag for Settings conditionals removal.
Bug: 142927361
Test: rebuild and manual
Change-Id: I795700c70c50bd8d18a64bfbe4293fd0fa0e2467
2019-12-13 12:11:11 +08:00
Paul Chang
6ae4c4d6ee Have a setting in Developer Options to choose bug report handler
- This setting let user determines which app handles the Bug Report
shortcut on device.

BUG:143017534
Test: make -j56 RunSettingsRoboTests
Test: Ensure bug report handler setting shows correct handler apps.
Change-Id: I6160dadcd048e6c79f422e58fcd8defa04f991bb
2019-12-13 11:15:53 +08:00
Automerger Merge Worker
df76207905 Merge "Dark theme settings activity" into qt-qpr1-dev am: 8b95d6ab2a am: cafec428ef
Change-Id: Ia345f84843f6df7f2e22ffc72988fc56935d9cf4
2019-12-12 21:10:38 +00:00
Jay Aliomer
8b95d6ab2a Merge "Dark theme settings activity" into qt-qpr1-dev 2019-12-12 20:32:01 +00:00
Jay Aliomer
82a0ea022e Dark theme settings activity
Dark theme settings is now launchable as an activity

Test: launch activity android.settings.DARK_THEME_SETTINGS
Fixes: 145560830

Change-Id: I24b8d3211e9d6e7a5b1f226001882573ae7fb311
2019-12-11 17:41:35 +00:00
Automerger Merge Worker
4fd41fe196 Prevent accounts page directly opening in screen pinning mode am: a545a85f9d am: fd45c98d53
Change-Id: Id48f14bb8258d615dc2fe9e552640ab06aa528ab
2019-12-11 06:51:34 +00:00
Raff Tsai
f71db73025 Implement work-profile infra in BasePreferenceController
- Add settings:forWork in xml
- Set mIsForWork based on xml attribute
- Delete WorkProfilePreferenceController and move its function to
BasePreferenceController

Fixes: 123376083
Test: Add work profile, go to Settings->System->Language&input,
UI should show work profile related items
Change-Id: Id2dcbb0e158c117cdfd363466a275f4e133c345e
2019-12-10 09:32:37 +08:00
Mill Chen
a545a85f9d Prevent accounts page directly opening in screen pinning mode
In Settings there is no auth mechanism to prevent accounts page being
opened in screen pinning mode. This CL makes it so that when users are
trying to navigate to any pages in Settings from other apps in screen
pinning mode, Settings app will directly close its page.

Bug: 137015265
Bug: 135604684
Test: manual
Change-Id: If26eda408a9ef6fa03ad82e5bee51bb7185950d6
Merged-In: If26eda408a9ef6fa03ad82e5bee51bb7185950d6
(cherry picked from commit f3242dab35)
2019-12-09 03:18:24 +00:00
Sunny Shao
fafcbd3ee2 Add a LiveDataController
Bug: 137558156
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.core

Change-Id: I5c223fbeb83e3f51ddb154de4990c3e3428ba442
2019-12-05 13:59:34 +08:00
Abhijeet Kaur
af95719337 Merge "Make Settings UI fuse flag "settings_fuse" persistent" 2019-12-02 15:48:28 +00:00
TreeHugger Robot
7e117fba33 Merge "Reorganize notification Settings classes" 2019-12-02 13:54:05 +00:00
TreeHugger Robot
0a2a6cfef7 Merge "Add page creation latency for updatePreferenceStates" 2019-12-02 02:44:00 +00:00
Sunny Shao
e5e82400ac Add page creation latency for updatePreferenceStates
- The updatePreferenceStates is called in the onResume. Here creates a new enum to
  record the elapsed time.

Bug: 137558156
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.dashboard
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.core
Change-Id: I02bdbeecd61fbc0082eea19ea64cbfe7541a6970
2019-11-28 17:00:31 +08:00
Yi-Ling Chuang
617458b07c Make all TogglePreferenceController slice-able.
All the descendants of TogglePreferenceController are now slice-able by
default, where every controller can still disable it by overriding this
value. Though all of them are now slice-able, doesn't necessarily means
they are exposed publicly as we set the default value of isPublicSlice()
to false. For those that want to be public ones will have to override
this value.

Bug: 141088937
Test: robotests
Change-Id: I2ea529c11f0177cd6c55754b632cd1fea1dcc48f
2019-11-28 14:12:41 +08:00
Julia Reynolds
aceccce75c Reorganize notification Settings classes
The notification package was getting too big.

Test: make -j64 RunSettingsRoboTests
Fixes: 145224451
Change-Id: I25ba82f42f7a137d8adcce72dcf8089d0e018bdc
2019-11-27 10:02:13 -05:00
Abhijeet Kaur
a667372c56 Make Settings UI fuse flag "settings_fuse" persistent
Bug: 144419848
Test: The value of system property settings_fuse persists after reboot
Change-Id: I207e72fdc56785dbde350e01f753c865294a3eba
2019-11-20 11:07:13 +00:00
Stanley Wang
4a08fc1c59 Add new method to preference controller base for dynamic index.
- Add updateDynamicRawDataToIndex method.
- Implement preference controller index in BaseSearchIndexProvider.

Fixes: 144545478
Test: make RunSettingsGoogleRoboTests -j
      make RunSettingsRoboTests ROBOTEST_FILTER=
      com.android.settings.search.BaseSearchIndexProviderTest
Change-Id: Ibb11002227b280102b45d7c0610eae48ecf4c0f3
2019-11-19 14:47:10 +08:00
Arc Wang
75dc89b122 [Wi-Fi] Create WifiNetworkDetailsFragment related version 2 files for WifiTracker2 development
Create below version 2 files for WifiTracker2 development, we can
check the feature flag only a few times and easily remove version 1
files in the future.

    src/com/android/settings/wifi/details2/
    src/com/android/settings/wifi/savedaccesspoints2/
    tests/robotests/src/com/android/settings/wifi/details2/
    tests/robotests/src/com/android/settings/wifi/savedaccesspoints2/

Bug: 143326832
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.wifi.details2
      make RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.wifi.savedaccesspoints2

Change-Id: I4d2caf1ce313871605252395764b02747240f217
2019-11-15 14:41:23 +08:00
Julia Reynolds
9540929cfe Merge "Add NLS specific screens for notification listener approval" 2019-11-13 14:02:39 +00:00
Sunny Shao
a4d2ab80fa Add a feature flag for controller loading enhancement
Bug: 137558156
Test: manual test
Change-Id: I4f2988ea889735e66bc227bb814707c5b01b770b
2019-11-13 08:47:43 +08:00
Raff Tsai
16a81eb3f6 Sync lastest lifecycle interface
Bug: 142938506
Test: rebuild
Change-Id: I6a8d75e5a3ba8564cfb400a88d6582c962c965ee
2019-11-11 16:19:07 +08:00
Julia Reynolds
31dc1fd806 Add NLS specific screens for notification listener approval
Fixes: 141689199
Fixes: 143639217
Test: atest

Change-Id: I4ead087e0015ad33d6be4f9357de50a4298b3347
2019-11-08 14:13:24 +00:00
Raff Tsai
1eccd55a70 Remove mobile network v1
Fixes: 142920912
Test: rebuild, robolectric
Change-Id: Ib365ba712af62729ca35abbc370aef087ce52a90
2019-11-05 17:54:54 +08:00
Bonian Chen
5cc9aad7a8 [Setting] Cleanup Unused SimSettings
There's no entry to access SimSettings.
Remove this unused UI.

Bug: 131324863
Test: manual
Change-Id: I3f50e528eb409215371a125184502d3531bad0a8
2019-10-20 09:01:30 +00:00
Raff Tsai
65866290ce Add tablayout for work/personal profile
- Add Tablayout in ProfileSelectFragment
- Add AccountWorkProfileDashboardFragment inherited from
ProfileSelectFragment
- Add ProfileFragmentBridge to convert AccountDashboardFragment
to AccountProfileSelectFragment
- Use flag settings_work_profile to guard the new fragment

Bug: 141601408
Test: Settings->developer options->feature flags->
turn settings_work_profile on/off, then go to settings->account
to see if UI is changed.

Change-Id: Ifb32c22cdeab69c51517664081cacf4a401c46a1
2019-10-15 18:01:08 +08:00
Jason Chiu
1a1f9314b6 Refactor Settings for injection v2 inline toggle
Bug: 132808482
Test: robotest
Change-Id: I0b74e05bc26b97259a15859c669060ce3da7972a
2019-10-04 18:32:11 +08:00
Raff Tsai
9e3a9fd255 Add fragment in xml instead of using injected way
- It can improve performance because we use less injected item
- Also remove summary provider from those fragments

Bug: 141653158
Test: robolectric
Change-Id: I6255f71b3b8300aea064a4fefd6711c1ff59e08a
2019-10-02 11:49:51 +08:00
Raff Tsai
966fa01423 Use SettingsLib Indexable
- Use SettingsLib Indexable
- Directly use resource id in getPreferenceScreenResId

Bug: 135053028
Test: roboletric
Change-Id: I05f493b55e8b6e2091301e9231ba5615215618e6
2019-09-25 18:24:56 +08:00
TreeHugger Robot
aa7e09ec26 Merge "Revert "Refreshes preference text when updateStates"" 2019-09-09 04:49:14 +00:00
Sunny Shao
92dbda2af0 Revert "Refreshes preference text when updateStates"
This reverts commit ff6cc9be3c.

Reason for revert: This cl caused some toggle preference just show on/off in the subtext.

Fixes: 138988285
Fixes: 140475264
Fixes: 140536268
Change-Id: I6cc5136205c50ae373fdfb32f2252a1f7a7c51aa
2019-09-09 03:44:58 +00:00
Mill Chen
14ed4a0efd Prevent accounts page directly opening in screen pinning mode
In Settings there is no auth mechanism to prevent accounts page being
opened in screen pinning mode. This CL makes it so that when users are
trying to navigate to any pages in Settings from other apps in screen
pinning mode, Settings app will directly close its page.

Bug: 137015265
Test: manual
Change-Id: Ice2250eb00be9d2181901cef6d1f04b4a8233bfc
2019-09-06 21:09:53 +08:00
Abhijeet Kaur
59be362d67 Use USE_BUGREPORT_API flag from FeatureFlagUtils
To avoid flag duplication, this flag is moved to FeatureFlagUtils.java
where other callers can also use this flag. Using this flag's value from
FeatureFlagUtils instead of the local FeatureFlag file in Settings.

Bug: 136548292
Test: Settings can still access this feature flag as before
Test: Builds and API workflow gets triggered by turning on the flag
Change-Id: I60e4d96033219c934a43e728705fee93e338d60e
2019-08-07 16:47:28 +01:00
Julia Reynolds
c400ce3c80 Move channel listing into a pref controller
And a hidden preference category. This makes
hiding/showing the list a lot cleaner and also allows more
of the code to be tested.

Also delete some unused code that no longer complied after
this refactor.

Fixes: 133443871
Test: atest
Change-Id: I4a5fe0e075019bae2df44a0a9dcec26a40ee6d12
(cherry picked from commit a295d71c94)
2019-07-26 19:24:43 +00:00
Quang Luong
b470e725c9 Added WifiSettings -> WifiSettings2 redirection behind feature flag
Use WifiSettings2 if settings_wifitracker2 feature flag is enabled.
WifiSettings2 will be used for changes to WifiSettings to incorporate
the WifiTracker2 refactor.

Bug: 70983952
Test: make, set feature flag, open Wifi settings to verify new page
opens.

Change-Id: I08edc227bf38ab4b3b785180bf123815bf95da81
2019-07-22 14:41:11 -07:00
Julia Reynolds
a295d71c94 Move channel listing into a pref controller
And a hidden preference category. This makes
hiding/showing the list a lot cleaner and also allows more
of the code to be tested.

Also delete some unused code that no longer complied after
this refactor.

Fixes: 133443871
Test: atest
Change-Id: I4a5fe0e075019bae2df44a0a9dcec26a40ee6d12
2019-07-02 11:24:50 -04:00
Andrew Sapperstein
82ce229d4a Merge "Add UI for mainline modules licenses." into qt-dev am: 72aded338a am: 0c1f7da25a
am: 722f8c0ac1

Change-Id: Ib41961f01cfc6530a43e65e593a1248714f6143c
2019-06-28 11:07:18 -07:00
Andrew Sapperstein
56a8c33c1b Add UI for mainline modules licenses.
Added a module licenses option that lives in Legal information settings.
Clicking that option opens module licenses page, which displays every
module by name, filtered to exclude modules without license files.
Clicking a module in the list opens HTMLViewer.

Created ModuleLicensesProvider, a new ContentProvider that serves as a
redirect for the Uris sent to HTMLViewer so that they open asset files.
In order to provide the redirect, the provider will write the license file
to a file in Settings' cache directory when the license does not exist
in the cache or is outdated. The provider then opens that cached file.

Fixes: 135183006
Test: robotests
Change-Id: I7d69da34780c8c4efb150d0c0411078c12bc80d8
2019-06-25 16:01:38 -07:00
Fan Zhang
13cf250be5 Remove "platform_slice" attribute from Settings.
Bug: 126222433
Test: robo
Change-Id: I05beec7d3e3ec713c40740a1adbcacaee88237b5
2019-06-10 14:05:43 -07:00
Fan Zhang
225da1517c Add interface and extend db to support storing slice uris
Bug: 126222433
Test: manual
Change-Id: Ie81e69477d297aa96a0daad02d56196c956271a3
2019-05-29 15:41:15 -07:00
Abhijeet Kaur
a8b8051725 Merge "Trigger a bugreport directly from shell" 2019-05-28 16:55:30 +00:00
Abhijeet Kaur
c5c84bc405 Trigger a bugreport directly from shell
Send broadcast to shell, so that it makes a call to bugreport API
directly.

Permission protected call is made so that not any app can send this
broadcast intent to shell.

Use Settings feature flag to turn on this workflow and leave the old workflow
untouched.

Bug: 123617758

Test: build and manual test by triggering bugreports from the device
Change-Id: Iec43fa1e5e379e2f5520a48f7fe036d59e2a8d28
2019-05-28 14:20:16 +01:00