Commit Graph

26838 Commits

Author SHA1 Message Date
Mady Mellor
32fa736dd6 Move feature-level Bubble setting into developer options; default to off
Functionality:
* Moves feature-level setting into developer settings (apps section)
* Adds bubbles in developer options under "apps" section
* Configures the app-specific bubble toggle in notifications settings
  to be hidden / shown based on the developer setting
* Configures the channel-specific bubble toggle in notification channel
  settings to be hidden / shown based on the developer setting

Tests:
* Anything that might be assuming that it's globally enabled now has
  a bit to enable it globally in that test
* There is a logic change now where the app-level setting would be available
  even if off globally, now that is not true -- if it's off globally the
  app-level is no longer available
* Adds tests for the developer setting

Test: make -j40 RunSettingsRoboTests ROBOTEST_FILTER="Bubble"
Bug: 131845765
Change-Id: I5f6bf74e5ada3fc023571825cca10d7bddc60e6e
2019-05-10 15:41:06 -07:00
Fan Zhang
9db66a562c Clean up before making all setting page render edge-to-edge
These classes are casting view to LinearLayout unnecessarily. Later we
might change the root view away from LinearLayout. The cast will cause
crash.

Bug: 132182711
Test: go through SUW.
Change-Id: Iea31882f8edea0c87ef8e95b4da9b6bffa8ea7d0
2019-05-10 21:27:05 +00:00
Brad Ebinger
96af57b47f Merge "Resolve the SIM call manager per subId" into qt-dev
am: 1350309ecc

Change-Id: I3d5c730efde6c0a8a1ecdba4e70793696ad7a598
2019-05-10 13:39:57 -07:00
Brad Ebinger
1350309ecc Merge "Resolve the SIM call manager per subId" into qt-dev 2019-05-10 20:17:38 +00:00
Brad Ebinger
9761dd4634 Merge "Allow SimDialogActivity to be started for result" into qt-dev
am: d204d6c33f

Change-Id: Ib448a6901581294050fc988ed9c16f7e93066860
2019-05-10 13:12:21 -07:00
Hai Shalom
3fc9dc3ada [WPA3] Fix connectivity issues with PSK-SAE Transtion mode
Fix two reported issues regarding PSK-SAE transition mode:
1. When phone supports SAE, creating a manual saved network with PSK
and manually connecting would cause the phone to connect but Settings
does not display any connected AP. Phone would not autoconnect.
2. When phone doesn't support SAE, phone cannot connect to an AP in
PSK-SAE Transition mode because the framework always targets the highest
security.

Bug: 132278271
Test: Connect to WPA2 network
Test: Connect to WPA3 network (w/capable phone)
Test: Connect to WPA2/3 Transition w/SAE capable phone
Test: Connect to WPA2/3 Transition w/SAE not-capable phone
Change-Id: I371bcb4b2cccfc8684ecb5db3a768524f7354598
2019-05-10 12:59:23 -07:00
Brad Ebinger
d204d6c33f Merge "Allow SimDialogActivity to be started for result" into qt-dev 2019-05-10 19:42:55 +00:00
hughchen
26aa660541 Merge "Clear media switcher items when in phone call" into qt-dev
am: 12dcbe7c71

Change-Id: Ieb3326b10dd25c22c9e16286585a6dbdedf2fa35
2019-05-10 11:49:43 -07:00
Brad Ebinger
d206835fe3 Allow SimDialogActivity to be started for result
In Telephony, we sometimes need to be able to launch
the SIM pick dialog activity for SMS without setting
a new default (i.e. user chose "ask every time") for
default SMS subscription.

Adds the ability for the SimDialogActivity to be
called using startActivityForResult and not set the
user's choice as the default.

Bug: 130853716
Bug: 130567323
Test: run Telephony SmsManagerTestApp
Change-Id: If9f9ebbfe9b7b6718ed759937abbcfa6d22c6295
2019-05-10 18:29:54 +00:00
TreeHugger Robot
12dcbe7c71 Merge "Clear media switcher items when in phone call" into qt-dev 2019-05-10 18:14:02 +00:00
Arc Wang
3ce4382031 Merge "Fix "Turn on Wi-Fi scanning?" does not pop up when clicking "Turn on Wi-Fi automatically"" into qt-dev
am: 41656de5d4

Change-Id: I9c051a5ecce1e9f0b2d8b58c1df8fbc7721cb8d7
2019-05-10 05:30:41 -07:00
lindatseng
d40facddb0 Merge "Set panel launch mode to singleInstance and fix animation" into qt-dev
am: 04623e81b8

Change-Id: I15fe1fb15753bf7ffb4bdaec3f3045a7c3d0aa66
2019-05-10 05:18:01 -07:00
Kevin Chang
9714ce162a Merge "Override performClick method to eliminate redundant click" into qt-dev
am: 1915fe3b67

Change-Id: I3de055284663373d83657334ae120c599682b97b
2019-05-10 02:24:16 -07:00
Pengquan Meng
f7c9da43cf Merge "Fixed network name for about/sim_status" into qt-dev
am: b73d3c70c8

Change-Id: I4163adc7824982b06324335651b8a5c681d6eef6
2019-05-10 02:14:09 -07:00
TreeHugger Robot
41656de5d4 Merge "Fix "Turn on Wi-Fi scanning?" does not pop up when clicking "Turn on Wi-Fi automatically"" into qt-dev 2019-05-10 09:09:25 +00:00
Kevin Chang
34e42d31b0 Merge "Improve the Accessibility warning dialog with new design" into qt-dev
am: 35890fabae

Change-Id: Ib1ae087015aabe65aefd493374cb681536cbc9ef
2019-05-10 02:03:36 -07:00
TreeHugger Robot
04623e81b8 Merge "Set panel launch mode to singleInstance and fix animation" into qt-dev 2019-05-10 08:41:12 +00:00
lindatseng
f23d16f577 Merge "Fix NPE when launching MediaOutput Panel" into qt-dev
am: b0f641869b

Change-Id: I82e8906d672fce4831dde200073db5b763205bee
2019-05-10 01:30:15 -07:00
lindatseng
2943c1de7a Set panel launch mode to singleInstance and fix animation
Set panel launch mode to singleInstance to avoid panel can show up
infinite time when user keep launching panels (Easy repro by
pressing volume hard key > settings again and again).

After changing launch mode to singleInstance, we will need to do
some refactors, to avoid weirdness when adding/changing/closing
panels:
1. Move and refactor logic in SettingsPanelActivity#onCreate.
   We will need onNewIntent here to handle Panel launching, since
   we only have one instance of SettingsPanelActivity now.

   Also do refactor here to reuse the PanelFragment instead of
   creating one every single time, to better handle the exit
   animation, avoid janky exit behavior from the old PanelFragment

2. Move logic from PanelFragment#onCreateView, to reuse it when
   updating panel content.

   Also add exiting animation when we are transitioning the panel
   from one to another.  Also add alpha animation to make it move
   more smoothly.

3. Adding flags to launch see more intent in settings.

Fixes: 131225920
Fixes: 131254399
Test: manual
Change-Id: I93d3708bd02a2d736e38685475f2d9988ef62d31
2019-05-10 07:14:13 +00:00
Jonathan Scott
21bb8ebde2 Merge "Make ScreenPinningSettings behaviour consistent with LockTaskController." into qt-dev
am: c6ebdfe982

Change-Id: I32964e483961eaf3139a864e525e45eb495bc5d7
2019-05-10 00:08:38 -07:00
Kevin Chang
1915fe3b67 Merge "Override performClick method to eliminate redundant click" into qt-dev 2019-05-10 06:32:25 +00:00
Arc Wang
454553ed52 Fix "Turn on Wi-Fi scanning?" does not pop up when clicking "Turn on Wi-Fi automatically"
We should make sure both 'Use location' & 'Wi-Fi scanning' are enabled
before calling setWifiWakeupEnabled.

Bug: 131777439
Test: manual
Change-Id: I602917cfa7c5581ecb414e8c44b4e20c8f9ea78d
2019-05-10 14:13:07 +08:00
Pengquan Meng
b73d3c70c8 Merge "Fixed network name for about/sim_status" into qt-dev 2019-05-10 06:10:48 +00:00
Kevin Chang
35890fabae Merge "Improve the Accessibility warning dialog with new design" into qt-dev 2019-05-10 05:49:59 +00:00
Kevin Chang
d3496412f7 Override performClick method to eliminate redundant click
Bug: 132226328
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SwitchBar
Change-Id: I22987a7695dfc84e50d6419604a9512f98cf4d13
2019-05-10 11:52:24 +08:00
Kevin Chang
bb6395eb4a Improve the Accessibility warning dialog with new design
Create new Accessibility warning dialog based on the style of permission
dialog

Bug: 129788631
Test: Visual
Change-Id: I0ec693f9c29e6e85e17d5bd1a64a4c0fe9499f95
2019-05-10 11:46:19 +08:00
hughchen
095c5be448 Clear media switcher items when in phone call
- update test case

Bug: 132385707
Test: make -j42 RunSettingsRoboTests
Change-Id: I2bbd35e869e8ab5596d280d04fddc98f05629190
2019-05-10 10:27:26 +08:00
TreeHugger Robot
b0f641869b Merge "Fix NPE when launching MediaOutput Panel" into qt-dev 2019-05-09 23:58:16 +00:00
TreeHugger Robot
c6ebdfe982 Merge "Make ScreenPinningSettings behaviour consistent with LockTaskController." into qt-dev 2019-05-09 23:46:22 +00:00
Pengquan Meng
0ab776f69d Fixed network name for about/sim_status
The network name in sim status dialog is not the same as the one in the
about page. This CL use the carrier text which is resolved in
ServiceStateTracker as the network name, this keep the network name sync
with the status bar and the summary of sim status in the about page.

Bug: 31784938
Test: build & manual test
Change-Id: Ia741baabaa98ae447dbedf9e28fd2fda222e6d2e
2019-05-09 15:16:20 -07:00
lindatseng
33c5d72ffe Fix NPE when launching MediaOutput Panel
Add NP check when to avoid NPE when launching MediaOutput Panel

Fixes: 132366620
Test: Manual
Change-Id: I21a481907a5bca83404e59e08ba11ce5c55199a4
2019-05-09 14:03:15 -07:00
Adam He
88ada1b06d Merge "Display profile picker for content capture settings." into qt-dev
am: f39ed1f432

Change-Id: I1103f4ba46db43209ae86f812d27505ce394eae3
2019-05-09 12:18:40 -07:00
TreeHugger Robot
f39ed1f432 Merge "Display profile picker for content capture settings." into qt-dev 2019-05-09 18:27:37 +00:00
tmfang
1ba833e74e Merge "Catch another exception when we are building slices data for search" into qt-dev
am: 7d3a67b04d

Change-Id: I1dec0dd96ff9611677313ba3416f3ca3766eb61e
2019-05-09 11:05:31 -07:00
Jason Chiu
46294872c7 Remove On/Off subtext next to the Wi-Fi toggle
Fixes: 132312797
Test: robotest, visual
Change-Id: I2c3b39e8deda211d23be0b2a73426778dbbf53db
2019-05-09 15:19:02 +08:00
tmfang
6410821f04 Catch another exception when we are building slices data for search
We lose chance to build all Settings slices if we got an exception
when settings was creating slice data for controllers.
We should make sure the process goes well even we got an exception
on an incorrect controller.

Also, we log exceptions for each catch.

Bug: 131449561
Test: Open Settings search and then we can see slice for some
search result.

Change-Id: Iac9f0e0a187f6d10cf53886afeb9cab479b6ce02
2019-05-09 10:31:53 +08:00
Arc Wang
6830a691dd Merge "Fix back arrow in wifi settings "connect to this network connection qr code" does not work" into qt-dev
am: 5c461a2859

Change-Id: If6b45a274e22f0bc8c60b2276a0db39778bd2b34
2019-05-08 19:11:24 -07:00
Andrew Sapperstein
f8058733c2 Merge "Update summary for mobile data toggle for CBRS." into qt-dev
am: cf964643b5

Change-Id: I01bb48fc8bf405d6d807630e01e1f03a14432f9f
2019-05-08 19:01:36 -07:00
Arc Wang
5c461a2859 Merge "Fix back arrow in wifi settings "connect to this network connection qr code" does not work" into qt-dev 2019-05-09 01:29:48 +00:00
TreeHugger Robot
cf964643b5 Merge "Update summary for mobile data toggle for CBRS." into qt-dev 2019-05-09 00:51:31 +00:00
Kevin Chyn
82703baa9d Merge changes from topic "Face Intro Changes" into qt-dev
am: 0f65b773be

Change-Id: I3868316218a7c6cd22e495f8a497941ab7451fc1
2019-05-08 17:08:01 -07:00
Kevin Chyn
0f65b773be Merge changes from topic "Face Intro Changes" into qt-dev
* changes:
  Added Face Enroll Education Screen
  Updated Face Enroll Introduction
2019-05-08 23:55:22 +00:00
Andrew Sapperstein
477e345f21 Update summary for mobile data toggle for CBRS.
Fixes: 127529917
Test: robotests
Change-Id: Id2d0bdbcf9674106a3dff8db8e9ceb22dbdda314
2019-05-08 15:55:04 -07:00
Salvador Martinez
63fb185d64 Merge "Clear preferences when dialog acknowledged and increase order" into qt-dev
am: cbd925bf73

Change-Id: Ide094fdbacadb8ea40f2e3b0bad32a8d9644ebe5
2019-05-08 14:28:12 -07:00
TreeHugger Robot
cbd925bf73 Merge "Clear preferences when dialog acknowledged and increase order" into qt-dev 2019-05-08 21:12:52 +00:00
Alex Salo
ee9f413a0f Merge "Re-enable the test" into qt-dev
am: 95c26b67f1

Change-Id: If57f2b5b8170d3f6ae303d8572244c97c6c94727
2019-05-08 14:07:58 -07:00
Fan Zhang
7f58e8cd1b Merge "Display settings homepage content fully edge-to-edge" into qt-dev
am: c084301c02

Change-Id: Iaf752753accb6324bcdc595fcd58042ca83ef7fd
2019-05-08 14:07:00 -07:00
Lei Yu
ddf3268ad1 Merge "Add null check when restart batteryinfo loader" into qt-dev
am: 285fc7f7c3

Change-Id: I75c8925d1b4b0707eb58de2e46f94c539e091e56
2019-05-08 13:50:37 -07:00
TreeHugger Robot
95c26b67f1 Merge "Re-enable the test" into qt-dev 2019-05-08 20:29:38 +00:00
Fan Zhang
c084301c02 Merge "Display settings homepage content fully edge-to-edge" into qt-dev 2019-05-08 20:26:31 +00:00