Commit Graph

5186 Commits

Author SHA1 Message Date
Yiyi Shen
322e153350 Rename AudioSharingLoadingStateDialogFragment and layout
Test: atest
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Bug: 362858894
Change-Id: I05e29b248541511daca355f1bbe4a13b17b4d20d
2024-09-23 15:46:27 +08:00
Edgar Wang
3f2d009c66 Merge "Refactor layout of ProcessStatsPreference" into main 2024-09-20 05:51:54 +00:00
Chaitanya Cheemala (xWF)
4764ef4bf1 Merge "Revert "Fix text alignment in RTL mode for volume sliders"" into main 2024-09-18 15:02:25 +00:00
Chaitanya Cheemala (xWF)
78ce35afc8 Revert "Fix text alignment in RTL mode for volume sliders"
This reverts commit e1faf0c8a9.

Reason for revert: Likely culprit for b/367986833  - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.

Change-Id: I0f5120cfd4a4cc44c5ef5c431deedfa3b38ee576
2024-09-18 13:42:01 +00:00
Yiyi Shen
301a898b72 Merge "Fix text alignment in RTL mode for volume sliders" into main 2024-09-18 09:47:15 +00:00
Diya Bera
8444136cd3 Merge "(1/N) Biometric error dialog" into main 2024-09-17 23:57:50 +00:00
Yuri Lin
4dcd12f02c Merge "Right-align "end time" text on the schedule setter" into main 2024-09-17 21:24:57 +00:00
Yuri Lin
300d3d14c3 Right-align "end time" text on the schedule setter
When the "end time" text label is wider than the actual time, then aligning it with the start of the time causes it to wrap, even when there's plenty more space on the screen. This change right-aligns it in all cases (even when it's shorter), as it's hard to get all three of "right-aligned when too long", "left-aligned to the time display when short enough", and "wraps when it hits the center line instead of overflowing".

Fixes: 367054151
Test: manual, in English & Danish
Flag: android.app.modes_ui
Change-Id: I106864d6fb09aeac5fcc8d22e8d3d67b1b31ce4e
2024-09-17 15:46:59 -04:00
Diya Bera
5335e26b29 (1/N) Biometric error dialog
Add an error dialog to help user recover from biometric error for
identity check feature

Flags: android.hardware.biometrics.flag.mandatory_biometrics
Fixes: 358641110
Fixes: 358179610
Test: atest DevelopmentSettingsDashboardFragmentTest

Change-Id: I6099bc57672b945fa4fa4de98be35bd097403b22
2024-09-17 14:45:51 +00:00
Pat Manning
4a552541aa Style changes for Pointer fill color settings.
Fix: 362455374
Test: Manual. Visual Changes only.
Flag: android.view.flags.enable_vector_cursor_a11y_settings
Change-Id: Id7a9d7eef540ea33f6bb47451b3d5c25328f9707
2024-09-16 14:01:55 +00:00
Yiyi Shen
e1faf0c8a9 Fix text alignment in RTL mode for volume sliders
The volume bars with layout preference_volume_slider won't align title text right in RTL mode (Force RTL layout direction is Developer options),
e.g. Sound & vibration page, Audio sharing page.

Test: manual
Bug: 359514080
Flag: EXEMPT minor layout change
Change-Id: I43daa46438e3fa0a879d831a97d05b31c7dcb52f
2024-09-14 08:16:48 +00:00
Chaohui Wang
04ef86d174 Merge "Fix description when erase esim" into main 2024-09-12 01:25:16 +00:00
Yiyi Shen
0e7d5fcf0d Merge "[Audiosharing] Add loading state dialog" into main 2024-09-11 05:55:24 +00:00
Chaohui Wang
c57ab6ee65 Fix description when erase esim
R.id.sud_layout_description no longer works any more, migrate to
setDescriptionText().

Fix: 365582830
Flag: EXEMPT bug fix
Test: manual - on erase all data
Test: atest MainClearConfirmTest
Change-Id: Icfb492ada862fb0584ffdb8da440d94ce719e518
2024-09-11 11:35:15 +08:00
Yiyi Shen
c347fba969 [Audiosharing] Add loading state dialog
Test: atest
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Bug: 362858894
Change-Id: Ic40c3c5971e29ce1dac896a8e4efa2284d95f45e
2024-09-10 15:37:40 +08:00
Edgar Wang
28d45b49e8 Refactor layout of ProcessStatsPreference
- only this preference use AppPreference.setProgress()
- create layout to handle progressbar in this class

Bug: 365506467
Test: atest
Flag: EXEMPT bugfix
Change-Id: Ie0daf4e4fc1736943afe243566392d57c63fe65a
2024-09-09 11:24:32 +00:00
Jason Chang
386071e91d Fix fingerprint enrollment animation is not in correct position.
1. Change SPFS ring progress bar and lottie animaiton from
layout_marginLeft/ layout_marginRight to marginStart/marginEnd for
RTL language.
2. Modify SPFS ring progress bar and lottie animaiton dimensioin for
RTL language and check three different SFPS projects.

Flag: NONE bug-fixing

Bug: 338911438

Test: manual build and check UI visually.
Change-Id: I88edad459eefbb3c6be337263045cd87685810e9
2024-09-09 07:02:54 +00:00
Haijie Hong
680df21339 Merge "Show a dialog if bluetooth key is missing when reconnecting" into main 2024-09-06 08:18:55 +00:00
Haijie Hong
f93aaadad0 Show a dialog if bluetooth key is missing when reconnecting
Previous change is reverted due to test failure in b/362901443.

BUG: 360031750
Test: atest BluetoothKeyMissingDialogTest
Flag: com.android.settings.flags.enable_bluetooth_key_missing_dialog
Change-Id: I05b940e8aac26c14f93baa19c224ad98c291b891
2024-09-04 09:05:08 +00:00
Chaohui Wang
d7a2aeb82d Clean up TARE
Bug: 331617295
Flag: EXEMPT clean up
Test: m Settings
Change-Id: Ie37617a082c7036672d2901ed45146932a5d97d8
2024-09-04 17:00:41 +08:00
Chaitanya Cheemala (xWF)
3605e23587 Merge "Revert "Show a dialog if bluetooth key is missing when reconnecting"" into main 2024-08-29 11:36:05 +00:00
Chaitanya Cheemala (xWF)
29c7cc0cb5 Revert "Show a dialog if bluetooth key is missing when reconnecting"
Revert submission 28985385-bt_key_missing_dialog

Reason for revert: Likely culprit for b/362901443  - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.

Reverted changes: /q/submissionid:28985385-bt_key_missing_dialog

Change-Id: I2a3ab8f0dbd2c81eda49d11abc6d586f59f149e9
2024-08-29 10:25:04 +00:00
Haijie Hong
5247f4936d Merge "Show a dialog if bluetooth key is missing when reconnecting" into main 2024-08-29 05:59:34 +00:00
Yiyi Shen
840495eb5c [Audiosharing] Fix text truncated
Fix: 359814312
Test: manual
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Change-Id: Ia278d30019efad4a035d02f7ea3812e84dfdba8f
2024-08-29 12:08:10 +08:00
Chris Antol
468e15f49a Supported updated suggestion cards in AOSP Settings
Flag: com.android.settings.flags.updated_suggestion_card_aosp
Bug: 323258154
Test: Enable flag and trigger suggestion cards to show
Change-Id: Iee47d05d8d75c10ba073ae3541f108bc37b4c09b
2024-08-28 16:35:01 +00:00
Haijie Hong
34cf0cbea1 Show a dialog if bluetooth key is missing when reconnecting
BUG: 360031750
Test: atest BluetoothKeyMissingDialogTest
Flag: com.android.settings.flags.enable_bluetooth_key_missing_dialog
Change-Id: Iab75675b4cd8fec7ab55516cd0f057a9c7d92f7e
2024-08-28 15:55:35 +08:00
Yuri Lin
29042b18a7 Add interstitial layout for larger screen devices
For large enough screens, always use the portrait (all vertical in one column) layout for the intestitial, since the landscape split in two halves only makes sense for smaller screens.

Renames the layout to mode_interstitial_layout_base and uses an alias so that we can reuse the same layout but with additional padding.

Fixes: 361344824
Test: manual
Flag: android.app.modes_ui
Change-Id: I4e02e9a246ee799e3a79508f11290397a236574c
2024-08-21 17:02:14 -04:00
Edgar Wang
fa32f347fe Merge "[Homepage Revamp] adjust search bar padding" into main 2024-08-20 09:42:49 +00:00
Matías Hernández
0a5c7530ed Merge "Fix several issues related to CircularIconsPreference" into main 2024-08-16 16:44:24 +00:00
Matías Hernández
b676ca3a62 Fix several issues related to CircularIconsPreference
* Sometimes would cause an unending stream of accessibility events (particularly if starting off-screen). This would break TalkBack and anything that depends on UiAutomator (although the system itself took it like a champ).
* Sometimes would not load images (because the ViewTreeObserver would never fire onGlobalLayout after being added because measured width was 0, even though a new width was calculated later).
* Would not recalculate the number of icons that fit if the width changes after the first layout.

Combining ViewHolders with waiting for measuring and/or ViewTreeObservers was always a wonky approach, even though it should've worked in theory. This should be more robust.

Also fixes the unwanted animation on mode screen load related to the absence of the header name being applied a tad too late.

Fixes: 359948417
Fixes: 360072876
Fixes: 360328804
Test: atest SettingsRoboTests + manual + adb shell uiautomator events
Flag: android.app.modes_ui
Change-Id: I7e5dfbdab220d1ebc1c68e5e87ce544ee86b6a65
2024-08-16 16:20:38 +02:00
Xinyi Mao
eb1fc8415b Merge "Migrate Spinner on Battery Usage to settingsLib Spinner widget." into main 2024-08-16 07:21:07 +00:00
mxyyiyi
05e857de6a Migrate Spinner on Battery Usage to settingsLib Spinner widget.
Bug: 359429437
Test: visual
Test: atest BatteryUsageBreakdownControllerTest
Flag: EXEMPT bug fix
Change-Id: I71bd1f31db302d407603c71d1a1163ed22fafed8
2024-08-16 13:40:07 +08:00
Edgar Wang
82b7908878 [Homepage Revamp] adjust search bar padding
Bug: 353607870
Test: manual
Flag: EXEMPT bugfix
Change-Id: I3a574afc16823fe0a98ebae5e1c9e8fd28f4e522
2024-08-15 12:09:56 +00:00
Matías Hernández
1dfc18740e Don't read the +N test of CircularIconsPreference
The description of the segment is already "App 1, App 2, and x more can interrupt", from its text. If the icons don't fit, there's a "+N" at the end. Accessibility services reading this is confusing, especially because the icons that don't fit are not the same as the names that don't fit, so you could get something like "App 1, App 2, and 9 more can interrupt, plus 4".

The whole circular-icons section is irrelevant for a11y so we just mark the container as "noHideDescendants" to save Talkback some work.

Fixes: 359837977
Test: Manual with Talkback
Flag: android.app.modes_ui
Change-Id: I346abcc94e25ef60c5e91f77b8e13f38ade39c71
2024-08-14 17:09:46 +00:00
Yuri Lin
24ba675fe4 Add images for interstitial pages.
This change removes the custom rounding of corners, as the provided images already have rounded corners.

Bug: 332730534
Test: manual (light & dark mode, various font/display sizes)
Flag: android.app.modes_ui
Change-Id: I71d0707554e5bc638add6a2907874e18e833da08
2024-08-13 16:46:05 -04:00
Matías Hernández
a274bcb400 Modes icon picker: measuring improvements
Ensure that horizontal spacing between items in the icon picker is distributed to the left and right of the row instead of between the items. This makes the horizontal and vertical spacing the same.

Bug: 359171199
Test: manual + hsv
Flag: android.app.modes_ui
Change-Id: I68c3860ba4092bb6fde2a1218b3f6a95d0c373da
2024-08-12 15:32:44 +02:00
Haijie Hong
c2ed6d3242 Move rename button next to the device name
BUG: 343317785
Test: atest GeneralBluetoothDetailsHeaderControllerTest
Flag: com.android.settings.flags.enable_bluetooth_device_details_polish
Change-Id: I87f030ca48d3edac13759fe51499b7e400dbb795
2024-08-12 12:31:45 +08:00
Yiyi Shen
4ac216914e Merge "[Audiosharing] Update dialog btn when start sharing with no extra connected device" into main 2024-08-09 02:37:20 +00:00
Treehugger Robot
93b093033a Merge "Migrate Tips Card in battery uasge to Settings Card." into main 2024-08-08 15:09:30 +00:00
mxyyiyi
427c9c3187 Migrate Tips Card in battery uasge to Settings Card.
before:
[Dark-settings]:https://screenshot.googleplex.com/56EiS3PbtRsh5RR
[Light-app]:https://screenshot.googleplex.com/8UDuFEkkrLUt53D

after:
[Dark-settings]:https://screenshot.googleplex.com/3zKxxGi2Awa6s72
[Light-settings]:https://screenshot.googleplex.com/rsgVh9P62x7itUa
[Dark-app]:https://screenshot.googleplex.com/56EiS3PbtRsh5RR
[Light-app]:https://screenshot.googleplex.com/6bfs2u43nZpHL8y

Bug: 357603119
Test: atest BatteryTipsControllerTest
Flag: EXEMPT bug fix
Change-Id: I25e3b407378b01ef9868326a005554ceb6e94181
2024-08-08 13:59:11 +00:00
Yiyi Shen
da812758f3 [Audiosharing] Update dialog btn when start sharing with no extra connected device
There are two btns now: Pair new device and Show QR code
Pair new device -> go to Pair new device page
Show QR code -> go to QR code page

Test: atest
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Bug: 305620450

Change-Id: Id5ddb66f1bbc3b02228a0d639bf30cdc40bef265
2024-08-07 17:58:37 +08:00
Angela Wang
faa8b24cc4 Fix text is not readable with black & white wallpaper issue
Flag: EXEMPT bugfix
Test: manually check the UI and attach the result in bug
Bug: 356065922
Change-Id: I955cd51823d2cac6deaca8280bc8572ed8518a8a
2024-08-07 07:13:18 +00:00
Chelsea Hao
5473fa04f5 Merge "[Audiosharing] When landscape mode, collapse app bar to make more space. Also refined fragments and make them scrollable." into main 2024-08-07 05:07:00 +00:00
Yuri Lin
eb6dd8432b Merge changes from topic "yl-interstitial" into main
* changes:
  Resize & round corners on a placeholder interstitial image
  Add interstitial for modes that are disabled but not by user
2024-08-06 19:38:45 +00:00
chelseahao
e7a1762ef3 [Audiosharing] When landscape mode, collapse app bar to make more space. Also refined fragments and make them scrollable.
Bug: b/356302527, b/356300387, b/356297148
Flag: com.android.settingslib.flags.enable_le_audio_qr_code_private_broadcast_sharing
Test: atest
Change-Id: I5d94f0d05afc78c13cab5b75ad662af72ffa0350
2024-08-06 09:09:11 +00:00
chelseahao
b377b1c0e4 [Audiosharing] Increase click target.
Bug: 357012346
Flag: com.android.settingslib.flags.enable_le_audio_qr_code_private_broadcast_sharing
Test: atest
Change-Id: I2ecaf4d3c8c2b249da4b25b6658f1aef3c43209e
2024-08-05 07:15:45 +00:00
Yuri Lin
cb824ccbd9 Resize & round corners on a placeholder interstitial image
This isn't a real image yet (just draws a diagonal gradient), but should now be roughly ready for inserting the correct drawables based on the mode whenever those are available.

Bug: 332730534
Test: manual, SetupInterstitialActivityTest
Flag: android.app.modes_ui
Change-Id: I45a78950f671a989258a85525a7a8ee0c445a332
2024-08-01 18:44:27 -04:00
Yuri Lin
65548c0e56 Add interstitial for modes that are disabled but not by user
This covers both the case of navigating to the mode page through the mode aggregator menu as well as if an app sends an intent to go to the mode.

The interstitial visuals are not done yet; in particular, the image is just a gray box for now.

Manual tests done:
- visually verifying the interstitial page in both portrait and landscape
- accessing the mode page from modes list, confirming interstitial pops up
- accessing enabled and disabled-by-user mode page from modes list (no interstitial)
- getting to the mode page from intent through an app
- accessing enabled and disabled-by-user mode pages from app intent (no interstitial)
- adjusted display and font size (it looks bad with max display & font size, maybe not much to be done)

Bug: 332730534
Test: manual, ZenModeFragmentTest, SetupInterstitialActivityTest
Flag: android.app.modes_ui
Change-Id: I21f13b0842d5b118a341f7d85e8fcac947ca3a06
2024-08-01 18:44:22 -04:00
chelseahao
cd6f77d432 [Audiosharing] Change text color.
Bug: 356080864
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Test: atest
Change-Id: Id0882547343cb63149f8a9335b023e9f50649e07
2024-08-01 04:25:43 +00:00
Matías Hernández
a463b0af7b Fix a11y issues in the schedule editor
* Don't read start / end time as separate labels.
* Fix content description of day buttons (ToggleButton's stateDescription is textOn/textOff -- which are the same for this particular button, thus it wasn't possible to know whether a day was selected or not).

Fixes: 346396147
Test: manual, with Talkback
Flag: android.app.modes_ui
Change-Id: If73a791cf9bd62cf17e058c81a8051b3e7fd82ea
2024-07-29 18:11:34 +00:00