Commit Graph

61643 Commits

Author SHA1 Message Date
Quang Luong
0ddc3675c4 Remove Connect/Disconnect button dependence on WifiEntry.isExpired()
WifiEntry.canConnect() may be true even if isExpired() is true, such as
in the case of connecting to renew a subscription. Thus, the
connect/disconnect button should only rely on canConnect() and
canDisconnect() (as well as the intermediate state of connecting) to
determine its visibility.

Bug: 150384136
Test: manually install expired passpoint profile and verify if the
connect button is visible and working.

Change-Id: Ibfdf285f3b97fd0de88804d4658df20bd67bf8e0
2020-04-30 20:36:32 -07:00
govenliu
4d74ae2e67 [Wi-Fi] Enhance com.android.settings.wifi.p2p unit test cases.
Add new unit test cases in WifiP2pSettingsTest.java, the coverage rate will raise from 30% to 71%.

Bug: 151696220
Test: make RunSettingsRoboTests ROBOTEST_FILTER=WifiP2pSettingsTest
Change-Id: I214866efae47a99e75178beca48deb398b70f9bd
2020-05-01 09:00:10 +08:00
Lucas Dupin
665c36eae2 Create QS media player setting
Test: make RunSettingsRoboTests ROBOTEST_FILTER=QuickSettingsMediaPlayerPreferenceControllerTest
Test: manual
Fixes: 155315021
Change-Id: I2583b985710898d0480f599fc9b5a2451c8950a7
2020-04-30 12:04:23 -07:00
Xiangyu/Malcolm Chen
8e35cc2c37 [automerger skipped] Merge "Fix Robo test failure in NrDisabledInDsdsFooterPreferenceControllerTest." am: 6819a64e45 am: 30792ed811 -s ours
am skip reason: Change-Id I77dfa6eb61ee7b2cf2eb4fd8d8a392a43f7035b3 with SHA-1 08cc6396b2 is in history

Change-Id: I2104d827861e2a8f04f61de8d93b47429aac2efb
2020-04-30 18:04:26 +00:00
Xiangyu/Malcolm Chen
30792ed811 Merge "Fix Robo test failure in NrDisabledInDsdsFooterPreferenceControllerTest." am: 6819a64e45
Change-Id: I6e2235612a27168fc095773e0638da0c9602addd
2020-04-30 17:38:16 +00:00
Xiangyu/Malcolm Chen
6819a64e45 Merge "Fix Robo test failure in NrDisabledInDsdsFooterPreferenceControllerTest." 2020-04-30 17:16:55 +00:00
Julia Reynolds
815ee670c9 Center text even if string is long
Test: manual in Armenian language
Fixes: 154930071
Change-Id: I61a84958a2043d36241b6fa5eff8dcb2c7ef0db0
2020-04-30 13:05:04 -04:00
TreeHugger Robot
503685b948 Merge "Add keyword for app pinning setting" into rvc-dev am: 6debb6a775
Change-Id: I86f6aa578c2224c8069333b5ebf593b5415b1459
2020-04-30 16:07:57 +00:00
TreeHugger Robot
6debb6a775 Merge "Add keyword for app pinning setting" into rvc-dev 2020-04-30 15:49:19 +00:00
TreeHugger Robot
53f3cdbba4 [automerger skipped] Merge "Fix missing zone strings in some cases" into rvc-dev am: 4f244f6b88 -s ours
am skip reason: Change-Id Ia89c777a832f8b41c8d56d3327a9b7370ba44b52 with SHA-1 eafec7a244 is in history

Change-Id: I98b0ebfea641e858072c260a9a5f7fa7550132a4
2020-04-30 14:42:58 +00:00
Edgar Wang
15e89819cb Merge "Add metrics log for special cases in Lanugages & About page" into rvc-dev am: cf654356d6
Change-Id: I61e0f2152f3d7249c7ed4c833bd0da04f066a996
2020-04-30 14:37:31 +00:00
TreeHugger Robot
4f244f6b88 Merge "Fix missing zone strings in some cases" into rvc-dev 2020-04-30 14:32:40 +00:00
Edgar Wang
cf654356d6 Merge "Add metrics log for special cases in Lanugages & About page" into rvc-dev 2020-04-30 14:27:23 +00:00
Yanting Yang
fb2ef59a3c Merge "Fix NPE crash when opening the app info from shortcut suggestion" into rvc-dev am: 459e5e1636
Change-Id: Iffcf5b68b1efb84ee0467480f68ef1cdb5d196e7
2020-04-30 13:37:42 +00:00
Tsung-Mao Fang
d3b4b1043b Add keyword for app pinning setting
We change the "screen pinning" to "app pinning",
and we still want to let user can get same search result
when they query "screen pinning".

Test: Open search and query "screen pinning", see the app pinning result
Bug: 151332926
Change-Id: Ice49d6db39ce89aa84508587262d9529df726784
2020-04-30 21:24:53 +08:00
Yanting Yang
459e5e1636 Merge "Fix NPE crash when opening the app info from shortcut suggestion" into rvc-dev 2020-04-30 13:17:01 +00:00
Yanting Yang
2309782c17 Merge "Remove index for Take call on of Sound page" into rvc-dev am: 855f704eca
Change-Id: I5a5f23f5520a73f107d7b5e136fa6697d3a386a6
2020-04-30 12:32:20 +00:00
Jason Hsu
7725372140 Merge "Logs accessibility service user trigger status." into rvc-dev am: a69eb462a8
Change-Id: I4d1770975ed6dc6f66fe1fd1b07869c36e754e70
2020-04-30 12:32:04 +00:00
TreeHugger Robot
b97b9a1906 Merge "A new ui flow for screen pinning feature" into rvc-dev am: 8da9374ace
Change-Id: Ib6dc8fe0cc36ddce8249e00af7a57664853afdb3
2020-04-30 12:31:26 +00:00
TreeHugger Robot
caf9a77274 Merge "Add icons to contextual Wi-Fi card header" into rvc-dev am: c4310e5980
Change-Id: I56e83fcc0c72387880d9ce2bc0dc5f336bcb79d9
2020-04-30 12:31:12 +00:00
Yanting Yang
855f704eca Merge "Remove index for Take call on of Sound page" into rvc-dev 2020-04-30 12:30:53 +00:00
Jason Hsu
a69eb462a8 Merge "Logs accessibility service user trigger status." into rvc-dev 2020-04-30 12:21:16 +00:00
TreeHugger Robot
8da9374ace Merge "A new ui flow for screen pinning feature" into rvc-dev 2020-04-30 12:09:54 +00:00
TreeHugger Robot
c4310e5980 Merge "Add icons to contextual Wi-Fi card header" into rvc-dev 2020-04-30 12:08:54 +00:00
Jason Chiu
e2c798b8a7 Merge "Refine contextual Bluetooth card behavior when Bluetooth is off" into rvc-dev am: 5b260b0bd1
Change-Id: I7da9e14073cd3e153f2b06432cf85fbe1ae1ff00
2020-04-30 10:57:07 +00:00
Jason Chiu
5b260b0bd1 Merge "Refine contextual Bluetooth card behavior when Bluetooth is off" into rvc-dev 2020-04-30 10:44:06 +00:00
Jason Chiu
509c0119fb Add icons to contextual Wi-Fi card header
Fixes: 149666241
Test: robotest
Change-Id: I67076eb561bc496b272b28dc54bce8845d8d622f
2020-04-30 18:34:33 +08:00
Tsung-Mao Fang
ae661a0782 A new ui flow for screen pinning feature
The purpose of this change is to resolve a number of security issue
around screen pinning.
See more detail go/screen-pinning-allows

There're a few change for Settings app.

- Rename the screen pinning to app pinning.
- Change the string description for app pinning.
- Pop up a warning dialog while user is enabling this feature.

Test: Rebuilt rom and see new ui flow.
Bug: 151332926
Change-Id: Ife07d7b95ab5dccb2aed7f2bc8fa32f97763bd63
2020-04-30 17:28:05 +08:00
Edgar Wang
329b20a445 Add metrics log for special cases in Lanugages & About page
Bug: 137559984
Test: robotest

Change-Id: I007282d8c4d5f9c6168dd84f6feee7e237ec7c42
2020-04-30 17:19:52 +08:00
Arc Wang
1efd7878c7 [Wi-Fi] Modify NetworkRequestDialog title & summary
Design change for UX improvement.

Bug: 155348488
Test: manual visual
Change-Id: I07d441f6fda8017cc9f4561ef64d57ff8db86f0f
2020-04-30 15:34:43 +08:00
TreeHugger Robot
2c53128d9d Merge "Twilight Location off text" into rvc-dev am: 136c101001
Change-Id: I20b97e1cb34ce75757da58cad8440ba4d4f77d39
2020-04-30 04:48:47 +00:00
TreeHugger Robot
136c101001 Merge "Twilight Location off text" into rvc-dev 2020-04-30 04:34:42 +00:00
TreeHugger Robot
70f3a1855e Merge "Add "Play <APP> to" string" into rvc-dev am: 9fd2ebf9ea
Change-Id: Id500f0c233cf861ef844fd0187542c5f7bc3b862
2020-04-30 04:20:00 +00:00
TreeHugger Robot
9fd2ebf9ea Merge "Add "Play <APP> to" string" into rvc-dev 2020-04-30 04:10:39 +00:00
Blake Kragten
ba264a325f Merge "Remove enhanced connectivity switch for non-pixel" into rvc-dev am: 6fe60521d1
Change-Id: I057a92706e916b54ee5caa4780ec8471c8cb17e9
2020-04-30 03:48:08 +00:00
Treehugger Robot
37ee14a792 [automerger skipped] Merge changes I6194592d,I5a02f847 am: 44146c8e3b am: ebea74264a -s ours
am skip reason: Change-Id I6194592d9a7bf4d4b7993fc344d7392bf5c296aa with SHA-1 c67a0d853b is in history

Change-Id: I3e9b8218b9ad4fdeb4b7d91b66f66881344b5036
2020-04-30 03:33:51 +00:00
Malcolm Chen
38687bab76 [automerger skipped] Define a helper link for 5G limitation in DSDS footer. am: 5e68080b1f am: b6fa2277f6 -s ours
am skip reason: Change-Id I5a02f847531988217cc6ab47e3b35ed319c1027c with SHA-1 80be9de6d0 is in history

Change-Id: I2151c3c3abe64328ef6f69adade622fb7b9700b5
2020-04-30 03:33:49 +00:00
Blake Kragten
6fe60521d1 Merge "Remove enhanced connectivity switch for non-pixel" into rvc-dev 2020-04-30 03:24:52 +00:00
Treehugger Robot
ebea74264a Merge changes I6194592d,I5a02f847 am: 44146c8e3b
Change-Id: I2ebc5edd89fb32b2698c8cfd6acb20342c9cec17
2020-04-30 03:17:19 +00:00
Malcolm Chen
b6fa2277f6 Define a helper link for 5G limitation in DSDS footer. am: 5e68080b1f
Change-Id: I3377b9cbc1d4722a8a96c18f40d1118e476c4ef7
2020-04-30 03:17:16 +00:00
Jay Aliomer
41ee5663ab Twilight Location off text
When location is disabled, dark theme and night light
will show text and button to take the user to location page

Fixes: 153115261
Fixes: 153115618
Test: manually turn off location and observe view
Change-Id: I24be2f26a4c9e1b3f2a17e83e6f91cb7685f2e28
2020-04-29 23:14:32 -04:00
Treehugger Robot
44146c8e3b Merge changes I6194592d,I5a02f847
* changes:
  Add check of canConnectTo5GInDsds to show NrDisabledInDsdsFooter
  Define a helper link for 5G limitation in DSDS footer.
2020-04-30 02:56:34 +00:00
Tim Peng
be4ed2a3cb Add "Play <APP> to" string
Bug: 155345595
Test: build pass
Change-Id: Ib656f0db2efa6f777ada2c2565493775e72634ae
2020-04-30 02:13:24 +00:00
Yanting Yang
9dc0a45fd8 Fix NPE crash when opening the app info from shortcut suggestion
It occurs NPE in invoking refreshUi() of AppButtonsPreferenceController
when user fully install the instant app from google play and then
directly open app info from the shortcut suggestion in launcher.

Root cause:
AppButtonsPreferenceController.refreshUi() will be invoked when user
directly open app info from the shortcut suggestion in launcher. In
refreshUi(), we will update the information of button preference, but
the preferences will not be initialized if device existed an instant
version for the app.

Solution:
Check button preference and initial them if need in refreshUi().

Fixes: 137854835
Test: visual, robotests
Change-Id: Id5c3e53b9db2683cab970c10eace7925d889eea3
2020-04-30 08:53:16 +08:00
TreeHugger Robot
7a41660242 Merge "Fix history task stack" into rvc-dev am: 7d1cfa4d84
Change-Id: I6112f47da149986b167befee9198d9f62d0c974d
2020-04-29 23:19:32 +00:00
TreeHugger Robot
7d1cfa4d84 Merge "Fix history task stack" into rvc-dev 2020-04-29 23:04:13 +00:00
Treehugger Robot
99c2ccf984 Merge "Disable 'Mobile data' selection after removing SIM" am: 87d1e30f17 am: d6859736a4
Change-Id: I77a6c089aec6fe57f79ef7dc7f6630ee8fc68ae7
2020-04-29 23:01:07 +00:00
Bob Badour
7c198d980d Merge "Remove MODULE_LICENSE_APACHE2 from apps/Settings" am: 2ab7555be5 am: 2cd2b9e4ab
Change-Id: I0f269573abc1d68816664f1ef020cb04dacfa69e
2020-04-29 23:00:38 +00:00
Treehugger Robot
d6859736a4 Merge "Disable 'Mobile data' selection after removing SIM" am: 87d1e30f17
Change-Id: I14dc87ff0f185bdbfb5734b6501f727e2cb19792
2020-04-29 22:50:24 +00:00
Bob Badour
2cd2b9e4ab Merge "Remove MODULE_LICENSE_APACHE2 from apps/Settings" am: 2ab7555be5
Change-Id: Ifabb259302be383fad6555849876a4d7e3a0a71a
2020-04-29 22:50:17 +00:00