Commit Graph

5267 Commits

Author SHA1 Message Date
Kasia Krejszeff
e0036fc8b2 Remove nested ScrollView in the PrivateSpaceEducation screen.
It is not needed for the scrolling to work -- GlifLayout from the SUW
library generates a ScrollView. Additional ScrollView causes Talkback to
interpret it as a separate item and read out contents of its all
children. See b/379256039.

Video before: https://drive.google.com/file/d/1H3k5AxlIdgAA15PHUQ9tVq5AechziA4Z/view?usp=sharing&resourcekey=0-ozeQsQSS5jubL0pZ5FAZHA
Video after: https://drive.google.com/file/d/1W_ODgQhbQS6Xf_57A4TcYeJbqMJxYF16/view?usp=sharing&resourcekey=0-zQ0_p3qlIxpBL3rB5SC4vQ

In the before video, talkback is highlighting and (the green frames) and reading out the whole "How it works" section in addition to each element separately. After the fix it only highlights elements separately.

Bug: 379256039
Test: Manually testesd and presubmit.
Flag: EXEMPT bugfix
Change-Id: Idf6772b8772c54c1907d3a12617fcd03451af41b
2025-01-07 14:52:20 +00:00
Haijie Hong
12f53fadd8 Merge "Fix device icon overflow issue" into main 2025-01-05 22:16:49 -08:00
Treehugger Robot
a98694a34c Merge "Add talkback hint to SIM name EditText" into main 2025-01-05 17:17:08 -08:00
Weng Su
e5c80148b7 Add talkback hint to SIM name EditText
Bug: 385808957
Flag: EXEMPT bugfix
Test: Manual testing
Change-Id: Ide9161690f87c048eaa348d410674a6fb74ea07c
2025-01-06 07:22:20 +08:00
Haijie Hong
7928455af6 Fix device icon overflow issue
Flag: EXEMPT minor fix
Bug: 373988997
Test: local tested
Change-Id: I13185e3fc0b57dd6079eb0bef5d8fbda5efbddb9
2025-01-04 21:47:22 +08:00
Yining Liu
9d200f1f38 Merge changes I1dffab01,I6e34ef9b,Ia8d472ea,Icf4e7003 into main
* changes:
  Notification on lockscreen settings: adapt text view for large font
  Inverse toggles on the notifications on locks screen settings page
  Update appearance of notifications on locks screen settings page
  Remove description from notifications on locks screen settings page
2025-01-02 16:11:51 -08:00
Shawn Lin
299449e29f Merge "[Biometric Onboarding & Edu] Support check enrolled fingerprint" into main 2025-01-01 21:51:52 -08:00
Shawn Lin
4bfbb8782a [Biometric Onboarding & Edu] Support check enrolled fingerprint
- Add a new PreferenceItem for check enrolled fingerprint
- Create a new DialogFragment for the check enrolled
  fingerprint with functions:
  - request an authentication to FingerprintManager
  - highlight the item when a authentication successes
  - show error text when authentication fails
  - close the authentication

Bug: 370940762
Test: atest FingerprintSettingsFragmentTest
Flag: com.android.settings.flags.biometrics_onboarding_education

Change-Id: I90637e4ec20ea46e6f530ffd7ba79df9c31eda6b
2024-12-30 10:20:23 +00:00
Angela Wang
b5ec99bf35 Merge "Update ShortcutPreference with expressive design" into main 2024-12-28 17:34:49 -08:00
Yining Liu
fb200f0d7b Notification on lockscreen settings: adapt text view for large font
Notification on lockscreen settings: adapt text view for large font and
long text languages.

Bug: 367455695
Flag: com.android.server.notification.notification_lock_screen_settings
Test: manual
Change-Id: I1dffab01433eff5e6af86c46b5d20340df6912db
2024-12-27 23:00:07 +00:00
Jacky Wang
82aa6c7e64 Merge "Revert "[Expressive design] Update MainSwitch in SettingsActivity."" into main 2024-12-26 23:17:38 -08:00
Angela Wang
0af1dbae4e Update ShortcutPreference with expressive design
To make hearing devices screen meets the expressive design, the shortcut
preference need to be updated.

Flag: EXEMPT flag by System prop
Bug: 349675952
Test: atest ShortcutPreferenceTest
Test: manually check the UI, screenshots attached on bug
Change-Id: I04a86c0592c5aa0e096b827a9ee65b12cf13ecf5
2024-12-27 07:08:58 +00:00
Jacky Wang
63a14901aa Revert "[Expressive design] Update MainSwitch in SettingsActivity."
This reverts commit b7e0923414.

Reason for revert: Cause regression b/385850462

Change-Id: I82992d428ea985bc2a762854df2abd555cc4a467
2024-12-26 20:44:31 -08:00
Yining Liu
7c8e313d11 Remove description from notifications on locks screen settings page
Remove the text descriptions for the notifications minimalism
style from the notifications on locks screen settings page.

Bug: 367455695
Flag: com.android.server.notification.notification_lock_screen_settings
Test: manual
Change-Id: Icf4e70033dab7aea829a09a6277b47da66efbd01
2024-12-27 00:06:46 +00:00
Shawn Lin
1ef5e68927 Merge "Revert "[Biometric Onboarding & Edu] Update Set up Fingerprint/F..."" into main 2024-12-23 23:10:08 -08:00
Jason Hsu
a1046fc847 Merge "[HA Input] Add UI to support hearing device microphone change ability in device details page" into main 2024-12-23 19:50:24 -08:00
jasonwshsu
1258059feb [HA Input] Add UI to support hearing device microphone change ability in device details page
In this patch:
* Add custom dialog preference: HearingDeviceInputRoutingPreference and its controller
* Contain radio group to show 'hearing device microphone' and 'this phone's microphone' for user's preference
* set/get user's preference via BluetoothDevice#isMicrophonePreferredForCalls, BluetoothDevicwe#setMicrophonePreferredForCalls
* check if support HapProfile and if in AudioManager#getDevice(GET_DEVICES_INPUTS) list

Bug: 349255906
Test: atest HearingDeviceInputRoutingPreferenceTest BluetoothDetailsHearingDeviceInputRoutingControllerTest BluetoothDetailsHearingDeviceControllerTest
Flag: com.android.settingslib.flags.hearing_devices_input_routing_control
Change-Id: I2e4dbc7fb98353ed52d0d175df4e8725df6b9a05
2024-12-23 19:57:39 +08:00
Shawn Lin
b75b3a373f Revert "[Biometric Onboarding & Edu] Update Set up Fingerprint/F..."
Revert submission 30754151-boe_fp_unlock

Reason for revert: prevent from leakage

Reverted changes: /q/submissionid:30754151-boe_fp_unlock

Change-Id: Ida3d127cc8cd71366c4375e90d6058e510f590c9
2024-12-22 23:44:11 -08:00
Pat Manning
9e93a0df64 Increase touch target of pointer stroke preference options.
Fix: 374886964
Test: Manual. TalkBack.
Flag: EXEMPT Bugfix.
Change-Id: I10ba80b26be5444096e6f81d1d2c12f3eb46b1ff
2024-12-20 07:26:47 -08:00
Vincent Wang
19544f9079 Merge "Remove reduant files from settings" into main 2024-12-19 00:27:51 -08:00
YK Hung
702da9b565 Merge "[Expressive Battery] Tweak the animation of Battery Usage screen." into main 2024-12-18 19:04:30 -08:00
Pat Manning
b50acbfeea Update pointer fill option backgrounds for color contrast and touch
target size.

Fix: 374885995
Fix: 374886964
Test: Manual.
Flag: EXEMPT Bugfix.
Change-Id: Ibf09bfae4a93868ac3605748854ccaaa10847eb6
2024-12-18 14:56:45 +00:00
mxyyiyi
c369a8df5a [Expressive Battery] Tweak the animation of Battery Usage screen.
Fix the blinking while tapping chart to select time intervals.
- setHasStableIds(true) to avoid BatteryChartView create viewHolder again when SettingsPreferenceGroupAdapter invoke notifyDataSetChanged()

Recover the fade-in animation when display the hourly chart for the first time.
- set the default alpha of hourly chart in xml to 0.

Bug: 378997970
Bug: 349652542
Flag: EXEMPT bug fix
Test: visual
Change-Id: Ia6c131452fca65db7149664c7e18ca68e9703def
2024-12-18 21:38:27 +08:00
Vincent Wang
50fe9178a8 Remove reduant files from settings
Bug: 383036790
Flag: EXEMPT for removing legacy files
Test: Build pass
Change-Id: I815c6f12f700f4b0daaa5c0e7cfe97e12acd593f
2024-12-18 06:50:04 +00:00
Treehugger Robot
c3fecca761 Merge "Remove old PK settings pages that are unused" into main 2024-12-17 19:50:54 -08:00
Yuchen Sun
9660169518 Merge "[Expressive design] Update MainSwitch in SettingsActivity." into main 2024-12-17 17:29:06 -08:00
Angela Wang
fb1efa69ac Merge changes from topics "ha-aics", "ha-aics-mute", "ha-local-data" into main
* changes:
  [Ambient Volume] Ambient volume icon
  [Ambient Volume] Show value with remote data
  [Ambient Volume] Show value with local data
  [Ambient Volume] UI of volume sliders in Settings
2024-12-17 01:17:38 -08:00
Haijie Hong
8cf4af9c90 Merge "Fix lcr icon direction in RTL layout" into main 2024-12-16 23:50:14 -08:00
Haijie Hong
5790356990 Fix lcr icon direction in RTL layout
BUG: 382407010
Test: local tested
Flag: EXEMPT minor fix
Change-Id: I62afca941d428e9b5510d54d1b3ed60d6f09a99c
2024-12-17 14:27:36 +08:00
Yuchen Sun
a4ed8acd25 Merge "[Expressive design] Update ApnPreference." into main 2024-12-16 22:16:32 -08:00
Yuchen
b7e0923414 [Expressive design] Update MainSwitch in SettingsActivity.
Bug: 349681531
Flag: EXEMPT migration
Test: visual
Change-Id: I0dc55e2ced5ba4ce808e0b29a9b3b60549972637
2024-12-17 03:17:38 +00:00
Matthew DeVore
7b7f72d902 Merge "Show display topology in the pane" into main 2024-12-16 16:24:18 -08:00
Matthew DeVore
807cf78a51 Show display topology in the pane
Populate the topology pane with the topology as returned from
DisplayManager.

This adds padding but not the proper rounded corners or highlighting for
the blocks. That will come later, probably after feature complete while
still in dogfood.

Test: add and remove overlays while external display fragment is shown - verify pane is refreshed
Test: add two overlay displays, verify two blocks appear in pane with system wallpaper
Test: with no freeform window displays, verify a "not enabled" message appears in pane with no display blocks
Test: DisplayTopologyPreferenceTest
Flag: com.android.settings.flags.display_topology_pane_in_display_list
Bug: b/352648432
Change-Id: Ibb35af53c24d6feb1d763e4b2bf2ec9fee2ae24d
2024-12-16 19:04:58 +00:00
Angela Wang
0595aed386 [Ambient Volume] UI of volume sliders in Settings
Collapse/expand the controls when clicking on the hearder with arrow.

Flag: com.android.settingslib.flags.hearing_devices_ambient_volume_control
Bug: 357878944
Test: atest AmbientVolumePreferenceTest
Test: atest BluetoothDetailsAmbientVolumePreferenceControllerTest
Test: atest BluetoothDetailsHearingDeviceControllerTest

Change-Id: I845a4397601e563ed027d7d2a0a13651e95de708
2024-12-16 15:24:19 +00:00
Yuchen
3f2448cfd6 [Expressive design] Update ApnPreference.
Migrate to TwoTargetPreference.
screenshot: https://hsv.googleplex.com/4840366858567680

Bug: 349681531
Flag: EXEMPT migration
Test: visual
Change-Id: Ia88f9f5f7f5388a7e66189e0b7a0be641d05f140
2024-12-16 07:45:28 +00:00
David Liu
aad7bf5ea8 Fixed battery chart flickering
- Hide the hourly chart view by default to avoid the calculate the
  space.
- Remove the alpha animation in chart group which causes the flickering
  when open the battery page.

Bug: 378997970
Flag: EXEMPT bugfix
Test: atest BatteryChartPreferenceControllerTest
Change-Id: I1b7e5f74fe63ebcae9f9737b0797d870fd56b134
2024-12-12 14:39:50 +08:00
Vaibhav Devmurari
58c4286ec9 Remove old PK settings pages that are unused
Test: manual
Bug: 330517633
Flag: EXEMPT cleanup
Change-Id: I2e0e21cf13ae39a09cd8c7b3697bbf18188e1fa8
2024-12-10 18:49:26 +00:00
Angela Wang
05783a589d Merge "Show battery info for mono audio location device" into main 2024-12-10 03:38:31 +00:00
Shawn Lin
97072e434d Merge "[Biometric Onboarding & Edu] Update Set up Fingerprint/Face Unlock page" into main 2024-12-09 10:37:03 +00:00
Shawn Lin
087ac777a8 [Biometric Onboarding & Edu] Update Set up Fingerprint/Face Unlock page
Update icons, strings and layouts for new UX design

Bug: 370940762
Test: manual:
      Pre condition - no fingerprint/face enrolled
      For FP: Go Settings>Security & privacy>Device unlock>Fingerprint unlock
      For Face: Go Settings>Security & privacy>Device unlock>Face unlock
Test: atest FaceEnrollIntroductionTest
Flag: com.android.settings.flags.biometrics_onboarding_education
Change-Id: Iaee6792d1a27be8fa4b443f783a47a3715b6d3a1
2024-12-09 07:52:08 +00:00
Marcelo Arteiro
8577c10535 Migrate materialColor* attributes into colors
The new color were already introduces in a previous CL ag/30322786

This CL is about replacing the attribute usage by the new color resources, which should work the same but cannot be overwritten, or styled, guaranteeing consistency across the OS.

The old attributes will be removed in CL: ag/29910036

Bug: 374273611
Test: presubmit
Flag: EXEMPT Un-flaggable refactor of private color resources
Change-Id: I05b5261054bcb6de40e4e40d633025495f3dd01f
2024-12-06 16:55:33 +00:00
Yining Liu
81d390968b Implement the preference switch for minimalism on ls settings page
Implement the preference switch for notification minimalism on the
notifications on lock screen settings page. The illustrations and
summaries will also update when switching the preference. This
preference will hide when the main toggle is unset or when the lock
screen notification minimalism feature flag is disabled.

Bug: 367455695
Flag: com.android.server.notification.notification_lock_screen_settings
Test: adb shell settings get secure \
 lock_screen_notification_minimalism <1|0>
Change-Id: Ie6596e518bd1aa2e828587d7d174b57256aec45b
2024-12-04 22:08:25 +00:00
Matías Hernández
aaee1a1511 Merge "(Once more) fix minimum height of mode name edit box for a11y" into main 2024-12-02 17:41:06 +00:00
Matías Hernández
b3468ca88a (Once more) fix minimum height of mode name edit box for a11y
We had fixed this before and then regressed when moving to TextInputLayout, so added a proper test this time.

Fixes: 380207192
Test: atest ZenModeEditNamePreferenceControllerTest
Flag: android.app.modes_ui
Change-Id: Ic25b0a5a6997e7b3bb26bf26ed7e8e92654a1c11
2024-12-02 16:06:58 +01:00
mxyyiyi
1cf9ab21b8 [ExpressiveBattery] Update BatteryHeaderTextPreference
- Remove background container
- Update the distance between status text and progress bar from 16dp to 10dp.

Bug: 349652542
Test: visual
Flag: EXEMPT flag by System prop
Change-Id: I1cd6f597e01daad9fbc5fb128926c8c153ff0328
2024-11-29 13:59:52 +08:00
Zaiyue Xue
178eb0bd15 Split battery header text to a separated preference
This is a no-op refactor. This change makes the Catalyst migration of battery level bar easy.

Bug: 372774754
Test: manual
Flag: EXEMPT bug fix
Change-Id: I6e64e6d9b34aeca584f4d4e951c58c3e1b361f9d
2024-11-26 13:09:12 +08:00
Matthew DeVore
6f28e1a3c7 Topology pane in extended displays list
Show an empty topology pane in the extended displays list. Even show
when no external display is connected.

This will be tweaked in a follow-up CL to include the built-in display
in the pane and the displays list.

This fixes an issue where the displays list is not shown when *no*
external displays are connected, which was not the intent of the flag.
The previous flag CL ag/30358161 only respected the flag when 1 external
display was connected.

Based on mocks at go/al-mm-figma

Bug: b/352650922
Test: reboot with zero displays attached and verify display list and pane are shown
Test: on al-13 device, make the activity fullscreen and verify the margins on left and right of pane are larger
Flag: com.android.settings.flags.display_topology_pane_in_display_list
Change-Id: If39fefe943a26c817fa6f636f21eb8aaa080adde
2024-11-25 12:06:04 -06:00
Angela Wang
b5dbe8af2b Show battery info for mono audio location device
1. Show mono battery info in LeAudioBluetoothDetailsHeaderController
   without side text in front of the battery icon
2. Show mono side device on Settings > Accessibility > Hearing devices's
   summary without side information

Flag: EXEMPT bugfix
Bug: 379616650
Test: atest AccessibilityHearingAidPreferenceControllerTest
Test: manually check UI with real device
Change-Id: I4a1a3357e2cef51df505923e38da33767c78e8f3
2024-11-22 07:17:48 +00:00
Chaohui Wang
9b65eafc84 Merge "Update color for reset_esim_desc" into main 2024-11-20 21:56:23 +00:00
Chaohui Wang
14926a34a6 Update color for reset_esim_desc
Fix: 379816199
Flag: EXEMPT bug fix
Test: visual
Change-Id: I88ee350222dcb273b777274acddcc71d9baf19b2
2024-11-20 17:11:02 +08:00