Commit Graph

140019 Commits

Author SHA1 Message Date
Treehugger Robot
1614fc4180 Merge "Fix ImpossibleNullComparison errorprone warning" into main 2024-03-26 04:59:55 +00:00
SongFerng Wang
bf210b9834 Merge "Replace the bottomsheet with dialog" into main 2024-03-26 03:50:09 +00:00
Haijie Hong
f5d8f4afa9 Merge "Disable media output switcher in Settings when audio sharing" into main 2024-03-26 03:23:51 +00:00
Josh Hou
3c38a12347 Aggregation checkbox and locale text
Refer to other settings with the checkbox to read the checkbox and corresponding text together, such as "Erase SIMs" or "Show password" in WiFi settings.

Bug: 288223637
Bug: 317927064
Test: Perform some accessibility test like TalkBack and Select to Speak
Change-Id: I571fe3f2f8d7b6b4f4c7b5804d0217a2a2b97757
2024-03-26 03:19:19 +00:00
Varun Shah
a5593de4c5 Hide the Perform Backup Tasks Settings page.
Since we are now hiding the new RUN_BACKUP_JOBS permission, hide the
associated special app access page in Settings.

Bug: 331272951
Test: BackupTasksAppsPreferenceControllerTest
Test: visual (Settings pages)
Change-Id: I875b286798f48ee4e94d5e37c1b21bb84acf390d
2024-03-26 02:43:30 +00:00
Zoey Chen
51d6aeb5c2 [ToA] Should strip u extension when check locale
Bug: 330664746
Change-Id: Ic7bfbfbf2a8abb70b96b9a6e26854af4f252722d
Test: manual
2024-03-26 02:10:46 +00:00
Vincent Wang
d5b1bf7554 Fix Settings crash after clicking "Add Fingerprint"
Bug: b/331136606
Test: 1.Add 1 Fingerprint
      2. adb shell am start -a android.settings.FINGERPRINT_SETTINGS
      3. input correct pin/pattern/password
      4. Click Add Fingerprint cehck if Setting work correctly
Change-Id: I076ed7488729a24aea9b47a843b7785e128f6791
2024-03-26 02:09:28 +00:00
Fan Wu
be3633ac17 Merge "Remove LooperMode.Legacy usage from settings/biometrics/" into main 2024-03-26 01:49:30 +00:00
Chun-Ku Lin
4c9d268fdf Rename AccessibilityGestureNavigationTutorial to AccessibilityShortcutsTutorial
AccessibilityGestureNavigationTutorial is not only for displaying
tutorial for accessibility gesture shortcut. It's used for display the
tutorials for all the selected accessibility shortcuts. Renamed the
class to match it's responsibility.

Bug: N/A
Flag: EXEMPT Strict mechanical refactors
Test: build succeed locally

Change-Id: I1dd212abc660454e77f18f770c2ecc17be320eaa
2024-03-26 01:13:28 +00:00
Angela Wang
53985e6307 Merge "Enable the hyphenation in pin confirm dialog" into main 2024-03-26 00:57:21 +00:00
Chun-Ku Lin
257ac13217 Merge "Update a11y edit shortcut screen's text and tutorial text" into main 2024-03-26 00:47:51 +00:00
Chris Antol
70a5a0fd35 Restrict Settings Homepage prior to provisioning
Bug: 327749022
Test: manual test
1. factory reset + launch Settings via ADB during Setup -> verify app closes
2. factory reset + bypass Setup + tap Settings icon in launcher -> verify app closes

Change-Id: I8cbe38109ebf88a0f68f3917e95468a81c6463c1
2024-03-25 23:51:04 +00:00
Chaohui Wang
fbaa520e43 Merge "Set Default APN radio button's size to 48dp" into main 2024-03-25 23:48:37 +00:00
Amith Yamasani
f43f72e5d2 Revert "Intent handler for new BACKGROUND_RESTRICTIONS_SETTINGS"
Revert submission 26202178-intent_restricted

Reason for revert: Not shipping this API for Androd 15

Reverted changes: /q/submissionid:26202178-intent_restricted

Change-Id: If542aa7ffe0e5dffa49bb5ad3e14ed23441843d4
2024-03-25 23:29:29 +00:00
Chun-Ku Lin
3aee92e2e8 Update a11y edit shortcut screen's text and tutorial text
Bug: 323792194

Test: manual
Test: atest com.android.settings.accessibility
Test: atest com.android.settings.accessibility.shortcuts

Flag: N/A simple string changes

NO_IFTTT=Introduce new IfThisThenThat lint

Change-Id: I7ba4096d669453c33257880407e85ffe76d358f8
2024-03-25 22:19:10 +00:00
Kyle Zhang
fc21e32cb3 Use new naming for Widevine Developer option.
Bug: 301669353
Change-Id: Idf9802fc6bbffdc81c9c0fa3527dc3eb7efbf2a1
2024-03-25 22:04:51 +00:00
Joseph Vincent
31e2dcbbb8 Merge "Enabling private space unit tests in presubmit" into main 2024-03-25 21:21:48 +00:00
Neil Fuller
43ded696dd UI changes to support time feedback
The feature is behind a release flag. It is also behind an experiment
flag so it can be trialed with Googlers before general release even
after being enabled in a release.

The feedback button only shows up if there is an intent URI configured,
which should be handled via an overlay. The design means that the intent
is potentially dependent on the manufacturer (good!), though I expect we
will suggest a standard one for GMS devices so we get feedback from a
variety of devices with different form factors / capabilities.
In this default, GMS core (Google Play Services) will handle the intent
and take the user through a feedback UI flow.

Testing:

To enable the button you need to build with one of release variants that
supports dynamic flags, e.g. trunk_food.

Then release flag:
$ adb shell device_config put location com.android.settings.flags.datetime_feedback true

It still won't work without the experiment flag:
$ adb shell device_config put settings_ui time_help_and_feedback_feature_supported true

Finally, the settings entry will launch an intent when pressed which has
to have a receiver. The receiver will be in GMS core but will be subject
to its own review / launch process. Until then, this feature will remain
quiet, biding its time.

Bug: 283239837
Test: Manual (see above)
Test: atest SettingsRoboTests:com.android.settings.datetime
Change-Id: I68798798fc0a47ae4c6755174ce509fbaee24142
2024-03-25 19:00:47 +00:00
Cole Faust
448c18e5ff Fix ImpossibleNullComparison errorprone warning
Protobuf fields cannot be null.

Bug: 253827323
Test: m RUN_ERROR_PRONE=true javac-check
Change-Id: Ied830dbf9ddde4c43281feb38a01f01d0750fea7
2024-03-25 11:56:24 -07:00
marcusge
05f42b52da [Accessibility] Color Contrast address UX bugs
Reformatted xml files and added constraints to make sure texts do not go
out of bound.

Test: local raven device
Screenshot: attached on bug
Bug: 329176991, 329169251
Flag: aconfig
com.android.settings.accessibility.enable_color_contrast_control

Change-Id: I7cb15a46557f54833c77fe41928fb6e98d5ec519
2024-03-25 17:57:28 +00:00
Hakjun Choi
6263205fa8 Fix the Settings to align with the requirements in PRD am: ec735999b0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/26691418

Change-Id: I5b92e67cb046e97bc5d70e08c6845bddab4ac462
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-25 17:56:24 +00:00
josephpv
4cc915ad64 Change icon for Private Space unlocked and setup success toast
Change is made to show customised icon in Toast message shown by using
Toast.makeCustomToastWithIcon()

Screenshots :
go/ss/AcaRQUJQfh79wDw.png
go/ss/5j4oD8xydwX7HTX.png

Bug: 329391204
Bug: 309575523
Test: Manual
Change-Id: I336d7d0419b1de60024e584e943a725662b446a9
2024-03-25 16:53:46 +00:00
YK Hung
85cc4cd821 Merge "Update detectSettingsAnomaly API to detectPowerAnomaly(1/2)" into main 2024-03-25 16:14:04 +00:00
Matías Hernández
a1d8044cbf Populate new fields in modes created via Settings
Type and trigger description on creation; trigger description on update.

Bug: 317370174
Bug: 320997361
Test: atest ZenModeScheduleRuleSettingsTest ZenModeEventRuleSettingsTest
Change-Id: Idb1edcc8829b54ec85494966eb391e52012a5348
2024-03-25 15:57:10 +01:00
Treehugger Robot
333b21c6d0 Merge "Disable even dimmer setting conditionally" into main 2024-03-25 12:59:59 +00:00
josephpv
31a793dfcf Enabling private space unit tests in presubmit
Bug: 330755765
Test: atest SettingsUnitTests
Change-Id: Iad53a5425238d933af96d4ef8c3f3fd8c04347f7
2024-03-25 12:38:39 +00:00
Chaohui Wang
1ea5a786e2 Set Default APN radio button's size to 48dp
Which is the minimum tap size.

Also set ApnPreference not selectable, since itspPrimary target and
radio button could be selectable, but entire preference itself is not
selectable.

Fix: 330812055
Fix: 330290274
Test: manual - with APNs
Change-Id: I651642e8a275932be6b8bcb365198e5dc1ad92f8
2024-03-25 12:23:33 +00:00
Fan Wu
8d1aa43cc5 Remove LooperMode.Legacy usage from settings/biometrics/
Bug: 330824314

Test: atest
Change-Id: I12e0d807c80469f219eb9c57bed1bbbb5da487b1
2024-03-25 18:23:10 +08:00
songferngwang
0dbe979994 Replace the bottomsheet with dialog
using the dialog and update the string

Bug: 330097568
Test: verify the UI

Change-Id: I4c9a21fc74e608e08db334053d4e5bfb57abce70
2024-03-25 10:08:40 +00:00
Jason Chiu
d89fd5942f [Safer intents] System
To avoid implicit intents, make intents launch explicitly.

Bug: 323061508
Test: build
Change-Id: Iaf5466f3acd3293e738f450e0117e180b93d4e1c
2024-03-25 18:08:03 +08:00
Jason Chiu
d785397930 [Safer intents] Accessibility
To avoid implicit intents, make intents launch explicitly.

Bug: 323061508
Test: build
Change-Id: I5be489f4e6b855156b8dd6b8e54b0b6116f728ad
2024-03-25 17:05:41 +08:00
Treehugger Robot
8e2324d9e0 Merge "Add missing required permissions for Settings" into main 2024-03-25 07:56:20 +00:00
Fan Wu
20f85c5282 Merge "Remove all LooperMode.LEGACY usages from settings/accessibility" into main 2024-03-25 07:40:22 +00:00
Shun Lung Chen
265fe257c2 Update detectSettingsAnomaly API to detectPowerAnomaly(1/2)
Since the detectSettingsAnomaly method does not only detect settings but
also other power related anomalies. Change the method name to
detectPowerAnomaly to make it more reflects what it really does.

Bug: 320404576
Test: make SettingsGoogleRoboTests
Change-Id: I4b5bec3aba81cd0dc6fef2c976eae3d64da3ede5
2024-03-25 07:34:33 +00:00
Tom Hsu
2625ca4e7d Merge "Settings: Fix force close for telephony callback exceeding limitation" into main am: 380a136e50 am: bca026c182
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2995004

Change-Id: I2c15c609239927bd2a87da19c99c8f3ee34e9a63
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-25 07:14:10 +00:00
Tom Hsu
bca026c182 Merge "Settings: Fix force close for telephony callback exceeding limitation" into main am: 380a136e50
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2995004

Change-Id: I66c3770935276a233374b1a6ab8bc23d80c64100
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-25 07:03:46 +00:00
Treehugger Robot
ddd539d590 Merge "Use the correct Edge to Edge flag" into main 2024-03-25 07:01:00 +00:00
Tom Hsu
380a136e50 Merge "Settings: Fix force close for telephony callback exceeding limitation" into main 2024-03-25 06:49:08 +00:00
Hakjun Choi
ec735999b0 Fix the Settings to align with the requirements in PRD
Update the guideline string to the latest from UX team.

Bug: 330961550
Test: manually testing from pixel device
Change-Id: Ic6eb4ba2a85cbfc5544182f30fe645283084084a
2024-03-25 06:09:26 +00:00
Haijie Hong
c1a5a7c9b1 Disable media output switcher in Settings when audio sharing
Bug: 327080094
Test: atest MediaOutputPreferenceControllerTest
Change-Id: I1e81d507c5c92c2b6f21494551931b359d5043cb
2024-03-25 14:01:35 +08:00
Ze Li
24652df671 Merge "[PairDevicePage] Add content description so that the loading icon will be announced." into main 2024-03-25 05:36:34 +00:00
Fan Wu
c788a90669 Remove all LooperMode.LEGACY usages from settings/accessibility
Bug: 331124680

Test: atest
Change-Id: I21cc137358e5cb29c16aeda0b744f36d9f8bf010
2024-03-25 11:42:34 +08:00
SongFerng Wang
a3b28762cb Merge "To gray out the next button if the user does not select two sim" into main 2024-03-25 03:15:08 +00:00
Tom Hsu
af5e80b7d8 Merge "Enforce BaseUserRestriction for DISALLOW_CONFIG_BRIGHTNESS" into main 2024-03-25 03:00:38 +00:00
Yiyi Shen
9ba24a5d2d Merge "[Audiosharing] Support sharing dialog when click media devices." into main 2024-03-25 02:44:35 +00:00
Sunny Shao
8d4ba6d904 Use the correct Edge to Edge flag
- Use the correct flag to fix the navigation bar problem.

Fixes: 330217912
Test: manual test
Change-Id: I37869d5cc713be2b03bc8e9206ff1e0dcee8512e
2024-03-25 09:19:11 +08:00
Rafael Higuera Silva
496075f1be Add new dialogue when user is going to delete multiple sims where aleast on of them use RAC.
Test: make, manually test, atest com.android.settings.network, atest SubscriptionUtilTest
Bug: 328649505
Change-Id: I0c6fb7b5407179ec6850ece47f486b64759e2d1c
(cherry picked from commit 9ac44b3aae)
2024-03-24 23:46:53 +00:00
Himanshu Gupta
8735770fa8 Merge "Disable PS entry point and Activity when PS is not allowed." into main 2024-03-24 14:45:32 +00:00
yomna
3fe5e5f843 Add missing required permissions for Settings
SettingsSpaUnitTests BackgroundInstalledAppsPageProviderTest#title_displayed is failing due to
missing permissions GET_BACKGROUND_INSTALLED_PACKAGES, which is required for the test.

Bug: b/329486029
Test: m & atest SubscriptionInfoListViewModelTest SettingsSpaUnitTests
Change-Id: I88038a5858e9a969ca8e3df6bc4e4e33d753f1e8
2024-03-23 02:22:48 +00:00
Fiona Campbell
4a401d4313 Disable even dimmer setting conditionally
- Disable even dimmer settings option if autobrightness is not enabled
  on the device

Bug:179428400
Test: manual

Change-Id: I8f7add839022fc7c27694fd8daa83a608cf2736a
2024-03-23 02:09:46 +00:00