Commit Graph

13009 Commits

Author SHA1 Message Date
Diya Bera
2d382d5e36 Update mandatory biometrics string
String has been changed from "This is needed since Identity Check is on"
to "Identity Check is on"

Flag: android.hardware.biometrics.flags.mandatory_biometrics
Fixes: 358175977
Test: Manual
Change-Id: I12976f8eb52f419e5a97c88c35a1264e843ec259
2024-08-08 16:25:11 +00:00
Matías Hernández
877d07be46 Make the a11y descriptions of icon options more literal
E.g. "briefcase" instead of "work"

Bug: 333901673
Test: manual, with Talkback
Flag: android.app.modes_ui
Change-Id: I4364820a82a7ba4b1345c2e0fea571ee7b6c4e6f
2024-08-07 17:58:21 +02:00
Matías Hernández
31d5fbff3c Merge "Update Priority Modes segment summary" into main 2024-08-07 10:07:58 +00:00
Angela Wang
73fd3c1e3f Merge "Update UI for Flash notifications" into main 2024-08-07 07:11:40 +00:00
Allen Su
ee4f6af308 Merge "Explain region selection" into main 2024-08-07 06:29:16 +00:00
Chelsea Hao
5473fa04f5 Merge "[Audiosharing] When landscape mode, collapse app bar to make more space. Also refined fragments and make them scrollable." into main 2024-08-07 05:07:00 +00:00
Allen Su
bc06ecf62c Explain region selection
Flag: EXEMPT resource only update
Bug: 353382794
Test: manual
Change-Id: Ief06a9aaee833f9dc0680c622b70b69130bd5653
2024-08-07 03:21:59 +00:00
Priyanka Advani (xWF)
605c160a49 Merge "Revert "Don't truncate the title in Color Correction options"" into main 2024-08-06 21:19:51 +00:00
Priyanka Advani (xWF)
74e3432b8c Revert "Don't truncate the title in Color Correction options"
Revert submission 28616239-356726764-dont-truncate-color-correction-options

Reason for revert: Droidmonitor created revert due to b/357907390. Will be verifying through ABTD before submission.

Reverted changes: /q/submissionid:28616239-356726764-dont-truncate-color-correction-options

Change-Id: Icb911cc954a046084dd198c61c2e6c4080145801
2024-08-06 19:57:02 +00:00
Yuri Lin
eb6dd8432b Merge changes from topic "yl-interstitial" into main
* changes:
  Resize & round corners on a placeholder interstitial image
  Add interstitial for modes that are disabled but not by user
2024-08-06 19:38:45 +00:00
Matías Hernández
f0952bef52 Update Priority Modes segment summary
* Display active modes regardless of DND status
* Only consider actually automatic rules for the "x rules can activate automatically" text.
* Also removed the duplicate settings observer in favor of ZenSettingsObserver.

Bug: 355615361
Test: atest ZenModesSummaryHelperTest
Flag: android.app.modes_ui
Change-Id: I39acb785e7b27c95ed664261640c42032acca9d1
2024-08-06 19:48:01 +02:00
Chun-Ku Lin
b1f8213735 Merge "Don't truncate the title in Color Correction options" into main 2024-08-06 16:55:39 +00:00
chelseahao
e7a1762ef3 [Audiosharing] When landscape mode, collapse app bar to make more space. Also refined fragments and make them scrollable.
Bug: b/356302527, b/356300387, b/356297148
Flag: com.android.settingslib.flags.enable_le_audio_qr_code_private_broadcast_sharing
Test: atest
Change-Id: I5d94f0d05afc78c13cab5b75ad662af72ffa0350
2024-08-06 09:09:11 +00:00
Allen Su
b22a9d03af Merge "Revert^2 "Expand ToA language support"" into main 2024-08-05 16:55:21 +00:00
Allen Su
6b6ab63918 Revert^2 "Expand ToA language support"
This reverts commit 773afdfaf7.

Reason for revert: b/357055415 has been fixed. Revert is unnecessary

Flag: TEST_ONLY
Bug: 328697623
Test: atest TermsOfAddressCategoryControllerTest
Change-Id: Ic1477e3dfdade68b81bbdcdb0c98109064278eb4
2024-08-05 15:10:17 +00:00
Joseph Vincent
7038ee8d24 Merge "Show different error screen for PS creation based on error" into main 2024-08-05 13:21:29 +00:00
Pechetty Sravani (xWF)
b50b1fc439 Merge "Revert "Expand ToA language support"" into main 2024-08-05 11:53:42 +00:00
Priyanka Advani (xWF)
773afdfaf7 Revert "Expand ToA language support"
This reverts commit a60a38dd39.

Reason for revert: Droidmonitor created revert due to b/357174479.

Change-Id: I2db3afbb148bf7a9d66d395c56e490d837cb8b93
2024-08-05 11:41:10 +00:00
Angela Wang
4ad8e0c568 Update UI for Flash notifications
1. Hide the preview button when it's disabled
2. Change the text from “Done” to “Save” in the color selector dialog

Flag: EXEMPT simple UI change
Bug: 356978471
Test: manually, video attached on the bug
Test: atest FlashNotificationsPreviewPreferenceControllerTest
Change-Id: I2e6e697ad10f0207602d613085663cdd82521ea2
2024-08-05 06:46:50 +00:00
Matías Hernández
7a1039fea4 Merge "Overhaul the message senders screen" into main 2024-08-02 12:43:31 +00:00
Allen Su
4bdb1dbcce Merge "Expand ToA language support" into main 2024-08-02 10:48:30 +00:00
Matías Hernández
a4c99767b7 Overhaul the message senders screen
* Fix combinations of messages=all with other conversation values.
* Correctly display policies with CONVERSATION_SENDERS_ANYONE. An additional checkbox is included, but _only_ if the policy has CONVERSATION_SENDERS_ANYONE when shown.
* Changed updateState() to consider the possible cases one by one. Because multiple policies are mapped to the same checkbox states, the strategy of "checking whether the state matches what the checkbox wants to set" doesn't really work.
* Fix messages summary and circles to support CONVERSATION_SENDERS_ANYONE.
* Added a lot of tests (actually, hopefully ALL OF THEM) covering the user-visible behavior. :)

Fixes: 354658240
Test: atest ZenModesSummaryHelperTest ZenModePrioritySendersPreferenceControllerTest
Flag: android.app.modes_ui
Change-Id: I727496ca3eb820e4baaab942b61d2e57cdb491fc
2024-08-02 12:36:44 +02:00
josephpv
af87233e1e Show different error screen for PS creation based on error
This contains the change to show a different fragment on private space
creation error based on the error code returned by UserManager.
On private space create error checks for the returned error code and if
PS is not supported on the device showns error screen containing a link to Help
Center atricle to find out more about the reason for profile creation
failure.

ACTION_PRIVATE_SPACE_SETUP_SPACE_ERRORS metric is logged with the error
code on create error else 0 on sucessful space creation.

Recording: b/340130375#comment17

Bug: 340130375
Test: Manual
Flag: android.multiuser.show_different_creation_error_for_unsupported_devices
Change-Id: Ifa0345fb6aad64599009f8aa79d168f57fd35c03
2024-08-02 10:03:12 +00:00
Allen Su
a60a38dd39 Expand ToA language support
Flag: EXEMPT resource only update
Bug: 328697623
Test: manual
Change-Id: Icbc0c986508065a4daf15e9354e0aa4283315fa9
2024-08-02 09:37:45 +00:00
Yuri Lin
cb824ccbd9 Resize & round corners on a placeholder interstitial image
This isn't a real image yet (just draws a diagonal gradient), but should now be roughly ready for inserting the correct drawables based on the mode whenever those are available.

Bug: 332730534
Test: manual, SetupInterstitialActivityTest
Flag: android.app.modes_ui
Change-Id: I45a78950f671a989258a85525a7a8ee0c445a332
2024-08-01 18:44:27 -04:00
Yuri Lin
65548c0e56 Add interstitial for modes that are disabled but not by user
This covers both the case of navigating to the mode page through the mode aggregator menu as well as if an app sends an intent to go to the mode.

The interstitial visuals are not done yet; in particular, the image is just a gray box for now.

Manual tests done:
- visually verifying the interstitial page in both portrait and landscape
- accessing the mode page from modes list, confirming interstitial pops up
- accessing enabled and disabled-by-user mode page from modes list (no interstitial)
- getting to the mode page from intent through an app
- accessing enabled and disabled-by-user mode pages from app intent (no interstitial)
- adjusted display and font size (it looks bad with max display & font size, maybe not much to be done)

Bug: 332730534
Test: manual, ZenModeFragmentTest, SetupInterstitialActivityTest
Flag: android.app.modes_ui
Change-Id: I21f13b0842d5b118a341f7d85e8fcac947ca3a06
2024-08-01 18:44:22 -04:00
Chun-Ku Lin
5460a244be Don't truncate the title in Color Correction options
By default, the SelectorWithWidgetPreference hard coded the maxlines of
the title to be 2 lines. Updating the SelectorWithWidgetPreference to
accept changes on maxlines on title.

Set titleMaxLines as 2147483647 (Integer.MAX_VALUE) as there is no
alternative to clear the maxLines that are already set by the Preference

Bug: 356726764
Test: manually tested the color correction screen in Deutsch
Test: verify the Wifi Hotspot sceurity screen is not affected by this
change (still have 2 as the max lines of the title)
Flag: EXEMPT resource only

Change-Id: I1414b6212b75d3f28bef6aad50a31ea7861d5811
2024-08-01 22:33:11 +00:00
Chun-Ku Lin
b656d7b2c4 Merge "Update color correction red-green options text" into main 2024-08-01 01:43:07 +00:00
Chun-Ku Lin
a5636c1cb9 Update color correction red-green options text
Bug: 354776203
Test: manually (see screenshots in the ticket)
Flag: EXEMPT resource only update
Change-Id: Iffda7f965e046ef5c6493ac5f9eb410e4db96790
2024-07-31 19:51:42 +00:00
Treehugger Robot
e79de39723 Merge "Revert^2 "Tweak Modes layouts and use updated strings to match mocks"" into main 2024-07-31 17:35:10 +00:00
Matías Hernández
4222bed264 Revert^2 "Tweak Modes layouts and use updated strings to match mocks"
This reverts commit 9804955ad5.

Reason for revert: Wrongly reverted; unrelated to the error

Change-Id: I94a2b05589fa80218db184e192f1c4a633ab61b0
2024-07-31 15:45:11 +00:00
ELIYAZ MOMIN
39a56459a5 Merge "Revert "Tweak Modes layouts and use updated strings to match mocks"" into main 2024-07-31 15:40:04 +00:00
ELIYAZ MOMIN
9804955ad5 Revert "Tweak Modes layouts and use updated strings to match mocks"
This reverts commit 0359aaeb47.

Reason for revert: <Potential culprit for b/356564046  - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.>

Change-Id: I980838773078d822d20608e5975a26cf8dbed2be
2024-07-31 14:56:30 +00:00
Matías Hernández
0b7a22210a Add new icons to the Modes icon picker
Bug: 333901673
Test: atest IconOptionsProviderImplTest
Flag: android.app.modes_ui
Change-Id: I6fa15fa12238eb9c0d1b93803010349b9092812b
2024-07-31 14:12:37 +02:00
Matías Hernández
0359aaeb47 Tweak Modes layouts and use updated strings to match mocks
Bug: 333682392
Test: mostly manual, also ZenModeTriggerUpdatePreferenceControllerTest
Flag: android.app.modes_ui
Change-Id: I5bae828a55128f3cb0b07ea0ff21ca196e7564dc
2024-07-30 17:45:38 +00:00
Alina Zaidi
441a202444 Merge "[dev_option] Update 'Desktop mode on secondary toggle' to be 'Freeform windows on secondary diplay'." into main 2024-07-29 17:49:54 +00:00
Chun-Ku Lin
b5e4a01553 Remove unused resources since A11yServiceWarning is moved to framework
Bug: 303511250
Flag: EXEMPT pure cleanup
Test: Build succeed
Test: atest com.android.settings.accessibility
Change-Id: Ic1813b4489be617c006426056abae3876c77a727
2024-07-26 17:56:32 +00:00
Alina Zaidi
e85695f88c [dev_option] Update 'Desktop mode on secondary toggle' to be
'Freeform windows on secondary diplay'.

Make sure the toggles enables freeform support on devices. This remove
reliance on 'Enable freeform windows suppport' toggle when using this
toggle.

Also update strings for all toggles to just use term 'freeform windows'
instead of 'desktop mode' or 'freeform windowing experiences'.

Two toggles have the same name 'enable freeform windows', but users will
see only one of them at a time.

Test: Added new tests
Bug: 348193756
Bug: 348186127
Flag: EXEMPT minor change
Change-Id: Ic4528618e6902d084c58a6b5ddeb4b92d63386d6
2024-07-26 13:33:23 +00:00
Chun-Ku Lin
919019ca56 [Flag cleanup] edit_shortcuts_in_full_screen is always on now
- Cleaned up the code that won't be executed when the flag is on
- Remove unused resources

Bug: 300302098
Test: Manually verify the user can change the shortcut type, and the
changes are saved
Test: atest com.android.settings.accessibility
Flag: EXEMPT removing com.android.settings.accessibility.edit_shortcuts_in_full_screen

Change-Id: I1e32b724ca3da909feda55e20fb1d51dc4680c09
2024-07-25 22:49:02 +00:00
Matías Hernández
246960de0c Update top of modes page
* Show blurb based on mode type.
* Make the icon bigger and highlight it when mode is active.
* Increase spacing between elements.

Also eliminate some code duplication between header of mode page and header of icon picker.

Fixes: 355415875
Test: manual
Flag: android.app.modes_ui
Change-Id: I7e788b9b5920cedb791d1571b19b37e65ece6d0b
2024-07-25 21:28:27 +02:00
Yuchen Sun
01ecf76247 Add content description to QR code image for talkback.
- Rename string name for reuse purpose.

Test: Visual
Flag: EXEMPT bug fix
Bug: 350603175
Change-Id: Id5b1383c9cf1c2509a621bb9b225e0efeb58ca7f
2024-07-25 08:47:32 +00:00
Oleg Blinnikov
2c2b7a5064 Merge "External display page is not searchable" into main 2024-07-24 22:23:44 +00:00
Matías Hernández
5eb776adef Merge "Show confirmation dialogs when enabling or disabling a mode" into main 2024-07-24 12:33:56 +00:00
Matías Hernández
77191e9519 Show confirmation dialogs when enabling or disabling a mode
(Strings are not final, but structure is there).

Bug: 349376785
Test: atest ZenModeSetTriggerLinkPreferenceControllerTest
Flag: android.app.modes_ui
Change-Id: Ia9e604483b90bc30ad1c12e5663a07e251084073
2024-07-24 13:14:41 +02:00
Yuchen Sun
ed3594fe61 Merge "Clean up preference_summary_default_combination in Settings." into main 2024-07-24 04:29:03 +00:00
Yuchen
48f304a23f Clean up preference_summary_default_combination in Settings.
Test: Existing tests passed
Flag: EXEMPT clean up
Bug: 328519240
Change-Id: I86996c43243b7a8e2d4b1a83180c189986b3a6ca
2024-07-24 02:36:09 +00:00
Matías Hernández
6a5e7b9631 Merge "Changes to the trigger segment" into main 2024-07-23 20:02:56 +00:00
Matías Hernández
9e2ac046e4 Changes to the trigger segment
* Switch is always visible, even without a configuration activity
* Custom icon, title, and summary for some mode types (such as SCHEDULE_TIME, etc).
* Default texts in case of missing trigger description.
* Different icons for having/missing configuration activity.
* Move the section to the top of the screen.

Bug: 349376785
Test: atest ZenModeTriggerLinkPreferenceControllerTest
Flag: android.app.modes_ui
Change-Id: I960318899cf4da20ffc5765818429d5790d05067
2024-07-23 18:14:34 +02:00
Chelsea Hao
7a01fb2679 Merge changes Ibb68252c,Ide20e07f,I5d2e2c70 into main
* changes:
  Add accessibility label for "QR code" scanner. Also added landscape mode.
  Add accessibility label for "QR code" image. Also added landscape mode.
  Add accessibility label for "QR code" button in Audio sharing page.
2024-07-23 02:52:11 +00:00
Haijie Hong
8b2d520221 Merge "Update color of ring battery indicator" into main 2024-07-23 02:29:35 +00:00