Commit Graph

18 Commits

Author SHA1 Message Date
Lifu Tang
caa1b51ef2 Revert "Remove duplicate strings."
Revert submission 19748582-settings_yesno

Reason for revert: Common strings in English could be translated into different strings in other languages.

Reverted changes: /q/submissionid:19748582-settings_yesno

Bug: 272603842
Test: build and open Settings app
Test: atest SettingsRoboTests
Change-Id: Iaad301c5513478fb95e40987ea3ccb4f923d71fa
2023-03-15 22:39:24 +00:00
Fan Zhang
f901a72fe2 Suppress emergency page search when needed.
When controller#shouldSuppressFromSearch returns true, suppresses page
search.

Fix: 268664782
Test: manual
Change-Id: Ida543ae47aed36380200d938ea31fe80195b7186
2023-02-13 12:26:54 -08:00
Kweku Adams
5949fccc7a Remove duplicate strings.
"Yes" and "no" were redefined many times with no clear benefit, so this
consolidates them into one definition.

Bug: 243843096
Test: Build, install, and open the Settings app
Test: atest SettingsRoboTests
Change-Id: I5f84d09f223efd478461ded93aeac82bf7b128d8
2022-08-26 00:07:08 +00:00
Fan Zhang
d9b0a13804 Simplify eSOS platform setting summary.
Old: Managed by [app]
New: On/Off

Test: robotests
Bug: 219103250
Change-Id: Ife77e0ff40cd6f1ef8fc01542b65b5a9881b4b9e
2022-05-02 22:10:19 +00:00
Patrick Huang
8f1e3fec84 Hide emergency setting from "Search settings"
Use the same config value created in ag/16497464 and ag/16497621
to determine if emergency setting should be searchable in Settings.

Bug: 220437126
Test: Manual test on affected phone and tablet
Change-Id: I964dd9f75f6a5c3b239aabfa4dfce84cb75c8565
2022-03-18 06:51:31 +00:00
Jason Chiu
9fc0f18181 Define a constant Sliceable#NO_RES for no resource cases
Fix: 204733076
Test: build
Change-Id: Ifa3b9db0e915a3ec056ad68a9a1862811594d423
2021-11-03 12:23:49 +08:00
Jason Chiu
2989c50a23 Add highlight menu keys for all toggle pref controllers and custom slices
Bug: 204695404
Test: manual, robotest build pass, unit
Change-Id: Iad2e28ada8ddb766ffa7eff2c8dc581250cbd6f8
2021-11-01 15:00:18 +08:00
Fan Zhang
2a3920e44d Use NEW_TASK|CLEAR_TOP when launching emergency app
This flag combination will attempt to go to the existing emergency app
task stack instead of creating duplicate ones.

Fix: 193108390
Test: manual
Change-Id: Ia9c9ead4e8b1d27582cdaff3e4d42c762e80709a
2021-08-09 22:54:21 +00:00
Tsung-Mao Fang
22b50de9f4 Add click tile event for tracking
- Search bar in homepage.
- Avatar icon in homepage.
- More personal safety in Safety & emergency.

Test: Rebuilt rom
Fix: 190341976
Change-Id: I14297211e4b7424f5fdeb46c360b3913101251d7
2021-06-17 17:50:34 +08:00
Shireesha Bongarala
2c5c048482 Hide Wireless Emergency Alerts on unsupported devices
Bug: 175158310
Test: make Settings -j40
Change-Id: I455613a8b80d828e0e068977fb1446c0a7a4f85d
2021-04-14 12:37:34 +00:00
Fan Zhang
eee07aacb9 Add icon to "Open [safety app] button
https://screenshot.googleplex.com/AjFhMECtQ4E9QAa.png

Bug: 184261824
Test: manual
Change-Id: I2b9b74077aec29dee3a34105584c5364fa663a84
2021-04-07 20:29:23 +00:00
Fan Zhang
a288358343 Button for opening app from Safety settings page
Bug: 179063896
Test: Manual

Change-Id: I4cf627d630de277ebea3fe551d6799e5589e1af3
2021-03-24 23:46:49 +00:00
Fan Zhang
9fdceaea78 Fallback to AOSP eSOS settings page if OEM impl fails
When OEM eSOS implementation fails for any reason (app disabled,
misconfigured, etc), Emergency SOS settings should fallack to the
default settings page (rather than hiding the setting entirely)

Bug: 180959553
Test: robotests
Change-Id: I31c08449eff3f01d4c33bf827023f17beade93c2
2021-03-11 20:30:55 +00:00
Fan Zhang
f5819fc80c Use EmergencyNumberUtils to get/set emergency settings.
EmergencyNumberUtils now contains centralized logic for interacting with
emergency gesture settings. Settings UI does not need to pay attention
to underlying data access, permission controler, etc etc.

Bug: 180236600
Test: robotests

Change-Id: If641ee36f237d153f1d790251af408969379a57a
2021-02-19 05:43:49 +00:00
Fan Zhang
6a8f11b2cf Hide esos setting if no app provides esos functionality
When user disables OEM app that provides esos, the setting is hidden as
well.

See more details on bug.

Bug: 178654110
Test: robotests
Change-Id: I7a0763381d3321124f4208a58bb8e10cf884f7c1
2021-01-28 18:38:52 +00:00
Fan Zhang
e81091175e Default emergency gesture setting On.
And a few drive-by fixes:
* Move all emergency gesture fragments and controllers to emergency
  package for better code colocation.
* Remove the placeholder video preference from emergency_gesture_settings.xml

Bug: 178009196
Test: reran robotests
Change-Id: Ifcb591e7ab8e5e5494c480cbbe9410c08c296f8e
2021-01-20 13:08:04 -08:00
Fan Zhang
78cbca8cbd Add android:order to all emergency setting items
Each item has a gap of 100 to allow external setting injection choose
where to display.

Bug: 175158310
Test: manual
Change-Id: Icf150ad8fc956c3db391251382b08b5155034a8b
2021-01-08 23:56:33 +00:00
Fan Zhang
9b1fb77b54 Add a empty page to host Safety/emergency settings
The page will eventually be displayed on settings root. It's currently
disabled to avoid QA/dogfood confusion, as the page is pretty empty at
this point.

Bug: 175158310
Test: manual only. Skipped robolectric because the page is pretty empty.
      Will add more test as we build business logic.
Change-Id: I80f193f6e90b89ab0c37d0f23f7174e4ba86c091
2021-01-07 10:56:32 -08:00