Commit Graph

2 Commits

Author SHA1 Message Date
Gustav Sennton
4790d7e8f2 Show current WebView package as selected in Dev Setting.
When intenting to the select-webview-implementation Dev Setting a user
won't know which package is currently being used as WebView
implementation. To solve this we change the background color of the item
representing the current WebView package.

With this CL, also ensure we update the summary of the WebView
implementation Dev Setting even if we failed to switch to the package
chosen by the user - we might have switched to another package instead.

Bug: 34702900
Test: Ensure the current WebView package has a different background
color than the rest of the packages.

Change-Id: Ieb65fdc635d5dd1253931c8ab8bb0d827a142c56
2017-01-25 17:32:40 +00:00
Gustav Sennton
4d3334c50b Update WebView implementation Dev Setting - new looks + descriptions.
Now that we are changing the WebView package mechanism so that a package
can only be used as WebView implementation if that package is enabled
for all users of the device we need to tell the user why a package can't
be chosen as WebView implementation.
With this CL we do so in the 'Set WebView Implementation' Developer
Setting.

We code for the WebView implementation Developer Setting is now based on
the same code as that of the Debug App Developer Setting.

Bug: 32894154
Test: Ensure WebView Implementation setting shows correct packages.
Test: Ensure WebView Implementation setting shows correct descriptions
for why a package is not usable - including the case where packages are
disabled/uninstalled for a second user.
Test: Ensure the summary for the WebView Implmentation setting is
updated after changing WebView package.
Test: Ensure the WebView package Activity
(Settings.ACTION_WEBVIEW_SETTINGS) is similar to the Dev Setting.
Test: ensure non-admin user cannot start WV-picker activity through
'adb shell am start -n com.android.settings/.WebViewImplementation'

Change-Id: Ia6e6e9e12ce8f8f45ec539807cd0c6479acb8ecb
2017-01-23 18:34:11 +00:00