A check for valid PSKs in the settings UI didnt capture the 64 character
HEX string case. Added a check for it.
Test: tests/app/src/com/android/settings/wifi/WifiSettingsUiTest.java
Test: manual verification
Bug: 67492639
Change-Id: Ide738c4a67f23b613883b4a69f8264a0ffb8a0bc
- The tile activity is internal to Settings and nobody should launch it
externally, thus it doesn't need to have its own activity. Preference
framework can launch the fragment as a SubSetting
Fixes: 67603649
Test: robotests
Change-Id: I9ba2fc55eb7f571f816ec045567f2dd2714c44e8
in ManageApplications, if getActivity is null, it will cause crash
because in HelpUtils#prepareHelpMenuItem it will call activity's
getString method.
Test: manual
Change-Id: I4c9cf985e94192a936d195ea4279ec1d0f22eb10
Signed-off-by: songkailun <songkailun@xiaomi.com>
There are many places on Settings that loads an icon provided by an application,
and if the icon is too big it crashes Settings.
This CL creates a helper method used to set an icon in a safe way, and
uses it in a few places (but most likely not all of them).
Bug: 65739885
Test: manual verification with an app providing a 2MB png
Change-Id: Iae2becb6d0ec8893328d9ef1de618f9bd12fa4a0
Symptom:
After manually pull out the removable sd card or usb storage in
StorageSettings screen, it automatically moves to
PrivateVolumeSettings screen. This time, launching
PrivateVolumeSettings Activity is triggered six times and end-user
has to press back key six times to exit PrivateVolumeSettings
screen.
Root cause:
When sd card is pulled out, StorageSettings got three state change
event (UNMOUNTED, BAD_REMOVAL and onDiskDestroyed) through
StorageEventListener that triggers launching PrivateVolumeSettings
screen. In addition StorageSettings register the listener two
times, then StorageSettings receives six event in total.
Therefore, PrivateVolumeSettings screen is launched six times.
Solution:
Skip launching PrivateVolumeSettings if it's already triggered.
And removed the duplicated listener registration.
Bug: 67612903
Change-Id: Iabef51677a393977b7be29fc54aa050434213500
- Create new LogdSizePreferenceControllerV2
- Deprecate LogdSizePreferenceController
- Create controller inside the DashboardFragment
- Port logic from DevelopmentSettings into the controller
Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I4bc03ee8481d01e553b8a4df9f9ec03b53d4eee4
Fix the issue that some 3rd-party apps call ZenModeScheduleRuleSettings directly
without set the extra ConditionProviderService.EXTRA_RULE_ID. It will raise the
exception and make settings crash.
Test: 1. Install the app "QuickShortcutMaker"
2. Following the steps descripted in the issue:
https://issuetracker.google.com/issues/37977351
3. make ROBOTEST_FILTER="(ZenModeScheduleRuleSettingsTest)" RunSettingsRoboTests
Change-Id: Ia7de0e691eef6d0da26e629ff0c6af7006757623
Signed-off-by: liurong <liurong@xiaomi.com>
- Refactor AdbPreferenceController to use
AbstractEnableAdbPreferenceController
Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: If34e2968ff8900276023e12f89d9cc86468adf7a
Also disables all anomalies out of the box.
Provides the ability to ignore certain wakeups if blacklisted in
AnomalyDetectionPolicy. Compares each wakeup to the blacklist and
if it exists, does not include it in the count used to compare against
the threshold.
Change-Id: I038ca966aed5a030853b4786bc201397bf4f9b70
Merged-In: I4ef548bd0952be5f0d4e36df5698f287839d0704
Fixes: 67000019
Test: robotests
Also disables all anomalies out of the box.
Provides the ability to ignore certain wakeups if blacklisted in
AnomalyDetectionPolicy. Compares each wakeup to the blacklist and
if it exists, does not include it in the count used to compare against
the threshold.
Change-Id: I4ef548bd0952be5f0d4e36df5698f287839d0704
Fixes: 67000019
Test: robotests
- Remove show_suggestion logging in DashboardAdapater. Showing
suggestion is logged inside SuggestionAdapter during onBind.
- Remove hide_suggestion logging. It's not used by anyone.
- Move SuggestionLogHelper into SuggestionFeatureProvider
Bug: 65065268
Test: robotests
Change-Id: I1e7929d739b79527d2ae01c25177676f6be6ddff
- Create new SelectUsbConfigController
- Create controller inside the DashboardFragment
- Port logic from DevelopmentSettings into the controller
Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I8d6b4eb2e8a90adb7f8bdf4aeec0f5929e8165b2
Use a custom item layout for the data usage warning unit selection
spinner to make the touch target bigger.
Change-Id: I2d73dc3ab4c99cea8f8c791c8c1346240456d6aa
Fixes: 66414539
Test: visual
- Create new HdcpCheckingPreferenceController
- Create controller inside the DashboardFragment
- Port logic from DevelopmentSettings into the controller
Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Id6eed501ce658b55dc4ad38f7408994f70923194
- Create new ShortcutManagerThrottlingPreferenceController
- Create controller inside the DashboardFragment
- Port logic from DevelopmentSettings into the controller
Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I5409b40b4ed7d350af34498da9a3d7d79200f69b
